[INFO] updating cached repository RyanBluth/dumbbell
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/RyanBluth/dumbbell
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/RyanBluth/dumbbell" "work/ex/clippy-test-run/sources/stable/gh/RyanBluth/dumbbell"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/RyanBluth/dumbbell'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/RyanBluth/dumbbell" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RyanBluth/dumbbell"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RyanBluth/dumbbell'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] b52cd1b7d30cd50ea05b397b59bfd6988d1b0456
[INFO] sha for GitHub repo RyanBluth/dumbbell: b52cd1b7d30cd50ea05b397b59bfd6988d1b0456
[INFO] validating manifest of RyanBluth/dumbbell on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of RyanBluth/dumbbell on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing RyanBluth/dumbbell
[INFO] finished frobbing RyanBluth/dumbbell
[INFO] frobbed toml for RyanBluth/dumbbell written to work/ex/clippy-test-run/sources/stable/gh/RyanBluth/dumbbell/Cargo.toml
[INFO] started frobbing RyanBluth/dumbbell
[INFO] finished frobbing RyanBluth/dumbbell
[INFO] frobbed toml for RyanBluth/dumbbell written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RyanBluth/dumbbell/Cargo.toml
[INFO] crate RyanBluth/dumbbell has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting RyanBluth/dumbbell against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/RyanBluth/dumbbell:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 82c66a8df93dbe4b79fc9128e3fdc543b6db23f185050ebf97250969f8a6fa0b
[INFO] running `"docker" "start" "-a" "82c66a8df93dbe4b79fc9128e3fdc543b6db23f185050ebf97250969f8a6fa0b"`
[INFO] [stderr]     Checking hyper v0.10.0
[INFO] [stderr]     Checking dumbbell v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:53:17
[INFO] [stderr]    |
[INFO] [stderr] 53 |                 key: key,
[INFO] [stderr]    |                 ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/main.rs:53:17
[INFO] [stderr]    |
[INFO] [stderr] 53 |                 key: key,
[INFO] [stderr]    |                 ^^^^^^^^ help: replace it with: `key`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `hyper::Client`
[INFO] [stderr]  --> src/main.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use hyper::Client;
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `SubCommand`
[INFO] [stderr]  --> src/main.rs:5:22
[INFO] [stderr]   |
[INFO] [stderr] 5 | use clap::{Arg, App, SubCommand, ArgMatches};
[INFO] [stderr]   |                      ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/main.rs:9:20
[INFO] [stderr]   |
[INFO] [stderr] 9 | const A_ENDPOINT: &'static str = "endpoint";
[INFO] [stderr]   |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:10:19
[INFO] [stderr]    |
[INFO] [stderr] 10 | const A_THREADS: &'static str = "threads";
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:11:20
[INFO] [stderr]    |
[INFO] [stderr] 11 | const A_REQUESTS: &'static str = "requests";
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:12:16
[INFO] [stderr]    |
[INFO] [stderr] 12 | const A_BODY: &'static str = "body";
[INFO] [stderr]    |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:13:19
[INFO] [stderr]    |
[INFO] [stderr] 13 | const A_HEADERS: &'static str = "headers";
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:22:9
[INFO] [stderr]    |
[INFO] [stderr] 22 |         return TaskError::ParseError;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TaskError::ParseError`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:52:13
[INFO] [stderr]    |
[INFO] [stderr] 52 | /             return Ok(Header {
[INFO] [stderr] 53 | |                 key: key,
[INFO] [stderr] 54 | |                 values: vals,
[INFO] [stderr] 55 | |             });
[INFO] [stderr]    | |_______________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 52 |             Ok(Header {
[INFO] [stderr] 53 |                 key: key,
[INFO] [stderr] 54 |                 values: vals,
[INFO] [stderr] 55 |             })
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:57:13
[INFO] [stderr]    |
[INFO] [stderr] 57 |             return Err(TaskError::ParseError);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TaskError::ParseError)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:82:9
[INFO] [stderr]    |
[INFO] [stderr] 82 |         return Result::Ok(result);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(result)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `hyper::Client`
[INFO] [stderr]  --> src/main.rs:2:5
[INFO] [stderr]   |
[INFO] [stderr] 2 | use hyper::Client;
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `SubCommand`
[INFO] [stderr]  --> src/main.rs:5:22
[INFO] [stderr]   |
[INFO] [stderr] 5 | use clap::{Arg, App, SubCommand, ArgMatches};
[INFO] [stderr]   |                      ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/main.rs:9:20
[INFO] [stderr]   |
[INFO] [stderr] 9 | const A_ENDPOINT: &'static str = "endpoint";
[INFO] [stderr]   |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:10:19
[INFO] [stderr]    |
[INFO] [stderr] 10 | const A_THREADS: &'static str = "threads";
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:11:20
[INFO] [stderr]    |
[INFO] [stderr] 11 | const A_REQUESTS: &'static str = "requests";
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:12:16
[INFO] [stderr]    |
[INFO] [stderr] 12 | const A_BODY: &'static str = "body";
[INFO] [stderr]    |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:13:19
[INFO] [stderr]    |
[INFO] [stderr] 13 | const A_HEADERS: &'static str = "headers";
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:22:9
[INFO] [stderr]    |
[INFO] [stderr] 22 |         return TaskError::ParseError;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TaskError::ParseError`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:52:13
[INFO] [stderr]    |
[INFO] [stderr] 52 | /             return Ok(Header {
[INFO] [stderr] 53 | |                 key: key,
[INFO] [stderr] 54 | |                 values: vals,
[INFO] [stderr] 55 | |             });
[INFO] [stderr]    | |_______________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 52 |             Ok(Header {
[INFO] [stderr] 53 |                 key: key,
[INFO] [stderr] 54 |                 values: vals,
[INFO] [stderr] 55 |             })
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:57:13
[INFO] [stderr]    |
[INFO] [stderr] 57 |             return Err(TaskError::ParseError);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TaskError::ParseError)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:82:9
[INFO] [stderr]    |
[INFO] [stderr] 82 |         return Result::Ok(result);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(result)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `err`
[INFO] [stderr]   --> src/main.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |     fn from(err: std::num::ParseIntError) -> TaskError {
[INFO] [stderr]    |             ^^^ help: consider using `_err` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:46:12
[INFO] [stderr]    |
[INFO] [stderr] 46 |         if split_res.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!split_res.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `split_res`.
[INFO] [stderr]   --> src/main.rs:49:22
[INFO] [stderr]    |
[INFO] [stderr] 49 |             for i in 1..split_res.len() {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 49 |             for <item> in split_res.iter().skip(1) {
[INFO] [stderr]    |                 ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `err`
[INFO] [stderr]   --> src/main.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |     fn from(err: std::num::ParseIntError) -> TaskError {
[INFO] [stderr]    |             ^^^ help: consider using `_err` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:46:12
[INFO] [stderr]    |
[INFO] [stderr] 46 |         if split_res.len() > 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!split_res.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `split_res`.
[INFO] [stderr]   --> src/main.rs:49:22
[INFO] [stderr]    |
[INFO] [stderr] 49 |             for i in 1..split_res.len() {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 49 |             for <item> in split_res.iter().skip(1) {
[INFO] [stderr]    |                 ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 6.54s
[INFO] running `"docker" "inspect" "82c66a8df93dbe4b79fc9128e3fdc543b6db23f185050ebf97250969f8a6fa0b"`
[INFO] running `"docker" "rm" "-f" "82c66a8df93dbe4b79fc9128e3fdc543b6db23f185050ebf97250969f8a6fa0b"`
[INFO] [stdout] 82c66a8df93dbe4b79fc9128e3fdc543b6db23f185050ebf97250969f8a6fa0b