[INFO] updating cached repository RustisLeague/rustis [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/RustisLeague/rustis [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/RustisLeague/rustis" "work/ex/clippy-test-run/sources/stable/gh/RustisLeague/rustis"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/RustisLeague/rustis'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/RustisLeague/rustis" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RustisLeague/rustis"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RustisLeague/rustis'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5440206c1ca7efe191c8b7b5a162f0fa41c4cbcf [INFO] sha for GitHub repo RustisLeague/rustis: 5440206c1ca7efe191c8b7b5a162f0fa41c4cbcf [INFO] validating manifest of RustisLeague/rustis on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of RustisLeague/rustis on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing RustisLeague/rustis [INFO] finished frobbing RustisLeague/rustis [INFO] frobbed toml for RustisLeague/rustis written to work/ex/clippy-test-run/sources/stable/gh/RustisLeague/rustis/Cargo.toml [INFO] started frobbing RustisLeague/rustis [INFO] finished frobbing RustisLeague/rustis [INFO] frobbed toml for RustisLeague/rustis written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RustisLeague/rustis/Cargo.toml [INFO] crate RustisLeague/rustis has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting RustisLeague/rustis against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/RustisLeague/rustis:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c420111062b6eb83a1893da5fb8e89a856094e2d4c6e6bac8ebf7afd6270d9c8 [INFO] running `"docker" "start" "-a" "c420111062b6eb83a1893da5fb8e89a856094e2d4c6e6bac8ebf7afd6270d9c8"` [INFO] [stderr] Checking rustis v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/rustis/command.rs:96:28 [INFO] [stderr] | [INFO] [stderr] 96 | &Return::Ok => write!(f, "+OK\r\n"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/rustis/command.rs:97:38 [INFO] [stderr] | [INFO] [stderr] 97 | &Return::Error(ref s) => write!(f, "-{}\r\n", s), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustis/db.rs:63:58 [INFO] [stderr] | [INFO] [stderr] 63 | return self.run_command(Command::IncrBy {key: key, increment: 1}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustis/db.rs:66:58 [INFO] [stderr] | [INFO] [stderr] 66 | return self.run_command(Command::IncrBy {key: key, increment: -1}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustis/db.rs:69:58 [INFO] [stderr] | [INFO] [stderr] 69 | return self.run_command(Command::IncrBy {key: key, increment: -decrement}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustis/db.rs:300:56 [INFO] [stderr] | [INFO] [stderr] 300 | return self.run_command(Command::Echo {message: message}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustis/server.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustis/server.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | dbs: dbs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dbs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/rustis/value.rs:19:40 [INFO] [stderr] | [INFO] [stderr] 19 | &Value::IntValue(ref i) => write!(f, ":{}\r\n", i), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/rustis/value.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | _ => write!(f, "$-1\r\n"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/rustis/command.rs:96:28 [INFO] [stderr] | [INFO] [stderr] 96 | &Return::Ok => write!(f, "+OK\r\n"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/rustis/command.rs:97:38 [INFO] [stderr] | [INFO] [stderr] 97 | &Return::Error(ref s) => write!(f, "-{}\r\n", s), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustis/db.rs:63:58 [INFO] [stderr] | [INFO] [stderr] 63 | return self.run_command(Command::IncrBy {key: key, increment: 1}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustis/db.rs:66:58 [INFO] [stderr] | [INFO] [stderr] 66 | return self.run_command(Command::IncrBy {key: key, increment: -1}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustis/db.rs:69:58 [INFO] [stderr] | [INFO] [stderr] 69 | return self.run_command(Command::IncrBy {key: key, increment: -decrement}); [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustis/db.rs:300:56 [INFO] [stderr] | [INFO] [stderr] 300 | return self.run_command(Command::Echo {message: message}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustis/server.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rustis/server.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | dbs: dbs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dbs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/rustis/value.rs:19:40 [INFO] [stderr] | [INFO] [stderr] 19 | &Value::IntValue(ref i) => write!(f, ":{}\r\n", i), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/rustis/value.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | _ => write!(f, "$-1\r\n"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/command.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / return if s.len() == 0 || s.contains(" ") { [INFO] [stderr] 57 | | format!("\"{}\"", s) [INFO] [stderr] 58 | | } else { [INFO] [stderr] 59 | | s.to_string() [INFO] [stderr] 60 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 56 | if s.len() == 0 || s.contains(" ") { [INFO] [stderr] 57 | format!("\"{}\"", s) [INFO] [stderr] 58 | } else { [INFO] [stderr] 59 | s.to_string() [INFO] [stderr] 60 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/command.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | return ParseResult(parsed_chars, commands); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ParseResult(parsed_chars, commands)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/command.rs:99:17 [INFO] [stderr] | [INFO] [stderr] 99 | return v.fmt(f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v.fmt(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / return RustisDb { [INFO] [stderr] 16 | | values: HashMap::with_capacity(1024), [INFO] [stderr] 17 | | exp: BinaryHeap::with_capacity(1024), [INFO] [stderr] 18 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 15 | RustisDb { [INFO] [stderr] 16 | values: HashMap::with_capacity(1024), [INFO] [stderr] 17 | exp: BinaryHeap::with_capacity(1024), [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | return Return::ValueReturn(value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | return Return::Ok; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Ok` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | return return_value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `return_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | return self.run_command(Command::IncrBy {key: key, increment: 1}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.run_command(Command::IncrBy {key: key, increment: 1})` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | return self.run_command(Command::IncrBy {key: key, increment: -1}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.run_command(Command::IncrBy {key: key, increment: -1})` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | return self.run_command(Command::IncrBy {key: key, increment: -decrement}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.run_command(Command::IncrBy {key: key, increment: -decrement})` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | return Return::ValueReturn(return_value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(return_value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | return Return::ValueReturn(return_value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(return_value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:118:33 [INFO] [stderr] | [INFO] [stderr] 118 | return Return::ValueReturn(Value::StrValue(l[i].clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::StrValue(l[i].clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:121:33 [INFO] [stderr] | [INFO] [stderr] 121 | return Return::Error("ERR index out of range".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("ERR index out of range".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:126:25 [INFO] [stderr] | [INFO] [stderr] 126 | return Return::Error("WRONGTYPE not a list".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("WRONGTYPE not a list".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:133:25 [INFO] [stderr] | [INFO] [stderr] 133 | return Return::ValueReturn(Value::IntValue(l.len() as i64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::IntValue(l.len() as i64))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:136:25 [INFO] [stderr] | [INFO] [stderr] 136 | return Return::Error("WRONGTYPE not a list".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("WRONGTYPE not a list".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:146:33 [INFO] [stderr] | [INFO] [stderr] 146 | return Return::ValueReturn(Value::StrValue(x)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::StrValue(x))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:149:33 [INFO] [stderr] | [INFO] [stderr] 149 | return Return::Error("ERR list is empty".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("ERR list is empty".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | return Return::Error("WRONGTYPE not a list".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("WRONGTYPE not a list".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:164:33 [INFO] [stderr] | [INFO] [stderr] 164 | return Return::ValueReturn(Value::StrValue(x)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::StrValue(x))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:167:33 [INFO] [stderr] | [INFO] [stderr] 167 | return Return::Error("ERR list is empty".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("ERR list is empty".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:172:25 [INFO] [stderr] | [INFO] [stderr] 172 | return Return::Error("WRONGTYPE not a list".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("WRONGTYPE not a list".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:185:25 [INFO] [stderr] | [INFO] [stderr] 185 | return Return::ValueReturn(Value::IntValue(l.len() as i64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::IntValue(l.len() as i64))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:188:25 [INFO] [stderr] | [INFO] [stderr] 188 | return Return::Error("WRONGTYPE not a list".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("WRONGTYPE not a list".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:201:25 [INFO] [stderr] | [INFO] [stderr] 201 | return Return::ValueReturn(Value::IntValue(l.len() as i64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::IntValue(l.len() as i64))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:204:25 [INFO] [stderr] | [INFO] [stderr] 204 | return Return::Error("WRONGTYPE not a list".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("WRONGTYPE not a list".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:214:33 [INFO] [stderr] | [INFO] [stderr] 214 | return Return::Ok; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Ok` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:217:33 [INFO] [stderr] | [INFO] [stderr] 217 | return Return::Error("ERR index out of range".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("ERR index out of range".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:222:25 [INFO] [stderr] | [INFO] [stderr] 222 | return Return::Error("WRONGTYPE not a list".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("WRONGTYPE not a list".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:239:25 [INFO] [stderr] | [INFO] [stderr] 239 | return Return::ValueReturn(Value::IntValue(added)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::IntValue(added))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:242:25 [INFO] [stderr] | [INFO] [stderr] 242 | return Return::Error("WRONGTYPE not a set".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("WRONGTYPE not a set".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:249:25 [INFO] [stderr] | [INFO] [stderr] 249 | return Return::ValueReturn(Value::IntValue(s.len() as i64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::IntValue(s.len() as i64))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:252:25 [INFO] [stderr] | [INFO] [stderr] 252 | return Return::Error("WRONGTYPE not a set".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("WRONGTYPE not a set".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:259:25 [INFO] [stderr] | [INFO] [stderr] 259 | return Return::ValueReturn(Value::IntValue(if s.contains(&member) {1} else {0})); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::IntValue(if s.contains(&member) {1} else {0}))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:262:25 [INFO] [stderr] | [INFO] [stderr] 262 | return Return::Error("WRONGTYPE not a set".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("WRONGTYPE not a set".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:276:25 [INFO] [stderr] | [INFO] [stderr] 276 | return Return::ValueReturn(Value::IntValue(removed)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::IntValue(removed))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:279:25 [INFO] [stderr] | [INFO] [stderr] 279 | return Return::Error("WRONGTYPE not a set".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("WRONGTYPE not a set".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:284:17 [INFO] [stderr] | [INFO] [stderr] 284 | return Return::ValueReturn(Value::IntValue(self.values.len() as i64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::IntValue(self.values.len() as i64))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:297:17 [INFO] [stderr] | [INFO] [stderr] 297 | return Return::ValueReturn(Value::IntValue(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::IntValue(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:300:17 [INFO] [stderr] | [INFO] [stderr] 300 | return self.run_command(Command::Echo {message: message}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.run_command(Command::Echo {message: message})` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:303:17 [INFO] [stderr] | [INFO] [stderr] 303 | return Return::ValueReturn(Value::StrValue(message)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::StrValue(message))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:306:17 [INFO] [stderr] | [INFO] [stderr] 306 | return Return::ValueReturn(Value::IntValue(if self.values.contains_key(&key) {1} else {0})); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::IntValue(if self.values.contains_key(&key) {1} else {0}))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:309:17 [INFO] [stderr] | [INFO] [stderr] 309 | / return match self.values.get(&key) { [INFO] [stderr] 310 | | Some(&Value::IntValue(_)) => Return::ValueReturn(Value::StrValue("string".to_string())), [INFO] [stderr] 311 | | Some(&Value::StrValue(_)) => Return::ValueReturn(Value::StrValue("string".to_string())), [INFO] [stderr] 312 | | Some(&Value::SetValue(_)) => Return::ValueReturn(Value::StrValue("set".to_string())), [INFO] [stderr] ... | [INFO] [stderr] 316 | | _ => Return::ValueReturn(Value::Nil), [INFO] [stderr] 317 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 309 | match self.values.get(&key) { [INFO] [stderr] 310 | Some(&Value::IntValue(_)) => Return::ValueReturn(Value::StrValue("string".to_string())), [INFO] [stderr] 311 | Some(&Value::StrValue(_)) => Return::ValueReturn(Value::StrValue("string".to_string())), [INFO] [stderr] 312 | Some(&Value::SetValue(_)) => Return::ValueReturn(Value::StrValue("set".to_string())), [INFO] [stderr] 313 | Some(&Value::ListValue(_)) => Return::ValueReturn(Value::StrValue("list".to_string())), [INFO] [stderr] 314 | Some(&Value::SortedSetValue(_)) => Return::ValueReturn(Value::StrValue("zset".to_string())), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:321:17 [INFO] [stderr] | [INFO] [stderr] 321 | return Return::Ok; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Ok` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:332:17 [INFO] [stderr] | [INFO] [stderr] 332 | return Return::ValueReturn(r); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:335:17 [INFO] [stderr] | [INFO] [stderr] 335 | return Return::Ok; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Ok` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:347:13 [INFO] [stderr] | [INFO] [stderr] 347 | return Some(index as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(index as usize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:349:13 [INFO] [stderr] | [INFO] [stderr] 349 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `IResult` [INFO] [stderr] --> src/rustis/parse.rs:1:11 [INFO] [stderr] | [INFO] [stderr] 1 | use nom::{IResult, digit}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/server.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | return self.client_tokens.pop().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.client_tokens.pop().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/command.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / return if s.len() == 0 || s.contains(" ") { [INFO] [stderr] 57 | | format!("\"{}\"", s) [INFO] [stderr] 58 | | } else { [INFO] [stderr] 59 | | s.to_string() [INFO] [stderr] 60 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 56 | if s.len() == 0 || s.contains(" ") { [INFO] [stderr] 57 | format!("\"{}\"", s) [INFO] [stderr] 58 | } else { [INFO] [stderr] 59 | s.to_string() [INFO] [stderr] 60 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/command.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | return ParseResult(parsed_chars, commands); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ParseResult(parsed_chars, commands)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/command.rs:99:17 [INFO] [stderr] | [INFO] [stderr] 99 | return v.fmt(f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v.fmt(f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | / return RustisDb { [INFO] [stderr] 16 | | values: HashMap::with_capacity(1024), [INFO] [stderr] 17 | | exp: BinaryHeap::with_capacity(1024), [INFO] [stderr] 18 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 15 | RustisDb { [INFO] [stderr] 16 | values: HashMap::with_capacity(1024), [INFO] [stderr] 17 | exp: BinaryHeap::with_capacity(1024), [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | return Return::ValueReturn(value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | return Return::Ok; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Ok` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | return return_value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `return_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | return self.run_command(Command::IncrBy {key: key, increment: 1}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.run_command(Command::IncrBy {key: key, increment: 1})` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | return self.run_command(Command::IncrBy {key: key, increment: -1}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.run_command(Command::IncrBy {key: key, increment: -1})` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | return self.run_command(Command::IncrBy {key: key, increment: -decrement}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.run_command(Command::IncrBy {key: key, increment: -decrement})` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | return Return::ValueReturn(return_value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(return_value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | return Return::ValueReturn(return_value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(return_value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:118:33 [INFO] [stderr] | [INFO] [stderr] 118 | return Return::ValueReturn(Value::StrValue(l[i].clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::StrValue(l[i].clone()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:121:33 [INFO] [stderr] | [INFO] [stderr] 121 | return Return::Error("ERR index out of range".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("ERR index out of range".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:126:25 [INFO] [stderr] | [INFO] [stderr] 126 | return Return::Error("WRONGTYPE not a list".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("WRONGTYPE not a list".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:133:25 [INFO] [stderr] | [INFO] [stderr] 133 | return Return::ValueReturn(Value::IntValue(l.len() as i64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::IntValue(l.len() as i64))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:136:25 [INFO] [stderr] | [INFO] [stderr] 136 | return Return::Error("WRONGTYPE not a list".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("WRONGTYPE not a list".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:146:33 [INFO] [stderr] | [INFO] [stderr] 146 | return Return::ValueReturn(Value::StrValue(x)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::StrValue(x))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:149:33 [INFO] [stderr] | [INFO] [stderr] 149 | return Return::Error("ERR list is empty".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("ERR list is empty".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | return Return::Error("WRONGTYPE not a list".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("WRONGTYPE not a list".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:164:33 [INFO] [stderr] | [INFO] [stderr] 164 | return Return::ValueReturn(Value::StrValue(x)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::StrValue(x))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:167:33 [INFO] [stderr] | [INFO] [stderr] 167 | return Return::Error("ERR list is empty".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("ERR list is empty".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:172:25 [INFO] [stderr] | [INFO] [stderr] 172 | return Return::Error("WRONGTYPE not a list".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("WRONGTYPE not a list".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:185:25 [INFO] [stderr] | [INFO] [stderr] 185 | return Return::ValueReturn(Value::IntValue(l.len() as i64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::IntValue(l.len() as i64))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:188:25 [INFO] [stderr] | [INFO] [stderr] 188 | return Return::Error("WRONGTYPE not a list".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("WRONGTYPE not a list".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:201:25 [INFO] [stderr] | [INFO] [stderr] 201 | return Return::ValueReturn(Value::IntValue(l.len() as i64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::IntValue(l.len() as i64))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:204:25 [INFO] [stderr] | [INFO] [stderr] 204 | return Return::Error("WRONGTYPE not a list".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("WRONGTYPE not a list".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:214:33 [INFO] [stderr] | [INFO] [stderr] 214 | return Return::Ok; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Ok` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:217:33 [INFO] [stderr] | [INFO] [stderr] 217 | return Return::Error("ERR index out of range".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("ERR index out of range".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:222:25 [INFO] [stderr] | [INFO] [stderr] 222 | return Return::Error("WRONGTYPE not a list".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("WRONGTYPE not a list".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:239:25 [INFO] [stderr] | [INFO] [stderr] 239 | return Return::ValueReturn(Value::IntValue(added)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::IntValue(added))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:242:25 [INFO] [stderr] | [INFO] [stderr] 242 | return Return::Error("WRONGTYPE not a set".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("WRONGTYPE not a set".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:249:25 [INFO] [stderr] | [INFO] [stderr] 249 | return Return::ValueReturn(Value::IntValue(s.len() as i64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::IntValue(s.len() as i64))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:252:25 [INFO] [stderr] | [INFO] [stderr] 252 | return Return::Error("WRONGTYPE not a set".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("WRONGTYPE not a set".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:259:25 [INFO] [stderr] | [INFO] [stderr] 259 | return Return::ValueReturn(Value::IntValue(if s.contains(&member) {1} else {0})); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::IntValue(if s.contains(&member) {1} else {0}))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:262:25 [INFO] [stderr] | [INFO] [stderr] 262 | return Return::Error("WRONGTYPE not a set".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("WRONGTYPE not a set".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:276:25 [INFO] [stderr] | [INFO] [stderr] 276 | return Return::ValueReturn(Value::IntValue(removed)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::IntValue(removed))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:279:25 [INFO] [stderr] | [INFO] [stderr] 279 | return Return::Error("WRONGTYPE not a set".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Error("WRONGTYPE not a set".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:284:17 [INFO] [stderr] | [INFO] [stderr] 284 | return Return::ValueReturn(Value::IntValue(self.values.len() as i64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::IntValue(self.values.len() as i64))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:297:17 [INFO] [stderr] | [INFO] [stderr] 297 | return Return::ValueReturn(Value::IntValue(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::IntValue(i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:300:17 [INFO] [stderr] | [INFO] [stderr] 300 | return self.run_command(Command::Echo {message: message}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.run_command(Command::Echo {message: message})` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:303:17 [INFO] [stderr] | [INFO] [stderr] 303 | return Return::ValueReturn(Value::StrValue(message)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::StrValue(message))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:306:17 [INFO] [stderr] | [INFO] [stderr] 306 | return Return::ValueReturn(Value::IntValue(if self.values.contains_key(&key) {1} else {0})); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(Value::IntValue(if self.values.contains_key(&key) {1} else {0}))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:309:17 [INFO] [stderr] | [INFO] [stderr] 309 | / return match self.values.get(&key) { [INFO] [stderr] 310 | | Some(&Value::IntValue(_)) => Return::ValueReturn(Value::StrValue("string".to_string())), [INFO] [stderr] 311 | | Some(&Value::StrValue(_)) => Return::ValueReturn(Value::StrValue("string".to_string())), [INFO] [stderr] 312 | | Some(&Value::SetValue(_)) => Return::ValueReturn(Value::StrValue("set".to_string())), [INFO] [stderr] ... | [INFO] [stderr] 316 | | _ => Return::ValueReturn(Value::Nil), [INFO] [stderr] 317 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 309 | match self.values.get(&key) { [INFO] [stderr] 310 | Some(&Value::IntValue(_)) => Return::ValueReturn(Value::StrValue("string".to_string())), [INFO] [stderr] 311 | Some(&Value::StrValue(_)) => Return::ValueReturn(Value::StrValue("string".to_string())), [INFO] [stderr] 312 | Some(&Value::SetValue(_)) => Return::ValueReturn(Value::StrValue("set".to_string())), [INFO] [stderr] 313 | Some(&Value::ListValue(_)) => Return::ValueReturn(Value::StrValue("list".to_string())), [INFO] [stderr] 314 | Some(&Value::SortedSetValue(_)) => Return::ValueReturn(Value::StrValue("zset".to_string())), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:321:17 [INFO] [stderr] | [INFO] [stderr] 321 | return Return::Ok; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Ok` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:332:17 [INFO] [stderr] | [INFO] [stderr] 332 | return Return::ValueReturn(r); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::ValueReturn(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:335:17 [INFO] [stderr] | [INFO] [stderr] 335 | return Return::Ok; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Return::Ok` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:347:13 [INFO] [stderr] | [INFO] [stderr] 347 | return Some(index as usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(index as usize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/db.rs:349:13 [INFO] [stderr] | [INFO] [stderr] 349 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/rustis/server.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | return self.client_tokens.pop().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.client_tokens.pop().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/rustis/db.rs:38:26 [INFO] [stderr] | [INFO] [stderr] 38 | Some(x) => { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `exp` [INFO] [stderr] --> src/rustis/db.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | exp:BinaryHeap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rustis/command.rs:56:19 [INFO] [stderr] | [INFO] [stderr] 56 | return if s.len() == 0 || s.contains(" ") { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rustis/command.rs:56:46 [INFO] [stderr] | [INFO] [stderr] 56 | return if s.len() == 0 || s.contains(" ") { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rustis/command.rs:67:15 [INFO] [stderr] | [INFO] [stderr] 67 | while s.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rustis/command.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | / match self { [INFO] [stderr] 96 | | &Return::Ok => write!(f, "+OK\r\n"), [INFO] [stderr] 97 | | &Return::Error(ref s) => write!(f, "-{}\r\n", s), [INFO] [stderr] 98 | | &Return::ValueReturn(ref v) => { [INFO] [stderr] 99 | | return v.fmt(f); [INFO] [stderr] 100 | | } [INFO] [stderr] 101 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 95 | match *self { [INFO] [stderr] 96 | Return::Ok => write!(f, "+OK\r\n"), [INFO] [stderr] 97 | Return::Error(ref s) => write!(f, "-{}\r\n", s), [INFO] [stderr] 98 | Return::ValueReturn(ref v) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `rustis::db::RustisDb` [INFO] [stderr] --> src/rustis/db.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> RustisDb { [INFO] [stderr] 15 | | return RustisDb { [INFO] [stderr] 16 | | values: HashMap::with_capacity(1024), [INFO] [stderr] 17 | | exp: BinaryHeap::with_capacity(1024), [INFO] [stderr] 18 | | }; [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/rustis/db.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | / match exp { [INFO] [stderr] 38 | | Some(x) => { [INFO] [stderr] 39 | | // TODO: add expiration time [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | None => {} [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | if let Some(x) = exp { [INFO] [stderr] 38 | // TODO: add expiration time [INFO] [stderr] 39 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rustis/db.rs:48:25 [INFO] [stderr] | [INFO] [stderr] 48 | / match x { [INFO] [stderr] 49 | | &Value::StrValue(ref s) => format!("{}{}", s, value), [INFO] [stderr] 50 | | &Value::IntValue(ref i) => format!("{}{}", i, value), [INFO] [stderr] 51 | | _ => return Return::Error("WRONGTYPE key doesn't contain a string".to_string()), [INFO] [stderr] 52 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | match *x { [INFO] [stderr] 49 | Value::StrValue(ref s) => format!("{}{}", s, value), [INFO] [stderr] 50 | Value::IntValue(ref i) => format!("{}{}", i, value), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/rustis/db.rs:290:21 [INFO] [stderr] | [INFO] [stderr] 290 | / match self.values.remove(key) { [INFO] [stderr] 291 | | Some(_) => { [INFO] [stderr] 292 | | i += 1; [INFO] [stderr] 293 | | } [INFO] [stderr] 294 | | None => {} [INFO] [stderr] 295 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 290 | if let Some(_) = self.values.remove(key) { [INFO] [stderr] 291 | i += 1; [INFO] [stderr] 292 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustis/db.rs:344:13 [INFO] [stderr] | [INFO] [stderr] 344 | index = len + index; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `index += len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/rustis/db.rs:38:26 [INFO] [stderr] | [INFO] [stderr] 38 | Some(x) => { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rustis/server.rs:46:28 [INFO] [stderr] | [INFO] [stderr] 46 | client_tokens: (1..MAX_CONNECTIONS+1).collect::>(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=MAX_CONNECTIONS)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/rustis/server.rs:79:29 [INFO] [stderr] | [INFO] [stderr] 79 | stream.read_to_string(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rustis/server.rs:83:43 [INFO] [stderr] | [INFO] [stderr] 83 | while c.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!c.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rustis/value.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / match self { [INFO] [stderr] 19 | | &Value::IntValue(ref i) => write!(f, ":{}\r\n", i), [INFO] [stderr] 20 | | &Value::StrValue(ref s) => write!(f, "${}\r\n{}\r\n", s.len(), s), [INFO] [stderr] 21 | | &Value::ArrayValue(ref a) => write!(f, "*{}\r\n{}", a.len(), a.iter().map(|ref x| format!("{}", x)).collect::>().join("")), [INFO] [stderr] 22 | | _ => write!(f, "$-1\r\n"), [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 18 | match *self { [INFO] [stderr] 19 | Value::IntValue(ref i) => write!(f, ":{}\r\n", i), [INFO] [stderr] 20 | Value::StrValue(ref s) => write!(f, "${}\r\n{}\r\n", s.len(), s), [INFO] [stderr] 21 | Value::ArrayValue(ref a) => write!(f, "*{}\r\n{}", a.len(), a.iter().map(|ref x| format!("{}", x)).collect::>().join("")), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: field is never used: `exp` [INFO] [stderr] --> src/rustis/db.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | exp:BinaryHeap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rustis/command.rs:56:19 [INFO] [stderr] | [INFO] [stderr] 56 | return if s.len() == 0 || s.contains(" ") { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/rustis/command.rs:56:46 [INFO] [stderr] | [INFO] [stderr] 56 | return if s.len() == 0 || s.contains(" ") { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rustis/command.rs:67:15 [INFO] [stderr] | [INFO] [stderr] 67 | while s.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rustis/command.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | / match self { [INFO] [stderr] 96 | | &Return::Ok => write!(f, "+OK\r\n"), [INFO] [stderr] 97 | | &Return::Error(ref s) => write!(f, "-{}\r\n", s), [INFO] [stderr] 98 | | &Return::ValueReturn(ref v) => { [INFO] [stderr] 99 | | return v.fmt(f); [INFO] [stderr] 100 | | } [INFO] [stderr] 101 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 95 | match *self { [INFO] [stderr] 96 | Return::Ok => write!(f, "+OK\r\n"), [INFO] [stderr] 97 | Return::Error(ref s) => write!(f, "-{}\r\n", s), [INFO] [stderr] 98 | Return::ValueReturn(ref v) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `rustis::db::RustisDb` [INFO] [stderr] --> src/rustis/db.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> RustisDb { [INFO] [stderr] 15 | | return RustisDb { [INFO] [stderr] 16 | | values: HashMap::with_capacity(1024), [INFO] [stderr] 17 | | exp: BinaryHeap::with_capacity(1024), [INFO] [stderr] 18 | | }; [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/rustis/db.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | / match exp { [INFO] [stderr] 38 | | Some(x) => { [INFO] [stderr] 39 | | // TODO: add expiration time [INFO] [stderr] 40 | | } [INFO] [stderr] 41 | | None => {} [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | if let Some(x) = exp { [INFO] [stderr] 38 | // TODO: add expiration time [INFO] [stderr] 39 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rustis/db.rs:48:25 [INFO] [stderr] | [INFO] [stderr] 48 | / match x { [INFO] [stderr] 49 | | &Value::StrValue(ref s) => format!("{}{}", s, value), [INFO] [stderr] 50 | | &Value::IntValue(ref i) => format!("{}{}", i, value), [INFO] [stderr] 51 | | _ => return Return::Error("WRONGTYPE key doesn't contain a string".to_string()), [INFO] [stderr] 52 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | match *x { [INFO] [stderr] 49 | Value::StrValue(ref s) => format!("{}{}", s, value), [INFO] [stderr] 50 | Value::IntValue(ref i) => format!("{}{}", i, value), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/rustis/db.rs:290:21 [INFO] [stderr] | [INFO] [stderr] 290 | / match self.values.remove(key) { [INFO] [stderr] 291 | | Some(_) => { [INFO] [stderr] 292 | | i += 1; [INFO] [stderr] 293 | | } [INFO] [stderr] 294 | | None => {} [INFO] [stderr] 295 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 290 | if let Some(_) = self.values.remove(key) { [INFO] [stderr] 291 | i += 1; [INFO] [stderr] 292 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/rustis/db.rs:344:13 [INFO] [stderr] | [INFO] [stderr] 344 | index = len + index; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `index += len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/rustis/server.rs:46:28 [INFO] [stderr] | [INFO] [stderr] 46 | client_tokens: (1..MAX_CONNECTIONS+1).collect::>(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=MAX_CONNECTIONS)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/rustis/server.rs:79:29 [INFO] [stderr] | [INFO] [stderr] 79 | stream.read_to_string(buf); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/rustis/server.rs:83:43 [INFO] [stderr] | [INFO] [stderr] 83 | while c.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!c.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/rustis/value.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / match self { [INFO] [stderr] 19 | | &Value::IntValue(ref i) => write!(f, ":{}\r\n", i), [INFO] [stderr] 20 | | &Value::StrValue(ref s) => write!(f, "${}\r\n{}\r\n", s.len(), s), [INFO] [stderr] 21 | | &Value::ArrayValue(ref a) => write!(f, "*{}\r\n{}", a.len(), a.iter().map(|ref x| format!("{}", x)).collect::>().join("")), [INFO] [stderr] 22 | | _ => write!(f, "$-1\r\n"), [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 18 | match *self { [INFO] [stderr] 19 | Value::IntValue(ref i) => write!(f, ":{}\r\n", i), [INFO] [stderr] 20 | Value::StrValue(ref s) => write!(f, "${}\r\n{}\r\n", s.len(), s), [INFO] [stderr] 21 | Value::ArrayValue(ref a) => write!(f, "*{}\r\n{}", a.len(), a.iter().map(|ref x| format!("{}", x)).collect::>().join("")), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.33s [INFO] running `"docker" "inspect" "c420111062b6eb83a1893da5fb8e89a856094e2d4c6e6bac8ebf7afd6270d9c8"` [INFO] running `"docker" "rm" "-f" "c420111062b6eb83a1893da5fb8e89a856094e2d4c6e6bac8ebf7afd6270d9c8"` [INFO] [stdout] c420111062b6eb83a1893da5fb8e89a856094e2d4c6e6bac8ebf7afd6270d9c8