[INFO] updating cached repository RubenTipparach/rustysponge [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/RubenTipparach/rustysponge [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/RubenTipparach/rustysponge" "work/ex/clippy-test-run/sources/stable/gh/RubenTipparach/rustysponge"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/RubenTipparach/rustysponge'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/RubenTipparach/rustysponge" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RubenTipparach/rustysponge"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RubenTipparach/rustysponge'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c3f94059f23801e743545971972c25584e344360 [INFO] sha for GitHub repo RubenTipparach/rustysponge: c3f94059f23801e743545971972c25584e344360 [INFO] validating manifest of RubenTipparach/rustysponge on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of RubenTipparach/rustysponge on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing RubenTipparach/rustysponge [INFO] finished frobbing RubenTipparach/rustysponge [INFO] frobbed toml for RubenTipparach/rustysponge written to work/ex/clippy-test-run/sources/stable/gh/RubenTipparach/rustysponge/Cargo.toml [INFO] started frobbing RubenTipparach/rustysponge [INFO] finished frobbing RubenTipparach/rustysponge [INFO] frobbed toml for RubenTipparach/rustysponge written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RubenTipparach/rustysponge/Cargo.toml [INFO] crate RubenTipparach/rustysponge has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting RubenTipparach/rustysponge against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/RubenTipparach/rustysponge:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a629e0d5dafa41834fd7468580b6c1564273604c73b0748cafc14348dcb45f79 [INFO] running `"docker" "start" "-a" "a629e0d5dafa41834fd7468580b6c1564273604c73b0748cafc14348dcb45f79"` [INFO] [stderr] Compiling libc v0.2.26 [INFO] [stderr] Checking shared_library v0.1.6 [INFO] [stderr] Checking tempfile v2.1.6 [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Compiling gl_generator v0.5.5 [INFO] [stderr] Checking gfx_core v0.5.1 [INFO] [stderr] Checking pistoncore-input v0.15.0 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Compiling rand v0.3.15 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking pistoncore-window v0.24.0 [INFO] [stderr] Compiling gl v0.6.3 [INFO] [stderr] Compiling glutin v0.7.4 [INFO] [stderr] Compiling gfx_gl v0.3.1 [INFO] [stderr] Compiling glutin v0.8.1 [INFO] [stderr] Checking pistoncore-event_loop v0.27.0 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking piston v0.27.0 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking image v0.12.4 [INFO] [stderr] Checking image v0.14.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.44.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.8 [INFO] [stderr] Checking wayland-sys v0.8.7 [INFO] [stderr] Checking wayland-client v0.7.8 [INFO] [stderr] Checking wayland-client v0.8.7 [INFO] [stderr] Checking wayland-window v0.4.4 [INFO] [stderr] Checking wayland-kbd v0.6.3 [INFO] [stderr] Checking wayland-window v0.5.0 [INFO] [stderr] Checking wayland-kbd v0.8.0 [INFO] [stderr] Checking gfx v0.13.0 [INFO] [stderr] Checking gfx_device_gl v0.12.0 [INFO] [stderr] Checking winit v0.5.11 [INFO] [stderr] Checking winit v0.6.4 [INFO] [stderr] Checking piston-gfx_texture v0.20.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.37.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.33.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.35.0 [INFO] [stderr] Checking piston_window v0.61.0 [INFO] [stderr] Checking pong v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:105:12 [INFO] [stderr] | [INFO] [stderr] 105 | if (self.px > (self.x + -25.0) [INFO] [stderr] | ____________^ [INFO] [stderr] 106 | | && (self.py > self.y - 25.0 && self.py < self.y + 25.0) [INFO] [stderr] 107 | | ) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 105 | if self.px > (self.x + -25.0) [INFO] [stderr] 106 | && (self.py > self.y - 25.0 && self.py < self.y + 25.0) [INFO] [stderr] 107 | [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:115:12 [INFO] [stderr] | [INFO] [stderr] 115 | if (self.px < (self.ex + 25.0) [INFO] [stderr] | ____________^ [INFO] [stderr] 116 | | && (self.py > self.ey - 25.0 && self.py < self.ey + 25.0)) [INFO] [stderr] | |__________________________________________________________________^ [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 115 | if self.px < (self.ex + 25.0) [INFO] [stderr] 116 | && (self.py > self.ey - 25.0 && self.py < self.ey + 25.0) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:124:11 [INFO] [stderr] | [INFO] [stderr] 124 | if(self.py > self.height as f64 / 2.0 || self.py < self.height as f64 / -2.0 ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:135:11 [INFO] [stderr] | [INFO] [stderr] 135 | if(self.px > self.width as f64/2.0 || self.px < -1.0*(self.width as f64)/2.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/main.rs:97:26 [INFO] [stderr] | [INFO] [stderr] 97 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `move_x` [INFO] [stderr] --> src/main.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | fn move_x(&mut self, val: f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `move_ex` [INFO] [stderr] --> src/main.rs:156:5 [INFO] [stderr] | [INFO] [stderr] 156 | fn move_ex(&mut self, val: f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `pongBall` should have a snake case name such as `pong_ball` [INFO] [stderr] --> src/main.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | let pongBall = rectangle::square(0.0, 0.0, 10.0); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | ((args.width / 2 ) as f64) + self.x, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width / 2 )` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | ((args.height / 2) as f64) + self.y, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | ((args.width / 2 ) as f64) + self.ex, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width / 2 )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | ((args.height / 2) as f64) + self.ey, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | ((args.width / 2 ) as f64) + self.px, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width / 2 )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | ((args.height / 2) as f64) + self.py); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable `playerTransform` should have a snake case name such as `player_transform` [INFO] [stderr] --> src/main.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | let playerTransform = c.transform.trans(x , y) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `enemyTransform` should have a snake case name such as `enemy_transform` [INFO] [stderr] --> src/main.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | let enemyTransform = c.transform.trans(ex , ey) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `pongTransform` should have a snake case name such as `pong_transform` [INFO] [stderr] --> src/main.rs:87:16 [INFO] [stderr] | [INFO] [stderr] 87 | let pongTransform = c.transform.trans(px , py) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:97:32 [INFO] [stderr] | [INFO] [stderr] 97 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:124:22 [INFO] [stderr] | [INFO] [stderr] 124 | if(self.py > self.height as f64 / 2.0 || self.py < self.height as f64 / -2.0 ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:124:60 [INFO] [stderr] | [INFO] [stderr] 124 | if(self.py > self.height as f64 / 2.0 || self.py < self.height as f64 / -2.0 ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | self.vpy = -1.0 * self.vpy; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.vpy *= -1.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:135:22 [INFO] [stderr] | [INFO] [stderr] 135 | if(self.px > self.width as f64/2.0 || self.px < -1.0*(self.width as f64)/2.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:135:62 [INFO] [stderr] | [INFO] [stderr] 135 | if(self.px > self.width as f64/2.0 || self.px < -1.0*(self.width as f64)/2.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:105:12 [INFO] [stderr] | [INFO] [stderr] 105 | if (self.px > (self.x + -25.0) [INFO] [stderr] | ____________^ [INFO] [stderr] 106 | | && (self.py > self.y - 25.0 && self.py < self.y + 25.0) [INFO] [stderr] 107 | | ) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 105 | if self.px > (self.x + -25.0) [INFO] [stderr] 106 | && (self.py > self.y - 25.0 && self.py < self.y + 25.0) [INFO] [stderr] 107 | [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:115:12 [INFO] [stderr] | [INFO] [stderr] 115 | if (self.px < (self.ex + 25.0) [INFO] [stderr] | ____________^ [INFO] [stderr] 116 | | && (self.py > self.ey - 25.0 && self.py < self.ey + 25.0)) [INFO] [stderr] | |__________________________________________________________________^ [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 115 | if self.px < (self.ex + 25.0) [INFO] [stderr] 116 | && (self.py > self.ey - 25.0 && self.py < self.ey + 25.0) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:124:11 [INFO] [stderr] | [INFO] [stderr] 124 | if(self.py > self.height as f64 / 2.0 || self.py < self.height as f64 / -2.0 ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:135:11 [INFO] [stderr] | [INFO] [stderr] 135 | if(self.px > self.width as f64/2.0 || self.px < -1.0*(self.width as f64)/2.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/main.rs:97:26 [INFO] [stderr] | [INFO] [stderr] 97 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `move_x` [INFO] [stderr] --> src/main.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | fn move_x(&mut self, val: f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `move_ex` [INFO] [stderr] --> src/main.rs:156:5 [INFO] [stderr] | [INFO] [stderr] 156 | fn move_ex(&mut self, val: f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `pongBall` should have a snake case name such as `pong_ball` [INFO] [stderr] --> src/main.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | let pongBall = rectangle::square(0.0, 0.0, 10.0); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | ((args.width / 2 ) as f64) + self.x, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width / 2 )` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | ((args.height / 2) as f64) + self.y, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | ((args.width / 2 ) as f64) + self.ex, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width / 2 )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | ((args.height / 2) as f64) + self.ey, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | ((args.width / 2 ) as f64) + self.px, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width / 2 )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | ((args.height / 2) as f64) + self.py); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable `playerTransform` should have a snake case name such as `player_transform` [INFO] [stderr] --> src/main.rs:72:17 [INFO] [stderr] | [INFO] [stderr] 72 | let playerTransform = c.transform.trans(x , y) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `enemyTransform` should have a snake case name such as `enemy_transform` [INFO] [stderr] --> src/main.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | let enemyTransform = c.transform.trans(ex , ey) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `pongTransform` should have a snake case name such as `pong_transform` [INFO] [stderr] --> src/main.rs:87:16 [INFO] [stderr] | [INFO] [stderr] 87 | let pongTransform = c.transform.trans(px , py) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:97:32 [INFO] [stderr] | [INFO] [stderr] 97 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:124:22 [INFO] [stderr] | [INFO] [stderr] 124 | if(self.py > self.height as f64 / 2.0 || self.py < self.height as f64 / -2.0 ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:124:60 [INFO] [stderr] | [INFO] [stderr] 124 | if(self.py > self.height as f64 / 2.0 || self.py < self.height as f64 / -2.0 ) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | self.vpy = -1.0 * self.vpy; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.vpy *= -1.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:135:22 [INFO] [stderr] | [INFO] [stderr] 135 | if(self.px > self.width as f64/2.0 || self.px < -1.0*(self.width as f64)/2.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:135:62 [INFO] [stderr] | [INFO] [stderr] 135 | if(self.px > self.width as f64/2.0 || self.px < -1.0*(self.width as f64)/2.0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 39s [INFO] running `"docker" "inspect" "a629e0d5dafa41834fd7468580b6c1564273604c73b0748cafc14348dcb45f79"` [INFO] running `"docker" "rm" "-f" "a629e0d5dafa41834fd7468580b6c1564273604c73b0748cafc14348dcb45f79"` [INFO] [stdout] a629e0d5dafa41834fd7468580b6c1564273604c73b0748cafc14348dcb45f79