[INFO] updating cached repository RomainCscn/messenger-links-parser
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/RomainCscn/messenger-links-parser
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/RomainCscn/messenger-links-parser" "work/ex/clippy-test-run/sources/stable/gh/RomainCscn/messenger-links-parser"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/RomainCscn/messenger-links-parser'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/RomainCscn/messenger-links-parser" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RomainCscn/messenger-links-parser"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RomainCscn/messenger-links-parser'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 82c04b0f0436080abb6afd1e2d1040ac2e0a2410
[INFO] sha for GitHub repo RomainCscn/messenger-links-parser: 82c04b0f0436080abb6afd1e2d1040ac2e0a2410
[INFO] validating manifest of RomainCscn/messenger-links-parser on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of RomainCscn/messenger-links-parser on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing RomainCscn/messenger-links-parser
[INFO] finished frobbing RomainCscn/messenger-links-parser
[INFO] frobbed toml for RomainCscn/messenger-links-parser written to work/ex/clippy-test-run/sources/stable/gh/RomainCscn/messenger-links-parser/Cargo.toml
[INFO] started frobbing RomainCscn/messenger-links-parser
[INFO] finished frobbing RomainCscn/messenger-links-parser
[INFO] frobbed toml for RomainCscn/messenger-links-parser written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RomainCscn/messenger-links-parser/Cargo.toml
[INFO] crate RomainCscn/messenger-links-parser has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting RomainCscn/messenger-links-parser against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/RomainCscn/messenger-links-parser:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e16b06fdb6594e069d48e0862afedef6fa91847934e5fae617b6d7be0f28a1cc
[INFO] running `"docker" "start" "-a" "e16b06fdb6594e069d48e0862afedef6fa91847934e5fae617b6d7be0f28a1cc"`
[INFO] [stderr]     Checking arc-swap v0.3.5
[INFO] [stderr]    Compiling ring v0.13.3
[INFO] [stderr]     Checking listenfd v0.3.3
[INFO] [stderr]     Checking serde_urlencoded v0.5.3
[INFO] [stderr]    Compiling synstructure v0.10.1
[INFO] [stderr]    Compiling actix_derive v0.3.2
[INFO] [stderr]     Checking env_logger v0.5.13
[INFO] [stderr]     Checking crossbeam-channel v0.2.6
[INFO] [stderr]     Checking tokio v0.1.11
[INFO] [stderr]     Checking signal-hook v0.1.6
[INFO] [stderr]     Checking tokio-signal v0.2.6
[INFO] [stderr]    Compiling failure_derive v0.1.3
[INFO] [stderr]     Checking failure v0.1.3
[INFO] [stderr]     Checking trust-dns-proto v0.5.0
[INFO] [stderr]     Checking cookie v0.11.0
[INFO] [stderr]     Checking trust-dns-resolver v0.10.0
[INFO] [stderr]     Checking actix v0.7.6
[INFO] [stderr]     Checking actix-net v0.1.1
[INFO] [stderr]     Checking actix-web v0.7.13
[INFO] [stderr]     Checking messenger_parser v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/lib.rs:100:5
[INFO] [stderr]     |
[INFO] [stderr] 100 |     link_info
[INFO] [stderr]     |     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/lib.rs:95:20
[INFO] [stderr]     |
[INFO] [stderr] 95  |      let link_info = LinkInfo {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 96  | |       sender_name,
[INFO] [stderr] 97  | |       date: dt.format("%d-%m-%Y %H:%M:%S").to_string(),
[INFO] [stderr] 98  | |       link,
[INFO] [stderr] 99  | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:109:3
[INFO] [stderr]     |
[INFO] [stderr] 109 |   return None;
[INFO] [stderr]     |   ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:121:3
[INFO] [stderr]     |
[INFO] [stderr] 121 |   return None;
[INFO] [stderr]     |   ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:382:25
[INFO] [stderr]     |
[INFO] [stderr] 382 |           timestamp_ms: 1518370388967,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^ help: consider: `1_518_370_388_967`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:388:25
[INFO] [stderr]     |
[INFO] [stderr] 388 |           timestamp_ms: 1433346000259,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^ help: consider: `1_433_346_000_259`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:394:25
[INFO] [stderr]     |
[INFO] [stderr] 394 |           timestamp_ms: 1518370850974,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^ help: consider: `1_518_370_850_974`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/lib.rs:100:5
[INFO] [stderr]     |
[INFO] [stderr] 100 |     link_info
[INFO] [stderr]     |     ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/lib.rs:95:20
[INFO] [stderr]     |
[INFO] [stderr] 95  |      let link_info = LinkInfo {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 96  | |       sender_name,
[INFO] [stderr] 97  | |       date: dt.format("%d-%m-%Y %H:%M:%S").to_string(),
[INFO] [stderr] 98  | |       link,
[INFO] [stderr] 99  | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:109:3
[INFO] [stderr]     |
[INFO] [stderr] 109 |   return None;
[INFO] [stderr]     |   ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:121:3
[INFO] [stderr]     |
[INFO] [stderr] 121 |   return None;
[INFO] [stderr]     |   ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/server.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 | /     let result;
[INFO] [stderr] 14 | |     if query.year.is_some() || query.month.is_some() || query.day.is_some() {
[INFO] [stderr] 15 | |         result = run(config, Some(query.into_inner())).unwrap();
[INFO] [stderr] 16 | |     } else {
[INFO] [stderr] 17 | |         result = run(config, None).unwrap();
[INFO] [stderr] 18 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let result = if query.year.is_some() || query.month.is_some() || query.day.is_some() { run(config, Some(query.into_inner())).unwrap() } else { run(config, None).unwrap() };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/server.rs:24:8
[INFO] [stderr]    |
[INFO] [stderr] 24 |     Ok(format!("{}", run_config(config, query)))
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `run_config(config, query).to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/server.rs:31:8
[INFO] [stderr]    |
[INFO] [stderr] 31 |     Ok(format!("{}", run_config(config, query)))
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `run_config(config, query).to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/server.rs:38:8
[INFO] [stderr]    |
[INFO] [stderr] 38 |     Ok(format!("{}", run_config(config, query)))
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `run_config(config, query).to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/server.rs:43:8
[INFO] [stderr]    |
[INFO] [stderr] 43 |     Ok(format!("{}", run_config(config, query)))
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `run_config(config, query).to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:208:34
[INFO] [stderr]     |
[INFO] [stderr] 208 | fn return_links_json(links_info: &Vec<LinkInfo>) -> Result<(String), Box<dyn Error>> {
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^ help: change this to: `&[LinkInfo]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]    --> src/lib.rs:307:41
[INFO] [stderr]     |
[INFO] [stderr] 307 |             search_links_without_filter(&vec![message1, message2, message3])
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[message1, message2, message3]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]    --> src/lib.rs:345:43
[INFO] [stderr]     |
[INFO] [stderr] 345 |             search_links_with_site_filter(&vec![message1, message2, message3], String::from("reddit"))
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[message1, message2, message3]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/server.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 | /     let result;
[INFO] [stderr] 14 | |     if query.year.is_some() || query.month.is_some() || query.day.is_some() {
[INFO] [stderr] 15 | |         result = run(config, Some(query.into_inner())).unwrap();
[INFO] [stderr] 16 | |     } else {
[INFO] [stderr] 17 | |         result = run(config, None).unwrap();
[INFO] [stderr] 18 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let result = if query.year.is_some() || query.month.is_some() || query.day.is_some() { run(config, Some(query.into_inner())).unwrap() } else { run(config, None).unwrap() };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/server.rs:24:8
[INFO] [stderr]    |
[INFO] [stderr] 24 |     Ok(format!("{}", run_config(config, query)))
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `run_config(config, query).to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/server.rs:31:8
[INFO] [stderr]    |
[INFO] [stderr] 31 |     Ok(format!("{}", run_config(config, query)))
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `run_config(config, query).to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/server.rs:38:8
[INFO] [stderr]    |
[INFO] [stderr] 38 |     Ok(format!("{}", run_config(config, query)))
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `run_config(config, query).to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/server.rs:43:8
[INFO] [stderr]    |
[INFO] [stderr] 43 |     Ok(format!("{}", run_config(config, query)))
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `run_config(config, query).to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:208:34
[INFO] [stderr]     |
[INFO] [stderr] 208 | fn return_links_json(links_info: &Vec<LinkInfo>) -> Result<(String), Box<dyn Error>> {
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^ help: change this to: `&[LinkInfo]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 26s
[INFO] running `"docker" "inspect" "e16b06fdb6594e069d48e0862afedef6fa91847934e5fae617b6d7be0f28a1cc"`
[INFO] running `"docker" "rm" "-f" "e16b06fdb6594e069d48e0862afedef6fa91847934e5fae617b6d7be0f28a1cc"`
[INFO] [stdout] e16b06fdb6594e069d48e0862afedef6fa91847934e5fae617b6d7be0f28a1cc