[INFO] updating cached repository RollForGuild/RoboGM [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/RollForGuild/RoboGM [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/RollForGuild/RoboGM" "work/ex/clippy-test-run/sources/stable/gh/RollForGuild/RoboGM"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/RollForGuild/RoboGM'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/RollForGuild/RoboGM" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RollForGuild/RoboGM"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RollForGuild/RoboGM'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] affcfd00c7449e36670731d4a29e0b3ef4e556ad [INFO] sha for GitHub repo RollForGuild/RoboGM: affcfd00c7449e36670731d4a29e0b3ef4e556ad [INFO] validating manifest of RollForGuild/RoboGM on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of RollForGuild/RoboGM on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing RollForGuild/RoboGM [INFO] finished frobbing RollForGuild/RoboGM [INFO] frobbed toml for RollForGuild/RoboGM written to work/ex/clippy-test-run/sources/stable/gh/RollForGuild/RoboGM/Cargo.toml [INFO] started frobbing RollForGuild/RoboGM [INFO] finished frobbing RollForGuild/RoboGM [INFO] frobbed toml for RollForGuild/RoboGM written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RollForGuild/RoboGM/Cargo.toml [INFO] crate RollForGuild/RoboGM has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting RollForGuild/RoboGM against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/RollForGuild/RoboGM:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6cfd5b621d5555df03e790ffe9e2ec3ac79a8ba05e5a2ce9ccc56af9ac347f8f [INFO] running `"docker" "start" "-a" "6cfd5b621d5555df03e790ffe9e2ec3ac79a8ba05e5a2ce9ccc56af9ac347f8f"` [INFO] [stderr] Checking robo_gm v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | let b: f64 = (radius as f64) * r * t.sin(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | let b: f64 = (radius as f64) * r * t.sin(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `rand::Rng` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use rand::Rng; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | fn gen_rectangles() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return (a.round() as i32, b.round() as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(a.round() as i32, b.round() as i32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | return (a, b); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `(a, b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rng` [INFO] [stderr] --> src/main.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | let mut rng = rand::thread_rng(); [INFO] [stderr] | ^^^ help: consider using `_rng` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | let mut rng = rand::thread_rng(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `gen_rectangles` [INFO] [stderr] --> src/main.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | fn gen_rectangles() -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `rand::Rng` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use rand::Rng; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | fn gen_rectangles() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return (a.round() as i32, b.round() as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(a.round() as i32, b.round() as i32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | return (a, b); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `(a, b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:40:42 [INFO] [stderr] | [INFO] [stderr] 40 | let (a, b) = point_in_cricle_f64(radius as f64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(radius)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / let r: f64; [INFO] [stderr] 50 | | if u > 1.0 { [INFO] [stderr] 51 | | r = 2.0 - u; [INFO] [stderr] 52 | | } else { [INFO] [stderr] 53 | | r = u; [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let r = if u > 1.0 { 2.0 - u } else { u };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rng` [INFO] [stderr] --> src/main.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | let mut rng = rand::thread_rng(); [INFO] [stderr] | ^^^ help: consider using `_rng` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | let mut rng = rand::thread_rng(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `gen_rectangles` [INFO] [stderr] --> src/main.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | fn gen_rectangles() -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:40:42 [INFO] [stderr] | [INFO] [stderr] 40 | let (a, b) = point_in_cricle_f64(radius as f64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(radius)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | / let r: f64; [INFO] [stderr] 50 | | if u > 1.0 { [INFO] [stderr] 51 | | r = 2.0 - u; [INFO] [stderr] 52 | | } else { [INFO] [stderr] 53 | | r = u; [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let r = if u > 1.0 { 2.0 - u } else { u };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.39s [INFO] running `"docker" "inspect" "6cfd5b621d5555df03e790ffe9e2ec3ac79a8ba05e5a2ce9ccc56af9ac347f8f"` [INFO] running `"docker" "rm" "-f" "6cfd5b621d5555df03e790ffe9e2ec3ac79a8ba05e5a2ce9ccc56af9ac347f8f"` [INFO] [stdout] 6cfd5b621d5555df03e790ffe9e2ec3ac79a8ba05e5a2ce9ccc56af9ac347f8f