[INFO] updating cached repository Rohrschacht/hashfilter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Rohrschacht/hashfilter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Rohrschacht/hashfilter" "work/ex/clippy-test-run/sources/stable/gh/Rohrschacht/hashfilter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Rohrschacht/hashfilter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Rohrschacht/hashfilter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Rohrschacht/hashfilter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Rohrschacht/hashfilter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 687876cf9b8fd3cdcf91dfc1c8e2c2ddeac4ab00 [INFO] sha for GitHub repo Rohrschacht/hashfilter: 687876cf9b8fd3cdcf91dfc1c8e2c2ddeac4ab00 [INFO] validating manifest of Rohrschacht/hashfilter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Rohrschacht/hashfilter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Rohrschacht/hashfilter [INFO] finished frobbing Rohrschacht/hashfilter [INFO] frobbed toml for Rohrschacht/hashfilter written to work/ex/clippy-test-run/sources/stable/gh/Rohrschacht/hashfilter/Cargo.toml [INFO] started frobbing Rohrschacht/hashfilter [INFO] finished frobbing Rohrschacht/hashfilter [INFO] frobbed toml for Rohrschacht/hashfilter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Rohrschacht/hashfilter/Cargo.toml [INFO] crate Rohrschacht/hashfilter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Rohrschacht/hashfilter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Rohrschacht/hashfilter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dfa531f6d313ad674c161bbf7d0d057309c349fafbc270751db2c69fad31275b [INFO] running `"docker" "start" "-a" "dfa531f6d313ad674c161bbf7d0d057309c349fafbc270751db2c69fad31275b"` [INFO] [stderr] Checking hashfilter v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:181:16 [INFO] [stderr] | [INFO] [stderr] 181 | _ => { return Err("Could not recognize hashing algorithm") } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Could not recognize hashing algorithm")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:314:9 [INFO] [stderr] | [INFO] [stderr] 314 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filter.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | return Err("Could not open _algorithm_sum.txt"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Could not open _algorithm_sum.txt")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filter.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/update.rs:87:90 [INFO] [stderr] | [INFO] [stderr] 87 | fn execute_threads_unlimited(opts: &super::util::Options, dirs_to_process: Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:11:25 [INFO] [stderr] | [INFO] [stderr] 11 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:181:16 [INFO] [stderr] | [INFO] [stderr] 181 | _ => { return Err("Could not recognize hashing algorithm") } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Could not recognize hashing algorithm")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:314:9 [INFO] [stderr] | [INFO] [stderr] 314 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filter.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | return Err("Could not open _algorithm_sum.txt"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Could not open _algorithm_sum.txt")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filter.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/update.rs:87:90 [INFO] [stderr] | [INFO] [stderr] 87 | fn execute_threads_unlimited(opts: &super::util::Options, dirs_to_process: Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:11:25 [INFO] [stderr] | [INFO] [stderr] 11 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/util.rs:78:32 [INFO] [stderr] | [INFO] [stderr] 78 | if arg.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/util.rs:85:47 [INFO] [stderr] | [INFO] [stderr] 85 | match args.get(i + 1).expect(format!("Usage: {} {} quiet/info/debug", opts.program_name, args[i]).as_ref()).as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Usage: {} {} quiet/info/debug", opts.program_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/util.rs:95:41 [INFO] [stderr] | [INFO] [stderr] 95 | .trim().parse().expect(format!("Usage: {} -T NUMBER_OF_MAX_THREADS", opts.program_name).as_ref()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Usage: {} -T NUMBER_OF_MAX_THREADS", opts.program_name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/util.rs:94:78 [INFO] [stderr] | [INFO] [stderr] 94 | "-T" | "--threads" => opts.num_threads = args.get(i + 1).expect(format!("Usage: {} -T NUMBER_OF_MAX_THREADS", opts.program_name).as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Usage: {} -T NUMBER_OF_MAX_THREADS", opts.program_name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/util.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | / match arg.contains("=") { [INFO] [stderr] 143 | | false => { [INFO] [stderr] 144 | | if arg.contains("-") && !arg.contains("--") && arg.len() > 2 { [INFO] [stderr] 145 | | let characters = &arg[1..]; [INFO] [stderr] ... | [INFO] [stderr] 160 | | } [INFO] [stderr] 161 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 142 | if arg.contains("=") { [INFO] [stderr] 143 | let position = arg.find("=").unwrap(); [INFO] [stderr] 144 | let prefix = arg[0..position].to_string(); [INFO] [stderr] 145 | let suffix = arg[position + 1 ..].to_string(); [INFO] [stderr] 146 | prepared_args.push(prefix); [INFO] [stderr] 147 | prepared_args.push(suffix); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/util.rs:142:28 [INFO] [stderr] | [INFO] [stderr] 142 | match arg.contains("=") { [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/util.rs:144:33 [INFO] [stderr] | [INFO] [stderr] 144 | if arg.contains("-") && !arg.contains("--") && arg.len() > 2 { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/util.rs:155:41 [INFO] [stderr] | [INFO] [stderr] 155 | let position = arg.find("=").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/util.rs:297:49 [INFO] [stderr] | [INFO] [stderr] 297 | let position = path_string.find("/").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/util.rs:322:12 [INFO] [stderr] | [INFO] [stderr] 322 | if self.unfinished_read.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.unfinished_read.is_empty()` [INFO] [stderr] | [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/util.rs:78:32 [INFO] [stderr] | [INFO] [stderr] 78 | if arg.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/util.rs:85:47 [INFO] [stderr] | [INFO] [stderr] 85 | match args.get(i + 1).expect(format!("Usage: {} {} quiet/info/debug", opts.program_name, args[i]).as_ref()).as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Usage: {} {} quiet/info/debug", opts.program_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/util.rs:95:41 [INFO] [stderr] | [INFO] [stderr] 95 | .trim().parse().expect(format!("Usage: {} -T NUMBER_OF_MAX_THREADS", opts.program_name).as_ref()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Usage: {} -T NUMBER_OF_MAX_THREADS", opts.program_name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/util.rs:94:78 [INFO] [stderr] | [INFO] [stderr] 94 | "-T" | "--threads" => opts.num_threads = args.get(i + 1).expect(format!("Usage: {} -T NUMBER_OF_MAX_THREADS", opts.program_name).as_ref()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Usage: {} -T NUMBER_OF_MAX_THREADS", opts.program_name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/util.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | / match arg.contains("=") { [INFO] [stderr] 143 | | false => { [INFO] [stderr] 144 | | if arg.contains("-") && !arg.contains("--") && arg.len() > 2 { [INFO] [stderr] 145 | | let characters = &arg[1..]; [INFO] [stderr] ... | [INFO] [stderr] 160 | | } [INFO] [stderr] 161 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 142 | if arg.contains("=") { [INFO] [stderr] 143 | let position = arg.find("=").unwrap(); [INFO] [stderr] 144 | let prefix = arg[0..position].to_string(); [INFO] [stderr] 145 | let suffix = arg[position + 1 ..].to_string(); [INFO] [stderr] 146 | prepared_args.push(prefix); [INFO] [stderr] 147 | prepared_args.push(suffix); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/util.rs:142:28 [INFO] [stderr] | [INFO] [stderr] 142 | match arg.contains("=") { [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/util.rs:144:33 [INFO] [stderr] | [INFO] [stderr] 144 | if arg.contains("-") && !arg.contains("--") && arg.len() > 2 { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/util.rs:155:41 [INFO] [stderr] | [INFO] [stderr] 155 | let position = arg.find("=").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/update.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / match opts.subdir_mode { [INFO] [stderr] 23 | | false => update_hashsums(PathBuf::from(&opts.folder), opts), [INFO] [stderr] 24 | | true => { [INFO] [stderr] 25 | | let dirs_to_process = gather_directories_to_process(&opts); [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/util.rs:297:49 [INFO] [stderr] | [INFO] [stderr] 297 | let position = path_string.find("/").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/util.rs:322:12 [INFO] [stderr] | [INFO] [stderr] 322 | if self.unfinished_read.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.unfinished_read.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 22 | if opts.subdir_mode { [INFO] [stderr] 23 | let dirs_to_process = gather_directories_to_process(&opts); [INFO] [stderr] 24 | [INFO] [stderr] 25 | match opts.num_threads { [INFO] [stderr] 26 | 0 => execute_threads_unlimited(&opts, dirs_to_process), [INFO] [stderr] 27 | _ => execute_threads_limited(opts, dirs_to_process) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/update.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / match opts.subdir_mode { [INFO] [stderr] 23 | | false => update_hashsums(PathBuf::from(&opts.folder), opts), [INFO] [stderr] 24 | | true => { [INFO] [stderr] 25 | | let dirs_to_process = gather_directories_to_process(&opts); [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 22 | if opts.subdir_mode { [INFO] [stderr] 23 | let dirs_to_process = gather_directories_to_process(&opts); [INFO] [stderr] 24 | [INFO] [stderr] 25 | match opts.num_threads { [INFO] [stderr] 26 | 0 => execute_threads_unlimited(&opts, dirs_to_process), [INFO] [stderr] 27 | _ => execute_threads_limited(opts, dirs_to_process) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/verify.rs:36:30 [INFO] [stderr] | [INFO] [stderr] 36 | let mut termios_noecho = termios_original.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `termios_original` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/verify.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / match opts.subdir_mode { [INFO] [stderr] 40 | | false => { [INFO] [stderr] 41 | | // execute in directory [INFO] [stderr] 42 | | [INFO] [stderr] ... | [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 39 | if opts.subdir_mode { [INFO] [stderr] 40 | // iterate over subdirs and spawn verify_directory threads [INFO] [stderr] 41 | [INFO] [stderr] 42 | let (dirs_to_process, longest_folder) = gather_directories_to_process(&opts, already_checked); [INFO] [stderr] 43 | [INFO] [stderr] 44 | if opts.loglevel_progress() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _unused =` [INFO] [stderr] --> src/verify.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | let _unused = termios::tcsetattr(0, termios::TCSANOW, &termios_noecho).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _unused =` [INFO] [stderr] --> src/verify.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | let _unused = termios::tcsetattr(0, termios::TCSANOW, &termios_noecho).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/verify.rs:36:30 [INFO] [stderr] | [INFO] [stderr] 36 | let mut termios_noecho = termios_original.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `termios_original` [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/verify.rs:113:76 [INFO] [stderr] | [INFO] [stderr] 113 | fn execute_threads_unlimited(opts: &super::util::Options, known_good_path: &String, to_check_path: &String, dirs_to_process: &Vec, longest_folder: usize) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 113 | fn execute_threads_unlimited(opts: &super::util::Options, known_good_path: &str, to_check_path: &String, dirs_to_process: &Vec, longest_folder: usize) { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `known_good_path.clone()` to [INFO] [stderr] | [INFO] [stderr] 120 | let thread_known_good_path = known_good_path.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/verify.rs:113:100 [INFO] [stderr] | [INFO] [stderr] 113 | fn execute_threads_unlimited(opts: &super::util::Options, known_good_path: &String, to_check_path: &String, dirs_to_process: &Vec, longest_folder: usize) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 113 | fn execute_threads_unlimited(opts: &super::util::Options, known_good_path: &String, to_check_path: &str, dirs_to_process: &Vec, longest_folder: usize) { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `to_check_path.clone()` to [INFO] [stderr] | [INFO] [stderr] 121 | let thread_to_check_path = to_check_path.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/verify.rs:113:126 [INFO] [stderr] | [INFO] [stderr] 113 | fn execute_threads_unlimited(opts: &super::util::Options, known_good_path: &String, to_check_path: &String, dirs_to_process: &Vec, longest_folder: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[PathBuf]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/verify.rs:122:33 [INFO] [stderr] | [INFO] [stderr] 122 | let thread_print_line = print_line.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `print_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/verify.rs:155:33 [INFO] [stderr] | [INFO] [stderr] 155 | let thread_print_line = print_line.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `print_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/verify.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / match opts.subdir_mode { [INFO] [stderr] 40 | | false => { [INFO] [stderr] 41 | | // execute in directory [INFO] [stderr] 42 | | [INFO] [stderr] ... | [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 39 | if opts.subdir_mode { [INFO] [stderr] 40 | // iterate over subdirs and spawn verify_directory threads [INFO] [stderr] 41 | [INFO] [stderr] 42 | let (dirs_to_process, longest_folder) = gather_directories_to_process(&opts, already_checked); [INFO] [stderr] 43 | [INFO] [stderr] 44 | if opts.loglevel_progress() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _unused =` [INFO] [stderr] --> src/verify.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | let _unused = termios::tcsetattr(0, termios::TCSANOW, &termios_noecho).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _unused =` [INFO] [stderr] --> src/verify.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | let _unused = termios::tcsetattr(0, termios::TCSANOW, &termios_noecho).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/verify.rs:113:76 [INFO] [stderr] | [INFO] [stderr] 113 | fn execute_threads_unlimited(opts: &super::util::Options, known_good_path: &String, to_check_path: &String, dirs_to_process: &Vec, longest_folder: usize) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 113 | fn execute_threads_unlimited(opts: &super::util::Options, known_good_path: &str, to_check_path: &String, dirs_to_process: &Vec, longest_folder: usize) { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `known_good_path.clone()` to [INFO] [stderr] | [INFO] [stderr] 120 | let thread_known_good_path = known_good_path.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/verify.rs:113:100 [INFO] [stderr] | [INFO] [stderr] 113 | fn execute_threads_unlimited(opts: &super::util::Options, known_good_path: &String, to_check_path: &String, dirs_to_process: &Vec, longest_folder: usize) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 113 | fn execute_threads_unlimited(opts: &super::util::Options, known_good_path: &String, to_check_path: &str, dirs_to_process: &Vec, longest_folder: usize) { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `to_check_path.clone()` to [INFO] [stderr] | [INFO] [stderr] 121 | let thread_to_check_path = to_check_path.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/verify.rs:113:126 [INFO] [stderr] | [INFO] [stderr] 113 | fn execute_threads_unlimited(opts: &super::util::Options, known_good_path: &String, to_check_path: &String, dirs_to_process: &Vec, longest_folder: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[PathBuf]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/verify.rs:122:33 [INFO] [stderr] | [INFO] [stderr] 122 | let thread_print_line = print_line.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `print_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/verify.rs:155:33 [INFO] [stderr] | [INFO] [stderr] 155 | let thread_print_line = print_line.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `print_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/verify.rs:184:19 [INFO] [stderr] | [INFO] [stderr] 184 | let success = match opts.loglevel_progress() { [INFO] [stderr] | ___________________^ [INFO] [stderr] 185 | | true => verify_directory_with_progressbar(&workdir, &opts, &print_line, &mut failed_paths, longest_folder), [INFO] [stderr] 186 | | false => verify_directory_oneshot(&workdir, &opts, &mut failed_paths) [INFO] [stderr] 187 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if opts.loglevel_progress() { verify_directory_with_progressbar(&workdir, &opts, &print_line, &mut failed_paths, longest_folder) } else { verify_directory_oneshot(&workdir, &opts, &mut failed_paths) }` [INFO] [stderr] | [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/verify.rs:184:19 [INFO] [stderr] | [INFO] [stderr] 184 | let success = match opts.loglevel_progress() { [INFO] [stderr] | ___________________^ [INFO] [stderr] 185 | | true => verify_directory_with_progressbar(&workdir, &opts, &print_line, &mut failed_paths, longest_folder), [INFO] [stderr] 186 | | false => verify_directory_oneshot(&workdir, &opts, &mut failed_paths) [INFO] [stderr] 187 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if opts.loglevel_progress() { verify_directory_with_progressbar(&workdir, &opts, &print_line, &mut failed_paths, longest_folder) } else { verify_directory_oneshot(&workdir, &opts, &mut failed_paths) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/verify.rs:206:108 [INFO] [stderr] | [INFO] [stderr] 206 | fn inform_directory_bad(workdir: PathBuf, to_check_path: String, opts: super::util::Options, failed_paths: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/verify.rs:206:108 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] 206 | fn inform_directory_bad(workdir: PathBuf, to_check_path: String, opts: super::util::Options, failed_paths: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/verify.rs:311:98 [INFO] [stderr] | [INFO] [stderr] 311 | fn verify_directory_with_progressbar(workdir: &PathBuf, opts: &super::util::Options, print_line: &u32, failed_paths: &mut Vec, longest_folder: usize) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/verify.rs:311:98 [INFO] [stderr] | [INFO] [stderr] 311 | fn verify_directory_with_progressbar(workdir: &PathBuf, opts: &super::util::Options, print_line: &u32, failed_paths: &mut Vec, longest_folder: usize) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/verify.rs:398:30 [INFO] [stderr] | [INFO] [stderr] 398 | fn print_progress(all_bytes: &u64, processed_bytes: &u64, line: &u32, workdir: &PathBuf, longest_folder: usize) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/verify.rs:398:53 [INFO] [stderr] | [INFO] [stderr] 398 | fn print_progress(all_bytes: &u64, processed_bytes: &u64, line: &u32, workdir: &PathBuf, longest_folder: usize) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/verify.rs:398:65 [INFO] [stderr] | [INFO] [stderr] 398 | fn print_progress(all_bytes: &u64, processed_bytes: &u64, line: &u32, workdir: &PathBuf, longest_folder: usize) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/verify.rs:398:30 [INFO] [stderr] | [INFO] [stderr] 398 | fn print_progress(all_bytes: &u64, processed_bytes: &u64, line: &u32, workdir: &PathBuf, longest_folder: usize) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/verify.rs:398:53 [INFO] [stderr] | [INFO] [stderr] 398 | fn print_progress(all_bytes: &u64, processed_bytes: &u64, line: &u32, workdir: &PathBuf, longest_folder: usize) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/verify.rs:412:12 [INFO] [stderr] | [INFO] [stderr] 412 | if (i as f64) < progress_bar { [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/verify.rs:398:65 [INFO] [stderr] | [INFO] [stderr] 398 | fn print_progress(all_bytes: &u64, processed_bytes: &u64, line: &u32, workdir: &PathBuf, longest_folder: usize) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/verify.rs:430:24 [INFO] [stderr] | [INFO] [stderr] 430 | fn print_message(line: &u32, message: &str, workdir: &PathBuf) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/verify.rs:412:12 [INFO] [stderr] | [INFO] [stderr] 412 | if (i as f64) < progress_bar { [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/verify.rs:433:5 [INFO] [stderr] | [INFO] [stderr] 433 | handle.write(b"\x1b[s")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/verify.rs:430:24 [INFO] [stderr] | [INFO] [stderr] 430 | fn print_message(line: &u32, message: &str, workdir: &PathBuf) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/verify.rs:433:5 [INFO] [stderr] | [INFO] [stderr] 433 | handle.write(b"\x1b[s")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/verify.rs:436:5 [INFO] [stderr] | [INFO] [stderr] 436 | handle.write(b"\x1b[u")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/verify.rs:436:5 [INFO] [stderr] | [INFO] [stderr] 436 | handle.write(b"\x1b[u")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `hashfilter`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `hashfilter`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "dfa531f6d313ad674c161bbf7d0d057309c349fafbc270751db2c69fad31275b"` [INFO] running `"docker" "rm" "-f" "dfa531f6d313ad674c161bbf7d0d057309c349fafbc270751db2c69fad31275b"` [INFO] [stdout] dfa531f6d313ad674c161bbf7d0d057309c349fafbc270751db2c69fad31275b