[INFO] updating cached repository RodrigoNascCarvalho/rust-101 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/RodrigoNascCarvalho/rust-101 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/RodrigoNascCarvalho/rust-101" "work/ex/clippy-test-run/sources/stable/gh/RodrigoNascCarvalho/rust-101"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/RodrigoNascCarvalho/rust-101'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/RodrigoNascCarvalho/rust-101" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RodrigoNascCarvalho/rust-101"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RodrigoNascCarvalho/rust-101'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8cd3636fce59aaacc8149d3e2daf67555a782fa9 [INFO] sha for GitHub repo RodrigoNascCarvalho/rust-101: 8cd3636fce59aaacc8149d3e2daf67555a782fa9 [INFO] validating manifest of RodrigoNascCarvalho/rust-101 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of RodrigoNascCarvalho/rust-101 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing RodrigoNascCarvalho/rust-101 [INFO] finished frobbing RodrigoNascCarvalho/rust-101 [INFO] frobbed toml for RodrigoNascCarvalho/rust-101 written to work/ex/clippy-test-run/sources/stable/gh/RodrigoNascCarvalho/rust-101/Cargo.toml [INFO] started frobbing RodrigoNascCarvalho/rust-101 [INFO] finished frobbing RodrigoNascCarvalho/rust-101 [INFO] frobbed toml for RodrigoNascCarvalho/rust-101 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RodrigoNascCarvalho/rust-101/Cargo.toml [INFO] crate RodrigoNascCarvalho/rust-101 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting RodrigoNascCarvalho/rust-101 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/RodrigoNascCarvalho/rust-101:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7bdd52083c0b105b2afea8bfe63c4fc0e9e51067afe9b070fb96d4e04525e482 [INFO] running `"docker" "start" "-a" "7bdd52083c0b105b2afea8bfe63c4fc0e9e51067afe9b070fb96d4e04525e482"` [INFO] [stderr] Checking rust-101-workspace v0.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/part05.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/part10.rs:36:39 [INFO] [stderr] | [INFO] [stderr] 36 | let my_action = PrintWithString { prefix: prefix }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `prefix` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/part05.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/part10.rs:36:39 [INFO] [stderr] | [INFO] [stderr] 36 | let my_action = PrintWithString { prefix: prefix }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `prefix` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/part00.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | return min; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `min` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/part00.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | return a; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/part00.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | return b; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/part05.rs:136:23 [INFO] [stderr] | [INFO] [stderr] 136 | let v = vec![0,00,000000,1,2,112345678900,00033333,3,522222]; [INFO] [stderr] | ^^^^^^ help: consider: `000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/part05.rs:136:34 [INFO] [stderr] | [INFO] [stderr] 136 | let v = vec![0,00,000000,1,2,112345678900,00033333,3,522222]; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `112_345_678_900` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/part05.rs:136:47 [INFO] [stderr] | [INFO] [stderr] 136 | let v = vec![0,00,000000,1,2,112345678900,00033333,3,522222]; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 136 | let v = vec![0,00,000000,1,2,112345678900,33333,3,522222]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 136 | let v = vec![0,00,000000,1,2,112345678900,0o33333,3,522222]; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/part05.rs:136:47 [INFO] [stderr] | [INFO] [stderr] 136 | let v = vec![0,00,000000,1,2,112345678900,00033333,3,522222]; [INFO] [stderr] | ^^^^^^^^ help: consider: `00_033_333` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/part05.rs:136:58 [INFO] [stderr] | [INFO] [stderr] 136 | let v = vec![0,00,000000,1,2,112345678900,00033333,3,522222]; [INFO] [stderr] | ^^^^^^ help: consider: `522_222` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/part00.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | return min; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `min` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/part00.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | return a; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/part00.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | return b; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/part05.rs:136:23 [INFO] [stderr] | [INFO] [stderr] 136 | let v = vec![0,00,000000,1,2,112345678900,00033333,3,522222]; [INFO] [stderr] | ^^^^^^ help: consider: `000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/part05.rs:136:34 [INFO] [stderr] | [INFO] [stderr] 136 | let v = vec![0,00,000000,1,2,112345678900,00033333,3,522222]; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `112_345_678_900` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/part05.rs:136:47 [INFO] [stderr] | [INFO] [stderr] 136 | let v = vec![0,00,000000,1,2,112345678900,00033333,3,522222]; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 136 | let v = vec![0,00,000000,1,2,112345678900,33333,3,522222]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 136 | let v = vec![0,00,000000,1,2,112345678900,0o33333,3,522222]; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/part05.rs:136:47 [INFO] [stderr] | [INFO] [stderr] 136 | let v = vec![0,00,000000,1,2,112345678900,00033333,3,522222]; [INFO] [stderr] | ^^^^^^^^ help: consider: `00_033_333` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/part05.rs:136:58 [INFO] [stderr] | [INFO] [stderr] 136 | let v = vec![0,00,000000,1,2,112345678900,00033333,3,522222]; [INFO] [stderr] | ^^^^^^ help: consider: `522_222` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/part02.rs:24:18 [INFO] [stderr] | [INFO] [stderr] 24 | fn to_option(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/part04.rs:22:15 [INFO] [stderr] | [INFO] [stderr] 22 | fn vec_min(v: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/part05.rs:22:12 [INFO] [stderr] | [INFO] [stderr] 22 | if self.data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/part05.rs:42:15 [INFO] [stderr] | [INFO] [stderr] 42 | while big.data.len() > 0 && big.data[big.data.len() - 1] == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!big.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/part06.rs:26:15 [INFO] [stderr] | [INFO] [stderr] 26 | fn vec_min(v: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[BigInt]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/part06.rs:44:15 [INFO] [stderr] | [INFO] [stderr] 44 | fn head(v: &Vec) -> Option<&T> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/part06.rs:45:8 [INFO] [stderr] | [INFO] [stderr] 45 | if v.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/part07.rs:11:31 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn vec_min(v: &Vec) -> Option<&T> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/part07.rs:46:59 [INFO] [stderr] | [INFO] [stderr] 46 | println!("b1 == b1: {} ; b1 == b2: {}; b1 != b2: {}", b1 == b1, b1 == b2, b1 != b2); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/part09.rs:55:29 [INFO] [stderr] | [INFO] [stderr] 55 | while let Some(digit) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for digit in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/part10.rs:70:55 [INFO] [stderr] | [INFO] [stderr] 70 | b.act(|digit| { println!("{}: {}", count, digit); count = count +1; } ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/part10.rs:77:27 [INFO] [stderr] | [INFO] [stderr] 77 | fn inc_print_threshold(v: &Vec, offset: i32, threshold: i32) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/part10.rs:84:41 [INFO] [stderr] | [INFO] [stderr] 84 | fn print_enumerated(v: &Vec) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/part10.rs:91:29 [INFO] [stderr] | [INFO] [stderr] 91 | fn filter_vec_by_divisor(v: &Vec, divisor: i32) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/part11.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | count = count+1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/part12.rs:67:16 [INFO] [stderr] | [INFO] [stderr] 67 | callbacks: Vec>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/part12.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | count = count+1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/part15.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | *counter = *counter + by; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*counter += by` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/part02.rs:24:18 [INFO] [stderr] | [INFO] [stderr] 24 | fn to_option(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-101-workspace`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/part04.rs:22:15 [INFO] [stderr] | [INFO] [stderr] 22 | fn vec_min(v: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/part05.rs:22:12 [INFO] [stderr] | [INFO] [stderr] 22 | if self.data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/part05.rs:42:15 [INFO] [stderr] | [INFO] [stderr] 42 | while big.data.len() > 0 && big.data[big.data.len() - 1] == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!big.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/part06.rs:26:15 [INFO] [stderr] | [INFO] [stderr] 26 | fn vec_min(v: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[BigInt]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/part06.rs:44:15 [INFO] [stderr] | [INFO] [stderr] 44 | fn head(v: &Vec) -> Option<&T> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/part06.rs:45:8 [INFO] [stderr] | [INFO] [stderr] 45 | if v.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/part07.rs:11:31 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn vec_min(v: &Vec) -> Option<&T> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/part07.rs:46:59 [INFO] [stderr] | [INFO] [stderr] 46 | println!("b1 == b1: {} ; b1 == b2: {}; b1 != b2: {}", b1 == b1, b1 == b2, b1 != b2); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/part09.rs:55:29 [INFO] [stderr] | [INFO] [stderr] 55 | while let Some(digit) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for digit in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/part10.rs:70:55 [INFO] [stderr] | [INFO] [stderr] 70 | b.act(|digit| { println!("{}: {}", count, digit); count = count +1; } ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/part10.rs:77:27 [INFO] [stderr] | [INFO] [stderr] 77 | fn inc_print_threshold(v: &Vec, offset: i32, threshold: i32) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/part10.rs:84:41 [INFO] [stderr] | [INFO] [stderr] 84 | fn print_enumerated(v: &Vec) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/part10.rs:91:29 [INFO] [stderr] | [INFO] [stderr] 91 | fn filter_vec_by_divisor(v: &Vec, divisor: i32) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/part11.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | count = count+1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/part12.rs:67:16 [INFO] [stderr] | [INFO] [stderr] 67 | callbacks: Vec>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/part12.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | count = count+1; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `count += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/part15.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | *counter = *counter + by; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*counter += by` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-101-workspace`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7bdd52083c0b105b2afea8bfe63c4fc0e9e51067afe9b070fb96d4e04525e482"` [INFO] running `"docker" "rm" "-f" "7bdd52083c0b105b2afea8bfe63c4fc0e9e51067afe9b070fb96d4e04525e482"` [INFO] [stdout] 7bdd52083c0b105b2afea8bfe63c4fc0e9e51067afe9b070fb96d4e04525e482