[INFO] updating cached repository RobotDisco/rust_chat
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/RobotDisco/rust_chat
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/RobotDisco/rust_chat" "work/ex/clippy-test-run/sources/stable/gh/RobotDisco/rust_chat"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/RobotDisco/rust_chat'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/RobotDisco/rust_chat" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RobotDisco/rust_chat"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RobotDisco/rust_chat'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] b039b619dc4f0f297228d09a894a0c41808447a9
[INFO] sha for GitHub repo RobotDisco/rust_chat: b039b619dc4f0f297228d09a894a0c41808447a9
[INFO] validating manifest of RobotDisco/rust_chat on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of RobotDisco/rust_chat on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing RobotDisco/rust_chat
[INFO] finished frobbing RobotDisco/rust_chat
[INFO] frobbed toml for RobotDisco/rust_chat written to work/ex/clippy-test-run/sources/stable/gh/RobotDisco/rust_chat/Cargo.toml
[INFO] started frobbing RobotDisco/rust_chat
[INFO] finished frobbing RobotDisco/rust_chat
[INFO] frobbed toml for RobotDisco/rust_chat written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RobotDisco/rust_chat/Cargo.toml
[INFO] crate RobotDisco/rust_chat has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] [stderr]     Blocking waiting for file lock on the registry index
[INFO] linting RobotDisco/rust_chat against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/RobotDisco/rust_chat:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 93da90659f380868e0d8076c634fb6b599bf57d001d46d400b21242a3ad84943
[INFO] running `"docker" "start" "-a" "93da90659f380868e0d8076c634fb6b599bf57d001d46d400b21242a3ad84943"`
[INFO] [stderr]     Checking net2 v0.2.33
[INFO] [stderr]    Compiling http-muncher v0.2.5
[INFO] [stderr]     Checking nix v0.5.1
[INFO] [stderr]     Checking sha1 v0.1.1
[INFO] [stderr]     Checking miow v0.1.5
[INFO] [stderr]     Checking mio v0.5.1
[INFO] [stderr]     Checking chat v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:129:13
[INFO] [stderr]     |
[INFO] [stderr] 129 |             socket: socket,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:129:13
[INFO] [stderr]     |
[INFO] [stderr] 129 |             socket: socket,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `socket`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 |     return buf.to_base64(STANDARD);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `buf.to_base64(STANDARD)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 |     return buf.to_base64(STANDARD);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `buf.to_base64(STANDARD)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:13:17
[INFO] [stderr]    |
[INFO] [stderr] 13 | fn gen_key(key: &String) -> String {
[INFO] [stderr]    |                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/main.rs:18:14
[INFO] [stderr]    |
[INFO] [stderr] 18 |     m.update("258EAFA5-E914-47DA-95CA-C5AB0DC85B11".as_bytes());
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"258EAFA5-E914-47DA-95CA-C5AB0DC85B11"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:13:17
[INFO] [stderr]    |
[INFO] [stderr] 13 | fn gen_key(key: &String) -> String {
[INFO] [stderr]    |                 ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/main.rs:18:14
[INFO] [stderr]    |
[INFO] [stderr] 18 |     m.update("258EAFA5-E914-47DA-95CA-C5AB0DC85B11".as_bytes());
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"258EAFA5-E914-47DA-95CA-C5AB0DC85B11"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 9.00s
[INFO] running `"docker" "inspect" "93da90659f380868e0d8076c634fb6b599bf57d001d46d400b21242a3ad84943"`
[INFO] running `"docker" "rm" "-f" "93da90659f380868e0d8076c634fb6b599bf57d001d46d400b21242a3ad84943"`
[INFO] [stdout] 93da90659f380868e0d8076c634fb6b599bf57d001d46d400b21242a3ad84943