[INFO] updating cached repository Robostorm/Aquabot-Locator-GUI-Rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Robostorm/Aquabot-Locator-GUI-Rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Robostorm/Aquabot-Locator-GUI-Rust" "work/ex/clippy-test-run/sources/stable/gh/Robostorm/Aquabot-Locator-GUI-Rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Robostorm/Aquabot-Locator-GUI-Rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Robostorm/Aquabot-Locator-GUI-Rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Robostorm/Aquabot-Locator-GUI-Rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Robostorm/Aquabot-Locator-GUI-Rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 34548908b47e07b7fc927c9c15565a32d52cba24 [INFO] sha for GitHub repo Robostorm/Aquabot-Locator-GUI-Rust: 34548908b47e07b7fc927c9c15565a32d52cba24 [INFO] validating manifest of Robostorm/Aquabot-Locator-GUI-Rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Robostorm/Aquabot-Locator-GUI-Rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Robostorm/Aquabot-Locator-GUI-Rust [INFO] finished frobbing Robostorm/Aquabot-Locator-GUI-Rust [INFO] frobbed toml for Robostorm/Aquabot-Locator-GUI-Rust written to work/ex/clippy-test-run/sources/stable/gh/Robostorm/Aquabot-Locator-GUI-Rust/Cargo.toml [INFO] started frobbing Robostorm/Aquabot-Locator-GUI-Rust [INFO] finished frobbing Robostorm/Aquabot-Locator-GUI-Rust [INFO] frobbed toml for Robostorm/Aquabot-Locator-GUI-Rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Robostorm/Aquabot-Locator-GUI-Rust/Cargo.toml [INFO] crate Robostorm/Aquabot-Locator-GUI-Rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Robostorm/Aquabot-Locator-GUI-Rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Robostorm/Aquabot-Locator-GUI-Rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 21244b204e8903c27cb761d99d16ae1663cb7d7719e83c1e7c2624e3958fb463 [INFO] running `"docker" "start" "-a" "21244b204e8903c27cb761d99d16ae1663cb7d7719e83c1e7c2624e3958fb463"` [INFO] [stderr] Compiling gdk-pixbuf v0.1.3 [INFO] [stderr] Compiling gio v0.1.3 [INFO] [stderr] Compiling gdk v0.5.3 [INFO] [stderr] Compiling gtk v0.1.3 [INFO] [stderr] Compiling gio-sys v0.3.4 [INFO] [stderr] Compiling pango-sys v0.3.4 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.3.4 [INFO] [stderr] Compiling gdk-sys v0.3.4 [INFO] [stderr] Compiling gtk-sys v0.3.4 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking serial-core v0.4.0 [INFO] [stderr] Checking ioctl-rs v0.1.5 [INFO] [stderr] Checking glib-sys v0.3.4 [INFO] [stderr] Checking cairo-sys-rs v0.3.4 [INFO] [stderr] Checking serial-unix v0.4.0 [INFO] [stderr] Checking serial v0.4.0 [INFO] [stderr] Checking gobject-sys v0.3.4 [INFO] [stderr] Checking glib v0.1.3 [INFO] [stderr] Checking atk-sys v0.3.4 [INFO] [stderr] Checking cairo-rs v0.1.3 [INFO] [stderr] Checking pango v0.1.3 [INFO] [stderr] Checking aquabot-locator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:41:24 [INFO] [stderr] | [INFO] [stderr] 41 | const START_LAT: f64 = 40.416623; [INFO] [stderr] | ^^^^^^^^^ help: consider: `40.416_623` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:42:26 [INFO] [stderr] | [INFO] [stderr] 42 | const START_LONG: f64 = -74.883628; [INFO] [stderr] | ^^^^^^^^^ help: consider: `74.883_628` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:43:22 [INFO] [stderr] | [INFO] [stderr] 43 | const END_LAT: f64 = 40.413900; [INFO] [stderr] | ^^^^^^^^^ help: consider: `40.413_900` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:44:24 [INFO] [stderr] | [INFO] [stderr] 44 | const END_LONG: f64 = -74.880168; [INFO] [stderr] | ^^^^^^^^^ help: consider: `74.880_168` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:41:24 [INFO] [stderr] | [INFO] [stderr] 41 | const START_LAT: f64 = 40.416623; [INFO] [stderr] | ^^^^^^^^^ help: consider: `40.416_623` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:42:26 [INFO] [stderr] | [INFO] [stderr] 42 | const START_LONG: f64 = -74.883628; [INFO] [stderr] | ^^^^^^^^^ help: consider: `74.883_628` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:43:22 [INFO] [stderr] | [INFO] [stderr] 43 | const END_LAT: f64 = 40.413900; [INFO] [stderr] | ^^^^^^^^^ help: consider: `40.413_900` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:44:24 [INFO] [stderr] | [INFO] [stderr] 44 | const END_LONG: f64 = -74.880168; [INFO] [stderr] | ^^^^^^^^^ help: consider: `74.880_168` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:122:25 [INFO] [stderr] | [INFO] [stderr] 122 | let img_ratio = pixbuf.get_height() as f64 / pixbuf.get_width() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pixbuf.get_height())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:122:54 [INFO] [stderr] | [INFO] [stderr] 122 | let img_ratio = pixbuf.get_height() as f64 / pixbuf.get_width() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pixbuf.get_width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:123:28 [INFO] [stderr] | [INFO] [stderr] 123 | let screen_ratio = widget.get_allocated_height() as f64 / widget.get_allocated_width() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(widget.get_allocated_height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:123:67 [INFO] [stderr] | [INFO] [stderr] 123 | let screen_ratio = widget.get_allocated_height() as f64 / widget.get_allocated_width() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(widget.get_allocated_width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | widget.get_allocated_height() as f64 / pixbuf.get_height() as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(widget.get_allocated_height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:126:52 [INFO] [stderr] | [INFO] [stderr] 126 | widget.get_allocated_height() as f64 / pixbuf.get_height() as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pixbuf.get_height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | widget.get_allocated_width() as f64 / pixbuf.get_width() as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(widget.get_allocated_width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:128:51 [INFO] [stderr] | [INFO] [stderr] 128 | widget.get_allocated_width() as f64 / pixbuf.get_width() as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pixbuf.get_width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:133:19 [INFO] [stderr] | [INFO] [stderr] 133 | let tx = (widget.get_allocated_width() as f64 - pixbuf.get_width() as f64 * scale) / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(widget.get_allocated_width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:133:57 [INFO] [stderr] | [INFO] [stderr] 133 | let tx = (widget.get_allocated_width() as f64 - pixbuf.get_width() as f64 * scale) / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pixbuf.get_width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:134:19 [INFO] [stderr] | [INFO] [stderr] 134 | let ty = (widget.get_allocated_height() as f64 - pixbuf.get_height() as f64 * scale) / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(widget.get_allocated_height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:134:58 [INFO] [stderr] | [INFO] [stderr] 134 | let ty = (widget.get_allocated_height() as f64 - pixbuf.get_height() as f64 * scale) / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pixbuf.get_height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:207:32 [INFO] [stderr] | [INFO] [stderr] 207 | if byte == '\n' as u8 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:251:39 [INFO] [stderr] | [INFO] [stderr] 251 | for part in bytes.split(|b| *b == ':' as u8) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b':' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:271:51 [INFO] [stderr] | [INFO] [stderr] 271 | println!("Fix: {:?}", if num == 0 { false } else { true }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!(num == 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:272:48 [INFO] [stderr] | [INFO] [stderr] 272 | aquabot_data.fix = if num == 0 { false } else { true }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!(num == 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:122:25 [INFO] [stderr] | [INFO] [stderr] 122 | let img_ratio = pixbuf.get_height() as f64 / pixbuf.get_width() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pixbuf.get_height())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:122:54 [INFO] [stderr] | [INFO] [stderr] 122 | let img_ratio = pixbuf.get_height() as f64 / pixbuf.get_width() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pixbuf.get_width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:123:28 [INFO] [stderr] | [INFO] [stderr] 123 | let screen_ratio = widget.get_allocated_height() as f64 / widget.get_allocated_width() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(widget.get_allocated_height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:123:67 [INFO] [stderr] | [INFO] [stderr] 123 | let screen_ratio = widget.get_allocated_height() as f64 / widget.get_allocated_width() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(widget.get_allocated_width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | widget.get_allocated_height() as f64 / pixbuf.get_height() as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(widget.get_allocated_height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:126:52 [INFO] [stderr] | [INFO] [stderr] 126 | widget.get_allocated_height() as f64 / pixbuf.get_height() as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pixbuf.get_height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | widget.get_allocated_width() as f64 / pixbuf.get_width() as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(widget.get_allocated_width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:128:51 [INFO] [stderr] | [INFO] [stderr] 128 | widget.get_allocated_width() as f64 / pixbuf.get_width() as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pixbuf.get_width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:133:19 [INFO] [stderr] | [INFO] [stderr] 133 | let tx = (widget.get_allocated_width() as f64 - pixbuf.get_width() as f64 * scale) / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(widget.get_allocated_width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:133:57 [INFO] [stderr] | [INFO] [stderr] 133 | let tx = (widget.get_allocated_width() as f64 - pixbuf.get_width() as f64 * scale) / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pixbuf.get_width())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:134:19 [INFO] [stderr] | [INFO] [stderr] 134 | let ty = (widget.get_allocated_height() as f64 - pixbuf.get_height() as f64 * scale) / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(widget.get_allocated_height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:134:58 [INFO] [stderr] | [INFO] [stderr] 134 | let ty = (widget.get_allocated_height() as f64 - pixbuf.get_height() as f64 * scale) / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pixbuf.get_height())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:207:32 [INFO] [stderr] | [INFO] [stderr] 207 | if byte == '\n' as u8 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\n' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:251:39 [INFO] [stderr] | [INFO] [stderr] 251 | for part in bytes.split(|b| *b == ':' as u8) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b':' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:271:51 [INFO] [stderr] | [INFO] [stderr] 271 | println!("Fix: {:?}", if num == 0 { false } else { true }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!(num == 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:272:48 [INFO] [stderr] | [INFO] [stderr] 272 | aquabot_data.fix = if num == 0 { false } else { true }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!(num == 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 57.20s [INFO] running `"docker" "inspect" "21244b204e8903c27cb761d99d16ae1663cb7d7719e83c1e7c2624e3958fb463"` [INFO] running `"docker" "rm" "-f" "21244b204e8903c27cb761d99d16ae1663cb7d7719e83c1e7c2624e3958fb463"` [INFO] [stdout] 21244b204e8903c27cb761d99d16ae1663cb7d7719e83c1e7c2624e3958fb463