[INFO] updating cached repository Robin-git/rust_naval_battle [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Robin-git/rust_naval_battle [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Robin-git/rust_naval_battle" "work/ex/clippy-test-run/sources/stable/gh/Robin-git/rust_naval_battle"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Robin-git/rust_naval_battle'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Robin-git/rust_naval_battle" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Robin-git/rust_naval_battle"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Robin-git/rust_naval_battle'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cb522355a444c1124fdffdc0674d974ac9b63c4c [INFO] sha for GitHub repo Robin-git/rust_naval_battle: cb522355a444c1124fdffdc0674d974ac9b63c4c [INFO] validating manifest of Robin-git/rust_naval_battle on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Robin-git/rust_naval_battle on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Robin-git/rust_naval_battle [INFO] finished frobbing Robin-git/rust_naval_battle [INFO] frobbed toml for Robin-git/rust_naval_battle written to work/ex/clippy-test-run/sources/stable/gh/Robin-git/rust_naval_battle/Cargo.toml [INFO] started frobbing Robin-git/rust_naval_battle [INFO] finished frobbing Robin-git/rust_naval_battle [INFO] frobbed toml for Robin-git/rust_naval_battle written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Robin-git/rust_naval_battle/Cargo.toml [INFO] crate Robin-git/rust_naval_battle has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Robin-git/rust_naval_battle against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Robin-git/rust_naval_battle:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b324557fd0fbb262848d14491ede5fe0e3a8f4b29708d1b850eeb5581b0d3435 [INFO] running `"docker" "start" "-a" "b324557fd0fbb262848d14491ede5fe0e3a8f4b29708d1b850eeb5581b0d3435"` [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Checking pistoncore-input v0.23.0 [INFO] [stderr] Checking smithay-client-toolkit v0.4.3 [INFO] [stderr] Checking pistoncore-window v0.34.0 [INFO] [stderr] Checking winit v0.18.0 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking pistoncore-event_loop v0.39.0 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking piston v0.39.0 [INFO] [stderr] Checking glutin v0.19.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.51.1 [INFO] [stderr] Checking piston2d-opengl_graphics v0.57.0 [INFO] [stderr] Checking fallout v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboard/gameboard_controller.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | gameboard: gameboard, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gameboard` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboard/gameboard_view.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | GameboardView { settings: settings } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboard/gameboard_controller.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | gameboard: gameboard, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gameboard` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboard/gameboard_view.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | GameboardView { settings: settings } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/gameboard/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | mod gameboard; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/gameboard/mod.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | mod gameboard; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/gameboard/gameboard_view.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | let ref settings = self.settings; [INFO] [stderr] | ----^^^^^^^^^^^^----------------- help: try: `let settings = &self.settings;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard/gameboard_view.rs:122:38 [INFO] [stderr] | [INFO] [stderr] 122 | let x = settings.position[0] + i as f64 / 10.0 * settings.size; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard/gameboard_view.rs:123:38 [INFO] [stderr] | [INFO] [stderr] 123 | let y = settings.position[1] + i as f64 / 10.0 * settings.size; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/gameboard/gameboard_view.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | let ref settings = self.settings; [INFO] [stderr] | ----^^^^^^^^^^^^----------------- help: try: `let settings = &self.settings;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard/gameboard_view.rs:122:38 [INFO] [stderr] | [INFO] [stderr] 122 | let x = settings.position[0] + i as f64 / 10.0 * settings.size; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard/gameboard_view.rs:123:38 [INFO] [stderr] | [INFO] [stderr] 123 | let y = settings.position[1] + i as f64 / 10.0 * settings.size; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 37.95s [INFO] running `"docker" "inspect" "b324557fd0fbb262848d14491ede5fe0e3a8f4b29708d1b850eeb5581b0d3435"` [INFO] running `"docker" "rm" "-f" "b324557fd0fbb262848d14491ede5fe0e3a8f4b29708d1b850eeb5581b0d3435"` [INFO] [stdout] b324557fd0fbb262848d14491ede5fe0e3a8f4b29708d1b850eeb5581b0d3435