[INFO] updating cached repository RlonRyan/rust-l-sys [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/RlonRyan/rust-l-sys [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/RlonRyan/rust-l-sys" "work/ex/clippy-test-run/sources/stable/gh/RlonRyan/rust-l-sys"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/RlonRyan/rust-l-sys'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/RlonRyan/rust-l-sys" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RlonRyan/rust-l-sys"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RlonRyan/rust-l-sys'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 04bba049484d66284ce27f7e1f9996e365210719 [INFO] sha for GitHub repo RlonRyan/rust-l-sys: 04bba049484d66284ce27f7e1f9996e365210719 [INFO] validating manifest of RlonRyan/rust-l-sys on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of RlonRyan/rust-l-sys on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing RlonRyan/rust-l-sys [INFO] finished frobbing RlonRyan/rust-l-sys [INFO] frobbed toml for RlonRyan/rust-l-sys written to work/ex/clippy-test-run/sources/stable/gh/RlonRyan/rust-l-sys/Cargo.toml [INFO] started frobbing RlonRyan/rust-l-sys [INFO] finished frobbing RlonRyan/rust-l-sys [INFO] frobbed toml for RlonRyan/rust-l-sys written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RlonRyan/rust-l-sys/Cargo.toml [INFO] crate RlonRyan/rust-l-sys has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting RlonRyan/rust-l-sys against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/RlonRyan/rust-l-sys:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a95abe714a698ba4244a081a8bf76e55e70d49b0568e3a76b6e2c7c16b5a9b16 [INFO] running `"docker" "start" "-a" "a95abe714a698ba4244a081a8bf76e55e70d49b0568e3a76b6e2c7c16b5a9b16"` [INFO] [stderr] Checking shared_library v0.1.7 [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking arrayvec v0.4.2 [INFO] [stderr] Checking x11-dl v2.15.0 [INFO] [stderr] Checking pistoncore-input v0.19.0 [INFO] [stderr] Checking libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking rusttype v0.2.3 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking pistoncore-window v0.29.0 [INFO] [stderr] Checking pistoncore-event_loop v0.34.0 [INFO] [stderr] Checking piston2d-graphics v0.22.0 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking piston v0.34.0 [INFO] [stderr] Checking wayland-window v0.7.0 [INFO] [stderr] Checking image v0.16.0 [INFO] [stderr] Checking winit v0.7.6 [INFO] [stderr] Checking glutin v0.9.2 [INFO] [stderr] Checking pistoncore-glutin_window v0.40.1 [INFO] [stderr] Checking piston2d-opengl_graphics v0.47.0 [INFO] [stderr] Checking rust-l-sys v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/turtle.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/turtle.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/turtle.rs:164:17 [INFO] [stderr] | [INFO] [stderr] 164 | print!("Turtle recieved invalid command: '{0}'!\n", command); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lsys.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | grammar: grammar, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `grammar` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lsys.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | max_depth: max_depth [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/turtle.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/turtle.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/turtle.rs:164:17 [INFO] [stderr] | [INFO] [stderr] 164 | print!("Turtle recieved invalid command: '{0}'!\n", command); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lsys.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | grammar: grammar, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `grammar` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lsys.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | max_depth: max_depth [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_depth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | return TurtleMovement::none(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TurtleMovement::none(self)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / return TurtleMovement { [INFO] [stderr] 86 | | x_from: ox, [INFO] [stderr] 87 | | y_from: oy, [INFO] [stderr] 88 | | x_to: self.state.x, [INFO] [stderr] 89 | | y_to: self.state.y, [INFO] [stderr] 90 | | draw: false [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 85 | TurtleMovement { [INFO] [stderr] 86 | x_from: ox, [INFO] [stderr] 87 | y_from: oy, [INFO] [stderr] 88 | x_to: self.state.x, [INFO] [stderr] 89 | y_to: self.state.y, [INFO] [stderr] 90 | draw: false [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | return TurtleMovement::none(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TurtleMovement::none(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | return TurtleMovement::none(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TurtleMovement::none(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | / return TurtleMovement { [INFO] [stderr] 117 | | x_from: ox, [INFO] [stderr] 118 | | y_from: oy, [INFO] [stderr] 119 | | x_to: self.state.x, [INFO] [stderr] 120 | | y_to: self.state.y, [INFO] [stderr] 121 | | draw: self.state.draw [INFO] [stderr] 122 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 116 | TurtleMovement { [INFO] [stderr] 117 | x_from: ox, [INFO] [stderr] 118 | y_from: oy, [INFO] [stderr] 119 | x_to: self.state.x, [INFO] [stderr] 120 | y_to: self.state.y, [INFO] [stderr] 121 | draw: self.state.draw [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | return TurtleMovement::none(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TurtleMovement::none(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | return TurtleMovement::none(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TurtleMovement::none(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:142:17 [INFO] [stderr] | [INFO] [stderr] 142 | return self.forward(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.forward()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | return self.turn_left(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.turn_left()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | return self.turn_right(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.turn_right()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:151:17 [INFO] [stderr] | [INFO] [stderr] 151 | return self.push(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.push()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:154:17 [INFO] [stderr] | [INFO] [stderr] 154 | return self.pop(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pop()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | return self.up(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.up()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:160:17 [INFO] [stderr] | [INFO] [stderr] 160 | return self.down(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.down()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:165:17 [INFO] [stderr] | [INFO] [stderr] 165 | return TurtleMovement::none(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TurtleMovement::none(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lsys.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | return grammar; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `grammar` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lsys.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | return chars; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `chars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lsys.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | return chars; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `chars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | return TurtleMovement::none(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TurtleMovement::none(self)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / return TurtleMovement { [INFO] [stderr] 86 | | x_from: ox, [INFO] [stderr] 87 | | y_from: oy, [INFO] [stderr] 88 | | x_to: self.state.x, [INFO] [stderr] 89 | | y_to: self.state.y, [INFO] [stderr] 90 | | draw: false [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 85 | TurtleMovement { [INFO] [stderr] 86 | x_from: ox, [INFO] [stderr] 87 | y_from: oy, [INFO] [stderr] 88 | x_to: self.state.x, [INFO] [stderr] 89 | y_to: self.state.y, [INFO] [stderr] 90 | draw: false [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | return TurtleMovement::none(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TurtleMovement::none(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | return TurtleMovement::none(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TurtleMovement::none(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | / return TurtleMovement { [INFO] [stderr] 117 | | x_from: ox, [INFO] [stderr] 118 | | y_from: oy, [INFO] [stderr] 119 | | x_to: self.state.x, [INFO] [stderr] 120 | | y_to: self.state.y, [INFO] [stderr] 121 | | draw: self.state.draw [INFO] [stderr] 122 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 116 | TurtleMovement { [INFO] [stderr] 117 | x_from: ox, [INFO] [stderr] 118 | y_from: oy, [INFO] [stderr] 119 | x_to: self.state.x, [INFO] [stderr] 120 | y_to: self.state.y, [INFO] [stderr] 121 | draw: self.state.draw [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | return TurtleMovement::none(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TurtleMovement::none(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | return TurtleMovement::none(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TurtleMovement::none(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:142:17 [INFO] [stderr] | [INFO] [stderr] 142 | return self.forward(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.forward()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | return self.turn_left(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.turn_left()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | return self.turn_right(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.turn_right()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:151:17 [INFO] [stderr] | [INFO] [stderr] 151 | return self.push(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.push()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:154:17 [INFO] [stderr] | [INFO] [stderr] 154 | return self.pop(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pop()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | return self.up(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.up()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:160:17 [INFO] [stderr] | [INFO] [stderr] 160 | return self.down(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.down()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/turtle.rs:165:17 [INFO] [stderr] | [INFO] [stderr] 165 | return TurtleMovement::none(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TurtleMovement::none(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lsys.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | return grammar; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `grammar` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lsys.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | return chars; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `chars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lsys.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | return chars; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `chars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/turtle.rs:73:25 [INFO] [stderr] | [INFO] [stderr] 73 | self.stack.push(self.state.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lsys.rs:100:30 [INFO] [stderr] | [INFO] [stderr] 100 | pub fn string_char_vec(line: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/turtle.rs:73:25 [INFO] [stderr] | [INFO] [stderr] 73 | self.stack.push(self.state.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lsys.rs:100:30 [INFO] [stderr] | [INFO] [stderr] 100 | pub fn string_char_vec(line: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 38.23s [INFO] running `"docker" "inspect" "a95abe714a698ba4244a081a8bf76e55e70d49b0568e3a76b6e2c7c16b5a9b16"` [INFO] running `"docker" "rm" "-f" "a95abe714a698ba4244a081a8bf76e55e70d49b0568e3a76b6e2c7c16b5a9b16"` [INFO] [stdout] a95abe714a698ba4244a081a8bf76e55e70d49b0568e3a76b6e2c7c16b5a9b16