[INFO] updating cached repository Retsam/delta [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Retsam/delta [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Retsam/delta" "work/ex/clippy-test-run/sources/stable/gh/Retsam/delta"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Retsam/delta'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Retsam/delta" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Retsam/delta"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Retsam/delta'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fba403d91ea8f7dfbea12d0a7f3447c6044c9bcb [INFO] sha for GitHub repo Retsam/delta: fba403d91ea8f7dfbea12d0a7f3447c6044c9bcb [INFO] validating manifest of Retsam/delta on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Retsam/delta on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Retsam/delta [INFO] finished frobbing Retsam/delta [INFO] frobbed toml for Retsam/delta written to work/ex/clippy-test-run/sources/stable/gh/Retsam/delta/Cargo.toml [INFO] started frobbing Retsam/delta [INFO] finished frobbing Retsam/delta [INFO] frobbed toml for Retsam/delta written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Retsam/delta/Cargo.toml [INFO] crate Retsam/delta has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Retsam/delta against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Retsam/delta:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 001fa10c38a579c633c398aef3a6b09db7ea0684d9610026371b4314f6bf1a0a [INFO] running `"docker" "start" "-a" "001fa10c38a579c633c398aef3a6b09db7ea0684d9610026371b4314f6bf1a0a"` [INFO] [stderr] Checking delta v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/main.rs:74:6 [INFO] [stderr] | [INFO] [stderr] 74 | for y in 0..SCREEN_HEIGHT { [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/main.rs:76:7 [INFO] [stderr] | [INFO] [stderr] 76 | for x in 0..SCREEN_WIDTH { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Vector` [INFO] [stderr] --> src/main.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | struct Vector { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `VIEW_WIDTH` [INFO] [stderr] --> src/main.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | const VIEW_WIDTH: f64 = 100 as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `VIEW_HEIGHT` [INFO] [stderr] --> src/main.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | const VIEW_HEIGHT: f64 = 100 as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `FOCAL_POINT` [INFO] [stderr] --> src/main.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | / const FOCAL_POINT: Point = Point { [INFO] [stderr] 41 | | x: 0 as f64, [INFO] [stderr] 42 | | y: 0 as f64, [INFO] [stderr] 43 | | z: 10 as f64 [INFO] [stderr] 44 | | }; [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:10 [INFO] [stderr] | [INFO] [stderr] 58 | x: 0 as f64, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:59:10 [INFO] [stderr] | [INFO] [stderr] 59 | y: 0 as f64, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:60:10 [INFO] [stderr] | [INFO] [stderr] 60 | z: -10 as f64 [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(-10)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | radius: 5 as f64 [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | fn render(field: &Vec) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Sphere]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/main.rs:74:6 [INFO] [stderr] | [INFO] [stderr] 74 | for y in 0..SCREEN_HEIGHT { [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/main.rs:76:7 [INFO] [stderr] | [INFO] [stderr] 76 | for x in 0..SCREEN_WIDTH { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Vector` [INFO] [stderr] --> src/main.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | struct Vector { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `VIEW_WIDTH` [INFO] [stderr] --> src/main.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | const VIEW_WIDTH: f64 = 100 as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `VIEW_HEIGHT` [INFO] [stderr] --> src/main.rs:38:1 [INFO] [stderr] | [INFO] [stderr] 38 | const VIEW_HEIGHT: f64 = 100 as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `FOCAL_POINT` [INFO] [stderr] --> src/main.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | / const FOCAL_POINT: Point = Point { [INFO] [stderr] 41 | | x: 0 as f64, [INFO] [stderr] 42 | | y: 0 as f64, [INFO] [stderr] 43 | | z: 10 as f64 [INFO] [stderr] 44 | | }; [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:10 [INFO] [stderr] | [INFO] [stderr] 58 | x: 0 as f64, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:59:10 [INFO] [stderr] | [INFO] [stderr] 59 | y: 0 as f64, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:60:10 [INFO] [stderr] | [INFO] [stderr] 60 | z: -10 as f64 [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(-10)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | radius: 5 as f64 [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | fn render(field: &Vec) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Sphere]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.64s [INFO] running `"docker" "inspect" "001fa10c38a579c633c398aef3a6b09db7ea0684d9610026371b4314f6bf1a0a"` [INFO] running `"docker" "rm" "-f" "001fa10c38a579c633c398aef3a6b09db7ea0684d9610026371b4314f6bf1a0a"` [INFO] [stdout] 001fa10c38a579c633c398aef3a6b09db7ea0684d9610026371b4314f6bf1a0a