[INFO] updating cached repository Reificator/brick [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Reificator/brick [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Reificator/brick" "work/ex/clippy-test-run/sources/stable/gh/Reificator/brick"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Reificator/brick'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Reificator/brick" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Reificator/brick"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Reificator/brick'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 95cb1760a063d52c72988753856aa3bf037a3f48 [INFO] sha for GitHub repo Reificator/brick: 95cb1760a063d52c72988753856aa3bf037a3f48 [INFO] validating manifest of Reificator/brick on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Reificator/brick on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Reificator/brick [INFO] finished frobbing Reificator/brick [INFO] frobbed toml for Reificator/brick written to work/ex/clippy-test-run/sources/stable/gh/Reificator/brick/Cargo.toml [INFO] started frobbing Reificator/brick [INFO] finished frobbing Reificator/brick [INFO] frobbed toml for Reificator/brick written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Reificator/brick/Cargo.toml [INFO] crate Reificator/brick has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] warning: Package `toml v0.4.5` does not have feature `serde`. It has a required dependency with that name, but only optional dependencies can be used as features. This is currently a warning to ease the transition, but it will become an error in the future. [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] warning: Package `toml v0.4.5` does not have feature `serde`. It has a required dependency with that name, but only optional dependencies can be used as features. This is currently a warning to ease the transition, but it will become an error in the future. [INFO] linting Reificator/brick against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Reificator/brick:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9a5cc5224cdbfb244fe33bf000f440569ef4f1f4bc110c48f2c41b81c1bea870 [INFO] running `"docker" "start" "-a" "9a5cc5224cdbfb244fe33bf000f440569ef4f1f4bc110c48f2c41b81c1bea870"` [INFO] [stderr] warning: Package `toml v0.4.5` does not have feature `serde`. It has a required dependency with that name, but only optional dependencies can be used as features. This is currently a warning to ease the transition, but it will become an error in the future. [INFO] [stderr] Compiling percent-encoding v1.0.0 [INFO] [stderr] Checking nodrop v0.1.12 [INFO] [stderr] Checking odds v0.2.26 [INFO] [stderr] Checking slog v2.0.12 [INFO] [stderr] Checking take_mut v0.1.3 [INFO] [stderr] Checking crossbeam v0.3.0 [INFO] [stderr] Compiling cmake v0.1.26 [INFO] [stderr] Compiling time v0.1.38 [INFO] [stderr] Compiling toml v0.2.1 [INFO] [stderr] Checking toml v0.4.5 [INFO] [stderr] Compiling idna v0.1.4 [INFO] [stderr] Checking pulse v0.5.3 [INFO] [stderr] Checking rayon-core v1.3.0 [INFO] [stderr] Compiling libz-sys v1.0.18 [INFO] [stderr] Checking arrayvec v0.3.24 [INFO] [stderr] Compiling shred-derive v0.3.0 [INFO] [stderr] Compiling libgit2-sys v0.6.16 [INFO] [stderr] Checking slog-async v2.1.0 [INFO] [stderr] Checking slog-term v2.2.0 [INFO] [stderr] Checking slog-json v2.0.2 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Compiling url v1.6.0 [INFO] [stderr] Checking shred v0.5.0 [INFO] [stderr] Checking hibitset v0.3.2 [INFO] [stderr] Checking specs v0.10.0 [INFO] [stderr] Compiling git2 v0.6.8 [INFO] [stderr] Compiling built v0.2.0 [INFO] [stderr] Compiling brick v0.1.0-pre1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logger.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | return logger; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `logger` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:7:25 [INFO] [stderr] | [INFO] [stderr] 7 | pub const PKG_VERSION: &'static str = "0.1.0-pre1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:9:31 [INFO] [stderr] | [INFO] [stderr] 9 | pub const PKG_VERSION_MAJOR: &'static str = "0"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:11:31 [INFO] [stderr] | [INFO] [stderr] 11 | pub const PKG_VERSION_MINOR: &'static str = "1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:13:31 [INFO] [stderr] | [INFO] [stderr] 13 | pub const PKG_VERSION_PATCH: &'static str = "0"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:15:29 [INFO] [stderr] | [INFO] [stderr] 15 | pub const PKG_VERSION_PRE: &'static str = "pre1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:17:25 [INFO] [stderr] | [INFO] [stderr] 17 | pub const PKG_AUTHORS: &'static str = "Reificator "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | pub const PKG_NAME: &'static str = "brick"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:21:29 [INFO] [stderr] | [INFO] [stderr] 21 | pub const PKG_DESCRIPTION: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | pub const PKG_HOMEPAGE: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | pub const TARGET: &'static str = "x86_64-unknown-linux-gnu"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | pub const HOST: &'static str = "x86_64-unknown-linux-gnu"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | pub const PROFILE: &'static str = "debug"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | pub const RUSTC: &'static str = "rustc"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:33:21 [INFO] [stderr] | [INFO] [stderr] 33 | pub const RUSTDOC: &'static str = "rustdoc"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:41:23 [INFO] [stderr] | [INFO] [stderr] 41 | pub const FEATURES: [&'static str; 0] = []; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | pub const FEATURES_STR: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:45:27 [INFO] [stderr] | [INFO] [stderr] 45 | pub const RUSTC_VERSION: &'static str = "rustc 1.32.0 (9fda7c223 2019-01-16)"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:47:29 [INFO] [stderr] | [INFO] [stderr] 47 | pub const RUSTDOC_VERSION: &'static str = "rustdoc 1.32.0 (9fda7c223 2019-01-16)"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:51:28 [INFO] [stderr] | [INFO] [stderr] 51 | pub const BUILT_TIME_UTC: &'static str = "Tue, 29 Jan 2019 07:48:48 GMT"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:53:29 [INFO] [stderr] | [INFO] [stderr] 53 | pub const CFG_TARGET_ARCH: &'static str = "x86_64"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:55:24 [INFO] [stderr] | [INFO] [stderr] 55 | pub const CFG_ENDIAN: &'static str = "little"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | pub const CFG_ENV: &'static str = "gnu"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | pub const CFG_FAMILY: &'static str = "unix"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:61:20 [INFO] [stderr] | [INFO] [stderr] 61 | pub const CFG_OS: &'static str = "linux"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:63:31 [INFO] [stderr] | [INFO] [stderr] 63 | pub const CFG_POINTER_WIDTH: &'static str = "64"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/logger.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | return logger; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `logger` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:7:25 [INFO] [stderr] | [INFO] [stderr] 7 | pub const PKG_VERSION: &'static str = "0.1.0-pre1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:9:31 [INFO] [stderr] | [INFO] [stderr] 9 | pub const PKG_VERSION_MAJOR: &'static str = "0"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:11:31 [INFO] [stderr] | [INFO] [stderr] 11 | pub const PKG_VERSION_MINOR: &'static str = "1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:13:31 [INFO] [stderr] | [INFO] [stderr] 13 | pub const PKG_VERSION_PATCH: &'static str = "0"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:15:29 [INFO] [stderr] | [INFO] [stderr] 15 | pub const PKG_VERSION_PRE: &'static str = "pre1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:17:25 [INFO] [stderr] | [INFO] [stderr] 17 | pub const PKG_AUTHORS: &'static str = "Reificator "; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | pub const PKG_NAME: &'static str = "brick"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:21:29 [INFO] [stderr] | [INFO] [stderr] 21 | pub const PKG_DESCRIPTION: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | pub const PKG_HOMEPAGE: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | pub const TARGET: &'static str = "x86_64-unknown-linux-gnu"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | pub const HOST: &'static str = "x86_64-unknown-linux-gnu"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | pub const PROFILE: &'static str = "debug"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | pub const RUSTC: &'static str = "rustc"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:33:21 [INFO] [stderr] | [INFO] [stderr] 33 | pub const RUSTDOC: &'static str = "rustdoc"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:41:23 [INFO] [stderr] | [INFO] [stderr] 41 | pub const FEATURES: [&'static str; 0] = []; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | pub const FEATURES_STR: &'static str = ""; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:45:27 [INFO] [stderr] | [INFO] [stderr] 45 | pub const RUSTC_VERSION: &'static str = "rustc 1.32.0 (9fda7c223 2019-01-16)"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:47:29 [INFO] [stderr] | [INFO] [stderr] 47 | pub const RUSTDOC_VERSION: &'static str = "rustdoc 1.32.0 (9fda7c223 2019-01-16)"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:51:28 [INFO] [stderr] | [INFO] [stderr] 51 | pub const BUILT_TIME_UTC: &'static str = "Tue, 29 Jan 2019 07:48:48 GMT"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:53:29 [INFO] [stderr] | [INFO] [stderr] 53 | pub const CFG_TARGET_ARCH: &'static str = "x86_64"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:55:24 [INFO] [stderr] | [INFO] [stderr] 55 | pub const CFG_ENDIAN: &'static str = "little"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | pub const CFG_ENV: &'static str = "gnu"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:59:24 [INFO] [stderr] | [INFO] [stderr] 59 | pub const CFG_FAMILY: &'static str = "unix"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:61:20 [INFO] [stderr] | [INFO] [stderr] 61 | pub const CFG_OS: &'static str = "linux"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/brick-874f36e0e0023619/out/built.rs:63:31 [INFO] [stderr] | [INFO] [stderr] 63 | pub const CFG_POINTER_WIDTH: &'static str = "64"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/logger.rs:109:28 [INFO] [stderr] | [INFO] [stderr] 109 | fn get_level_by_name(name: &String) -> slog::Level { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config.rs:43:8 [INFO] [stderr] | [INFO] [stderr] 43 | if cfg_str.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cfg_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/logger.rs:109:28 [INFO] [stderr] | [INFO] [stderr] 109 | fn get_level_by_name(name: &String) -> slog::Level { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config.rs:43:8 [INFO] [stderr] | [INFO] [stderr] 43 | if cfg_str.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cfg_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 34.02s [INFO] running `"docker" "inspect" "9a5cc5224cdbfb244fe33bf000f440569ef4f1f4bc110c48f2c41b81c1bea870"` [INFO] running `"docker" "rm" "-f" "9a5cc5224cdbfb244fe33bf000f440569ef4f1f4bc110c48f2c41b81c1bea870"` [INFO] [stdout] 9a5cc5224cdbfb244fe33bf000f440569ef4f1f4bc110c48f2c41b81c1bea870