[INFO] updating cached repository Regan-Koopmans/time-serv [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Regan-Koopmans/time-serv [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Regan-Koopmans/time-serv" "work/ex/clippy-test-run/sources/stable/gh/Regan-Koopmans/time-serv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Regan-Koopmans/time-serv'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Regan-Koopmans/time-serv" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Regan-Koopmans/time-serv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Regan-Koopmans/time-serv'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 77f02d2192cbfe98340c9662d886516065bd196b [INFO] sha for GitHub repo Regan-Koopmans/time-serv: 77f02d2192cbfe98340c9662d886516065bd196b [INFO] validating manifest of Regan-Koopmans/time-serv on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Regan-Koopmans/time-serv on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Regan-Koopmans/time-serv [INFO] finished frobbing Regan-Koopmans/time-serv [INFO] frobbed toml for Regan-Koopmans/time-serv written to work/ex/clippy-test-run/sources/stable/gh/Regan-Koopmans/time-serv/Cargo.toml [INFO] started frobbing Regan-Koopmans/time-serv [INFO] finished frobbing Regan-Koopmans/time-serv [INFO] frobbed toml for Regan-Koopmans/time-serv written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Regan-Koopmans/time-serv/Cargo.toml [INFO] crate Regan-Koopmans/time-serv has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Regan-Koopmans/time-serv against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Regan-Koopmans/time-serv:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3ebd09ee5d90f10a7232481e470857fc11a7399e9397efd12b98effb03a75d55 [INFO] running `"docker" "start" "-a" "3ebd09ee5d90f10a7232481e470857fc11a7399e9397efd12b98effb03a75d55"` [INFO] [stderr] Checking practical_3 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:119:52 [INFO] [stderr] | [INFO] [stderr] 119 | let line_array: Vec<&str> = line.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:178:5 [INFO] [stderr] | [INFO] [stderr] 178 | / match response.1 { [INFO] [stderr] 179 | | true => write_response(reader.into_inner(),response.0, true), [INFO] [stderr] 180 | | false => write_response(reader.into_inner(),response.0, false), [INFO] [stderr] 181 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if response.1 { write_response(reader.into_inner(),response.0, true) } else { write_response(reader.into_inner(),response.0, false) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:119:52 [INFO] [stderr] | [INFO] [stderr] 119 | let line_array: Vec<&str> = line.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:178:5 [INFO] [stderr] | [INFO] [stderr] 178 | / match response.1 { [INFO] [stderr] 179 | | true => write_response(reader.into_inner(),response.0, true), [INFO] [stderr] 180 | | false => write_response(reader.into_inner(),response.0, false), [INFO] [stderr] 181 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if response.1 { write_response(reader.into_inner(),response.0, true) } else { write_response(reader.into_inner(),response.0, false) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.02s [INFO] running `"docker" "inspect" "3ebd09ee5d90f10a7232481e470857fc11a7399e9397efd12b98effb03a75d55"` [INFO] running `"docker" "rm" "-f" "3ebd09ee5d90f10a7232481e470857fc11a7399e9397efd12b98effb03a75d55"` [INFO] [stdout] 3ebd09ee5d90f10a7232481e470857fc11a7399e9397efd12b98effb03a75d55