[INFO] updating cached repository Redhotsmasher/RedhotScaler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Redhotsmasher/RedhotScaler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Redhotsmasher/RedhotScaler" "work/ex/clippy-test-run/sources/stable/gh/Redhotsmasher/RedhotScaler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Redhotsmasher/RedhotScaler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Redhotsmasher/RedhotScaler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Redhotsmasher/RedhotScaler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Redhotsmasher/RedhotScaler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ea83a4fc3894c2a23b4326e39d7f2d74c4e23bd8 [INFO] sha for GitHub repo Redhotsmasher/RedhotScaler: ea83a4fc3894c2a23b4326e39d7f2d74c4e23bd8 [INFO] validating manifest of Redhotsmasher/RedhotScaler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Redhotsmasher/RedhotScaler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Redhotsmasher/RedhotScaler [INFO] finished frobbing Redhotsmasher/RedhotScaler [INFO] frobbed toml for Redhotsmasher/RedhotScaler written to work/ex/clippy-test-run/sources/stable/gh/Redhotsmasher/RedhotScaler/Cargo.toml [INFO] started frobbing Redhotsmasher/RedhotScaler [INFO] finished frobbing Redhotsmasher/RedhotScaler [INFO] frobbed toml for Redhotsmasher/RedhotScaler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Redhotsmasher/RedhotScaler/Cargo.toml [INFO] crate Redhotsmasher/RedhotScaler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Redhotsmasher/RedhotScaler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Redhotsmasher/RedhotScaler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6dce17be23e7b982425907ff55e694d9d3cfd1715a129ef71529d424cba9e012 [INFO] running `"docker" "start" "-a" "6dce17be23e7b982425907ff55e694d9d3cfd1715a129ef71529d424cba9e012"` [INFO] [stderr] Checking num-iter v0.1.37 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking soundthingy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:61:32 [INFO] [stderr] | [INFO] [stderr] 61 | let result: Sound = Sound {spec: spec, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `spec` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:61:44 [INFO] [stderr] | [INFO] [stderr] 61 | let result: Sound = Sound {spec: spec, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:150:32 [INFO] [stderr] | [INFO] [stderr] 150 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:150:44 [INFO] [stderr] | [INFO] [stderr] 150 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:374:32 [INFO] [stderr] | [INFO] [stderr] 374 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:374:44 [INFO] [stderr] | [INFO] [stderr] 374 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:419:32 [INFO] [stderr] | [INFO] [stderr] 419 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:419:44 [INFO] [stderr] | [INFO] [stderr] 419 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:541:32 [INFO] [stderr] | [INFO] [stderr] 541 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:541:44 [INFO] [stderr] | [INFO] [stderr] 541 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:580:32 [INFO] [stderr] | [INFO] [stderr] 580 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:580:44 [INFO] [stderr] | [INFO] [stderr] 580 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:619:32 [INFO] [stderr] | [INFO] [stderr] 619 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:619:44 [INFO] [stderr] | [INFO] [stderr] 619 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:658:32 [INFO] [stderr] | [INFO] [stderr] 658 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:658:44 [INFO] [stderr] | [INFO] [stderr] 658 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:695:32 [INFO] [stderr] | [INFO] [stderr] 695 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:695:44 [INFO] [stderr] | [INFO] [stderr] 695 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:732:32 [INFO] [stderr] | [INFO] [stderr] 732 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:732:44 [INFO] [stderr] | [INFO] [stderr] 732 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:771:32 [INFO] [stderr] | [INFO] [stderr] 771 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:771:44 [INFO] [stderr] | [INFO] [stderr] 771 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:810:32 [INFO] [stderr] | [INFO] [stderr] 810 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:810:44 [INFO] [stderr] | [INFO] [stderr] 810 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:853:32 [INFO] [stderr] | [INFO] [stderr] 853 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:853:44 [INFO] [stderr] | [INFO] [stderr] 853 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:896:32 [INFO] [stderr] | [INFO] [stderr] 896 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:896:44 [INFO] [stderr] | [INFO] [stderr] 896 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:936:32 [INFO] [stderr] | [INFO] [stderr] 936 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:936:44 [INFO] [stderr] | [INFO] [stderr] 936 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:976:32 [INFO] [stderr] | [INFO] [stderr] 976 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:976:44 [INFO] [stderr] | [INFO] [stderr] 976 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:1014:32 [INFO] [stderr] | [INFO] [stderr] 1014 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:1014:44 [INFO] [stderr] | [INFO] [stderr] 1014 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:61:32 [INFO] [stderr] | [INFO] [stderr] 61 | let result: Sound = Sound {spec: spec, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `spec` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:61:44 [INFO] [stderr] | [INFO] [stderr] 61 | let result: Sound = Sound {spec: spec, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:150:32 [INFO] [stderr] | [INFO] [stderr] 150 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:150:44 [INFO] [stderr] | [INFO] [stderr] 150 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:374:32 [INFO] [stderr] | [INFO] [stderr] 374 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:374:44 [INFO] [stderr] | [INFO] [stderr] 374 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:419:32 [INFO] [stderr] | [INFO] [stderr] 419 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:419:44 [INFO] [stderr] | [INFO] [stderr] 419 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:541:32 [INFO] [stderr] | [INFO] [stderr] 541 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:541:44 [INFO] [stderr] | [INFO] [stderr] 541 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:580:32 [INFO] [stderr] | [INFO] [stderr] 580 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:580:44 [INFO] [stderr] | [INFO] [stderr] 580 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:619:32 [INFO] [stderr] | [INFO] [stderr] 619 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:619:44 [INFO] [stderr] | [INFO] [stderr] 619 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:658:32 [INFO] [stderr] | [INFO] [stderr] 658 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:658:44 [INFO] [stderr] | [INFO] [stderr] 658 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:695:32 [INFO] [stderr] | [INFO] [stderr] 695 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:695:44 [INFO] [stderr] | [INFO] [stderr] 695 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:732:32 [INFO] [stderr] | [INFO] [stderr] 732 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:732:44 [INFO] [stderr] | [INFO] [stderr] 732 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:771:32 [INFO] [stderr] | [INFO] [stderr] 771 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:771:44 [INFO] [stderr] | [INFO] [stderr] 771 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:810:32 [INFO] [stderr] | [INFO] [stderr] 810 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:810:44 [INFO] [stderr] | [INFO] [stderr] 810 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:853:32 [INFO] [stderr] | [INFO] [stderr] 853 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:853:44 [INFO] [stderr] | [INFO] [stderr] 853 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:896:32 [INFO] [stderr] | [INFO] [stderr] 896 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:896:44 [INFO] [stderr] | [INFO] [stderr] 896 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:936:32 [INFO] [stderr] | [INFO] [stderr] 936 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:936:44 [INFO] [stderr] | [INFO] [stderr] 936 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:976:32 [INFO] [stderr] | [INFO] [stderr] 976 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:976:44 [INFO] [stderr] | [INFO] [stderr] 976 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:1014:32 [INFO] [stderr] | [INFO] [stderr] 1014 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:1014:44 [INFO] [stderr] | [INFO] [stderr] 1014 | let result: Image = Image {info: info, data: data}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:151:5 [INFO] [stderr] | [INFO] [stderr] 151 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:203:5 [INFO] [stderr] | [INFO] [stderr] 203 | return amplitude*(((((x as Float)-shift)/(0.5*width)).powi(2)*-0.5).exp()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `amplitude*(((((x as Float)-shift)/(0.5*width)).powi(2)*-0.5).exp())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:218:5 [INFO] [stderr] | [INFO] [stderr] 218 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:235:5 [INFO] [stderr] | [INFO] [stderr] 235 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:245:5 [INFO] [stderr] | [INFO] [stderr] 245 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:277:5 [INFO] [stderr] | [INFO] [stderr] 277 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:287:5 [INFO] [stderr] | [INFO] [stderr] 287 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:297:5 [INFO] [stderr] | [INFO] [stderr] 297 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:307:5 [INFO] [stderr] | [INFO] [stderr] 307 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:330:5 [INFO] [stderr] | [INFO] [stderr] 330 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:375:5 [INFO] [stderr] | [INFO] [stderr] 375 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:420:5 [INFO] [stderr] | [INFO] [stderr] 420 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:456:5 [INFO] [stderr] | [INFO] [stderr] 456 | return modsignal; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `modsignal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:503:5 [INFO] [stderr] | [INFO] [stderr] 503 | return modimage; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `modimage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:542:5 [INFO] [stderr] | [INFO] [stderr] 542 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:581:5 [INFO] [stderr] | [INFO] [stderr] 581 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:620:5 [INFO] [stderr] | [INFO] [stderr] 620 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:659:5 [INFO] [stderr] | [INFO] [stderr] 659 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:696:5 [INFO] [stderr] | [INFO] [stderr] 696 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:733:5 [INFO] [stderr] | [INFO] [stderr] 733 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:772:5 [INFO] [stderr] | [INFO] [stderr] 772 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:811:5 [INFO] [stderr] | [INFO] [stderr] 811 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:854:5 [INFO] [stderr] | [INFO] [stderr] 854 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:897:5 [INFO] [stderr] | [INFO] [stderr] 897 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:937:5 [INFO] [stderr] | [INFO] [stderr] 937 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:977:5 [INFO] [stderr] | [INFO] [stderr] 977 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:1015:5 [INFO] [stderr] | [INFO] [stderr] 1015 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:1021:5 [INFO] [stderr] | [INFO] [stderr] 1021 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:1027:5 [INFO] [stderr] | [INFO] [stderr] 1027 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:1137:5 [INFO] [stderr] | [INFO] [stderr] 1137 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/main.rs:1067:23 [INFO] [stderr] | [INFO] [stderr] 1067 | oldbdiff[j] = (oldsignal[j]-oldsignal[j-1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/main.rs:1071:23 [INFO] [stderr] | [INFO] [stderr] 1071 | oldfdiff[j] = (oldsignal[j]-oldsignal[j+1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/main.rs:1075:23 [INFO] [stderr] | [INFO] [stderr] 1075 | newbdiff[j] = (newsignal[j]-newsignal[j-1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/main.rs:1079:23 [INFO] [stderr] | [INFO] [stderr] 1079 | newfdiff[j] = (newsignal[j]-newsignal[j+1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:1097:16 [INFO] [stderr] | [INFO] [stderr] 1097 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 1098 | | if newbdiff[j].abs() >= oldbdiff[j].abs() { [INFO] [stderr] 1099 | | let mut temp = 0.0; [INFO] [stderr] 1100 | | if newsignal[j] > 0.0 { [INFO] [stderr] ... | [INFO] [stderr] 1134 | | //result[j] = oldsignal[j]; // I think more advanced logic is needed here, probably figure out which side for which the if conditional does not hold and adjust the result values until it does? [INFO] [stderr] 1135 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1097 | } else if newbdiff[j].abs() >= oldbdiff[j].abs() { [INFO] [stderr] 1098 | let mut temp = 0.0; [INFO] [stderr] 1099 | if newsignal[j] > 0.0 { [INFO] [stderr] 1100 | temp = newsignal[j] - (oldbdiff[j]-newbdiff[j]).abs(); [INFO] [stderr] 1101 | } else { [INFO] [stderr] 1102 | temp = newsignal[j] + (oldbdiff[j]-newbdiff[j]).abs(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:1203:5 [INFO] [stderr] | [INFO] [stderr] 1203 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:151:5 [INFO] [stderr] | [INFO] [stderr] 151 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:203:5 [INFO] [stderr] | [INFO] [stderr] 203 | return amplitude*(((((x as Float)-shift)/(0.5*width)).powi(2)*-0.5).exp()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `amplitude*(((((x as Float)-shift)/(0.5*width)).powi(2)*-0.5).exp())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:218:5 [INFO] [stderr] | [INFO] [stderr] 218 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:235:5 [INFO] [stderr] | [INFO] [stderr] 235 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:245:5 [INFO] [stderr] | [INFO] [stderr] 245 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:267:5 [INFO] [stderr] | [INFO] [stderr] 267 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:277:5 [INFO] [stderr] | [INFO] [stderr] 277 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:287:5 [INFO] [stderr] | [INFO] [stderr] 287 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:297:5 [INFO] [stderr] | [INFO] [stderr] 297 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:307:5 [INFO] [stderr] | [INFO] [stderr] 307 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:330:5 [INFO] [stderr] | [INFO] [stderr] 330 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:375:5 [INFO] [stderr] | [INFO] [stderr] 375 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:420:5 [INFO] [stderr] | [INFO] [stderr] 420 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:456:5 [INFO] [stderr] | [INFO] [stderr] 456 | return modsignal; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `modsignal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:503:5 [INFO] [stderr] | [INFO] [stderr] 503 | return modimage; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `modimage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:542:5 [INFO] [stderr] | [INFO] [stderr] 542 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:581:5 [INFO] [stderr] | [INFO] [stderr] 581 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:620:5 [INFO] [stderr] | [INFO] [stderr] 620 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:659:5 [INFO] [stderr] | [INFO] [stderr] 659 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:696:5 [INFO] [stderr] | [INFO] [stderr] 696 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:733:5 [INFO] [stderr] | [INFO] [stderr] 733 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:772:5 [INFO] [stderr] | [INFO] [stderr] 772 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:811:5 [INFO] [stderr] | [INFO] [stderr] 811 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:854:5 [INFO] [stderr] | [INFO] [stderr] 854 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:897:5 [INFO] [stderr] | [INFO] [stderr] 897 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:937:5 [INFO] [stderr] | [INFO] [stderr] 937 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:977:5 [INFO] [stderr] | [INFO] [stderr] 977 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:1015:5 [INFO] [stderr] | [INFO] [stderr] 1015 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:1021:5 [INFO] [stderr] | [INFO] [stderr] 1021 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:1027:5 [INFO] [stderr] | [INFO] [stderr] 1027 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:1137:5 [INFO] [stderr] | [INFO] [stderr] 1137 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/main.rs:1067:23 [INFO] [stderr] | [INFO] [stderr] 1067 | oldbdiff[j] = (oldsignal[j]-oldsignal[j-1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/main.rs:1071:23 [INFO] [stderr] | [INFO] [stderr] 1071 | oldfdiff[j] = (oldsignal[j]-oldsignal[j+1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/main.rs:1075:23 [INFO] [stderr] | [INFO] [stderr] 1075 | newbdiff[j] = (newsignal[j]-newsignal[j-1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/main.rs:1079:23 [INFO] [stderr] | [INFO] [stderr] 1079 | newfdiff[j] = (newsignal[j]-newsignal[j+1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:1097:16 [INFO] [stderr] | [INFO] [stderr] 1097 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 1098 | | if newbdiff[j].abs() >= oldbdiff[j].abs() { [INFO] [stderr] 1099 | | let mut temp = 0.0; [INFO] [stderr] 1100 | | if newsignal[j] > 0.0 { [INFO] [stderr] ... | [INFO] [stderr] 1134 | | //result[j] = oldsignal[j]; // I think more advanced logic is needed here, probably figure out which side for which the if conditional does not hold and adjust the result values until it does? [INFO] [stderr] 1135 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1097 | } else if newbdiff[j].abs() >= oldbdiff[j].abs() { [INFO] [stderr] 1098 | let mut temp = 0.0; [INFO] [stderr] 1099 | if newsignal[j] > 0.0 { [INFO] [stderr] 1100 | temp = newsignal[j] - (oldbdiff[j]-newbdiff[j]).abs(); [INFO] [stderr] 1101 | } else { [INFO] [stderr] 1102 | temp = newsignal[j] + (oldbdiff[j]-newbdiff[j]).abs(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:1203:5 [INFO] [stderr] | [INFO] [stderr] 1203 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: value assigned to `y` is never read [INFO] [stderr] --> src/main.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | let mut y = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `temp` is never read [INFO] [stderr] --> src/main.rs:177:25 [INFO] [stderr] | [INFO] [stderr] 177 | let mut temp = 0.0; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `resultlen` [INFO] [stderr] --> src/main.rs:223:9 [INFO] [stderr] | [INFO] [stderr] 223 | let resultlen = result.len(); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_resultlen` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `newsignal` [INFO] [stderr] --> src/main.rs:430:13 [INFO] [stderr] | [INFO] [stderr] 430 | let mut newsignal = nn4s_interpolate_signal(&signal); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_newsignal` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `newsignal` is never read [INFO] [stderr] --> src/main.rs:437:13 [INFO] [stderr] | [INFO] [stderr] 437 | let mut newsignal = nn4s_interpolate_signal(&signal); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `k` [INFO] [stderr] --> src/main.rs:446:13 [INFO] [stderr] | [INFO] [stderr] 446 | for k in 0..iter2 { [INFO] [stderr] | ^ help: consider using `_k` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `newimage` [INFO] [stderr] --> src/main.rs:466:13 [INFO] [stderr] | [INFO] [stderr] 466 | let mut newimage = nn4s_interpolate_image_2d(&image); [INFO] [stderr] | ^^^^^^^^ help: consider using `_newimage` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `newimage` is never read [INFO] [stderr] --> src/main.rs:469:13 [INFO] [stderr] | [INFO] [stderr] 469 | let mut newimage = nn4s_interpolate_image_2d(&image); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `dnewimage` is never read [INFO] [stderr] --> src/main.rs:476:17 [INFO] [stderr] | [INFO] [stderr] 476 | let mut dnewimage = convolve_image_horizontal(&newimage, &kernel); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `k` [INFO] [stderr] --> src/main.rs:485:13 [INFO] [stderr] | [INFO] [stderr] 485 | for k in 0..iter2 { [INFO] [stderr] | ^ help: consider using `_k` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `k` [INFO] [stderr] --> src/main.rs:489:13 [INFO] [stderr] | [INFO] [stderr] 489 | for k in 0..iter2 { [INFO] [stderr] | ^ help: consider using `_k` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `c` is never read [INFO] [stderr] --> src/main.rs:845:5 [INFO] [stderr] | [INFO] [stderr] 845 | c = 0; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `c` is never read [INFO] [stderr] --> src/main.rs:888:5 [INFO] [stderr] | [INFO] [stderr] 888 | c = 0; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `c` is never read [INFO] [stderr] --> src/main.rs:928:5 [INFO] [stderr] | [INFO] [stderr] 928 | c = 0; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `c` is never read [INFO] [stderr] --> src/main.rs:968:5 [INFO] [stderr] | [INFO] [stderr] 968 | c = 0; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `c` is never read [INFO] [stderr] --> src/main.rs:1006:5 [INFO] [stderr] | [INFO] [stderr] 1006 | c = 0; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `temp` is never read [INFO] [stderr] --> src/main.rs:1099:25 [INFO] [stderr] | [INFO] [stderr] 1099 | let mut temp = 0.0; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `temp` is never read [INFO] [stderr] --> src/main.rs:1111:25 [INFO] [stderr] | [INFO] [stderr] 1111 | let mut temp = 0.0; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:350:17 [INFO] [stderr] | [INFO] [stderr] 350 | let mut scaledline = redhotscale(&currline); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:395:17 [INFO] [stderr] | [INFO] [stderr] 395 | let mut scaledcol = redhotscale(&currcol); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:430:9 [INFO] [stderr] | [INFO] [stderr] 430 | let mut newsignal = nn4s_interpolate_signal(&signal); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:466:9 [INFO] [stderr] | [INFO] [stderr] 466 | let mut newimage = nn4s_interpolate_image_2d(&image); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:467:9 [INFO] [stderr] | [INFO] [stderr] 467 | let mut oldimage = mul_image(&image, 1.0); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:523:17 [INFO] [stderr] | [INFO] [stderr] 523 | let mut scaledline = nn4s_interpolate_signal(&currline); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:562:17 [INFO] [stderr] | [INFO] [stderr] 562 | let mut scaledcol = nn4s_interpolate_signal(&currcol); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:601:17 [INFO] [stderr] | [INFO] [stderr] 601 | let mut scaledline = subsample_signal_offset(&currline, factor, offset); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:640:17 [INFO] [stderr] | [INFO] [stderr] 640 | let mut scaledcol = subsample_signal_offset(&currcol, factor, offset); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:677:17 [INFO] [stderr] | [INFO] [stderr] 677 | let mut convolvedline = unpadsignal(&convolve(&padsignal(&currline, kernel.len()), &kernel), kernel.len()); [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:714:17 [INFO] [stderr] | [INFO] [stderr] 714 | let mut convolvedcol = unpadsignal(&convolve(&padsignal(&currcol, kernel.len()), &kernel), kernel.len()); [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:753:17 [INFO] [stderr] | [INFO] [stderr] 753 | let mut antirippledline = antiripple(&curroldline, &currline); [INFO] [stderr] | ----^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:792:17 [INFO] [stderr] | [INFO] [stderr] 792 | let mut antirippledcol = antiripple(&curroldcol, &currcol); [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:917:17 [INFO] [stderr] | [INFO] [stderr] 917 | let mut addedline = add_signals(&currline, &currline2); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:957:17 [INFO] [stderr] | [INFO] [stderr] 957 | let mut subtractedline = subtract_signals(&currline, &currline2); [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:995:17 [INFO] [stderr] | [INFO] [stderr] 995 | let mut multipliedline = mul_signal(&currline, factor); [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: value assigned to `y` is never read [INFO] [stderr] --> src/main.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | let mut y = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `temp` is never read [INFO] [stderr] --> src/main.rs:177:25 [INFO] [stderr] | [INFO] [stderr] 177 | let mut temp = 0.0; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `resultlen` [INFO] [stderr] --> src/main.rs:223:9 [INFO] [stderr] | [INFO] [stderr] 223 | let resultlen = result.len(); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_resultlen` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `newsignal` [INFO] [stderr] --> src/main.rs:430:13 [INFO] [stderr] | [INFO] [stderr] 430 | let mut newsignal = nn4s_interpolate_signal(&signal); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_newsignal` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `newsignal` is never read [INFO] [stderr] --> src/main.rs:437:13 [INFO] [stderr] | [INFO] [stderr] 437 | let mut newsignal = nn4s_interpolate_signal(&signal); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `k` [INFO] [stderr] --> src/main.rs:446:13 [INFO] [stderr] | [INFO] [stderr] 446 | for k in 0..iter2 { [INFO] [stderr] | ^ help: consider using `_k` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `newimage` [INFO] [stderr] --> src/main.rs:466:13 [INFO] [stderr] | [INFO] [stderr] 466 | let mut newimage = nn4s_interpolate_image_2d(&image); [INFO] [stderr] | ^^^^^^^^ help: consider using `_newimage` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `newimage` is never read [INFO] [stderr] --> src/main.rs:469:13 [INFO] [stderr] | [INFO] [stderr] 469 | let mut newimage = nn4s_interpolate_image_2d(&image); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `dnewimage` is never read [INFO] [stderr] --> src/main.rs:476:17 [INFO] [stderr] | [INFO] [stderr] 476 | let mut dnewimage = convolve_image_horizontal(&newimage, &kernel); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `k` [INFO] [stderr] --> src/main.rs:485:13 [INFO] [stderr] | [INFO] [stderr] 485 | for k in 0..iter2 { [INFO] [stderr] | ^ help: consider using `_k` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `k` [INFO] [stderr] --> src/main.rs:489:13 [INFO] [stderr] | [INFO] [stderr] 489 | for k in 0..iter2 { [INFO] [stderr] | ^ help: consider using `_k` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `c` is never read [INFO] [stderr] --> src/main.rs:845:5 [INFO] [stderr] | [INFO] [stderr] 845 | c = 0; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `c` is never read [INFO] [stderr] --> src/main.rs:888:5 [INFO] [stderr] | [INFO] [stderr] 888 | c = 0; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `c` is never read [INFO] [stderr] --> src/main.rs:928:5 [INFO] [stderr] | [INFO] [stderr] 928 | c = 0; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `c` is never read [INFO] [stderr] --> src/main.rs:968:5 [INFO] [stderr] | [INFO] [stderr] 968 | c = 0; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `c` is never read [INFO] [stderr] --> src/main.rs:1006:5 [INFO] [stderr] | [INFO] [stderr] 1006 | c = 0; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Subwave` [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | struct Subwave { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `temp` is never read [INFO] [stderr] --> src/main.rs:1099:25 [INFO] [stderr] | [INFO] [stderr] 1099 | let mut temp = 0.0; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `scale_image_horizontal` [INFO] [stderr] --> src/main.rs:333:1 [INFO] [stderr] | [INFO] [stderr] 333 | fn scale_image_horizontal(image: Image) -> Image { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `temp` is never read [INFO] [stderr] --> src/main.rs:1111:25 [INFO] [stderr] | [INFO] [stderr] 1111 | let mut temp = 0.0; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `scale_image_vertical` [INFO] [stderr] --> src/main.rs:378:1 [INFO] [stderr] | [INFO] [stderr] 378 | fn scale_image_vertical(image: Image) -> Image { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `antiripple_bak` [INFO] [stderr] --> src/main.rs:1140:1 [INFO] [stderr] | [INFO] [stderr] 1140 | fn antiripple_bak(oldsignal: &[Float], newsignal: &[Float]) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:41:35 [INFO] [stderr] | [INFO] [stderr] 41 | data[c as usize].push(s.unwrap() as Float); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(s.unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:51:53 [INFO] [stderr] | [INFO] [stderr] 51 | let multiplier: Float = (2.0 as Float).powi(spec.bits_per_sample as i32 - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(spec.bits_per_sample)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:53:35 [INFO] [stderr] | [INFO] [stderr] 53 | data[c as usize].push((s.unwrap() as Float)/multiplier); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(s.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:80:46 [INFO] [stderr] | [INFO] [stderr] 80 | let multiplier = (2.0 as Float).powi(sound.spec.bits_per_sample as i32 - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(sound.spec.bits_per_sample)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:139:20 [INFO] [stderr] | [INFO] [stderr] 139 | if gamma == true { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `gamma` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:140:44 [INFO] [stderr] | [INFO] [stderr] 140 | data[z as usize].push((buf[(y*info.width*channels+x*channels+z) as usize] as Float/multiplier).powf(gammafactor)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(buf[(y*info.width*channels+x*channels+z) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:142:43 [INFO] [stderr] | [INFO] [stderr] 142 | data[z as usize].push(buf[(y*info.width*channels+x*channels+z) as usize] as Float/multiplier); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(buf[(y*info.width*channels+x*channels+z) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | let ref mut w = BufWriter::new(file); [INFO] [stderr] | ----^^^^^^^^^------------------------ help: try: `let w = &mut BufWriter::new(file);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:177:17 [INFO] [stderr] | [INFO] [stderr] 177 | / let mut temp = 0.0; [INFO] [stderr] 178 | | if gamma == true { [INFO] [stderr] 179 | | temp = ((image.data[z as usize][(y*image.info.width+x) as usize]).powf(gammafactor)*multiplier).round(); [INFO] [stderr] 180 | | } else { [INFO] [stderr] 181 | | temp = (image.data[z as usize][(y*image.info.width+x) as usize]*multiplier).round(); [INFO] [stderr] 182 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let temp = if gamma == true { ((image.data[z as usize][(y*image.info.width+x) as usize]).powf(gammafactor)*multiplier).round() } else { (image.data[z as usize][(y*image.info.width+x) as usize]*multiplier).round() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:178:20 [INFO] [stderr] | [INFO] [stderr] 178 | if gamma == true { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `gamma` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:203:26 [INFO] [stderr] | [INFO] [stderr] 203 | return amplitude*(((((x as Float)-shift)/(0.5*width)).powi(2)*-0.5).exp()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:350:17 [INFO] [stderr] | [INFO] [stderr] 350 | let mut scaledline = redhotscale(&currline); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:395:17 [INFO] [stderr] | [INFO] [stderr] 395 | let mut scaledcol = redhotscale(&currcol); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:430:9 [INFO] [stderr] | [INFO] [stderr] 430 | let mut newsignal = nn4s_interpolate_signal(&signal); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:466:9 [INFO] [stderr] | [INFO] [stderr] 466 | let mut newimage = nn4s_interpolate_image_2d(&image); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:467:9 [INFO] [stderr] | [INFO] [stderr] 467 | let mut oldimage = mul_image(&image, 1.0); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:523:17 [INFO] [stderr] | [INFO] [stderr] 523 | let mut scaledline = nn4s_interpolate_signal(&currline); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:562:17 [INFO] [stderr] | [INFO] [stderr] 562 | let mut scaledcol = nn4s_interpolate_signal(&currcol); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:601:17 [INFO] [stderr] | [INFO] [stderr] 601 | let mut scaledline = subsample_signal_offset(&currline, factor, offset); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:640:17 [INFO] [stderr] | [INFO] [stderr] 640 | let mut scaledcol = subsample_signal_offset(&currcol, factor, offset); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:677:17 [INFO] [stderr] | [INFO] [stderr] 677 | let mut convolvedline = unpadsignal(&convolve(&padsignal(&currline, kernel.len()), &kernel), kernel.len()); [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:714:17 [INFO] [stderr] | [INFO] [stderr] 714 | let mut convolvedcol = unpadsignal(&convolve(&padsignal(&currcol, kernel.len()), &kernel), kernel.len()); [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:753:17 [INFO] [stderr] | [INFO] [stderr] 753 | let mut antirippledline = antiripple(&curroldline, &currline); [INFO] [stderr] | ----^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/main.rs:433:14 [INFO] [stderr] | [INFO] [stderr] 433 | for j in 0..signal.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] help: try replacing the loop by [INFO] [stderr] | [INFO] [stderr] 433 | for j in oldsignal[..signal.len()].clone_from_slice(&signal[..]) [INFO] [stderr] 434 | modsignal[..signal.len()].clone_from_slice(&signal[..]) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:792:17 [INFO] [stderr] | [INFO] [stderr] 792 | let mut antirippledcol = antiripple(&curroldcol, &currcol); [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:917:17 [INFO] [stderr] | [INFO] [stderr] 917 | let mut addedline = add_signals(&currline, &currline2); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:957:17 [INFO] [stderr] | [INFO] [stderr] 957 | let mut subtractedline = subtract_signals(&currline, &currline2); [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:995:17 [INFO] [stderr] | [INFO] [stderr] 995 | let mut multipliedline = mul_signal(&currline, factor); [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Subwave` [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | struct Subwave { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `scale_image_horizontal` [INFO] [stderr] --> src/main.rs:333:1 [INFO] [stderr] | [INFO] [stderr] 333 | fn scale_image_horizontal(image: Image) -> Image { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `scale_image_vertical` [INFO] [stderr] --> src/main.rs:378:1 [INFO] [stderr] | [INFO] [stderr] 378 | fn scale_image_vertical(image: Image) -> Image { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `antiripple_bak` [INFO] [stderr] --> src/main.rs:1140:1 [INFO] [stderr] | [INFO] [stderr] 1140 | fn antiripple_bak(oldsignal: &[Float], newsignal: &[Float]) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:41:35 [INFO] [stderr] | [INFO] [stderr] 41 | data[c as usize].push(s.unwrap() as Float); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(s.unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:51:53 [INFO] [stderr] | [INFO] [stderr] 51 | let multiplier: Float = (2.0 as Float).powi(spec.bits_per_sample as i32 - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(spec.bits_per_sample)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:53:35 [INFO] [stderr] | [INFO] [stderr] 53 | data[c as usize].push((s.unwrap() as Float)/multiplier); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(s.unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:80:46 [INFO] [stderr] | [INFO] [stderr] 80 | let multiplier = (2.0 as Float).powi(sound.spec.bits_per_sample as i32 - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(sound.spec.bits_per_sample)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:139:20 [INFO] [stderr] | [INFO] [stderr] 139 | if gamma == true { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `gamma` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:140:44 [INFO] [stderr] | [INFO] [stderr] 140 | data[z as usize].push((buf[(y*info.width*channels+x*channels+z) as usize] as Float/multiplier).powf(gammafactor)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(buf[(y*info.width*channels+x*channels+z) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:142:43 [INFO] [stderr] | [INFO] [stderr] 142 | data[z as usize].push(buf[(y*info.width*channels+x*channels+z) as usize] as Float/multiplier); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(buf[(y*info.width*channels+x*channels+z) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | let ref mut w = BufWriter::new(file); [INFO] [stderr] | ----^^^^^^^^^------------------------ help: try: `let w = &mut BufWriter::new(file);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:177:17 [INFO] [stderr] | [INFO] [stderr] 177 | / let mut temp = 0.0; [INFO] [stderr] 178 | | if gamma == true { [INFO] [stderr] 179 | | temp = ((image.data[z as usize][(y*image.info.width+x) as usize]).powf(gammafactor)*multiplier).round(); [INFO] [stderr] 180 | | } else { [INFO] [stderr] 181 | | temp = (image.data[z as usize][(y*image.info.width+x) as usize]*multiplier).round(); [INFO] [stderr] 182 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let temp = if gamma == true { ((image.data[z as usize][(y*image.info.width+x) as usize]).powf(gammafactor)*multiplier).round() } else { (image.data[z as usize][(y*image.info.width+x) as usize]*multiplier).round() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:178:20 [INFO] [stderr] | [INFO] [stderr] 178 | if gamma == true { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `gamma` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:203:26 [INFO] [stderr] | [INFO] [stderr] 203 | return amplitude*(((((x as Float)-shift)/(0.5*width)).powi(2)*-0.5).exp()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:1099:17 [INFO] [stderr] | [INFO] [stderr] 1099 | / let mut temp = 0.0; [INFO] [stderr] 1100 | | if newsignal[j] > 0.0 { [INFO] [stderr] 1101 | | temp = newsignal[j] - (oldbdiff[j]-newbdiff[j]).abs(); [INFO] [stderr] 1102 | | } else { [INFO] [stderr] 1103 | | temp = newsignal[j] + (oldbdiff[j]-newbdiff[j]).abs(); [INFO] [stderr] 1104 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let temp = if newsignal[j] > 0.0 { newsignal[j] - (oldbdiff[j]-newbdiff[j]).abs() } else { newsignal[j] + (oldbdiff[j]-newbdiff[j]).abs() };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:1111:17 [INFO] [stderr] | [INFO] [stderr] 1111 | / let mut temp = 0.0; [INFO] [stderr] 1112 | | if newsignal[j] > 0.0 { [INFO] [stderr] 1113 | | temp = newsignal[j] - (oldfdiff[j]-newfdiff[j]).abs(); [INFO] [stderr] 1114 | | } else { [INFO] [stderr] 1115 | | temp = newsignal[j] + (oldfdiff[j]-newfdiff[j]).abs(); [INFO] [stderr] 1116 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let temp = if newsignal[j] > 0.0 { newsignal[j] - (oldfdiff[j]-newfdiff[j]).abs() } else { newsignal[j] + (oldfdiff[j]-newfdiff[j]).abs() };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/main.rs:433:14 [INFO] [stderr] | [INFO] [stderr] 433 | for j in 0..signal.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] help: try replacing the loop by [INFO] [stderr] | [INFO] [stderr] 433 | for j in oldsignal[..signal.len()].clone_from_slice(&signal[..]) [INFO] [stderr] 434 | modsignal[..signal.len()].clone_from_slice(&signal[..]) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:1099:17 [INFO] [stderr] | [INFO] [stderr] 1099 | / let mut temp = 0.0; [INFO] [stderr] 1100 | | if newsignal[j] > 0.0 { [INFO] [stderr] 1101 | | temp = newsignal[j] - (oldbdiff[j]-newbdiff[j]).abs(); [INFO] [stderr] 1102 | | } else { [INFO] [stderr] 1103 | | temp = newsignal[j] + (oldbdiff[j]-newbdiff[j]).abs(); [INFO] [stderr] 1104 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let temp = if newsignal[j] > 0.0 { newsignal[j] - (oldbdiff[j]-newbdiff[j]).abs() } else { newsignal[j] + (oldbdiff[j]-newbdiff[j]).abs() };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:1111:17 [INFO] [stderr] | [INFO] [stderr] 1111 | / let mut temp = 0.0; [INFO] [stderr] 1112 | | if newsignal[j] > 0.0 { [INFO] [stderr] 1113 | | temp = newsignal[j] - (oldfdiff[j]-newfdiff[j]).abs(); [INFO] [stderr] 1114 | | } else { [INFO] [stderr] 1115 | | temp = newsignal[j] + (oldfdiff[j]-newfdiff[j]).abs(); [INFO] [stderr] 1116 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let temp = if newsignal[j] > 0.0 { newsignal[j] - (oldfdiff[j]-newfdiff[j]).abs() } else { newsignal[j] + (oldfdiff[j]-newfdiff[j]).abs() };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.73s [INFO] running `"docker" "inspect" "6dce17be23e7b982425907ff55e694d9d3cfd1715a129ef71529d424cba9e012"` [INFO] running `"docker" "rm" "-f" "6dce17be23e7b982425907ff55e694d9d3cfd1715a129ef71529d424cba9e012"` [INFO] [stdout] 6dce17be23e7b982425907ff55e694d9d3cfd1715a129ef71529d424cba9e012