[INFO] updating cached repository Ratismal/adventofcode2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Ratismal/adventofcode2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Ratismal/adventofcode2018" "work/ex/clippy-test-run/sources/stable/gh/Ratismal/adventofcode2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Ratismal/adventofcode2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Ratismal/adventofcode2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ratismal/adventofcode2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ratismal/adventofcode2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8ed412b3d04c39a2f6d7895d57fc2f1d9b39a759 [INFO] sha for GitHub repo Ratismal/adventofcode2018: 8ed412b3d04c39a2f6d7895d57fc2f1d9b39a759 [INFO] validating manifest of Ratismal/adventofcode2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Ratismal/adventofcode2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Ratismal/adventofcode2018 [INFO] finished frobbing Ratismal/adventofcode2018 [INFO] frobbed toml for Ratismal/adventofcode2018 written to work/ex/clippy-test-run/sources/stable/gh/Ratismal/adventofcode2018/Cargo.toml [INFO] started frobbing Ratismal/adventofcode2018 [INFO] finished frobbing Ratismal/adventofcode2018 [INFO] frobbed toml for Ratismal/adventofcode2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ratismal/adventofcode2018/Cargo.toml [INFO] crate Ratismal/adventofcode2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Ratismal/adventofcode2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Ratismal/adventofcode2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 859445fb4300d4c2390accde340e445170552ccd9bc0c107c03bf829da48b4e9 [INFO] running `"docker" "start" "-a" "859445fb4300d4c2390accde340e445170552ccd9bc0c107c03bf829da48b4e9"` [INFO] [stderr] Checking adventofcode2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:8:62 [INFO] [stderr] | [INFO] [stderr] 8 | println!("{yellow}@=========================@", yellow = "\x1B[33m"); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | yellow = "\x1B[33m", [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:12:17 [INFO] [stderr] | [INFO] [stderr] 12 | green = "\x1B[32m", [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:13:15 [INFO] [stderr] | [INFO] [stderr] 13 | red = "\x1B[31m", [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:14:16 [INFO] [stderr] | [INFO] [stderr] 14 | cyan = "\x1B[36m" [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | yellow = "\x1B[33m", [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | green = "\x1B[32m", [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:20:15 [INFO] [stderr] | [INFO] [stderr] 20 | red = "\x1B[31m" [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:22:62 [INFO] [stderr] | [INFO] [stderr] 22 | println!("@=========================@{reset}\n", reset = "\x1B[0m"); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:8:62 [INFO] [stderr] | [INFO] [stderr] 8 | println!("{yellow}@=========================@", yellow = "\x1B[33m"); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | yellow = "\x1B[33m", [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:12:17 [INFO] [stderr] | [INFO] [stderr] 12 | green = "\x1B[32m", [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:13:15 [INFO] [stderr] | [INFO] [stderr] 13 | red = "\x1B[31m", [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:14:16 [INFO] [stderr] | [INFO] [stderr] 14 | cyan = "\x1B[36m" [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | yellow = "\x1B[33m", [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | green = "\x1B[32m", [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:20:15 [INFO] [stderr] | [INFO] [stderr] 20 | red = "\x1B[31m" [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:22:62 [INFO] [stderr] | [INFO] [stderr] 22 | println!("@=========================@{reset}\n", reset = "\x1B[0m"); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d1.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | / return ( [INFO] [stderr] 10 | | String::from("Add a series of numbers"), [INFO] [stderr] 11 | | String::from("Find first repeated sum"), [INFO] [stderr] 12 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 9 | ( [INFO] [stderr] 10 | String::from("Add a series of numbers"), [INFO] [stderr] 11 | String::from("Find first repeated sum"), [INFO] [stderr] 12 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d1.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d1.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d2.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / return ( [INFO] [stderr] 10 | | String::from("Finds a checksum from IDs"), [INFO] [stderr] 11 | | String::from("Find IDs one step apart"), [INFO] [stderr] 12 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 9 | ( [INFO] [stderr] 10 | String::from("Finds a checksum from IDs"), [INFO] [stderr] 11 | String::from("Find IDs one step apart"), [INFO] [stderr] 12 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d2.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | return (two_count * three_count).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(two_count * three_count).to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d2.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | return String::from("No match found"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("No match found")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d2.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | return (two, three); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(two, three)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d2.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | return (misses == 1, matches); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(misses == 1, matches)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d3.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / return ( [INFO] [stderr] 26 | | String::from("Find overlapping coordinates"), [INFO] [stderr] 27 | | String::from("Find distinct coordinates"), [INFO] [stderr] 28 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 25 | ( [INFO] [stderr] 26 | String::from("Find overlapping coordinates"), [INFO] [stderr] 27 | String::from("Find distinct coordinates"), [INFO] [stderr] 28 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d3.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | return count.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `count.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d3.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return id.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `id.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d3.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | return (id, pos, dim); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(id, pos, dim)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d3.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | return map; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d4.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | return highest_minute; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `highest_minute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d4.rs:50:7 [INFO] [stderr] | [INFO] [stderr] 50 | return *count; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `*count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d4.rs:52:7 [INFO] [stderr] | [INFO] [stderr] 52 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d4.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / return ( [INFO] [stderr] 62 | | String::from("Find when a guard is asleep"), [INFO] [stderr] 63 | | String::from("Find the sleepiest guard"), [INFO] [stderr] 64 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 61 | ( [INFO] [stderr] 62 | String::from("Find when a guard is asleep"), [INFO] [stderr] 63 | String::from("Find the sleepiest guard"), [INFO] [stderr] 64 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d4.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | return (sleepiest.id * highest_minute).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(sleepiest.id * highest_minute).to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d4.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | return (highest_minute * highest_guard.id).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(highest_minute * highest_guard.id).to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d4.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | / return LogEntry { [INFO] [stderr] 147 | | entry_type, [INFO] [stderr] 148 | | date, [INFO] [stderr] 149 | | hour, [INFO] [stderr] 150 | | minute, [INFO] [stderr] 151 | | id, [INFO] [stderr] 152 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 146 | LogEntry { [INFO] [stderr] 147 | entry_type, [INFO] [stderr] 148 | date, [INFO] [stderr] 149 | hour, [INFO] [stderr] 150 | minute, [INFO] [stderr] 151 | id, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d4.rs:207:5 [INFO] [stderr] | [INFO] [stderr] 207 | return guard_map; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `guard_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d5.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / return ( [INFO] [stderr] 8 | | String::from("Eliminate differing cases"), [INFO] [stderr] 9 | | String::from("Find efficient elimination"), [INFO] [stderr] 10 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 7 | ( [INFO] [stderr] 8 | String::from("Eliminate differing cases"), [INFO] [stderr] 9 | String::from("Find efficient elimination"), [INFO] [stderr] 10 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d5.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return self.react(input).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.react(input).to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d5.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | return lengths[0].to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `lengths[0].to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d5.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return chars.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `chars.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d5.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | return input.replace(lower[0], "").replace(upper[0], ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `input.replace(lower[0], "").replace(upper[0], "")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d6.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / return ( [INFO] [stderr] 9 | | String::from("Find furthest points"), [INFO] [stderr] 10 | | String::from("Find closest points"), [INFO] [stderr] 11 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 8 | ( [INFO] [stderr] 9 | String::from("Find furthest points"), [INFO] [stderr] 10 | String::from("Find closest points"), [INFO] [stderr] 11 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d6.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | return largest_point.area.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `largest_point.area.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d6.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return area_sum.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `area_sum.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d6.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | return points; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d6.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | return point; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d6.rs:179:5 [INFO] [stderr] | [INFO] [stderr] 179 | return (self.x - target.x).abs() + (self.y - target.y).abs(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.x - target.x).abs() + (self.y - target.y).abs()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d7.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / return ( [INFO] [stderr] 11 | | String::from("To be determined..."), [INFO] [stderr] 12 | | String::from("To be determined..."), [INFO] [stderr] 13 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 10 | ( [INFO] [stderr] 11 | String::from("To be determined..."), [INFO] [stderr] 12 | String::from("To be determined..."), [INFO] [stderr] 13 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d7.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return completed.join(""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `completed.join("")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d7.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | return seconds.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `seconds.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d7.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | return map; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d7.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | return id; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d7.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | return 60 + i; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `60 + i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/puzzles/d8.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d8.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | return (String::from("Placeholder"), String::from("Placeholder")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(String::from("Placeholder"), String::from("Placeholder"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d8.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return String::from("Placeholder"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("Placeholder")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d8.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return String::from("Placeholder"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("Placeholder")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d8.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | return elements; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `elements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/mod.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d1.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | / return ( [INFO] [stderr] 10 | | String::from("Add a series of numbers"), [INFO] [stderr] 11 | | String::from("Find first repeated sum"), [INFO] [stderr] 12 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 9 | ( [INFO] [stderr] 10 | String::from("Add a series of numbers"), [INFO] [stderr] 11 | String::from("Find first repeated sum"), [INFO] [stderr] 12 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d1.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d1.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d2.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / return ( [INFO] [stderr] 10 | | String::from("Finds a checksum from IDs"), [INFO] [stderr] 11 | | String::from("Find IDs one step apart"), [INFO] [stderr] 12 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 9 | ( [INFO] [stderr] 10 | String::from("Finds a checksum from IDs"), [INFO] [stderr] 11 | String::from("Find IDs one step apart"), [INFO] [stderr] 12 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d2.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | return (two_count * three_count).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(two_count * three_count).to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d2.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | return String::from("No match found"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("No match found")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d2.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | return (two, three); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(two, three)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d2.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | return (misses == 1, matches); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(misses == 1, matches)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d3.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | / return ( [INFO] [stderr] 26 | | String::from("Find overlapping coordinates"), [INFO] [stderr] 27 | | String::from("Find distinct coordinates"), [INFO] [stderr] 28 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 25 | ( [INFO] [stderr] 26 | String::from("Find overlapping coordinates"), [INFO] [stderr] 27 | String::from("Find distinct coordinates"), [INFO] [stderr] 28 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d3.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | return count.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `count.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d3.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return id.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `id.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d3.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | return (id, pos, dim); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(id, pos, dim)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d3.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | return map; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d4.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | return highest_minute; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `highest_minute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d4.rs:50:7 [INFO] [stderr] | [INFO] [stderr] 50 | return *count; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `*count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d4.rs:52:7 [INFO] [stderr] | [INFO] [stderr] 52 | return 0; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d4.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / return ( [INFO] [stderr] 62 | | String::from("Find when a guard is asleep"), [INFO] [stderr] 63 | | String::from("Find the sleepiest guard"), [INFO] [stderr] 64 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 61 | ( [INFO] [stderr] 62 | String::from("Find when a guard is asleep"), [INFO] [stderr] 63 | String::from("Find the sleepiest guard"), [INFO] [stderr] 64 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d4.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | return (sleepiest.id * highest_minute).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(sleepiest.id * highest_minute).to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d4.rs:112:5 [INFO] [stderr] | [INFO] [stderr] 112 | return (highest_minute * highest_guard.id).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(highest_minute * highest_guard.id).to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d4.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | / return LogEntry { [INFO] [stderr] 147 | | entry_type, [INFO] [stderr] 148 | | date, [INFO] [stderr] 149 | | hour, [INFO] [stderr] 150 | | minute, [INFO] [stderr] 151 | | id, [INFO] [stderr] 152 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 146 | LogEntry { [INFO] [stderr] 147 | entry_type, [INFO] [stderr] 148 | date, [INFO] [stderr] 149 | hour, [INFO] [stderr] 150 | minute, [INFO] [stderr] 151 | id, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d4.rs:207:5 [INFO] [stderr] | [INFO] [stderr] 207 | return guard_map; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `guard_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d5.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | / return ( [INFO] [stderr] 8 | | String::from("Eliminate differing cases"), [INFO] [stderr] 9 | | String::from("Find efficient elimination"), [INFO] [stderr] 10 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 7 | ( [INFO] [stderr] 8 | String::from("Eliminate differing cases"), [INFO] [stderr] 9 | String::from("Find efficient elimination"), [INFO] [stderr] 10 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d5.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return self.react(input).to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.react(input).to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d5.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | return lengths[0].to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `lengths[0].to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d5.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | return chars.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `chars.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d5.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | return input.replace(lower[0], "").replace(upper[0], ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `input.replace(lower[0], "").replace(upper[0], "")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d6.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / return ( [INFO] [stderr] 9 | | String::from("Find furthest points"), [INFO] [stderr] 10 | | String::from("Find closest points"), [INFO] [stderr] 11 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 8 | ( [INFO] [stderr] 9 | String::from("Find furthest points"), [INFO] [stderr] 10 | String::from("Find closest points"), [INFO] [stderr] 11 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d6.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | return largest_point.area.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `largest_point.area.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d6.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return area_sum.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `area_sum.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d6.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | return points; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `points` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d6.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | return point; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d6.rs:179:5 [INFO] [stderr] | [INFO] [stderr] 179 | return (self.x - target.x).abs() + (self.y - target.y).abs(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.x - target.x).abs() + (self.y - target.y).abs()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d7.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / return ( [INFO] [stderr] 11 | | String::from("To be determined..."), [INFO] [stderr] 12 | | String::from("To be determined..."), [INFO] [stderr] 13 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 10 | ( [INFO] [stderr] 11 | String::from("To be determined..."), [INFO] [stderr] 12 | String::from("To be determined..."), [INFO] [stderr] 13 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d7.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return completed.join(""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `completed.join("")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d7.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | return seconds.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `seconds.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d7.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | return map; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d7.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | return id; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d7.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | return 60 + i; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `60 + i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/puzzles/d8.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d8.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | return (String::from("Placeholder"), String::from("Placeholder")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(String::from("Placeholder"), String::from("Placeholder"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d8.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return String::from("Placeholder"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("Placeholder")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d8.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return String::from("Placeholder"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("Placeholder")` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/d8.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | return elements; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `elements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/puzzles/mod.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/puzzles/d8.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | let mut state: State = State::HEADER_CHILD; [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `child_nodes` [INFO] [stderr] --> src/puzzles/d8.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | let mut child_nodes: u32; [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_child_nodes` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `meta_elements` [INFO] [stderr] --> src/puzzles/d8.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | let mut meta_elements: u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_meta_elements` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/puzzles/d8.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | for i in elements {} [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `elements` [INFO] [stderr] --> src/puzzles/d8.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | let elements = self.parse(&input); [INFO] [stderr] | ^^^^^^^^ help: consider using `_elements` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/puzzles/d8.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | let mut state: State = State::HEADER_CHILD; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/puzzles/d8.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | let mut child_nodes: u32; [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/puzzles/d8.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | let mut meta_elements: u32; [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Node` [INFO] [stderr] --> src/puzzles/d8.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | struct Node { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `HEADER_META` [INFO] [stderr] --> src/puzzles/d8.rs:13:3 [INFO] [stderr] | [INFO] [stderr] 13 | HEADER_META, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `META` [INFO] [stderr] --> src/puzzles/d8.rs:14:3 [INFO] [stderr] | [INFO] [stderr] 14 | META, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/puzzles/d1.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | / if map.contains_key(&result) { [INFO] [stderr] 43 | | cont = false; [INFO] [stderr] 44 | | break; [INFO] [stderr] 45 | | } else { [INFO] [stderr] 46 | | map.insert(result, true); [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________________^ help: consider using: `map.entry(result)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/puzzles/d2.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | for (_, val) in &map { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 66 | for val in map.values() { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/puzzles/d3.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | for (_, val) in &map { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 34 | for val in map.values() { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/puzzles/d3.rs:60:12 [INFO] [stderr] | [INFO] [stderr] 60 | if good == false { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `!good` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/puzzles/d3.rs:64:10 [INFO] [stderr] | [INFO] [stderr] 64 | if good == true { [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `good` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/puzzles/d3.rs:79:39 [INFO] [stderr] | [INFO] [stderr] 79 | let sn3: Vec<&str> = sn2[0].split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/puzzles/d3.rs:80:39 [INFO] [stderr] | [INFO] [stderr] 80 | let sn4: Vec<&str> = sn2[1].split("x").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/puzzles/d4.rs:38:10 [INFO] [stderr] | [INFO] [stderr] 38 | if count > &highest_count { [INFO] [stderr] | ^^^^^^^^-------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `highest_count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/puzzles/d4.rs:41:44 [INFO] [stderr] | [INFO] [stderr] 41 | } else if count == &highest_count && minute < &highest_minute { [INFO] [stderr] | ^^^^^^^^^--------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `highest_minute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/puzzles/d4.rs:49:19 [INFO] [stderr] | [INFO] [stderr] 49 | let count = self.minute_map.get(&minute).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.minute_map[&minute]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/puzzles/d4.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | / for cap in entry_re.captures_iter(line) { [INFO] [stderr] 128 | | date = cap[1].to_string(); [INFO] [stderr] 129 | | hour = cap[2].parse().unwrap(); [INFO] [stderr] 130 | | minute = cap[3].parse().unwrap(); [INFO] [stderr] 131 | | text = cap[4].parse().unwrap(); [INFO] [stderr] 132 | | break; [INFO] [stderr] 133 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/puzzles/d4.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | / for cap in shift_re.captures_iter(text.as_ref()) { [INFO] [stderr] 140 | | id = cap[1].parse().unwrap(); [INFO] [stderr] 141 | | break; [INFO] [stderr] 142 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/puzzles/d5.rs:31:32 [INFO] [stderr] | [INFO] [stderr] 31 | let mut chars: Vec = input.chars().into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `input.chars()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/puzzles/d6.rs:61:27 [INFO] [stderr] | [INFO] [stderr] 61 | for (_, point) in &points { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 61 | for point in points.values() { [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/puzzles/d8.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | let mut state: State = State::HEADER_CHILD; [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `child_nodes` [INFO] [stderr] --> src/puzzles/d8.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | let mut child_nodes: u32; [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_child_nodes` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `meta_elements` [INFO] [stderr] --> src/puzzles/d8.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | let mut meta_elements: u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_meta_elements` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/puzzles/d8.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | for i in elements {} [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `elements` [INFO] [stderr] --> src/puzzles/d8.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | let elements = self.parse(&input); [INFO] [stderr] | ^^^^^^^^ help: consider using `_elements` instead [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/puzzles/d6.rs:74:33 [INFO] [stderr] | [INFO] [stderr] 74 | fn parse_points(&self, input: &String, max_point: &mut Point) -> HashMap { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/puzzles/d6.rs:118:23 [INFO] [stderr] | [INFO] [stderr] 118 | for (_, point) in points { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 118 | for point in points.values() { [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/puzzles/d7.rs:21:10 [INFO] [stderr] | [INFO] [stderr] 21 | if task.before.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `task.before.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/puzzles/d7.rs:26:11 [INFO] [stderr] | [INFO] [stderr] 26 | while queue.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/puzzles/d7.rs:38:10 [INFO] [stderr] | [INFO] [stderr] 38 | if task.before.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `task.before.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/puzzles/d7.rs:50:22 [INFO] [stderr] | [INFO] [stderr] 50 | let task = map.get(&t).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[&t]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/puzzles/d7.rs:52:32 [INFO] [stderr] | [INFO] [stderr] 52 | let task2: &Task = map.get(&tid).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[&tid]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/puzzles/d7.rs:71:28 [INFO] [stderr] | [INFO] [stderr] 71 | while workers > 0 && queue.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/puzzles/d7.rs:81:10 [INFO] [stderr] | [INFO] [stderr] 81 | if queue.len() == 0 && workers == 5 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/puzzles/d7.rs:91:26 [INFO] [stderr] | [INFO] [stderr] 91 | fn parse(&self, input: &String) -> HashMap { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/puzzles/d7.rs:127:16 [INFO] [stderr] | [INFO] [stderr] 127 | completed: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/puzzles/d7.rs:152:31 [INFO] [stderr] | [INFO] [stderr] 152 | fn time_required(&self, id: &String) -> i32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variant `HEADER_CHILD` should have a camel case name such as `HeaderChild` [INFO] [stderr] --> src/puzzles/d8.rs:12:3 [INFO] [stderr] | [INFO] [stderr] 12 | HEADER_CHILD, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `HEADER_META` should have a camel case name such as `HeaderMeta` [INFO] [stderr] --> src/puzzles/d8.rs:13:3 [INFO] [stderr] | [INFO] [stderr] 13 | HEADER_META, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/puzzles/d8.rs:41:26 [INFO] [stderr] | [INFO] [stderr] 41 | fn parse(&self, input: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/puzzles/d8.rs:43:28 [INFO] [stderr] | [INFO] [stderr] 43 | for set in input.split(" ") { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/puzzles/mod.rs:65:19 [INFO] [stderr] | [INFO] [stderr] 65 | if trimmed == String::from("q") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"q"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `adventofcode2018`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/puzzles/d8.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | let mut state: State = State::HEADER_CHILD; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/puzzles/d8.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | let mut child_nodes: u32; [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/puzzles/d8.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | let mut meta_elements: u32; [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Node` [INFO] [stderr] --> src/puzzles/d8.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | struct Node { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `HEADER_META` [INFO] [stderr] --> src/puzzles/d8.rs:13:3 [INFO] [stderr] | [INFO] [stderr] 13 | HEADER_META, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `META` [INFO] [stderr] --> src/puzzles/d8.rs:14:3 [INFO] [stderr] | [INFO] [stderr] 14 | META, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/puzzles/d1.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | / if map.contains_key(&result) { [INFO] [stderr] 43 | | cont = false; [INFO] [stderr] 44 | | break; [INFO] [stderr] 45 | | } else { [INFO] [stderr] 46 | | map.insert(result, true); [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________________^ help: consider using: `map.entry(result)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/puzzles/d2.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | for (_, val) in &map { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 66 | for val in map.values() { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/puzzles/d3.rs:34:21 [INFO] [stderr] | [INFO] [stderr] 34 | for (_, val) in &map { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 34 | for val in map.values() { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/puzzles/d3.rs:60:12 [INFO] [stderr] | [INFO] [stderr] 60 | if good == false { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `!good` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/puzzles/d3.rs:64:10 [INFO] [stderr] | [INFO] [stderr] 64 | if good == true { [INFO] [stderr] | ^^^^^^^^^^^^ help: try simplifying it as shown: `good` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/puzzles/d3.rs:79:39 [INFO] [stderr] | [INFO] [stderr] 79 | let sn3: Vec<&str> = sn2[0].split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/puzzles/d3.rs:80:39 [INFO] [stderr] | [INFO] [stderr] 80 | let sn4: Vec<&str> = sn2[1].split("x").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'x'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/puzzles/d4.rs:38:10 [INFO] [stderr] | [INFO] [stderr] 38 | if count > &highest_count { [INFO] [stderr] | ^^^^^^^^-------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `highest_count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/puzzles/d4.rs:41:44 [INFO] [stderr] | [INFO] [stderr] 41 | } else if count == &highest_count && minute < &highest_minute { [INFO] [stderr] | ^^^^^^^^^--------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `highest_minute` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/puzzles/d4.rs:49:19 [INFO] [stderr] | [INFO] [stderr] 49 | let count = self.minute_map.get(&minute).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.minute_map[&minute]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/puzzles/d4.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | / for cap in entry_re.captures_iter(line) { [INFO] [stderr] 128 | | date = cap[1].to_string(); [INFO] [stderr] 129 | | hour = cap[2].parse().unwrap(); [INFO] [stderr] 130 | | minute = cap[3].parse().unwrap(); [INFO] [stderr] 131 | | text = cap[4].parse().unwrap(); [INFO] [stderr] 132 | | break; [INFO] [stderr] 133 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/puzzles/d4.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | / for cap in shift_re.captures_iter(text.as_ref()) { [INFO] [stderr] 140 | | id = cap[1].parse().unwrap(); [INFO] [stderr] 141 | | break; [INFO] [stderr] 142 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/puzzles/d5.rs:31:32 [INFO] [stderr] | [INFO] [stderr] 31 | let mut chars: Vec = input.chars().into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `input.chars()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/puzzles/d6.rs:61:27 [INFO] [stderr] | [INFO] [stderr] 61 | for (_, point) in &points { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 61 | for point in points.values() { [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/puzzles/d6.rs:74:33 [INFO] [stderr] | [INFO] [stderr] 74 | fn parse_points(&self, input: &String, max_point: &mut Point) -> HashMap { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/puzzles/d6.rs:118:23 [INFO] [stderr] | [INFO] [stderr] 118 | for (_, point) in points { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 118 | for point in points.values() { [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/puzzles/d7.rs:21:10 [INFO] [stderr] | [INFO] [stderr] 21 | if task.before.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `task.before.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/puzzles/d7.rs:26:11 [INFO] [stderr] | [INFO] [stderr] 26 | while queue.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/puzzles/d7.rs:38:10 [INFO] [stderr] | [INFO] [stderr] 38 | if task.before.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `task.before.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/puzzles/d7.rs:50:22 [INFO] [stderr] | [INFO] [stderr] 50 | let task = map.get(&t).unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[&t]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/puzzles/d7.rs:52:32 [INFO] [stderr] | [INFO] [stderr] 52 | let task2: &Task = map.get(&tid).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[&tid]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/puzzles/d7.rs:71:28 [INFO] [stderr] | [INFO] [stderr] 71 | while workers > 0 && queue.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/puzzles/d7.rs:81:10 [INFO] [stderr] | [INFO] [stderr] 81 | if queue.len() == 0 && workers == 5 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `queue.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/puzzles/d7.rs:91:26 [INFO] [stderr] | [INFO] [stderr] 91 | fn parse(&self, input: &String) -> HashMap { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/puzzles/d7.rs:127:16 [INFO] [stderr] | [INFO] [stderr] 127 | completed: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/puzzles/d7.rs:152:31 [INFO] [stderr] | [INFO] [stderr] 152 | fn time_required(&self, id: &String) -> i32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variant `HEADER_CHILD` should have a camel case name such as `HeaderChild` [INFO] [stderr] --> src/puzzles/d8.rs:12:3 [INFO] [stderr] | [INFO] [stderr] 12 | HEADER_CHILD, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant `HEADER_META` should have a camel case name such as `HeaderMeta` [INFO] [stderr] --> src/puzzles/d8.rs:13:3 [INFO] [stderr] | [INFO] [stderr] 13 | HEADER_META, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/puzzles/d8.rs:41:26 [INFO] [stderr] | [INFO] [stderr] 41 | fn parse(&self, input: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/puzzles/d8.rs:43:28 [INFO] [stderr] | [INFO] [stderr] 43 | for set in input.split(" ") { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/puzzles/mod.rs:65:19 [INFO] [stderr] | [INFO] [stderr] 65 | if trimmed == String::from("q") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"q"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `adventofcode2018`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "859445fb4300d4c2390accde340e445170552ccd9bc0c107c03bf829da48b4e9"` [INFO] running `"docker" "rm" "-f" "859445fb4300d4c2390accde340e445170552ccd9bc0c107c03bf829da48b4e9"` [INFO] [stdout] 859445fb4300d4c2390accde340e445170552ccd9bc0c107c03bf829da48b4e9