[INFO] updating cached repository RaineForest/FateExtraSolver [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/RaineForest/FateExtraSolver [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/RaineForest/FateExtraSolver" "work/ex/clippy-test-run/sources/stable/gh/RaineForest/FateExtraSolver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/RaineForest/FateExtraSolver'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/RaineForest/FateExtraSolver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RaineForest/FateExtraSolver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RaineForest/FateExtraSolver'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8e117b3ce106f17fb2a59d453ad1f590b4e38c75 [INFO] sha for GitHub repo RaineForest/FateExtraSolver: 8e117b3ce106f17fb2a59d453ad1f590b4e38c75 [INFO] validating manifest of RaineForest/FateExtraSolver on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of RaineForest/FateExtraSolver on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing RaineForest/FateExtraSolver [INFO] finished frobbing RaineForest/FateExtraSolver [INFO] frobbed toml for RaineForest/FateExtraSolver written to work/ex/clippy-test-run/sources/stable/gh/RaineForest/FateExtraSolver/Cargo.toml [INFO] started frobbing RaineForest/FateExtraSolver [INFO] finished frobbing RaineForest/FateExtraSolver [INFO] frobbed toml for RaineForest/FateExtraSolver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RaineForest/FateExtraSolver/Cargo.toml [INFO] crate RaineForest/FateExtraSolver has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting RaineForest/FateExtraSolver against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/RaineForest/FateExtraSolver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1f0989bcc12f775a7fcd66cf771e7f78070287495014c8760ed89de8861890b8 [INFO] running `"docker" "start" "-a" "1f0989bcc12f775a7fcd66cf771e7f78070287495014c8760ed89de8861890b8"` [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Checking regex v0.2.10 [INFO] [stderr] Checking fate_extra_solver v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/action.rs:44:27 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn deserialize(s: &String) -> Action { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/action_count.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match a { [INFO] [stderr] 42 | | &Action::Attack => ActionCount { attacks: 1, guards: 0, breaks: 0, specials: 0, }, [INFO] [stderr] 43 | | &Action::Guard => ActionCount { attacks: 0, guards: 1, breaks: 0, specials: 0, }, [INFO] [stderr] 44 | | &Action::Break => ActionCount { attacks: 0, guards: 0, breaks: 1, specials: 0, }, [INFO] [stderr] 45 | | &Action::Special => ActionCount { attacks: 0, guards: 0, breaks: 0, specials: 1, }, [INFO] [stderr] 46 | | _ => ActionCount { attacks: 0, guards: 0, breaks: 0, specials: 0, }, [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 41 | match *a { [INFO] [stderr] 42 | Action::Attack => ActionCount { attacks: 1, guards: 0, breaks: 0, specials: 0, }, [INFO] [stderr] 43 | Action::Guard => ActionCount { attacks: 0, guards: 1, breaks: 0, specials: 0, }, [INFO] [stderr] 44 | Action::Break => ActionCount { attacks: 0, guards: 0, breaks: 1, specials: 0, }, [INFO] [stderr] 45 | Action::Special => ActionCount { attacks: 0, guards: 0, breaks: 0, specials: 1, }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/action_count.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | / match a { [INFO] [stderr] 56 | | &Action::Attack => self.attacks, [INFO] [stderr] 57 | | &Action::Guard => self.guards, [INFO] [stderr] 58 | | &Action::Break => self.breaks, [INFO] [stderr] 59 | | &Action::Special => self.specials, [INFO] [stderr] 60 | | _ => 0, [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 55 | match *a { [INFO] [stderr] 56 | Action::Attack => self.attacks, [INFO] [stderr] 57 | Action::Guard => self.guards, [INFO] [stderr] 58 | Action::Break => self.breaks, [INFO] [stderr] 59 | Action::Special => self.specials, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/action_count.rs:107:23 [INFO] [stderr] | [INFO] [stderr] 107 | } else if f == m { [INFO] [stderr] | ^^^^^^ help: consider comparing them within some error: `(f - m).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/action_count.rs:107:23 [INFO] [stderr] | [INFO] [stderr] 107 | } else if f == m { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/enemy.rs:41:45 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn matching_strings(&self, actions: &Vec) -> Vec<&Vec> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Action]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/enemy.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / self.action_strings.iter().map(|x| { [INFO] [stderr] 50 | | x.iter().map(|y| { [INFO] [stderr] 51 | | print!("{}\t", y); [INFO] [stderr] 52 | | }).collect::>(); [INFO] [stderr] 53 | | println!(); [INFO] [stderr] 54 | | }).collect::>(); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/enemy.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / self.action_strings.iter().map(|x| { [INFO] [stderr] 50 | | x.iter().map(|y| { [INFO] [stderr] 51 | | print!("{}\t", y); [INFO] [stderr] 52 | | }).collect::>(); [INFO] [stderr] 53 | | println!(); [INFO] [stderr] 54 | | }).collect::>(); [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/enemy.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | / x.iter().map(|y| { [INFO] [stderr] 51 | | print!("{}\t", y); [INFO] [stderr] 52 | | }).collect::>(); [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/enemy.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | / x.iter().map(|y| { [INFO] [stderr] 51 | | print!("{}\t", y); [INFO] [stderr] 52 | | }).collect::>(); [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/enemy.rs:57:36 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn count_actions(patterns: &Vec<&Vec>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[&Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/enemy.rs:70:33 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn trump_string(counts: &Vec, strat: &Fn(&ActionCount) -> Action) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[ActionCount]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/enemy_builder.rs:12:38 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn read_pattern(r: &Regex, line: &String, start: usize) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `a` is only used to index `cap`. [INFO] [stderr] --> src/enemy_builder.rs:15:18 [INFO] [stderr] | [INFO] [stderr] 15 | for a in start..cap.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 15 | for in cap.iter().skip(start) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/enemy_builder.rs:22:32 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn enemy_builder(filename: &String) -> Result, Error> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:16:27 [INFO] [stderr] | [INFO] [stderr] 16 | fn print_pattern(pattern: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Action]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:24:29 [INFO] [stderr] | [INFO] [stderr] 24 | fn print_patterns(patterns: &Vec<&Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[&Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/main.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | patterns.iter().map(|x| print_pattern(&x)).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/main.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | patterns.iter().map(|x| print_pattern(&x)).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:28:34 [INFO] [stderr] | [INFO] [stderr] 28 | fn get_counter(e: &Enemy, known: &Vec, threshold: f32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Action]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:48:12 [INFO] [stderr] | [INFO] [stderr] 48 | if tokens.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/main.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | / enemies.iter().map(|(k,_)| { [INFO] [stderr] 84 | | println!("{}", k); [INFO] [stderr] 85 | | }).collect::>(); [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/main.rs:83:17 [INFO] [stderr] | [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] 83 | / enemies.iter().map(|(k,_)| { [INFO] [stderr] 84 | | println!("{}", k); [INFO] [stderr] --> src/action.rs:44:27 [INFO] [stderr] 85 | | }).collect::>(); [INFO] [stderr] | [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] 44 | pub fn deserialize(s: &String) -> Action { [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/action_count.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match a { [INFO] [stderr] 42 | | &Action::Attack => ActionCount { attacks: 1, guards: 0, breaks: 0, specials: 0, }, [INFO] [stderr] 43 | | &Action::Guard => ActionCount { attacks: 0, guards: 1, breaks: 0, specials: 0, }, [INFO] [stderr] 44 | | &Action::Break => ActionCount { attacks: 0, guards: 0, breaks: 1, specials: 0, }, [INFO] [stderr] 45 | | &Action::Special => ActionCount { attacks: 0, guards: 0, breaks: 0, specials: 1, }, [INFO] [stderr] 46 | | _ => ActionCount { attacks: 0, guards: 0, breaks: 0, specials: 0, }, [INFO] [stderr] 47 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 41 | match *a { [INFO] [stderr] 42 | Action::Attack => ActionCount { attacks: 1, guards: 0, breaks: 0, specials: 0, }, [INFO] [stderr] 43 | Action::Guard => ActionCount { attacks: 0, guards: 1, breaks: 0, specials: 0, }, [INFO] [stderr] 44 | Action::Break => ActionCount { attacks: 0, guards: 0, breaks: 1, specials: 0, }, [INFO] [stderr] 45 | Action::Special => ActionCount { attacks: 0, guards: 0, breaks: 0, specials: 1, }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/action_count.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | / match a { [INFO] [stderr] 56 | | &Action::Attack => self.attacks, [INFO] [stderr] 57 | | &Action::Guard => self.guards, [INFO] [stderr] 58 | | &Action::Break => self.breaks, [INFO] [stderr] 59 | | &Action::Special => self.specials, [INFO] [stderr] 60 | | _ => 0, [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 55 | match *a { [INFO] [stderr] 56 | Action::Attack => self.attacks, [INFO] [stderr] 57 | Action::Guard => self.guards, [INFO] [stderr] 58 | Action::Break => self.breaks, [INFO] [stderr] 59 | Action::Special => self.specials, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/action_count.rs:107:23 [INFO] [stderr] | [INFO] [stderr] 107 | } else if f == m { [INFO] [stderr] | ^^^^^^ help: consider comparing them within some error: `(f - m).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/action_count.rs:107:23 [INFO] [stderr] | [INFO] [stderr] 107 | } else if f == m { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: Could not compile `fate_extra_solver`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/enemy.rs:41:45 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn matching_strings(&self, actions: &Vec) -> Vec<&Vec> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Action]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/enemy.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / self.action_strings.iter().map(|x| { [INFO] [stderr] 50 | | x.iter().map(|y| { [INFO] [stderr] 51 | | print!("{}\t", y); [INFO] [stderr] 52 | | }).collect::>(); [INFO] [stderr] 53 | | println!(); [INFO] [stderr] 54 | | }).collect::>(); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/enemy.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / self.action_strings.iter().map(|x| { [INFO] [stderr] 50 | | x.iter().map(|y| { [INFO] [stderr] 51 | | print!("{}\t", y); [INFO] [stderr] 52 | | }).collect::>(); [INFO] [stderr] 53 | | println!(); [INFO] [stderr] 54 | | }).collect::>(); [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/enemy.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | / x.iter().map(|y| { [INFO] [stderr] 51 | | print!("{}\t", y); [INFO] [stderr] 52 | | }).collect::>(); [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/enemy.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | / x.iter().map(|y| { [INFO] [stderr] 51 | | print!("{}\t", y); [INFO] [stderr] 52 | | }).collect::>(); [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/enemy.rs:57:36 [INFO] [stderr] | [INFO] [stderr] 57 | pub fn count_actions(patterns: &Vec<&Vec>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[&Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/enemy.rs:70:33 [INFO] [stderr] | [INFO] [stderr] 70 | pub fn trump_string(counts: &Vec, strat: &Fn(&ActionCount) -> Action) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[ActionCount]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/enemy_builder.rs:12:38 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn read_pattern(r: &Regex, line: &String, start: usize) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `a` is only used to index `cap`. [INFO] [stderr] --> src/enemy_builder.rs:15:18 [INFO] [stderr] | [INFO] [stderr] 15 | for a in start..cap.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 15 | for in cap.iter().skip(start) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/enemy_builder.rs:22:32 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn enemy_builder(filename: &String) -> Result, Error> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:16:27 [INFO] [stderr] | [INFO] [stderr] 16 | fn print_pattern(pattern: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Action]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:24:29 [INFO] [stderr] | [INFO] [stderr] 24 | fn print_patterns(patterns: &Vec<&Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[&Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/main.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | patterns.iter().map(|x| print_pattern(&x)).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/main.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | patterns.iter().map(|x| print_pattern(&x)).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:28:34 [INFO] [stderr] | [INFO] [stderr] 28 | fn get_counter(e: &Enemy, known: &Vec, threshold: f32) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Action]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:48:12 [INFO] [stderr] | [INFO] [stderr] 48 | if tokens.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/main.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | / enemies.iter().map(|(k,_)| { [INFO] [stderr] 84 | | println!("{}", k); [INFO] [stderr] 85 | | }).collect::>(); [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/main.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | / enemies.iter().map(|(k,_)| { [INFO] [stderr] 84 | | println!("{}", k); [INFO] [stderr] 85 | | }).collect::>(); [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `fate_extra_solver`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "1f0989bcc12f775a7fcd66cf771e7f78070287495014c8760ed89de8861890b8"` [INFO] running `"docker" "rm" "-f" "1f0989bcc12f775a7fcd66cf771e7f78070287495014c8760ed89de8861890b8"` [INFO] [stdout] 1f0989bcc12f775a7fcd66cf771e7f78070287495014c8760ed89de8861890b8