[INFO] updating cached repository RadicalZephyr/rust-advent-2016
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/RadicalZephyr/rust-advent-2016
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/RadicalZephyr/rust-advent-2016" "work/ex/clippy-test-run/sources/stable/gh/RadicalZephyr/rust-advent-2016"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/RadicalZephyr/rust-advent-2016'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/RadicalZephyr/rust-advent-2016" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RadicalZephyr/rust-advent-2016"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RadicalZephyr/rust-advent-2016'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 9418ec28f1aca9fb24c3348e891d2d389266797f
[INFO] sha for GitHub repo RadicalZephyr/rust-advent-2016: 9418ec28f1aca9fb24c3348e891d2d389266797f
[INFO] validating manifest of RadicalZephyr/rust-advent-2016 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of RadicalZephyr/rust-advent-2016 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing RadicalZephyr/rust-advent-2016
[INFO] finished frobbing RadicalZephyr/rust-advent-2016
[INFO] frobbed toml for RadicalZephyr/rust-advent-2016 written to work/ex/clippy-test-run/sources/stable/gh/RadicalZephyr/rust-advent-2016/Cargo.toml
[INFO] started frobbing RadicalZephyr/rust-advent-2016
[INFO] finished frobbing RadicalZephyr/rust-advent-2016
[INFO] frobbed toml for RadicalZephyr/rust-advent-2016 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RadicalZephyr/rust-advent-2016/Cargo.toml
[INFO] crate RadicalZephyr/rust-advent-2016 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting RadicalZephyr/rust-advent-2016 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/RadicalZephyr/rust-advent-2016:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d135fb2c591efde784ba9b6e36dc5d260fee205c7b0020533c07371a8c0ed1c0
[INFO] running `"docker" "start" "-a" "d135fb2c591efde784ba9b6e36dc5d260fee205c7b0020533c07371a8c0ed1c0"`
[INFO] [stderr]     Checking nom v2.0.0
[INFO] [stderr]     Checking advent-2016 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day_1/parse.rs:25:9
[INFO] [stderr]    |
[INFO] [stderr] 25 |         direction: direction,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day_1/parse.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         distance: distance,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `distance`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/day_1/navigation.rs:145:13
[INFO] [stderr]     |
[INFO] [stderr] 145 |             visited: visited,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `visited`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/day_1/navigation.rs:179:13
[INFO] [stderr]     |
[INFO] [stderr] 179 |             hq_location: hq_location,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hq_location`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day_1/mod.rs:19:13
[INFO] [stderr]    |
[INFO] [stderr] 19 |             direction: direction,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day_1/mod.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |             distance: distance,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `distance`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day_2/mod.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 |             lookup: lookup,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `lookup`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day_4/mod.rs:33:13
[INFO] [stderr]    |
[INFO] [stderr] 33 |             sector_id: sector_id,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sector_id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day_1/parse.rs:25:9
[INFO] [stderr]    |
[INFO] [stderr] 25 |         direction: direction,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day_1/parse.rs:26:9
[INFO] [stderr]    |
[INFO] [stderr] 26 |         distance: distance,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `distance`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/day_1/navigation.rs:145:13
[INFO] [stderr]     |
[INFO] [stderr] 145 |             visited: visited,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `visited`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/day_1/navigation.rs:179:13
[INFO] [stderr]     |
[INFO] [stderr] 179 |             hq_location: hq_location,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hq_location`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day_1/mod.rs:19:13
[INFO] [stderr]    |
[INFO] [stderr] 19 |             direction: direction,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day_1/mod.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |             distance: distance,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `distance`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day_2/mod.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 |             lookup: lookup,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `lookup`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/day_4/mod.rs:33:13
[INFO] [stderr]    |
[INFO] [stderr] 33 |             sector_id: sector_id,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sector_id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/day_1/navigation.rs:27:17
[INFO] [stderr]    |
[INFO] [stderr] 27 |     pub fn turn(&self, d: Direction) -> Self {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/day_1/navigation.rs:28:10
[INFO] [stderr]    |
[INFO] [stderr] 28 |         *Self::mappings().get(self).unwrap().get(&d).unwrap()
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&Self::mappings()[self]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/day_1/navigation.rs:34:20
[INFO] [stderr]    |
[INFO] [stderr] 34 |     let distance = distance as i64;
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^ help: try: `i64::from(distance)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/day_1/navigation.rs:45:20
[INFO] [stderr]    |
[INFO] [stderr] 45 |     let distance = distance as i64;
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^ help: try: `i64::from(distance)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/day_1/navigation.rs:46:26
[INFO] [stderr]    |
[INFO] [stderr] 46 |     let distance_range = (0..(distance)).into_iter();
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..(distance))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `day_1::navigation::Location`
[INFO] [stderr]   --> src/day_1/navigation.rs:79:5
[INFO] [stderr]    |
[INFO] [stderr] 79 | /     pub fn new() -> Self {
[INFO] [stderr] 80 | |         Location {
[INFO] [stderr] 81 | |             x: 0,
[INFO] [stderr] 82 | |             y: 0,
[INFO] [stderr] 83 | |             heading: Heading::North,
[INFO] [stderr] 84 | |         }
[INFO] [stderr] 85 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 78 | impl Default for day_1::navigation::Location {
[INFO] [stderr] 79 |     fn default() -> Self {
[INFO] [stderr] 80 |         Self::new()
[INFO] [stderr] 81 |     }
[INFO] [stderr] 82 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/day_1/navigation.rs:96:41
[INFO] [stderr]    |
[INFO] [stderr] 96 |     pub fn turn_for(&self, instruction: &Instruction) -> Self {
[INFO] [stderr]    |                                         ^^^^^^^^^^^^ help: consider passing by value instead: `Instruction`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/day_1/navigation.rs:100:41
[INFO] [stderr]     |
[INFO] [stderr] 100 |     pub fn walk_for(&self, instruction: &Instruction) -> Self {
[INFO] [stderr]     |                                         ^^^^^^^^^^^^ help: consider passing by value instead: `Instruction`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/day_1/navigation.rs:104:61
[INFO] [stderr]     |
[INFO] [stderr] 104 |     pub fn locations_walked_through_for(&self, instruction: &Instruction) -> Vec<Self> {
[INFO] [stderr]     |                                                             ^^^^^^^^^^^^ help: consider passing by value instead: `Instruction`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/day_1/navigation.rs:115:40
[INFO] [stderr]     |
[INFO] [stderr] 115 |     pub fn follow_instruction(self, i: &Instruction) -> Self {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^ help: consider passing by value instead: `Instruction`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day_1/navigation.rs:121:56
[INFO] [stderr]     |
[INFO] [stderr] 121 |     pub fn follow_all_instructions(self, instructions: &Vec<Instruction>) -> Self {
[INFO] [stderr]     |                                                        ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day_1/navigation.rs:125:56
[INFO] [stderr]     |
[INFO] [stderr] 125 |     pub fn first_repeated_location(self, instructions: &Vec<Instruction>) -> Option<Self> {
[INFO] [stderr]     |                                                        ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/day_1/navigation.rs:150:54
[INFO] [stderr]     |
[INFO] [stderr] 150 |     pub fn travel_along_path(&mut self, instruction: &Instruction) -> (Location, Option<Location>) {
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^ help: consider passing by value instead: `Instruction`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/day_1/navigation.rs:175:54
[INFO] [stderr]     |
[INFO] [stderr] 175 |     pub fn follow_instruction(mut self, instruction: &Instruction) -> Self {
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^ help: consider passing by value instead: `Instruction`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day_2/mod.rs:26:44
[INFO] [stderr]    |
[INFO] [stderr] 26 |     pub fn next_key(&mut self, directions: &Vec<Direction>) {
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^ help: change this to: `&[Direction]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/day_2/mod.rs:32:42
[INFO] [stderr]    |
[INFO] [stderr] 32 |     pub fn do_move(&mut self, direction: &Direction) {
[INFO] [stderr]    |                                          ^^^^^^^^^^ help: consider passing by value instead: `Direction`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/day_2/mod.rs:36:42
[INFO] [stderr]    |
[INFO] [stderr] 36 |     pub fn lookup_move(&self, direction: &Direction) -> u8 {
[INFO] [stderr]    |                                          ^^^^^^^^^^ help: consider passing by value instead: `Direction`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/day_3/mod.rs:19:30
[INFO] [stderr]    |
[INFO] [stderr] 19 |     pub fn from_block(block: ((u16, u16, u16), (u16, u16, u16), (u16, u16, u16))) -> Vec<Self> {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/day_3/mod.rs:24:18
[INFO] [stderr]    |
[INFO] [stderr] 24 |     pub fn valid(&self) -> bool {
[INFO] [stderr]    |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/day_4/mod.rs:16:27
[INFO] [stderr]    |
[INFO] [stderr] 16 |         let x = c as u8 - 'a' as u8;
[INFO] [stderr]    |                           ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'a'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/day_4/mod.rs:18:15
[INFO] [stderr]    |
[INFO] [stderr] 18 |         (x1 + 'a' as u8) as char
[INFO] [stderr]    |               ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'a'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: the `r @ _` pattern can be written as just `r`
[INFO] [stderr]   --> src/day_4/mod.rs:64:17
[INFO] [stderr]    |
[INFO] [stderr] 64 |                 r @ _ => r,
[INFO] [stderr]    |                 ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/bin/day_5.rs:50:5
[INFO] [stderr]    |
[INFO] [stderr] 50 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/day_1/navigation.rs:27:17
[INFO] [stderr]    |
[INFO] [stderr] 27 |     pub fn turn(&self, d: Direction) -> Self {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/day_1/navigation.rs:28:10
[INFO] [stderr]    |
[INFO] [stderr] 28 |         *Self::mappings().get(self).unwrap().get(&d).unwrap()
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&Self::mappings()[self]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/day_1/navigation.rs:34:20
[INFO] [stderr]    |
[INFO] [stderr] 34 |     let distance = distance as i64;
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^ help: try: `i64::from(distance)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/day_1/navigation.rs:45:20
[INFO] [stderr]    |
[INFO] [stderr] 45 |     let distance = distance as i64;
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^ help: try: `i64::from(distance)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/day_1/navigation.rs:46:26
[INFO] [stderr]    |
[INFO] [stderr] 46 |     let distance_range = (0..(distance)).into_iter();
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..(distance))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `day_1::navigation::Location`
[INFO] [stderr]   --> src/day_1/navigation.rs:79:5
[INFO] [stderr]    |
[INFO] [stderr] 79 | /     pub fn new() -> Self {
[INFO] [stderr] 80 | |         Location {
[INFO] [stderr] 81 | |             x: 0,
[INFO] [stderr] 82 | |             y: 0,
[INFO] [stderr] 83 | |             heading: Heading::North,
[INFO] [stderr] 84 | |         }
[INFO] [stderr] 85 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 78 | impl Default for day_1::navigation::Location {
[INFO] [stderr] 79 |     fn default() -> Self {
[INFO] [stderr] 80 |         Self::new()
[INFO] [stderr] 81 |     }
[INFO] [stderr] 82 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/day_1/navigation.rs:96:41
[INFO] [stderr]    |
[INFO] [stderr] 96 |     pub fn turn_for(&self, instruction: &Instruction) -> Self {
[INFO] [stderr]    |                                         ^^^^^^^^^^^^ help: consider passing by value instead: `Instruction`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/day_1/navigation.rs:100:41
[INFO] [stderr]     |
[INFO] [stderr] 100 |     pub fn walk_for(&self, instruction: &Instruction) -> Self {
[INFO] [stderr]     |                                         ^^^^^^^^^^^^ help: consider passing by value instead: `Instruction`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/bin/day_2.rs:32:5
[INFO] [stderr]    |
[INFO] [stderr] 32 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/bin/day_2.rs:41:5
[INFO] [stderr]    |
[INFO] [stderr] 41 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/day_1/navigation.rs:104:61
[INFO] [stderr]     |
[INFO] [stderr] 104 |     pub fn locations_walked_through_for(&self, instruction: &Instruction) -> Vec<Self> {
[INFO] [stderr]     |                                                             ^^^^^^^^^^^^ help: consider passing by value instead: `Instruction`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/day_1/navigation.rs:115:40
[INFO] [stderr]     |
[INFO] [stderr] 115 |     pub fn follow_instruction(self, i: &Instruction) -> Self {
[INFO] [stderr]     |                                        ^^^^^^^^^^^^ help: consider passing by value instead: `Instruction`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day_1/navigation.rs:121:56
[INFO] [stderr]     |
[INFO] [stderr] 121 |     pub fn follow_all_instructions(self, instructions: &Vec<Instruction>) -> Self {
[INFO] [stderr]     |                                                        ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/day_1/navigation.rs:125:56
[INFO] [stderr]     |
[INFO] [stderr] 125 |     pub fn first_repeated_location(self, instructions: &Vec<Instruction>) -> Option<Self> {
[INFO] [stderr]     |                                                        ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/day_1/navigation.rs:150:54
[INFO] [stderr]     |
[INFO] [stderr] 150 |     pub fn travel_along_path(&mut self, instruction: &Instruction) -> (Location, Option<Location>) {
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^ help: consider passing by value instead: `Instruction`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/day_1/navigation.rs:175:54
[INFO] [stderr]     |
[INFO] [stderr] 175 |     pub fn follow_instruction(mut self, instruction: &Instruction) -> Self {
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^ help: consider passing by value instead: `Instruction`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/bin/day_2.rs:32:5
[INFO] [stderr]    |
[INFO] [stderr] 32 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/bin/day_2.rs:41:5
[INFO] [stderr]    |
[INFO] [stderr] 41 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/day_2/mod.rs:26:44
[INFO] [stderr]    |
[INFO] [stderr] 26 |     pub fn next_key(&mut self, directions: &Vec<Direction>) {
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^ help: change this to: `&[Direction]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/day_2/mod.rs:32:42
[INFO] [stderr]    |
[INFO] [stderr] 32 |     pub fn do_move(&mut self, direction: &Direction) {
[INFO] [stderr]    |                                          ^^^^^^^^^^ help: consider passing by value instead: `Direction`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/day_2/mod.rs:36:42
[INFO] [stderr]    |
[INFO] [stderr] 36 |     pub fn lookup_move(&self, direction: &Direction) -> u8 {
[INFO] [stderr]    |                                          ^^^^^^^^^^ help: consider passing by value instead: `Direction`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/day_3/mod.rs:19:30
[INFO] [stderr]    |
[INFO] [stderr] 19 |     pub fn from_block(block: ((u16, u16, u16), (u16, u16, u16), (u16, u16, u16))) -> Vec<Self> {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/day_3/mod.rs:24:18
[INFO] [stderr]    |
[INFO] [stderr] 24 |     pub fn valid(&self) -> bool {
[INFO] [stderr]    |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/day_4/mod.rs:16:27
[INFO] [stderr]    |
[INFO] [stderr] 16 |         let x = c as u8 - 'a' as u8;
[INFO] [stderr]    |                           ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'a'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]   --> src/day_4/mod.rs:18:15
[INFO] [stderr]    |
[INFO] [stderr] 18 |         (x1 + 'a' as u8) as char
[INFO] [stderr]    |               ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Consider using a byte literal instead:
[INFO] [stderr]            b'a'
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: the `r @ _` pattern can be written as just `r`
[INFO] [stderr]   --> src/day_4/mod.rs:64:17
[INFO] [stderr]    |
[INFO] [stderr] 64 |                 r @ _ => r,
[INFO] [stderr]    |                 ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/bin/day_4.rs:25:18
[INFO] [stderr]    |
[INFO] [stderr] 25 | fn part_1(rooms: &Vec<Room>) {
[INFO] [stderr]    |                  ^^^^^^^^^^ help: change this to: `&[Room]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/bin/day_4.rs:28:33
[INFO] [stderr]    |
[INFO] [stderr] 28 |         .fold(0, |sum, r| sum + r.sector_id as u64);
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(r.sector_id)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/bin/day_4.rs:32:18
[INFO] [stderr]    |
[INFO] [stderr] 32 | fn part_2(rooms: &Vec<Room>) {
[INFO] [stderr]    |                  ^^^^^^^^^^ help: change this to: `&[Room]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/bin/day_1.rs:26:25
[INFO] [stderr]    |
[INFO] [stderr] 26 | fn part_1(instructions: &Vec<Instruction>) {
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]`
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/bin/day_2.rs:26:30
[INFO] [stderr]    |
[INFO] [stderr] 26 | fn part_1(instructions_list: &Vec<Vec<Direction>>) {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<Direction>]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/bin/day_2.rs:35:30
[INFO] [stderr]    |
[INFO] [stderr] 35 | fn part_2(instructions_list: &Vec<Vec<Direction>>) {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<Direction>]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/bin/day_1.rs:31:25
[INFO] [stderr]    |
[INFO] [stderr] 31 | fn part_2(instructions: &Vec<Instruction>) {
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/bin/day_5.rs:50:5
[INFO] [stderr]    |
[INFO] [stderr] 50 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/bin/day_2.rs:26:30
[INFO] [stderr]    |
[INFO] [stderr] 26 | fn part_1(instructions_list: &Vec<Vec<Direction>>) {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<Direction>]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/bin/day_2.rs:35:30
[INFO] [stderr]    |
[INFO] [stderr] 35 | fn part_2(instructions_list: &Vec<Vec<Direction>>) {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec<Direction>]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/bin/day_5.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/bin/day_5.rs:28:26
[INFO] [stderr]    |
[INFO] [stderr] 28 |         let first_five = output[0] as i32 + output[1] as i32 + (output[2] >> 4) as i32;
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^ help: try: `i32::from(output[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/bin/day_5.rs:28:45
[INFO] [stderr]    |
[INFO] [stderr] 28 |         let first_five = output[0] as i32 + output[1] as i32 + (output[2] >> 4) as i32;
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^ help: try: `i32::from(output[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/bin/day_5.rs:28:64
[INFO] [stderr]    |
[INFO] [stderr] 28 |         let first_five = output[0] as i32 + output[1] as i32 + (output[2] >> 4) as i32;
[INFO] [stderr]    |                                                                ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(output[2] >> 4)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/bin/day_5.rs:40:21
[INFO] [stderr]    |
[INFO] [stderr] 40 |                     found_code_position = found_code_position | nth_bit;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `found_code_position |= nth_bit`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/bin/day_1.rs:26:25
[INFO] [stderr]    |
[INFO] [stderr] 26 | fn part_1(instructions: &Vec<Instruction>) {
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/bin/day_1.rs:31:25
[INFO] [stderr]    |
[INFO] [stderr] 31 | fn part_2(instructions: &Vec<Instruction>) {
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^ help: change this to: `&[Instruction]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/bin/day_5.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/bin/day_4.rs:25:18
[INFO] [stderr]    |
[INFO] [stderr] 25 | fn part_1(rooms: &Vec<Room>) {
[INFO] [stderr]    |                  ^^^^^^^^^^ help: change this to: `&[Room]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/bin/day_4.rs:28:33
[INFO] [stderr]    |
[INFO] [stderr] 28 |         .fold(0, |sum, r| sum + r.sector_id as u64);
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(r.sector_id)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/bin/day_4.rs:32:18
[INFO] [stderr]    |
[INFO] [stderr] 32 | fn part_2(rooms: &Vec<Room>) {
[INFO] [stderr]    |                  ^^^^^^^^^^ help: change this to: `&[Room]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/bin/day_5.rs:28:26
[INFO] [stderr]    |
[INFO] [stderr] 28 |         let first_five = output[0] as i32 + output[1] as i32 + (output[2] >> 4) as i32;
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^ help: try: `i32::from(output[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/bin/day_5.rs:28:45
[INFO] [stderr]    |
[INFO] [stderr] 28 |         let first_five = output[0] as i32 + output[1] as i32 + (output[2] >> 4) as i32;
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^ help: try: `i32::from(output[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/bin/day_5.rs:28:64
[INFO] [stderr]    |
[INFO] [stderr] 28 |         let first_five = output[0] as i32 + output[1] as i32 + (output[2] >> 4) as i32;
[INFO] [stderr]    |                                                                ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(output[2] >> 4)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/bin/day_5.rs:40:21
[INFO] [stderr]    |
[INFO] [stderr] 40 |                     found_code_position = found_code_position | nth_bit;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `found_code_position |= nth_bit`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 5.75s
[INFO] running `"docker" "inspect" "d135fb2c591efde784ba9b6e36dc5d260fee205c7b0020533c07371a8c0ed1c0"`
[INFO] running `"docker" "rm" "-f" "d135fb2c591efde784ba9b6e36dc5d260fee205c7b0020533c07371a8c0ed1c0"`
[INFO] [stdout] d135fb2c591efde784ba9b6e36dc5d260fee205c7b0020533c07371a8c0ed1c0