[INFO] updating cached repository RadicalZephyr/hyper-explicit-setup-ex [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/RadicalZephyr/hyper-explicit-setup-ex [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/RadicalZephyr/hyper-explicit-setup-ex" "work/ex/clippy-test-run/sources/stable/gh/RadicalZephyr/hyper-explicit-setup-ex"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/RadicalZephyr/hyper-explicit-setup-ex'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/RadicalZephyr/hyper-explicit-setup-ex" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RadicalZephyr/hyper-explicit-setup-ex"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RadicalZephyr/hyper-explicit-setup-ex'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 056408e705f89143f32c8b2175918d2df2eb34bd [INFO] sha for GitHub repo RadicalZephyr/hyper-explicit-setup-ex: 056408e705f89143f32c8b2175918d2df2eb34bd [INFO] validating manifest of RadicalZephyr/hyper-explicit-setup-ex on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of RadicalZephyr/hyper-explicit-setup-ex on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing RadicalZephyr/hyper-explicit-setup-ex [INFO] finished frobbing RadicalZephyr/hyper-explicit-setup-ex [INFO] frobbed toml for RadicalZephyr/hyper-explicit-setup-ex written to work/ex/clippy-test-run/sources/stable/gh/RadicalZephyr/hyper-explicit-setup-ex/Cargo.toml [INFO] started frobbing RadicalZephyr/hyper-explicit-setup-ex [INFO] finished frobbing RadicalZephyr/hyper-explicit-setup-ex [INFO] frobbed toml for RadicalZephyr/hyper-explicit-setup-ex written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RadicalZephyr/hyper-explicit-setup-ex/Cargo.toml [INFO] crate RadicalZephyr/hyper-explicit-setup-ex has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting RadicalZephyr/hyper-explicit-setup-ex against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/RadicalZephyr/hyper-explicit-setup-ex:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 879671fd7067ac48e299a23878ace5cdba58f12fdd2868d7b4f8d9153f5501d9 [INFO] running `"docker" "start" "-a" "879671fd7067ac48e299a23878ace5cdba58f12fdd2868d7b4f8d9153f5501d9"` [INFO] [stderr] Checking simple_logger v0.5.0 [INFO] [stderr] Checking tokio-current-thread v0.1.0 [INFO] [stderr] Checking hyper-explicit v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | serve_all [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | let serve_all = serve.for_each(move |connecting| { [INFO] [stderr] | _____________________^ [INFO] [stderr] 51 | | trace!("spawning connection future onto the current thread"); [INFO] [stderr] 52 | | trace!("got a {:?}", connecting); [INFO] [stderr] 53 | | current_thread::spawn(connecting [INFO] [stderr] ... | [INFO] [stderr] 59 | | Ok(()) [INFO] [stderr] 60 | | }).map_err(|e| { error!("serve_all: {:?}", e); () }); [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:54:81 [INFO] [stderr] | [INFO] [stderr] 54 | .map_err(|e| { error!("serve.for_each: {:?}", e); () }) [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:60:52 [INFO] [stderr] | [INFO] [stderr] 60 | }).map_err(|e| { error!("serve_all: {:?}", e); () }); [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | serve_all [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | let serve_all = serve.for_each(move |connecting| { [INFO] [stderr] | _____________________^ [INFO] [stderr] 51 | | trace!("spawning connection future onto the current thread"); [INFO] [stderr] 52 | | trace!("got a {:?}", connecting); [INFO] [stderr] 53 | | current_thread::spawn(connecting [INFO] [stderr] ... | [INFO] [stderr] 59 | | Ok(()) [INFO] [stderr] 60 | | }).map_err(|e| { error!("serve_all: {:?}", e); () }); [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:54:81 [INFO] [stderr] | [INFO] [stderr] 54 | .map_err(|e| { error!("serve.for_each: {:?}", e); () }) [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:60:52 [INFO] [stderr] | [INFO] [stderr] 60 | }).map_err(|e| { error!("serve_all: {:?}", e); () }); [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.01s [INFO] running `"docker" "inspect" "879671fd7067ac48e299a23878ace5cdba58f12fdd2868d7b4f8d9153f5501d9"` [INFO] running `"docker" "rm" "-f" "879671fd7067ac48e299a23878ace5cdba58f12fdd2868d7b4f8d9153f5501d9"` [INFO] [stdout] 879671fd7067ac48e299a23878ace5cdba58f12fdd2868d7b4f8d9153f5501d9