[INFO] updating cached repository RPGLibrarium/Liberation [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/RPGLibrarium/Liberation [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/RPGLibrarium/Liberation" "work/ex/clippy-test-run/sources/stable/gh/RPGLibrarium/Liberation"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/RPGLibrarium/Liberation'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/RPGLibrarium/Liberation" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RPGLibrarium/Liberation"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RPGLibrarium/Liberation'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d0b23854cc7543812efbee0ae538c63e21e84890 [INFO] sha for GitHub repo RPGLibrarium/Liberation: d0b23854cc7543812efbee0ae538c63e21e84890 [INFO] validating manifest of RPGLibrarium/Liberation on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of RPGLibrarium/Liberation on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing RPGLibrarium/Liberation [INFO] finished frobbing RPGLibrarium/Liberation [INFO] frobbed toml for RPGLibrarium/Liberation written to work/ex/clippy-test-run/sources/stable/gh/RPGLibrarium/Liberation/Cargo.toml [INFO] started frobbing RPGLibrarium/Liberation [INFO] finished frobbing RPGLibrarium/Liberation [INFO] frobbed toml for RPGLibrarium/Liberation written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/RPGLibrarium/Liberation/Cargo.toml [INFO] crate RPGLibrarium/Liberation has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting RPGLibrarium/Liberation against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/RPGLibrarium/Liberation:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4a1ad0a18ec5d3627ce20ca2479229c8084ea749042b648d509e2338e30c6efc [INFO] running `"docker" "start" "-a" "4a1ad0a18ec5d3627ce20ca2479229c8084ea749042b648d509e2338e30c6efc"` [INFO] [stderr] Checking rust-ini v0.12.2 [INFO] [stderr] Checking url_serde v0.2.0 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking serde-hjson v0.8.2 [INFO] [stderr] Checking tokio-threadpool v0.1.9 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking oauth2 v2.0.0-alpha.2 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking config v0.9.1 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking mysql_common v0.9.2 [INFO] [stderr] Checking jsonwebtoken v5.0.1 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-signal v0.2.7 [INFO] [stderr] Checking trust-dns-proto v0.5.0 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking mysql v14.1.1 [INFO] [stderr] Checking trust-dns-resolver v0.10.0 [INFO] [stderr] Checking actix v0.7.7 [INFO] [stderr] Checking actix-net v0.2.4 [INFO] [stderr] Checking actix-web v0.7.14 [INFO] [stderr] Checking liberation v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/dto.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | system: system, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `system` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/auth.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | cache: cache, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cache` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/business/mod.rs:178:21 [INFO] [stderr] | [INFO] [stderr] 178 | available: available, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `available` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/book.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/book.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/book.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | owner_type: owner_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `owner_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/book.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | owner: owner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `owner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/book.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | quality: quality, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `quality` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/guild.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/guild.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/guild.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | address: address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/guild.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | contact: contact, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `contact` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/guild.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/guild.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/guild.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | address: address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/guild.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | contact: contact [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `contact` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/guild.rs:79:29 [INFO] [stderr] | [INFO] [stderr] 79 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/guild.rs:80:29 [INFO] [stderr] | [INFO] [stderr] 80 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/guild.rs:81:29 [INFO] [stderr] | [INFO] [stderr] 81 | address: address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/guild.rs:82:29 [INFO] [stderr] | [INFO] [stderr] 82 | contact: contact, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `contact` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/member.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/member.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | external_id: external_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `external_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/member.rs:55:29 [INFO] [stderr] | [INFO] [stderr] 55 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/member.rs:56:29 [INFO] [stderr] | [INFO] [stderr] 56 | external_id: external_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `external_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/member.rs:73:29 [INFO] [stderr] | [INFO] [stderr] 73 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/member.rs:74:29 [INFO] [stderr] | [INFO] [stderr] 74 | external_id: external_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `external_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rental.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rental.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | from: from, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rental.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | to: to, [INFO] [stderr] | ^^^^^^ help: replace it with: `to` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rental.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | book: book, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `book` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rental.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | rentee: rentee, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `rentee` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rental.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | rentee_type: rentee_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rentee_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rpgsystem.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rpgsystem.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rpgsystem.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | shortname: shortname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shortname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rpgsystem.rs:60:29 [INFO] [stderr] | [INFO] [stderr] 60 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rpgsystem.rs:61:29 [INFO] [stderr] | [INFO] [stderr] 61 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rpgsystem.rs:82:37 [INFO] [stderr] | [INFO] [stderr] 82 | RpgSystem { id: id, name: name, shortname: short } [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rpgsystem.rs:82:45 [INFO] [stderr] | [INFO] [stderr] 82 | RpgSystem { id: id, name: name, shortname: short } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | system: system, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `system` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | language: language, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `language` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | publisher: publisher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `publisher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | year: year, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | coverimage: coverimage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coverimage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | system: system, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `system` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | language: language, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `language` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | publisher: publisher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `publisher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | year: year, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | coverimage: coverimage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coverimage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:82:21 [INFO] [stderr] | [INFO] [stderr] 82 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:83:21 [INFO] [stderr] | [INFO] [stderr] 83 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:84:21 [INFO] [stderr] | [INFO] [stderr] 84 | system: system, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `system` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | language: language, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `language` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | publisher: publisher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `publisher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | year: year, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | coverimage: coverimage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coverimage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:104:30 [INFO] [stderr] | [INFO] [stderr] 104 | return Ok(Database { pool: pool }); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:146:21 [INFO] [stderr] | [INFO] [stderr] 146 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:147:21 [INFO] [stderr] | [INFO] [stderr] 147 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:148:21 [INFO] [stderr] | [INFO] [stderr] 148 | system: system, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `system` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:149:21 [INFO] [stderr] | [INFO] [stderr] 149 | language: language, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `language` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:150:21 [INFO] [stderr] | [INFO] [stderr] 150 | publisher: publisher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `publisher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:151:21 [INFO] [stderr] | [INFO] [stderr] 151 | year: year, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:152:21 [INFO] [stderr] | [INFO] [stderr] 152 | coverimage: coverimage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coverimage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:175:29 [INFO] [stderr] | [INFO] [stderr] 175 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:176:29 [INFO] [stderr] | [INFO] [stderr] 176 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:178:29 [INFO] [stderr] | [INFO] [stderr] 178 | language: language, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `language` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:179:29 [INFO] [stderr] | [INFO] [stderr] 179 | publisher: publisher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `publisher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:180:29 [INFO] [stderr] | [INFO] [stderr] 180 | year: year, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:181:29 [INFO] [stderr] | [INFO] [stderr] 181 | coverimage: coverimage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coverimage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:218:33 [INFO] [stderr] | [INFO] [stderr] 218 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:219:33 [INFO] [stderr] | [INFO] [stderr] 219 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:221:33 [INFO] [stderr] | [INFO] [stderr] 221 | language: language, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `language` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:222:33 [INFO] [stderr] | [INFO] [stderr] 222 | publisher: publisher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `publisher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:223:33 [INFO] [stderr] | [INFO] [stderr] 223 | year: year, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:224:33 [INFO] [stderr] | [INFO] [stderr] 224 | coverimage: coverimage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coverimage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:275:29 [INFO] [stderr] | [INFO] [stderr] 275 | quality: quality, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `quality` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | db: db, [INFO] [stderr] | ^^^^^^ help: replace it with: `db` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/api/dto.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | system: system, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `system` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/auth.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | cache: cache, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cache` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/business/mod.rs:178:21 [INFO] [stderr] | [INFO] [stderr] 178 | available: available, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `available` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/book.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/book.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | title: title, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/book.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | owner_type: owner_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `owner_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/book.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | owner: owner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `owner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/book.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | quality: quality, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `quality` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/guild.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/guild.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/guild.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | address: address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/guild.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | contact: contact, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `contact` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/guild.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/guild.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/guild.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | address: address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/guild.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | contact: contact [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `contact` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/guild.rs:79:29 [INFO] [stderr] | [INFO] [stderr] 79 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/guild.rs:80:29 [INFO] [stderr] | [INFO] [stderr] 80 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/guild.rs:81:29 [INFO] [stderr] | [INFO] [stderr] 81 | address: address, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/guild.rs:82:29 [INFO] [stderr] | [INFO] [stderr] 82 | contact: contact, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `contact` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/member.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/member.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | external_id: external_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `external_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/member.rs:55:29 [INFO] [stderr] | [INFO] [stderr] 55 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/member.rs:56:29 [INFO] [stderr] | [INFO] [stderr] 56 | external_id: external_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `external_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/member.rs:73:29 [INFO] [stderr] | [INFO] [stderr] 73 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/member.rs:74:29 [INFO] [stderr] | [INFO] [stderr] 74 | external_id: external_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `external_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rental.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rental.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | from: from, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rental.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | to: to, [INFO] [stderr] | ^^^^^^ help: replace it with: `to` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rental.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | book: book, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `book` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rental.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | rentee: rentee, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `rentee` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rental.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | rentee_type: rentee_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rentee_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rpgsystem.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rpgsystem.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rpgsystem.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | shortname: shortname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shortname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rpgsystem.rs:60:29 [INFO] [stderr] | [INFO] [stderr] 60 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rpgsystem.rs:61:29 [INFO] [stderr] | [INFO] [stderr] 61 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rpgsystem.rs:82:37 [INFO] [stderr] | [INFO] [stderr] 82 | RpgSystem { id: id, name: name, shortname: short } [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/rpgsystem.rs:82:45 [INFO] [stderr] | [INFO] [stderr] 82 | RpgSystem { id: id, name: name, shortname: short } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | system: system, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `system` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | language: language, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `language` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | publisher: publisher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `publisher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | year: year, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | coverimage: coverimage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coverimage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | system: system, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `system` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:60:17 [INFO] [stderr] | [INFO] [stderr] 60 | language: language, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `language` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:61:17 [INFO] [stderr] | [INFO] [stderr] 61 | publisher: publisher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `publisher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | year: year, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | coverimage: coverimage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coverimage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:82:21 [INFO] [stderr] | [INFO] [stderr] 82 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:83:21 [INFO] [stderr] | [INFO] [stderr] 83 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:84:21 [INFO] [stderr] | [INFO] [stderr] 84 | system: system, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `system` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | language: language, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `language` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | publisher: publisher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `publisher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | year: year, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/title.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | coverimage: coverimage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coverimage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:104:30 [INFO] [stderr] | [INFO] [stderr] 104 | return Ok(Database { pool: pool }); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:146:21 [INFO] [stderr] | [INFO] [stderr] 146 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:147:21 [INFO] [stderr] | [INFO] [stderr] 147 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:148:21 [INFO] [stderr] | [INFO] [stderr] 148 | system: system, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `system` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:149:21 [INFO] [stderr] | [INFO] [stderr] 149 | language: language, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `language` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:150:21 [INFO] [stderr] | [INFO] [stderr] 150 | publisher: publisher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `publisher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:151:21 [INFO] [stderr] | [INFO] [stderr] 151 | year: year, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:152:21 [INFO] [stderr] | [INFO] [stderr] 152 | coverimage: coverimage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coverimage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:175:29 [INFO] [stderr] | [INFO] [stderr] 175 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:176:29 [INFO] [stderr] | [INFO] [stderr] 176 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:178:29 [INFO] [stderr] | [INFO] [stderr] 178 | language: language, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `language` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:179:29 [INFO] [stderr] | [INFO] [stderr] 179 | publisher: publisher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `publisher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:180:29 [INFO] [stderr] | [INFO] [stderr] 180 | year: year, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:181:29 [INFO] [stderr] | [INFO] [stderr] 181 | coverimage: coverimage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coverimage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:218:33 [INFO] [stderr] | [INFO] [stderr] 218 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:219:33 [INFO] [stderr] | [INFO] [stderr] 219 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:221:33 [INFO] [stderr] | [INFO] [stderr] 221 | language: language, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `language` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:222:33 [INFO] [stderr] | [INFO] [stderr] 222 | publisher: publisher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `publisher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:223:33 [INFO] [stderr] | [INFO] [stderr] 223 | year: year, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:224:33 [INFO] [stderr] | [INFO] [stderr] 224 | coverimage: coverimage, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coverimage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database/mod.rs:275:29 [INFO] [stderr] | [INFO] [stderr] 275 | quality: quality, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `quality` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | db: db, [INFO] [stderr] | ^^^^^^ help: replace it with: `db` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api/dto.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / return GetRpgSystem { [INFO] [stderr] 26 | | rpgsystem: RpgSystemWithTitles { [INFO] [stderr] 27 | | id: rpg_system.id.expect("RpgSystem must contain an Id"), [INFO] [stderr] 28 | | name: rpg_system.name, [INFO] [stderr] 29 | | titles, [INFO] [stderr] 30 | | }, [INFO] [stderr] 31 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 25 | GetRpgSystem { [INFO] [stderr] 26 | rpgsystem: RpgSystemWithTitles { [INFO] [stderr] 27 | id: rpg_system.id.expect("RpgSystem must contain an Id"), [INFO] [stderr] 28 | name: rpg_system.name, [INFO] [stderr] 29 | titles, [INFO] [stderr] 30 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused import: `actix_web::error::Error as ActixError` [INFO] [stderr] --> src/api/mod.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use actix_web::error::Error as ActixError; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `actix_web::error::InternalError` [INFO] [stderr] --> src/api/mod.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use actix_web::error::InternalError; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `core::num::ParseIntError` [INFO] [stderr] --> src/api/mod.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | use core::num::ParseIntError; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api/mod.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / return bus::get_rpgsystems(&_req.state().db, &_req.state().kc) [INFO] [stderr] 96 | | .and_then(|systems| Ok(Json(systems))); [INFO] [stderr] | |_______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 95 | bus::get_rpgsystems(&_req.state().db, &_req.state().kc) [INFO] [stderr] 96 | .and_then(|systems| Ok(Json(systems))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api/mod.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | return Ok(obj); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(obj)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/auth.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | return (*pk).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(*pk).clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/auth.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | return kc; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `kc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/business/mod.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | return Ok(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/business/mod.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/business/mod.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/business/mod.rs:149:25 [INFO] [stderr] | [INFO] [stderr] 149 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/business/mod.rs:163:17 [INFO] [stderr] | [INFO] [stderr] 163 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/book.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / return Book { [INFO] [stderr] 31 | | id: id, [INFO] [stderr] 32 | | title: title, [INFO] [stderr] 33 | | owner_type: owner_type, [INFO] [stderr] 34 | | owner: owner, [INFO] [stderr] 35 | | quality: quality, [INFO] [stderr] 36 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 30 | Book { [INFO] [stderr] 31 | id: id, [INFO] [stderr] 32 | title: title, [INFO] [stderr] 33 | owner_type: owner_type, [INFO] [stderr] 34 | owner: owner, [INFO] [stderr] 35 | quality: quality, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/book.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | return Ok(results.pop()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(results.pop())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/entity.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | return EntityType::from_str(s.as_str()).map_err(de::Error::custom); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `EntityType::from_str(s.as_str()).map_err(de::Error::custom)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/guild.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | return Ok(results.pop()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(results.pop())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/member.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return Ok(results.pop()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(results.pop())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/rental.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / return Rental { [INFO] [stderr] 37 | | id: id, [INFO] [stderr] 38 | | from: from, [INFO] [stderr] 39 | | to: to, [INFO] [stderr] ... | [INFO] [stderr] 42 | | rentee_type: rentee_type, [INFO] [stderr] 43 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 36 | Rental { [INFO] [stderr] 37 | id: id, [INFO] [stderr] 38 | from: from, [INFO] [stderr] 39 | to: to, [INFO] [stderr] 40 | book: book, [INFO] [stderr] 41 | rentee: rentee, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/rental.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | return Ok(results.pop()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(results.pop())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/rpgsystem.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | return Ok(results.pop()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(results.pop())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/title.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | return Ok(results.pop()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(results.pop())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/mod.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | return Ok(Database { pool: pool }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Database { pool: pool })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/mod.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | return results; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/mod.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/mod.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | return Ok(result.pop()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result.pop())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/mod.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | return Ok(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/mod.rs:248:9 [INFO] [stderr] | [INFO] [stderr] 248 | / return self.pool [INFO] [stderr] 249 | | .prep_exec( [INFO] [stderr] 250 | | "select [INFO] [stderr] 251 | | books.book_id, books.owner_type, books.quality, books.title_by_id, \ [INFO] [stderr] ... | [INFO] [stderr] 287 | | }).collect::, bool)>>() [INFO] [stderr] 288 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 248 | self.pool [INFO] [stderr] 249 | .prep_exec( [INFO] [stderr] 250 | "select [INFO] [stderr] 251 | books.book_id, books.owner_type, books.quality, books.title_by_id, \ [INFO] [stderr] 252 | if(books.owner_type = 'member', o_members.member_id, o_guilds.guild_id) as owner_id, \ [INFO] [stderr] 253 | rentals.rental_id, rentals.from_date, rentals.to_date, rentals.rentee_type, \ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/serde_formats.rs:4:25 [INFO] [stderr] | [INFO] [stderr] 4 | const DATE_FORMAT: &'static str = "%Y-%m-%d"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'database::Role': this is a stub for later oauth roles [INFO] [stderr] --> src/api/dto.rs:284:20 [INFO] [stderr] | [INFO] [stderr] 284 | pub roles: Vec, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'database::Role': this is a stub for later oauth roles [INFO] [stderr] --> src/database/mod.rs:313:12 [INFO] [stderr] | [INFO] [stderr] 313 | pub struct Role { [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'database::Role': this is a stub for later oauth roles [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api/dto.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / return GetRpgSystem { [INFO] [stderr] 26 | | rpgsystem: RpgSystemWithTitles { [INFO] [stderr] 27 | | id: rpg_system.id.expect("RpgSystem must contain an Id"), [INFO] [stderr] 28 | | name: rpg_system.name, [INFO] [stderr] 29 | | titles, [INFO] [stderr] 30 | | }, [INFO] [stderr] 31 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 25 | GetRpgSystem { [INFO] [stderr] 26 | rpgsystem: RpgSystemWithTitles { [INFO] [stderr] 27 | id: rpg_system.id.expect("RpgSystem must contain an Id"), [INFO] [stderr] 28 | name: rpg_system.name, [INFO] [stderr] 29 | titles, [INFO] [stderr] 30 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused import: `actix_web::error::Error as ActixError` [INFO] [stderr] --> src/api/mod.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use actix_web::error::Error as ActixError; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `actix_web::error::InternalError` [INFO] [stderr] --> src/api/mod.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use actix_web::error::InternalError; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `core::num::ParseIntError` [INFO] [stderr] --> src/api/mod.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | use core::num::ParseIntError; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api/mod.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / return bus::get_rpgsystems(&_req.state().db, &_req.state().kc) [INFO] [stderr] 96 | | .and_then(|systems| Ok(Json(systems))); [INFO] [stderr] | |_______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 95 | bus::get_rpgsystems(&_req.state().db, &_req.state().kc) [INFO] [stderr] 96 | .and_then(|systems| Ok(Json(systems))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api/mod.rs:140:13 [INFO] [stderr] | [INFO] [stderr] 140 | return Ok(obj); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(obj)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/auth.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | return (*pk).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(*pk).clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/auth.rs:165:9 [INFO] [stderr] | [INFO] [stderr] 165 | return kc; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `kc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/business/mod.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | return Ok(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/business/mod.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/business/mod.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/business/mod.rs:149:25 [INFO] [stderr] | [INFO] [stderr] 149 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/business/mod.rs:163:17 [INFO] [stderr] | [INFO] [stderr] 163 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/book.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / return Book { [INFO] [stderr] 31 | | id: id, [INFO] [stderr] 32 | | title: title, [INFO] [stderr] 33 | | owner_type: owner_type, [INFO] [stderr] 34 | | owner: owner, [INFO] [stderr] 35 | | quality: quality, [INFO] [stderr] 36 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 30 | Book { [INFO] [stderr] 31 | id: id, [INFO] [stderr] 32 | title: title, [INFO] [stderr] 33 | owner_type: owner_type, [INFO] [stderr] 34 | owner: owner, [INFO] [stderr] 35 | quality: quality, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/book.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | return Ok(results.pop()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(results.pop())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/database/book.rs:183:17 [INFO] [stderr] | [INFO] [stderr] 183 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/database/book.rs:239:21 [INFO] [stderr] | [INFO] [stderr] 239 | 01248163264, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 239 | 1248163264, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 239 | 0o1248163264, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/database/book.rs:239:21 [INFO] [stderr] | [INFO] [stderr] 239 | 01248163264, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `01_248_163_264` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/database/book.rs:272:21 [INFO] [stderr] | [INFO] [stderr] 272 | 012481632, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 272 | 12481632, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 272 | 0o12481632, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/database/book.rs:272:21 [INFO] [stderr] | [INFO] [stderr] 272 | 012481632, [INFO] [stderr] | ^^^^^^^^^ help: consider: `012_481_632` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/database/book.rs:305:21 [INFO] [stderr] | [INFO] [stderr] 305 | 012481632, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 305 | 12481632, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 305 | 0o12481632, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/database/book.rs:305:21 [INFO] [stderr] | [INFO] [stderr] 305 | 012481632, [INFO] [stderr] | ^^^^^^^^^ help: consider: `012_481_632` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/database/book.rs:370:17 [INFO] [stderr] | [INFO] [stderr] 370 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/database/book.rs:382:24 [INFO] [stderr] | [INFO] [stderr] 382 | title: 012481642, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 382 | title: 12481642, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 382 | title: 0o12481642, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/database/book.rs:382:24 [INFO] [stderr] | [INFO] [stderr] 382 | title: 012481642, [INFO] [stderr] | ^^^^^^^^^ help: consider: `012_481_642` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/database/book.rs:401:24 [INFO] [stderr] | [INFO] [stderr] 401 | owner: 012481642, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 401 | owner: 12481642, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 401 | owner: 0o12481642, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/database/book.rs:401:24 [INFO] [stderr] | [INFO] [stderr] 401 | owner: 012481642, [INFO] [stderr] | ^^^^^^^^^ help: consider: `012_481_642` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/entity.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | return EntityType::from_str(s.as_str()).map_err(de::Error::custom); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `EntityType::from_str(s.as_str()).map_err(de::Error::custom)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/guild.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | return Ok(results.pop()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(results.pop())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/database/guild.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/database/guild.rs:217:17 [INFO] [stderr] | [INFO] [stderr] 217 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/member.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return Ok(results.pop()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(results.pop())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/database/member.rs:177:17 [INFO] [stderr] | [INFO] [stderr] 177 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/member.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | return db.update(&member_in); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `db.update(&member_in)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/rental.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / return Rental { [INFO] [stderr] 37 | | id: id, [INFO] [stderr] 38 | | from: from, [INFO] [stderr] 39 | | to: to, [INFO] [stderr] ... | [INFO] [stderr] 42 | | rentee_type: rentee_type, [INFO] [stderr] 43 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 36 | Rental { [INFO] [stderr] 37 | id: id, [INFO] [stderr] 38 | from: from, [INFO] [stderr] 39 | to: to, [INFO] [stderr] 40 | book: book, [INFO] [stderr] 41 | rentee: rentee, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/rental.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | return Ok(results.pop()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(results.pop())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/database/rental.rs:213:17 [INFO] [stderr] | [INFO] [stderr] 213 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/database/rental.rs:226:30 [INFO] [stderr] | [INFO] [stderr] 226 | _d(3264, 12, 08), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 226 | _d(3264, 12, 8), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 226 | _d(3264, 12, 0o8), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/database/rental.rs:227:17 [INFO] [stderr] | [INFO] [stderr] 227 | 1235415123, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_235_415_123` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/database/rental.rs:247:30 [INFO] [stderr] | [INFO] [stderr] 247 | _d(3264, 12, 08), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 247 | _d(3264, 12, 8), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 247 | _d(3264, 12, 0o8), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/database/rental.rs:249:17 [INFO] [stderr] | [INFO] [stderr] 249 | 12342433, [INFO] [stderr] | ^^^^^^^^ help: consider: `12_342_433` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/database/rental.rs:268:30 [INFO] [stderr] | [INFO] [stderr] 268 | _d(3264, 12, 08), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 268 | _d(3264, 12, 8), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 268 | _d(3264, 12, 0o8), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/database/rental.rs:269:17 [INFO] [stderr] | [INFO] [stderr] 269 | 012481632, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 269 | 12481632, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 269 | 0o12481632, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/database/rental.rs:269:17 [INFO] [stderr] | [INFO] [stderr] 269 | 012481632, [INFO] [stderr] | ^^^^^^^^^ help: consider: `012_481_632` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/database/rental.rs:355:17 [INFO] [stderr] | [INFO] [stderr] 355 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/database/rental.rs:433:31 [INFO] [stderr] | [INFO] [stderr] 433 | rental.book = 012481632; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 433 | rental.book = 12481632; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 433 | rental.book = 0o12481632; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/database/rental.rs:433:31 [INFO] [stderr] | [INFO] [stderr] 433 | rental.book = 012481632; [INFO] [stderr] | ^^^^^^^^^ help: consider: `012_481_632` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/database/rental.rs:464:33 [INFO] [stderr] | [INFO] [stderr] 464 | rental.rentee = 012481632; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 464 | rental.rentee = 12481632; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 464 | rental.rentee = 0o12481632; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/database/rental.rs:464:33 [INFO] [stderr] | [INFO] [stderr] 464 | rental.rentee = 012481632; [INFO] [stderr] | ^^^^^^^^^ help: consider: `012_481_632` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/rpgsystem.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | return Ok(results.pop()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(results.pop())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/database/rpgsystem.rs:219:17 [INFO] [stderr] | [INFO] [stderr] 219 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/database/rpgsystem.rs:246:17 [INFO] [stderr] | [INFO] [stderr] 246 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/title.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | return Ok(results.pop()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(results.pop())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/database/title.rs:250:17 [INFO] [stderr] | [INFO] [stderr] 250 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/title.rs:274:17 [INFO] [stderr] | [INFO] [stderr] 274 | return db.update(&orig_title); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `db.update(&orig_title)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/title.rs:302:17 [INFO] [stderr] | [INFO] [stderr] 302 | return db.update(&orig_title); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `db.update(&orig_title)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/title.rs:330:17 [INFO] [stderr] | [INFO] [stderr] 330 | return db.update(&orig_title); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `db.update(&orig_title)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/database/title.rs:374:17 [INFO] [stderr] | [INFO] [stderr] 374 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/mod.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | return Ok(Database { pool: pool }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Database { pool: pool })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/mod.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | return results; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/mod.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/mod.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | return Ok(result.pop()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result.pop())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/mod.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | return Ok(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/mod.rs:248:9 [INFO] [stderr] | [INFO] [stderr] 248 | / return self.pool [INFO] [stderr] 249 | | .prep_exec( [INFO] [stderr] 250 | | "select [INFO] [stderr] 251 | | books.book_id, books.owner_type, books.quality, books.title_by_id, \ [INFO] [stderr] ... | [INFO] [stderr] 287 | | }).collect::, bool)>>() [INFO] [stderr] 288 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 248 | self.pool [INFO] [stderr] 249 | .prep_exec( [INFO] [stderr] 250 | "select [INFO] [stderr] 251 | books.book_id, books.owner_type, books.quality, books.title_by_id, \ [INFO] [stderr] 252 | if(books.owner_type = 'member', o_members.member_id, o_guilds.guild_id) as owner_id, \ [INFO] [stderr] 253 | rentals.rental_id, rentals.from_date, rentals.to_date, rentals.rentee_type, \ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/mod.rs:365:9 [INFO] [stderr] | [INFO] [stderr] 365 | return settings; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `settings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/database/mod.rs:390:9 [INFO] [stderr] | [INFO] [stderr] 390 | / return db [INFO] [stderr] 391 | | .insert(&mut RpgSystem::new(None, _s("Kobolde"), None)) [INFO] [stderr] 392 | | .and_then(|system_id| { [INFO] [stderr] 393 | | db.insert(&mut Title::new( [INFO] [stderr] ... | [INFO] [stderr] 415 | | db.insert(&mut book).and_then(|id| Ok((id, book))) [INFO] [stderr] 416 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 390 | db [INFO] [stderr] 391 | .insert(&mut RpgSystem::new(None, _s("Kobolde"), None)) [INFO] [stderr] 392 | .and_then(|system_id| { [INFO] [stderr] 393 | db.insert(&mut Title::new( [INFO] [stderr] 394 | None, [INFO] [stderr] 395 | _s("Kobolde"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/serde_formats.rs:4:25 [INFO] [stderr] | [INFO] [stderr] 4 | const DATE_FORMAT: &'static str = "%Y-%m-%d"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'database::Role': this is a stub for later oauth roles [INFO] [stderr] --> src/api/dto.rs:284:20 [INFO] [stderr] | [INFO] [stderr] 284 | pub roles: Vec, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'database::Role': this is a stub for later oauth roles [INFO] [stderr] --> src/database/mod.rs:313:12 [INFO] [stderr] | [INFO] [stderr] 313 | pub struct Role { [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'database::Role': this is a stub for later oauth roles [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'database::Role::identifier': this is a stub for later oauth roles [INFO] [stderr] --> src/database/mod.rs:312:32 [INFO] [stderr] | [INFO] [stderr] 312 | #[derive(Debug, PartialEq, Eq, Serialize)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'database::Role::identifier': this is a stub for later oauth roles [INFO] [stderr] --> src/database/mod.rs:312:32 [INFO] [stderr] | [INFO] [stderr] 312 | #[derive(Debug, PartialEq, Eq, Serialize)] [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `kc` [INFO] [stderr] --> src/business/mod.rs:8:38 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn get_rpgsystems(db: &Database, kc: &KeycloakCache) -> Result { [INFO] [stderr] | ^^ help: consider using `_kc` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | claims: Option, [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | claims: Option, [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | claims: Option, [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | claims: Option, [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:100:33 [INFO] [stderr] | [INFO] [stderr] 100 | pub fn put_title(db: &Database, claims: Option, title: PutPostTitle) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:106:36 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn delete_title(db: &Database, claims: Option, id: TitleId) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `db` [INFO] [stderr] --> src/business/mod.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | db: &Database, [INFO] [stderr] | ^^ help: consider using `_db` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `id` [INFO] [stderr] --> src/business/mod.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | id: TitleId, [INFO] [stderr] | ^^ help: consider using `_id` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | claims: Option, [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:123:33 [INFO] [stderr] | [INFO] [stderr] 123 | pub fn get_books(db: &Database, claims: Option) -> Result { [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `db` [INFO] [stderr] --> src/business/mod.rs:219:17 [INFO] [stderr] | [INFO] [stderr] 219 | pub fn get_book(db: &Database, claims: Option, id: BookId) -> Result<(), Error> { [INFO] [stderr] | ^^ help: consider using `_db` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:219:32 [INFO] [stderr] | [INFO] [stderr] 219 | pub fn get_book(db: &Database, claims: Option, id: BookId) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `id` [INFO] [stderr] --> src/business/mod.rs:219:56 [INFO] [stderr] | [INFO] [stderr] 219 | pub fn get_book(db: &Database, claims: Option, id: BookId) -> Result<(), Error> { [INFO] [stderr] | ^^ help: consider using `_id` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `db` [INFO] [stderr] --> src/business/mod.rs:226:5 [INFO] [stderr] | [INFO] [stderr] 226 | db: &Database, [INFO] [stderr] | ^^ help: consider using `_db` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:227:5 [INFO] [stderr] | [INFO] [stderr] 227 | claims: Option, [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `book` [INFO] [stderr] --> src/business/mod.rs:228:5 [INFO] [stderr] | [INFO] [stderr] 228 | book: PutPostBook, [INFO] [stderr] | ^^^^ help: consider using `_book` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `db` [INFO] [stderr] --> src/business/mod.rs:235:17 [INFO] [stderr] | [INFO] [stderr] 235 | pub fn put_book(db: &Database, claims: Option, book: PutPostBook) -> Result<(), Error> { [INFO] [stderr] | ^^ help: consider using `_db` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:235:32 [INFO] [stderr] | [INFO] [stderr] 235 | pub fn put_book(db: &Database, claims: Option, book: PutPostBook) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `book` [INFO] [stderr] --> src/business/mod.rs:235:56 [INFO] [stderr] | [INFO] [stderr] 235 | pub fn put_book(db: &Database, claims: Option, book: PutPostBook) -> Result<(), Error> { [INFO] [stderr] | ^^^^ help: consider using `_book` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:241:35 [INFO] [stderr] | [INFO] [stderr] 241 | pub fn delete_book(db: &Database, claims: Option, id: BookId) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `db` [INFO] [stderr] --> src/business/mod.rs:248:20 [INFO] [stderr] | [INFO] [stderr] 248 | pub fn get_members(db: &Database, claims: Option) -> Result { [INFO] [stderr] | ^^ help: consider using `_db` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:248:35 [INFO] [stderr] | [INFO] [stderr] 248 | pub fn get_members(db: &Database, claims: Option) -> Result { [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `db` [INFO] [stderr] --> src/business/mod.rs:255:19 [INFO] [stderr] | [INFO] [stderr] 255 | pub fn get_member(db: &Database, claims: Option, id: MemberId) -> Result<(), Error> { [INFO] [stderr] | ^^ help: consider using `_db` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:255:34 [INFO] [stderr] | [INFO] [stderr] 255 | pub fn get_member(db: &Database, claims: Option, id: MemberId) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `id` [INFO] [stderr] --> src/business/mod.rs:255:58 [INFO] [stderr] | [INFO] [stderr] 255 | pub fn get_member(db: &Database, claims: Option, id: MemberId) -> Result<(), Error> { [INFO] [stderr] | ^^ help: consider using `_id` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `db` [INFO] [stderr] --> src/business/mod.rs:262:19 [INFO] [stderr] | [INFO] [stderr] 262 | pub fn get_guilds(db: &Database, claims: Option) -> Result { [INFO] [stderr] | ^^ help: consider using `_db` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:262:34 [INFO] [stderr] | [INFO] [stderr] 262 | pub fn get_guilds(db: &Database, claims: Option) -> Result { [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `db` [INFO] [stderr] --> src/business/mod.rs:267:18 [INFO] [stderr] | [INFO] [stderr] 267 | pub fn get_guild(db: &Database, claims: Option, id: GuildId) -> Result<(), Error> { [INFO] [stderr] | ^^ help: consider using `_db` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:267:33 [INFO] [stderr] | [INFO] [stderr] 267 | pub fn get_guild(db: &Database, claims: Option, id: GuildId) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `id` [INFO] [stderr] --> src/business/mod.rs:267:57 [INFO] [stderr] | [INFO] [stderr] 267 | pub fn get_guild(db: &Database, claims: Option, id: GuildId) -> Result<(), Error> { [INFO] [stderr] | ^^ help: consider using `_id` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `db` [INFO] [stderr] --> src/business/mod.rs:273:5 [INFO] [stderr] | [INFO] [stderr] 273 | db: &Database, [INFO] [stderr] | ^^ help: consider using `_db` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:274:5 [INFO] [stderr] | [INFO] [stderr] 274 | claims: Option, [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `guild` [INFO] [stderr] --> src/business/mod.rs:275:5 [INFO] [stderr] | [INFO] [stderr] 275 | guild: PutPostGuild, [INFO] [stderr] | ^^^^^ help: consider using `_guild` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `db` [INFO] [stderr] --> src/business/mod.rs:281:18 [INFO] [stderr] | [INFO] [stderr] 281 | pub fn put_guild(db: &Database, claims: Option, guild: PutPostGuild) -> Result<(), Error> { [INFO] [stderr] | ^^ help: consider using `_db` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:281:33 [INFO] [stderr] | [INFO] [stderr] 281 | pub fn put_guild(db: &Database, claims: Option, guild: PutPostGuild) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `guild` [INFO] [stderr] --> src/business/mod.rs:281:57 [INFO] [stderr] | [INFO] [stderr] 281 | pub fn put_guild(db: &Database, claims: Option, guild: PutPostGuild) -> Result<(), Error> { [INFO] [stderr] | ^^^^^ help: consider using `_guild` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `db` [INFO] [stderr] --> src/business/mod.rs:286:21 [INFO] [stderr] | [INFO] [stderr] 286 | pub fn delete_guild(db: &Database, claims: Option, guild: GuildId) -> Result<(), Error> { [INFO] [stderr] | ^^ help: consider using `_db` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:286:36 [INFO] [stderr] | [INFO] [stderr] 286 | pub fn delete_guild(db: &Database, claims: Option, guild: GuildId) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `guild` [INFO] [stderr] --> src/business/mod.rs:286:60 [INFO] [stderr] | [INFO] [stderr] 286 | pub fn delete_guild(db: &Database, claims: Option, guild: GuildId) -> Result<(), Error> { [INFO] [stderr] | ^^^^^ help: consider using `_guild` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `empty_key` [INFO] [stderr] --> src/auth.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | let mut empty_key: [u8; 0]; [INFO] [stderr] | ^^^^^^^^^ help: consider using `_empty_key` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cloned_cache2` [INFO] [stderr] --> src/auth.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | let cloned_cache2 = kc.cache.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_cloned_cache2` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `id` [INFO] [stderr] --> src/database/mod.rs:241:38 [INFO] [stderr] | [INFO] [stderr] 241 | pub fn get_books_by_title(&self, id: TitleId) -> Result, Error> { [INFO] [stderr] | ^^ help: consider using `_id` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/auth.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | let mut empty_key: [u8; 0]; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `kc` [INFO] [stderr] --> src/business/mod.rs:8:38 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn get_rpgsystems(db: &Database, kc: &KeycloakCache) -> Result { [INFO] [stderr] | ^^ help: consider using `_kc` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | claims: Option, [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | claims: Option, [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | claims: Option, [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | claims: Option, [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:100:33 [INFO] [stderr] | [INFO] [stderr] 100 | pub fn put_title(db: &Database, claims: Option, title: PutPostTitle) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:106:36 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn delete_title(db: &Database, claims: Option, id: TitleId) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `db` [INFO] [stderr] --> src/business/mod.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | db: &Database, [INFO] [stderr] | ^^ help: consider using `_db` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `id` [INFO] [stderr] --> src/business/mod.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | id: TitleId, [INFO] [stderr] | ^^ help: consider using `_id` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | claims: Option, [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:123:33 [INFO] [stderr] | [INFO] [stderr] 123 | pub fn get_books(db: &Database, claims: Option) -> Result { [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `db` [INFO] [stderr] --> src/business/mod.rs:219:17 [INFO] [stderr] | [INFO] [stderr] 219 | pub fn get_book(db: &Database, claims: Option, id: BookId) -> Result<(), Error> { [INFO] [stderr] | ^^ help: consider using `_db` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:219:32 [INFO] [stderr] | [INFO] [stderr] 219 | pub fn get_book(db: &Database, claims: Option, id: BookId) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `id` [INFO] [stderr] --> src/business/mod.rs:219:56 [INFO] [stderr] | [INFO] [stderr] 219 | pub fn get_book(db: &Database, claims: Option, id: BookId) -> Result<(), Error> { [INFO] [stderr] | ^^ help: consider using `_id` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `db` [INFO] [stderr] --> src/business/mod.rs:226:5 [INFO] [stderr] | [INFO] [stderr] 226 | db: &Database, [INFO] [stderr] | ^^ help: consider using `_db` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:227:5 [INFO] [stderr] | [INFO] [stderr] 227 | claims: Option, [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `book` [INFO] [stderr] --> src/business/mod.rs:228:5 [INFO] [stderr] | [INFO] [stderr] 228 | book: PutPostBook, [INFO] [stderr] | ^^^^ help: consider using `_book` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `db` [INFO] [stderr] --> src/business/mod.rs:235:17 [INFO] [stderr] | [INFO] [stderr] 235 | pub fn put_book(db: &Database, claims: Option, book: PutPostBook) -> Result<(), Error> { [INFO] [stderr] | ^^ help: consider using `_db` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:235:32 [INFO] [stderr] | [INFO] [stderr] 235 | pub fn put_book(db: &Database, claims: Option, book: PutPostBook) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `book` [INFO] [stderr] --> src/business/mod.rs:235:56 [INFO] [stderr] | [INFO] [stderr] 235 | pub fn put_book(db: &Database, claims: Option, book: PutPostBook) -> Result<(), Error> { [INFO] [stderr] | ^^^^ help: consider using `_book` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:241:35 [INFO] [stderr] | [INFO] [stderr] 241 | pub fn delete_book(db: &Database, claims: Option, id: BookId) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `db` [INFO] [stderr] --> src/business/mod.rs:248:20 [INFO] [stderr] | [INFO] [stderr] 248 | pub fn get_members(db: &Database, claims: Option) -> Result { [INFO] [stderr] | ^^ help: consider using `_db` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:248:35 [INFO] [stderr] | [INFO] [stderr] 248 | pub fn get_members(db: &Database, claims: Option) -> Result { [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `db` [INFO] [stderr] --> src/business/mod.rs:255:19 [INFO] [stderr] | [INFO] [stderr] 255 | pub fn get_member(db: &Database, claims: Option, id: MemberId) -> Result<(), Error> { [INFO] [stderr] | ^^ help: consider using `_db` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:255:34 [INFO] [stderr] | [INFO] [stderr] 255 | pub fn get_member(db: &Database, claims: Option, id: MemberId) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `id` [INFO] [stderr] --> src/business/mod.rs:255:58 [INFO] [stderr] | [INFO] [stderr] 255 | pub fn get_member(db: &Database, claims: Option, id: MemberId) -> Result<(), Error> { [INFO] [stderr] | ^^ help: consider using `_id` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `db` [INFO] [stderr] --> src/business/mod.rs:262:19 [INFO] [stderr] | [INFO] [stderr] 262 | pub fn get_guilds(db: &Database, claims: Option) -> Result { [INFO] [stderr] | ^^ help: consider using `_db` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:262:34 [INFO] [stderr] | [INFO] [stderr] 262 | pub fn get_guilds(db: &Database, claims: Option) -> Result { [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `db` [INFO] [stderr] --> src/business/mod.rs:267:18 [INFO] [stderr] | [INFO] [stderr] 267 | pub fn get_guild(db: &Database, claims: Option, id: GuildId) -> Result<(), Error> { [INFO] [stderr] | ^^ help: consider using `_db` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:267:33 [INFO] [stderr] | [INFO] [stderr] 267 | pub fn get_guild(db: &Database, claims: Option, id: GuildId) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `id` [INFO] [stderr] --> src/business/mod.rs:267:57 [INFO] [stderr] | [INFO] [stderr] 267 | pub fn get_guild(db: &Database, claims: Option, id: GuildId) -> Result<(), Error> { [INFO] [stderr] | ^^ help: consider using `_id` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `db` [INFO] [stderr] --> src/business/mod.rs:273:5 [INFO] [stderr] | [INFO] [stderr] 273 | db: &Database, [INFO] [stderr] | ^^ help: consider using `_db` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:274:5 [INFO] [stderr] | [INFO] [stderr] 274 | claims: Option, [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `guild` [INFO] [stderr] --> src/business/mod.rs:275:5 [INFO] [stderr] | [INFO] [stderr] 275 | guild: PutPostGuild, [INFO] [stderr] | ^^^^^ help: consider using `_guild` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `db` [INFO] [stderr] --> src/business/mod.rs:281:18 [INFO] [stderr] | [INFO] [stderr] 281 | pub fn put_guild(db: &Database, claims: Option, guild: PutPostGuild) -> Result<(), Error> { [INFO] [stderr] | ^^ help: consider using `_db` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:281:33 [INFO] [stderr] | [INFO] [stderr] 281 | pub fn put_guild(db: &Database, claims: Option, guild: PutPostGuild) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `guild` [INFO] [stderr] --> src/business/mod.rs:281:57 [INFO] [stderr] | [INFO] [stderr] 281 | pub fn put_guild(db: &Database, claims: Option, guild: PutPostGuild) -> Result<(), Error> { [INFO] [stderr] | ^^^^^ help: consider using `_guild` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `db` [INFO] [stderr] --> src/business/mod.rs:286:21 [INFO] [stderr] | [INFO] [stderr] 286 | pub fn delete_guild(db: &Database, claims: Option, guild: GuildId) -> Result<(), Error> { [INFO] [stderr] | ^^ help: consider using `_db` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `claims` [INFO] [stderr] --> src/business/mod.rs:286:36 [INFO] [stderr] | [INFO] [stderr] 286 | pub fn delete_guild(db: &Database, claims: Option, guild: GuildId) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^ help: consider using `_claims` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `guild` [INFO] [stderr] --> src/business/mod.rs:286:60 [INFO] [stderr] | [INFO] [stderr] 286 | pub fn delete_guild(db: &Database, claims: Option, guild: GuildId) -> Result<(), Error> { [INFO] [stderr] | ^^^^^ help: consider using `_guild` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `book_id` [INFO] [stderr] --> src/database/book.rs:436:58 [INFO] [stderr] | [INFO] [stderr] 436 | let result = insert_book_default(&db).and_then(|(book_id, mut orig_book)| { [INFO] [stderr] | ^^^^^^^ help: consider using `_book_id` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `guild_id` [INFO] [stderr] --> src/database/guild.rs:237:32 [INFO] [stderr] | [INFO] [stderr] 237 | .and_then(|guild_id| Ok(orig_guild)) [INFO] [stderr] | ^^^^^^^^ help: consider using `_guild_id` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `member_id` [INFO] [stderr] --> src/database/member.rs:188:58 [INFO] [stderr] | [INFO] [stderr] 188 | let result = db.insert(&mut member_in).and_then(|member_id| { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_member_id` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `book_id` [INFO] [stderr] --> src/database/rental.rs:222:58 [INFO] [stderr] | [INFO] [stderr] 222 | let result = insert_book_default(&db).and_then(|(book_id, book)| { [INFO] [stderr] | ^^^^^^^ help: consider using `_book_id` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `book_id` [INFO] [stderr] --> src/database/rental.rs:264:58 [INFO] [stderr] | [INFO] [stderr] 264 | let result = insert_book_default(&db).and_then(|(book_id, book)| { [INFO] [stderr] | ^^^^^^^ help: consider using `_book_id` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `db` [INFO] [stderr] --> src/database/mod.rs:435:13 [INFO] [stderr] | [INFO] [stderr] 435 | let db = Database::from_settings(&settings).unwrap(); [INFO] [stderr] | ^^ help: consider using `_db` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `db` [INFO] [stderr] --> src/database/mod.rs:442:13 [INFO] [stderr] | [INFO] [stderr] 442 | let db = Database::from_settings(&settings).unwrap(); [INFO] [stderr] | ^^ help: consider using `_db` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `empty_key` [INFO] [stderr] --> src/auth.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | let mut empty_key: [u8; 0]; [INFO] [stderr] | ^^^^^^^^^ help: consider using `_empty_key` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cloned_cache2` [INFO] [stderr] --> src/auth.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | let cloned_cache2 = kc.cache.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_cloned_cache2` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `id` [INFO] [stderr] --> src/database/mod.rs:241:38 [INFO] [stderr] | [INFO] [stderr] 241 | pub fn get_books_by_title(&self, id: TitleId) -> Result, Error> { [INFO] [stderr] | ^^ help: consider using `_id` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/auth.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | let mut empty_key: [u8; 0]; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `GetBook` [INFO] [stderr] --> src/api/dto.rs:92:1 [INFO] [stderr] | [INFO] [stderr] 92 | pub struct GetBook { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `GetMember` [INFO] [stderr] --> src/api/dto.rs:110:1 [INFO] [stderr] | [INFO] [stderr] 110 | pub struct GetMember { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `GetMemberInventory` [INFO] [stderr] --> src/api/dto.rs:116:1 [INFO] [stderr] | [INFO] [stderr] 116 | pub struct GetMemberInventory { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `GetGuild` [INFO] [stderr] --> src/api/dto.rs:135:1 [INFO] [stderr] | [INFO] [stderr] 135 | pub struct GetGuild { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `GetGuildInventory` [INFO] [stderr] --> src/api/dto.rs:141:1 [INFO] [stderr] | [INFO] [stderr] 141 | pub struct GetGuildInventory { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Inventory` [INFO] [stderr] --> src/api/dto.rs:274:1 [INFO] [stderr] | [INFO] [stderr] 274 | pub struct Inventory { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `delete_title` [INFO] [stderr] --> src/api/mod.rs:206:1 [INFO] [stderr] | [INFO] [stderr] 206 | fn delete_title(_req: HttpRequest) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `delete_book` [INFO] [stderr] --> src/api/mod.rs:265:1 [INFO] [stderr] | [INFO] [stderr] 265 | fn delete_book(_req: HttpRequest) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_user` [INFO] [stderr] --> src/auth.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn get_user(&self, user_id: &ExternalId) -> Result, Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reset_users` [INFO] [stderr] --> src/auth.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn reset_users(&self) {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `delete_title` [INFO] [stderr] --> src/business/mod.rs:106:1 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn delete_title(db: &Database, claims: Option, id: TitleId) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `delete_book` [INFO] [stderr] --> src/business/mod.rs:241:1 [INFO] [stderr] | [INFO] [stderr] 241 | pub fn delete_book(db: &Database, claims: Option, id: BookId) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `delete_guild` [INFO] [stderr] --> src/business/mod.rs:286:1 [INFO] [stderr] | [INFO] [stderr] 286 | pub fn delete_guild(db: &Database, claims: Option, guild: GuildId) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/database/guild.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn new(id: Option, name: String, address: String, contact: MemberId) -> Guild { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/database/member.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn new(id: Option, external_id: ExternalId) -> Member { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/database/rpgsystem.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn new(id: Option, name: String, shortname: Option) -> RpgSystem { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/database/title.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn new( [INFO] [stderr] 29 | | id: Option, [INFO] [stderr] 30 | | name: String, [INFO] [stderr] 31 | | system: RpgSystemId, [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_books_by_title` [INFO] [stderr] --> src/database/mod.rs:241:5 [INFO] [stderr] | [INFO] [stderr] 241 | pub fn get_books_by_title(&self, id: TitleId) -> Result, Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/database/rental.rs:331:38 [INFO] [stderr] | [INFO] [stderr] 331 | }).and_then(|(rental_id, mut orig_rental, book_id, guild_id)| { [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/api/mod.rs:228:73 [INFO] [stderr] | [INFO] [stderr] 228 | bus::get_book(&_req.state().db, claims, id).and_then(|book| Ok(Json(book))) [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 228 | bus::get_book(&_req.state().db, claims, id).and_then(|book| Ok(Json(()))) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/api/mod.rs:293:77 [INFO] [stderr] | [INFO] [stderr] 293 | bus::get_member(&_req.state().db, claims, id).and_then(|member| Ok(Json(member))) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 293 | bus::get_member(&_req.state().db, claims, id).and_then(|member| Ok(Json(()))) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/api/mod.rs:319:75 [INFO] [stderr] | [INFO] [stderr] 319 | bus::get_guild(&_req.state().db, claims, id).and_then(|guild| Ok(Json(guild))) [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 319 | bus::get_guild(&_req.state().db, claims, id).and_then(|guild| Ok(Json(()))) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `GetBook` [INFO] [stderr] --> src/api/dto.rs:92:1 [INFO] [stderr] | [INFO] [stderr] 92 | pub struct GetBook { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `GetMember` [INFO] [stderr] --> src/api/dto.rs:110:1 [INFO] [stderr] | [INFO] [stderr] 110 | pub struct GetMember { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `GetMemberInventory` [INFO] [stderr] --> src/api/dto.rs:116:1 [INFO] [stderr] | [INFO] [stderr] 116 | pub struct GetMemberInventory { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `GetGuild` [INFO] [stderr] --> src/api/dto.rs:135:1 [INFO] [stderr] | [INFO] [stderr] 135 | pub struct GetGuild { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `GetGuildInventory` [INFO] [stderr] --> src/api/dto.rs:141:1 [INFO] [stderr] | [INFO] [stderr] 141 | pub struct GetGuildInventory { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Inventory` [INFO] [stderr] --> src/api/dto.rs:274:1 [INFO] [stderr] | [INFO] [stderr] 274 | pub struct Inventory { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/auth.rs:95:37 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn get_user(&self, user_id: &ExternalId) -> Result, Error> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: function is never used: `delete_title` [INFO] [stderr] --> src/api/mod.rs:206:1 [INFO] [stderr] | [INFO] [stderr] 206 | fn delete_title(_req: HttpRequest) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `delete_book` [INFO] [stderr] --> src/api/mod.rs:265:1 [INFO] [stderr] | [INFO] [stderr] 265 | fn delete_book(_req: HttpRequest) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_user` [INFO] [stderr] --> src/auth.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn get_user(&self, user_id: &ExternalId) -> Result, Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reset_users` [INFO] [stderr] --> src/auth.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | pub fn reset_users(&self) {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `delete_title` [INFO] [stderr] --> src/business/mod.rs:106:1 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn delete_title(db: &Database, claims: Option, id: TitleId) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `delete_book` [INFO] [stderr] --> src/business/mod.rs:241:1 [INFO] [stderr] | [INFO] [stderr] 241 | pub fn delete_book(db: &Database, claims: Option, id: BookId) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `delete_guild` [INFO] [stderr] --> src/business/mod.rs:286:1 [INFO] [stderr] | [INFO] [stderr] 286 | pub fn delete_guild(db: &Database, claims: Option, guild: GuildId) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_books_by_title` [INFO] [stderr] --> src/database/mod.rs:241:5 [INFO] [stderr] | [INFO] [stderr] 241 | pub fn get_books_by_title(&self, id: TitleId) -> Result, Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/auth.rs:203:26 [INFO] [stderr] | [INFO] [stderr] 203 | .map_err(|err| Error::KeycloakConnectionError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::KeycloakConnectionError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/auth.rs:206:45 [INFO] [stderr] | [INFO] [stderr] 206 | response.json().map_err(|err| Error::JsonPayloadError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::JsonPayloadError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/auth.rs:237:26 [INFO] [stderr] | [INFO] [stderr] 237 | .map_err(|err| Error::KeycloakConnectionError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::KeycloakConnectionError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/auth.rs:238:62 [INFO] [stderr] | [INFO] [stderr] 238 | .and_then(|response| response.json().map_err(|err| Error::JsonPayloadError(err))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::JsonPayloadError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/auth.rs:309:5 [INFO] [stderr] | [INFO] [stderr] 309 | / match roles.is_empty() { [INFO] [stderr] 310 | | true => Ok(claims), [INFO] [stderr] 311 | | false => match claims { [INFO] [stderr] 312 | | Some(cl) => { [INFO] [stderr] ... | [INFO] [stderr] 322 | | }, [INFO] [stderr] 323 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 309 | if roles.is_empty() { Ok(claims) } else { match claims { [INFO] [stderr] 310 | Some(cl) => { [INFO] [stderr] 311 | for role in roles.iter() { [INFO] [stderr] 312 | //let roleString = String::from(*role); [INFO] [stderr] 313 | if cl.roles.contains(&String::from(*role)) { [INFO] [stderr] 314 | return Ok(Some(cl)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/business/mod.rs:32:31 [INFO] [stderr] | [INFO] [stderr] 32 | Ok(db.insert::(&mut system.rpgsystem)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/business/mod.rs:42:8 [INFO] [stderr] | [INFO] [stderr] 42 | Ok(db.update::(&system.rpgsystem)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 42 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/business/mod.rs:102:8 [INFO] [stderr] | [INFO] [stderr] 102 | Ok(db.update::(&title.title)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 102 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/business/mod.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | / match system.id { [INFO] [stderr] 135 | | Some(id) => { [INFO] [stderr] 136 | | systems_map.insert(id, system); [INFO] [stderr] 137 | | () [INFO] [stderr] 138 | | } [INFO] [stderr] 139 | | None => (), [INFO] [stderr] 140 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 134 | if let Some(id) = system.id { [INFO] [stderr] 135 | systems_map.insert(id, system); [INFO] [stderr] 136 | () [INFO] [stderr] 137 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/business/mod.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | / match title.id { [INFO] [stderr] 145 | | Some(id) => { [INFO] [stderr] 146 | | match systems_map.get(&title.system).cloned() { [INFO] [stderr] 147 | | Some(system) => { [INFO] [stderr] ... | [INFO] [stderr] 155 | | None => (), [INFO] [stderr] 156 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 144 | if let Some(id) = title.id { [INFO] [stderr] 145 | match systems_map.get(&title.system).cloned() { [INFO] [stderr] 146 | Some(system) => { [INFO] [stderr] 147 | titles_map.insert(id, TitleWithSystem::new(title, system, 0, 0)); [INFO] [stderr] 148 | () [INFO] [stderr] 149 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/business/mod.rs:146:17 [INFO] [stderr] | [INFO] [stderr] 146 | / match systems_map.get(&title.system).cloned() { [INFO] [stderr] 147 | | Some(system) => { [INFO] [stderr] 148 | | titles_map.insert(id, TitleWithSystem::new(title, system, 0, 0)); [INFO] [stderr] 149 | | () [INFO] [stderr] 150 | | } [INFO] [stderr] 151 | | None => (), [INFO] [stderr] 152 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | if let Some(system) = systems_map.get(&title.system).cloned() { [INFO] [stderr] 147 | titles_map.insert(id, TitleWithSystem::new(title, system, 0, 0)); [INFO] [stderr] 148 | () [INFO] [stderr] 149 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/business/mod.rs:160:9 [INFO] [stderr] | [INFO] [stderr] 160 | / match guild.id { [INFO] [stderr] 161 | | Some(id) => { [INFO] [stderr] 162 | | guilds_map.insert(id, guild); [INFO] [stderr] 163 | | () [INFO] [stderr] 164 | | } [INFO] [stderr] 165 | | None => (), [INFO] [stderr] 166 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 160 | if let Some(id) = guild.id { [INFO] [stderr] 161 | guilds_map.insert(id, guild); [INFO] [stderr] 162 | () [INFO] [stderr] 163 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/database/book.rs:120:12 [INFO] [stderr] | [INFO] [stderr] 120 | Ok(db.pool.prep_exec("update books set title_by_id=:title, owner_member_by_id=:owner_member, owner_guild_by_id=:owner_guild, quality=:quality where book_id=:id;", [INFO] [stderr] | ____________^ [INFO] [stderr] 121 | | params!{ [INFO] [stderr] 122 | | "title" => book.title, [INFO] [stderr] 123 | | "owner_member" => match book.owner_type { [INFO] [stderr] ... | [INFO] [stderr] 132 | | "id" => book.id, [INFO] [stderr] 133 | | }).and(Ok(()))?) [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 120 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/database/book.rs:144:23 [INFO] [stderr] | [INFO] [stderr] 144 | ).map_err(|err| Error::DatabaseError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::DatabaseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/database/guild.rs:90:12 [INFO] [stderr] | [INFO] [stderr] 90 | Ok(db.pool.prep_exec("update guilds set name=:name, address=:address, contact_by_member_id=:contact where guild_id=:id", [INFO] [stderr] | ____________^ [INFO] [stderr] 91 | | params!{ [INFO] [stderr] 92 | | "name" => guild.name.clone(), [INFO] [stderr] 93 | | "address" => guild.address.clone(), [INFO] [stderr] 94 | | "contact" => guild.contact, [INFO] [stderr] 95 | | "id" => guild.id, [INFO] [stderr] 96 | | }).and(Ok(()))?) [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 90 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/database/guild.rs:107:23 [INFO] [stderr] | [INFO] [stderr] 107 | ).map_err(|err| Error::DatabaseError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::DatabaseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/database/member.rs:82:12 [INFO] [stderr] | [INFO] [stderr] 82 | Ok(db [INFO] [stderr] | ____________^ [INFO] [stderr] 83 | | .pool [INFO] [stderr] 84 | | .prep_exec( [INFO] [stderr] 85 | | "update members set external_id=:external_id where member_id=:id", [INFO] [stderr] ... | [INFO] [stderr] 89 | | }, [INFO] [stderr] 90 | | ).and(Ok(()))?) [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 82 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/database/member.rs:101:23 [INFO] [stderr] | [INFO] [stderr] 101 | ).map_err(|err| Error::DatabaseError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::DatabaseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/database/rental.rs:131:12 [INFO] [stderr] | [INFO] [stderr] 131 | Ok(db.pool.prep_exec("update rentals set from_date=:from, to_date=:to, book_by_id=:book, rentee_member_by_id=:rentee_member, rentee_guild_by_id=:rentee_guild where rental_id=:id;", [INFO] [stderr] | ____________^ [INFO] [stderr] 132 | | params!{ [INFO] [stderr] 133 | | //"from" => rental.from.format(SQL_DATEFORMAT).to_string(), [INFO] [stderr] 134 | | //"to" => rental.to.format(SQL_DATEFORMAT).to_string(), [INFO] [stderr] ... | [INFO] [stderr] 146 | | "id" => rental.id, [INFO] [stderr] 147 | | }).and(Ok(()))?) [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 131 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/database/rental.rs:158:23 [INFO] [stderr] | [INFO] [stderr] 158 | ).map_err(|err| Error::DatabaseError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::DatabaseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/api/mod.rs:228:73 [INFO] [stderr] | [INFO] [stderr] 228 | bus::get_book(&_req.state().db, claims, id).and_then(|book| Ok(Json(book))) [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 228 | bus::get_book(&_req.state().db, claims, id).and_then(|book| Ok(Json(()))) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/database/rpgsystem.rs:96:12 [INFO] [stderr] | [INFO] [stderr] 96 | Ok(db [INFO] [stderr] | ____________^ [INFO] [stderr] 97 | | .pool [INFO] [stderr] 98 | | .prep_exec( [INFO] [stderr] 99 | | "update rpg_systems set name=:name, shortname=:short where rpg_system_id=:id;", [INFO] [stderr] ... | [INFO] [stderr] 104 | | }, [INFO] [stderr] 105 | | ).map(|_| ())?) [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 96 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/database/rpgsystem.rs:116:23 [INFO] [stderr] | [INFO] [stderr] 116 | ).map_err(|err| Error::DatabaseError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::DatabaseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/api/mod.rs:293:77 [INFO] [stderr] | [INFO] [stderr] 293 | bus::get_member(&_req.state().db, claims, id).and_then(|member| Ok(Json(member))) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 293 | bus::get_member(&_req.state().db, claims, id).and_then(|member| Ok(Json(()))) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/api/mod.rs:319:75 [INFO] [stderr] | [INFO] [stderr] 319 | bus::get_guild(&_req.state().db, claims, id).and_then(|guild| Ok(Json(guild))) [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 319 | bus::get_guild(&_req.state().db, claims, id).and_then(|guild| Ok(Json(()))) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/database/title.rs:112:12 [INFO] [stderr] | [INFO] [stderr] 112 | Ok(db.pool.prep_exec("update titles set name=:name, rpg_system_by_id=:system, language=:language, publisher=:publisher, year=:year, coverimage=:coverimage where title_id=:id;", [INFO] [stderr] | ____________^ [INFO] [stderr] 113 | | params!{ [INFO] [stderr] 114 | | "name" => title.name.clone(), [INFO] [stderr] 115 | | "system" => title.system, [INFO] [stderr] ... | [INFO] [stderr] 120 | | "id" => title.id, [INFO] [stderr] 121 | | }).and(Ok(()))?) [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 112 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/database/title.rs:132:23 [INFO] [stderr] | [INFO] [stderr] 132 | ).map_err(|err| Error::DatabaseError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::DatabaseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/database/mod.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | / match settings.port { [INFO] [stderr] 93 | | Some(port) => { [INFO] [stderr] 94 | | opts.tcp_port(port); [INFO] [stderr] 95 | | } [INFO] [stderr] 96 | | None => {} [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 92 | if let Some(port) = settings.port { [INFO] [stderr] 93 | opts.tcp_port(port); [INFO] [stderr] 94 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/database/mod.rs:141:18 [INFO] [stderr] | [INFO] [stderr] 141 | .map_err(|err| Error::DatabaseError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::DatabaseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/database/mod.rs:169:22 [INFO] [stderr] | [INFO] [stderr] 169 | .map_err(|err| Error::DatabaseError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::DatabaseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/database/mod.rs:172:132 [INFO] [stderr] | [INFO] [stderr] 172 | let (id, name, language, publisher, year, coverimage, system_id, system_name, system_short, stock, available): (Option<TitleId>, String, String, String, i16, Option<String>, RpgSystemId, String, Option<String>, u32, u32) = mysql::from_row(row); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/database/mod.rs:212:22 [INFO] [stderr] | [INFO] [stderr] 212 | .map_err(|err| Error::DatabaseError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::DatabaseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/database/mod.rs:215:133 [INFO] [stderr] | [INFO] [stderr] 215 | let (id, name, language, publisher, year, coverimage, system_id, system_name, system_short, stock, available) : (Option<TitleId>, String, String, String, i16, Option<String>, RpgSystemId, String, Option<String>, u32, u32) = mysql::from_row(row); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/database/mod.rs:264:22 [INFO] [stderr] | [INFO] [stderr] 264 | .map_err(|err| Error::DatabaseError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::DatabaseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/database/mod.rs:268:23 [INFO] [stderr] | [INFO] [stderr] 268 | : (BookId, String, String, TitleId, EntityId, Option<RentalId>, Option<NaiveDate>, Option<NaiveDate>, Option<String>, Option<EntityId>, bool) = mysql::from_row(row); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/error.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | DatabaseError(MySqlError), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 15 | DatabaseError(Box<MySqlError>), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/serde_formats.rs:8:15 [INFO] [stderr] | [INFO] [stderr] 8 | date: &NaiveDate, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `NaiveDate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/auth.rs:95:37 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn get_user(&self, user_id: &ExternalId) -> Result<Option<KeycloakUser>, Error> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/auth.rs:203:26 [INFO] [stderr] | [INFO] [stderr] 203 | .map_err(|err| Error::KeycloakConnectionError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::KeycloakConnectionError` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/auth.rs:206:45 [INFO] [stderr] | [INFO] [stderr] 206 | response.json().map_err(|err| Error::JsonPayloadError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::JsonPayloadError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/auth.rs:237:26 [INFO] [stderr] | [INFO] [stderr] 237 | .map_err(|err| Error::KeycloakConnectionError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::KeycloakConnectionError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/auth.rs:238:62 [INFO] [stderr] | [INFO] [stderr] 238 | .and_then(|response| response.json().map_err(|err| Error::JsonPayloadError(err))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::JsonPayloadError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/auth.rs:309:5 [INFO] [stderr] | [INFO] [stderr] 309 | / match roles.is_empty() { [INFO] [stderr] 310 | | true => Ok(claims), [INFO] [stderr] 311 | | false => match claims { [INFO] [stderr] 312 | | Some(cl) => { [INFO] [stderr] ... | [INFO] [stderr] 322 | | }, [INFO] [stderr] 323 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 309 | if roles.is_empty() { Ok(claims) } else { match claims { [INFO] [stderr] 310 | Some(cl) => { [INFO] [stderr] 311 | for role in roles.iter() { [INFO] [stderr] 312 | //let roleString = String::from(*role); [INFO] [stderr] 313 | if cl.roles.contains(&String::from(*role)) { [INFO] [stderr] 314 | return Ok(Some(cl)); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/business/mod.rs:32:31 [INFO] [stderr] | [INFO] [stderr] 32 | Ok(db.insert::<RpgSystem>(&mut system.rpgsystem)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/business/mod.rs:42:8 [INFO] [stderr] | [INFO] [stderr] 42 | Ok(db.update::<RpgSystem>(&system.rpgsystem)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 42 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/business/mod.rs:102:8 [INFO] [stderr] | [INFO] [stderr] 102 | Ok(db.update::<Title>(&title.title)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 102 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/business/mod.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | / match system.id { [INFO] [stderr] 135 | | Some(id) => { [INFO] [stderr] 136 | | systems_map.insert(id, system); [INFO] [stderr] 137 | | () [INFO] [stderr] 138 | | } [INFO] [stderr] 139 | | None => (), [INFO] [stderr] 140 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 134 | if let Some(id) = system.id { [INFO] [stderr] 135 | systems_map.insert(id, system); [INFO] [stderr] 136 | () [INFO] [stderr] 137 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/business/mod.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | / match title.id { [INFO] [stderr] 145 | | Some(id) => { [INFO] [stderr] 146 | | match systems_map.get(&title.system).cloned() { [INFO] [stderr] 147 | | Some(system) => { [INFO] [stderr] ... | [INFO] [stderr] 155 | | None => (), [INFO] [stderr] 156 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 144 | if let Some(id) = title.id { [INFO] [stderr] 145 | match systems_map.get(&title.system).cloned() { [INFO] [stderr] 146 | Some(system) => { [INFO] [stderr] 147 | titles_map.insert(id, TitleWithSystem::new(title, system, 0, 0)); [INFO] [stderr] 148 | () [INFO] [stderr] 149 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/business/mod.rs:146:17 [INFO] [stderr] | [INFO] [stderr] 146 | / match systems_map.get(&title.system).cloned() { [INFO] [stderr] 147 | | Some(system) => { [INFO] [stderr] 148 | | titles_map.insert(id, TitleWithSystem::new(title, system, 0, 0)); [INFO] [stderr] 149 | | () [INFO] [stderr] 150 | | } [INFO] [stderr] 151 | | None => (), [INFO] [stderr] 152 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 146 | if let Some(system) = systems_map.get(&title.system).cloned() { [INFO] [stderr] 147 | titles_map.insert(id, TitleWithSystem::new(title, system, 0, 0)); [INFO] [stderr] 148 | () [INFO] [stderr] 149 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/business/mod.rs:160:9 [INFO] [stderr] | [INFO] [stderr] 160 | / match guild.id { [INFO] [stderr] 161 | | Some(id) => { [INFO] [stderr] 162 | | guilds_map.insert(id, guild); [INFO] [stderr] 163 | | () [INFO] [stderr] 164 | | } [INFO] [stderr] 165 | | None => (), [INFO] [stderr] 166 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 160 | if let Some(id) = guild.id { [INFO] [stderr] 161 | guilds_map.insert(id, guild); [INFO] [stderr] 162 | () [INFO] [stderr] 163 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/database/book.rs:120:12 [INFO] [stderr] | [INFO] [stderr] 120 | Ok(db.pool.prep_exec("update books set title_by_id=:title, owner_member_by_id=:owner_member, owner_guild_by_id=:owner_guild, quality=:quality where book_id=:id;", [INFO] [stderr] | ____________^ [INFO] [stderr] 121 | | params!{ [INFO] [stderr] 122 | | "title" => book.title, [INFO] [stderr] 123 | | "owner_member" => match book.owner_type { [INFO] [stderr] ... | [INFO] [stderr] 132 | | "id" => book.id, [INFO] [stderr] 133 | | }).and(Ok(()))?) [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 120 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/database/book.rs:144:23 [INFO] [stderr] | [INFO] [stderr] 144 | ).map_err(|err| Error::DatabaseError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::DatabaseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/book.rs:193:21 [INFO] [stderr] | [INFO] [stderr] 193 | .insert(&mut RpgSystem::new(None, _s("Kobolde"), None)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/book.rs:195:27 [INFO] [stderr] | [INFO] [stderr] 195 | db.insert(&mut Title::new( [INFO] [stderr] | ___________________________^ [INFO] [stderr] 196 | | None, [INFO] [stderr] 197 | | _s("Kobolde"), [INFO] [stderr] 198 | | system_id, [INFO] [stderr] ... | [INFO] [stderr] 202 | | None, [INFO] [stderr] 203 | | )) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/book.rs:205:27 [INFO] [stderr] | [INFO] [stderr] 205 | db.insert(&mut Member::new( [INFO] [stderr] | ___________________________^ [INFO] [stderr] 206 | | None, [INFO] [stderr] 207 | | _s("uiii-a-uuid-or-sth-similar-2481632"), [INFO] [stderr] 208 | | )).and_then(|member_id| Ok((title_id, member_id))) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/book.rs:210:27 [INFO] [stderr] | [INFO] [stderr] 210 | db.insert(&mut Book::new( [INFO] [stderr] | ___________________________^ [INFO] [stderr] 211 | | None, [INFO] [stderr] 212 | | title_id, [INFO] [stderr] 213 | | member_id, [INFO] [stderr] 214 | | EntityType::Member, [INFO] [stderr] 215 | | _s(TOO_LONG_STRING), [INFO] [stderr] 216 | | )) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/book.rs:233:21 [INFO] [stderr] | [INFO] [stderr] 233 | .insert(&mut Member::new( [INFO] [stderr] | _____________________^ [INFO] [stderr] 234 | | None, [INFO] [stderr] 235 | | _s("uiii-a-uuid-or-sth-similar-2481632"), [INFO] [stderr] 236 | | )).and_then(|member_id| { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/book.rs:237:27 [INFO] [stderr] | [INFO] [stderr] 237 | db.insert(&mut Book::new( [INFO] [stderr] | ___________________________^ [INFO] [stderr] 238 | | None, [INFO] [stderr] 239 | | 01248163264, [INFO] [stderr] 240 | | member_id, [INFO] [stderr] 241 | | EntityType::Member, [INFO] [stderr] 242 | | _s("quite good"), [INFO] [stderr] 243 | | )) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/book.rs:257:21 [INFO] [stderr] | [INFO] [stderr] 257 | .insert(&mut RpgSystem::new(None, _s("Kobolde"), None)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/book.rs:259:27 [INFO] [stderr] | [INFO] [stderr] 259 | db.insert(&mut Title::new( [INFO] [stderr] | ___________________________^ [INFO] [stderr] 260 | | None, [INFO] [stderr] 261 | | _s("Kobolde"), [INFO] [stderr] 262 | | system_id, [INFO] [stderr] ... | [INFO] [stderr] 266 | | None, [INFO] [stderr] 267 | | )) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/book.rs:269:27 [INFO] [stderr] | [INFO] [stderr] 269 | db.insert(&mut Book::new( [INFO] [stderr] | ___________________________^ [INFO] [stderr] 270 | | None, [INFO] [stderr] 271 | | title_id, [INFO] [stderr] 272 | | 012481632, [INFO] [stderr] 273 | | EntityType::Member, [INFO] [stderr] 274 | | _s("quite good"), [INFO] [stderr] 275 | | )) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/book.rs:290:21 [INFO] [stderr] | [INFO] [stderr] 290 | .insert(&mut RpgSystem::new(None, _s("Kobolde"), None)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/book.rs:292:27 [INFO] [stderr] | [INFO] [stderr] 292 | db.insert(&mut Title::new( [INFO] [stderr] | ___________________________^ [INFO] [stderr] 293 | | None, [INFO] [stderr] 294 | | _s("Kobolde"), [INFO] [stderr] 295 | | system_id, [INFO] [stderr] ... | [INFO] [stderr] 299 | | None, [INFO] [stderr] 300 | | )) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/book.rs:302:27 [INFO] [stderr] | [INFO] [stderr] 302 | db.insert(&mut Book::new( [INFO] [stderr] | ___________________________^ [INFO] [stderr] 303 | | None, [INFO] [stderr] 304 | | title_id, [INFO] [stderr] 305 | | 012481632, [INFO] [stderr] 306 | | EntityType::Guild, [INFO] [stderr] 307 | | _s("quite good"), [INFO] [stderr] 308 | | )) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/book.rs:322:21 [INFO] [stderr] | [INFO] [stderr] 322 | .insert(&mut RpgSystem::new(None, _s("Cthulhu"), Some(_s("CoC")))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/book.rs:324:27 [INFO] [stderr] | [INFO] [stderr] 324 | db.insert(&mut Title::new( [INFO] [stderr] | ___________________________^ [INFO] [stderr] 325 | | None, [INFO] [stderr] 326 | | _s("Cthulhu 666th Edition"), [INFO] [stderr] 327 | | system_id, [INFO] [stderr] ... | [INFO] [stderr] 331 | | None, [INFO] [stderr] 332 | | )) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/book.rs:334:27 [INFO] [stderr] | [INFO] [stderr] 334 | db.insert(&mut Member::new( [INFO] [stderr] | ___________________________^ [INFO] [stderr] 335 | | None, [INFO] [stderr] 336 | | _s("annother-uuuuuiiii-iiiiddd-123443214"), [INFO] [stderr] 337 | | )).and_then(|member_id| Ok((title_id, member_id))) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/book.rs:339:27 [INFO] [stderr] | [INFO] [stderr] 339 | db.insert(&mut Guild::new( [INFO] [stderr] | ___________________________^ [INFO] [stderr] 340 | | None, [INFO] [stderr] 341 | | _s("Ravenclaw"), [INFO] [stderr] 342 | | _s("Sesame Street 123"), [INFO] [stderr] 343 | | member_id, [INFO] [stderr] 344 | | )).and_then(|guild_id| Ok((title_id, guild_id))) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> src/database/book.rs:355:23 [INFO] [stderr] | [INFO] [stderr] 355 | ..orig_book [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_update)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/database/guild.rs:90:12 [INFO] [stderr] | [INFO] [stderr] 90 | Ok(db.pool.prep_exec("update guilds set name=:name, address=:address, contact_by_member_id=:contact where guild_id=:id", [INFO] [stderr] | ____________^ [INFO] [stderr] 91 | | params!{ [INFO] [stderr] 92 | | "name" => guild.name.clone(), [INFO] [stderr] 93 | | "address" => guild.address.clone(), [INFO] [stderr] 94 | | "contact" => guild.contact, [INFO] [stderr] 95 | | "id" => guild.id, [INFO] [stderr] 96 | | }).and(Ok(()))?) [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 90 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/database/guild.rs:107:23 [INFO] [stderr] | [INFO] [stderr] 107 | ).map_err(|err| Error::DatabaseError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::DatabaseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/guild.rs:126:21 [INFO] [stderr] | [INFO] [stderr] 126 | .insert(&mut Member::new(None, _s("external_id"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/guild.rs:134:27 [INFO] [stderr] | [INFO] [stderr] 134 | db.insert(&mut orig_guild) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/guild.rs:163:27 [INFO] [stderr] | [INFO] [stderr] 163 | db.insert(&mut Guild::new( [INFO] [stderr] | ___________________________^ [INFO] [stderr] 164 | | None, [INFO] [stderr] 165 | | _s(TOO_LONG_STRING), [INFO] [stderr] 166 | | _s("Postfach 1231238581412 1238414812 Aachen"), [INFO] [stderr] 167 | | member_id, [INFO] [stderr] 168 | | )) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/guild.rs:183:21 [INFO] [stderr] | [INFO] [stderr] 183 | .insert(&mut Member::new(None, _s("external_id1"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/guild.rs:191:27 [INFO] [stderr] | [INFO] [stderr] 191 | db.insert(&mut orig_guild) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/guild.rs:197:27 [INFO] [stderr] | [INFO] [stderr] 197 | db.insert(&mut Member::new(None, _s("other_id"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/guild.rs:228:21 [INFO] [stderr] | [INFO] [stderr] 228 | .insert(&mut Member::new(None, _s("external_id1"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/guild.rs:236:27 [INFO] [stderr] | [INFO] [stderr] 236 | db.insert(&mut orig_guild) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/guild.rs:259:21 [INFO] [stderr] | [INFO] [stderr] 259 | .insert(&mut Member::new(None, _s("external_id1"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/guild.rs:267:27 [INFO] [stderr] | [INFO] [stderr] 267 | db.insert(&mut orig_guild).and_then(|_| Ok(orig_guild)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/guild.rs:288:32 [INFO] [stderr] | [INFO] [stderr] 288 | let result = db.insert(&mut Guild::new( [INFO] [stderr] | ________________________________^ [INFO] [stderr] 289 | | None, [INFO] [stderr] 290 | | _s("RPG Librarium Aachen"), [INFO] [stderr] 291 | | _s("Postfach 1231238581412 1238414812 Aachen"), [INFO] [stderr] 292 | | 12345, [INFO] [stderr] 293 | | )); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/guild.rs:307:21 [INFO] [stderr] | [INFO] [stderr] 307 | .insert(&mut Member::new(None, _s("external_id1"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/guild.rs:315:27 [INFO] [stderr] | [INFO] [stderr] 315 | db.insert(&mut orig_guild) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/database/member.rs:82:12 [INFO] [stderr] | [INFO] [stderr] 82 | Ok(db [INFO] [stderr] | ____________^ [INFO] [stderr] 83 | | .pool [INFO] [stderr] 84 | | .prep_exec( [INFO] [stderr] 85 | | "update members set external_id=:external_id where member_id=:id", [INFO] [stderr] ... | [INFO] [stderr] 89 | | }, [INFO] [stderr] 90 | | ).and(Ok(()))?) [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 82 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/database/member.rs:101:23 [INFO] [stderr] | [INFO] [stderr] 101 | ).map_err(|err| Error::DatabaseError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::DatabaseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/member.rs:119:36 [INFO] [stderr] | [INFO] [stderr] 119 | let member_out = db.insert(&mut member_in).and_then(|member_id| { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/member.rs:139:32 [INFO] [stderr] | [INFO] [stderr] 139 | let result = db.insert(&mut Member::new(None, String::from(TOO_LONG_STRING))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/member.rs:157:32 [INFO] [stderr] | [INFO] [stderr] 157 | let result = db.insert(&mut member_in).and_then(|member_id| { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> src/database/member.rs:161:19 [INFO] [stderr] | [INFO] [stderr] 161 | ..member_in [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/member.rs:188:32 [INFO] [stderr] | [INFO] [stderr] 188 | let result = db.insert(&mut member_in).and_then(|member_id| { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/database/rental.rs:131:12 [INFO] [stderr] | [INFO] [stderr] 131 | Ok(db.pool.prep_exec("update rentals set from_date=:from, to_date=:to, book_by_id=:book, rentee_member_by_id=:rentee_member, rentee_guild_by_id=:rentee_guild where rental_id=:id;", [INFO] [stderr] | ____________^ [INFO] [stderr] 132 | | params!{ [INFO] [stderr] 133 | | //"from" => rental.from.format(SQL_DATEFORMAT).to_string(), [INFO] [stderr] 134 | | //"to" => rental.to.format(SQL_DATEFORMAT).to_string(), [INFO] [stderr] ... | [INFO] [stderr] 146 | | "id" => rental.id, [INFO] [stderr] 147 | | }).and(Ok(()))?) [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 131 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/database/rental.rs:158:23 [INFO] [stderr] | [INFO] [stderr] 158 | ).map_err(|err| Error::DatabaseError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::DatabaseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/rental.rs:177:21 [INFO] [stderr] | [INFO] [stderr] 177 | .insert(&mut member_in) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/rental.rs:193:27 [INFO] [stderr] | [INFO] [stderr] 193 | db.insert(&mut rental_in).and_then(|id| Ok((id, rental_in))) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/rental.rs:223:23 [INFO] [stderr] | [INFO] [stderr] 223 | db.insert(&mut Rental::new( [INFO] [stderr] | _______________________^ [INFO] [stderr] 224 | | None, [INFO] [stderr] 225 | | _d(2014, 8, 16), [INFO] [stderr] 226 | | _d(3264, 12, 08), [INFO] [stderr] ... | [INFO] [stderr] 229 | | book.owner_type, [INFO] [stderr] 230 | | )) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/rental.rs:244:23 [INFO] [stderr] | [INFO] [stderr] 244 | db.insert(&mut Rental::new( [INFO] [stderr] | _______________________^ [INFO] [stderr] 245 | | None, [INFO] [stderr] 246 | | _d(2014, 8, 16), [INFO] [stderr] 247 | | _d(3264, 12, 08), [INFO] [stderr] ... | [INFO] [stderr] 250 | | book.owner_type, [INFO] [stderr] 251 | | )) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/rental.rs:265:23 [INFO] [stderr] | [INFO] [stderr] 265 | db.insert(&mut Rental::new( [INFO] [stderr] | _______________________^ [INFO] [stderr] 266 | | None, [INFO] [stderr] 267 | | _d(2014, 8, 16), [INFO] [stderr] 268 | | _d(3264, 12, 08), [INFO] [stderr] ... | [INFO] [stderr] 274 | | }, [INFO] [stderr] 275 | | )) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/rental.rs:298:27 [INFO] [stderr] | [INFO] [stderr] 298 | db.insert(&mut orig_rental) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/rental.rs:301:27 [INFO] [stderr] | [INFO] [stderr] 301 | db.insert(&mut Member::new(None, _s("rincewind"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/rental.rs:304:27 [INFO] [stderr] | [INFO] [stderr] 304 | db.insert(&mut Guild::new( [INFO] [stderr] | ___________________________^ [INFO] [stderr] 305 | | None, [INFO] [stderr] 306 | | _s("Yordle Academy of Science and Progress"), [INFO] [stderr] 307 | | _s("Piltover"), [INFO] [stderr] 308 | | member_id, [INFO] [stderr] 309 | | )).and_then(|guild_id| Ok((rental_id, orig_rental, guild_id))) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/rental.rs:311:27 [INFO] [stderr] | [INFO] [stderr] 311 | db.insert(&mut RpgSystem::new(None, _s("Discworld"), None)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/rental.rs:314:27 [INFO] [stderr] | [INFO] [stderr] 314 | db.insert(&mut Title::new( [INFO] [stderr] | ___________________________^ [INFO] [stderr] 315 | | None, [INFO] [stderr] 316 | | _s("Unseen University Adventures"), [INFO] [stderr] 317 | | system_id, [INFO] [stderr] ... | [INFO] [stderr] 321 | | None, [INFO] [stderr] 322 | | )).and_then(|title_id| Ok((rental_id, orig_rental, guild_id, title_id))) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/rental.rs:324:27 [INFO] [stderr] | [INFO] [stderr] 324 | db.insert(&mut Book::new( [INFO] [stderr] | ___________________________^ [INFO] [stderr] 325 | | None, [INFO] [stderr] 326 | | title_id, [INFO] [stderr] 327 | | guild_id, [INFO] [stderr] 328 | | EntityType::Guild, [INFO] [stderr] 329 | | _s("impressive"), [INFO] [stderr] 330 | | )).and_then(|book_id| Ok((rental_id, orig_rental, book_id, guild_id))) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stderr] --> src/database/rental.rs:339:23 [INFO] [stderr] | [INFO] [stderr] 339 | ..orig_rental [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/rental.rs:374:27 [INFO] [stderr] | [INFO] [stderr] 374 | db.insert(&mut rental).and_then(|_| Ok(rental)) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/rental.rs:400:27 [INFO] [stderr] | [INFO] [stderr] 400 | db.insert(&mut rental).and_then(|_| Ok(rental)) [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/rental.rs:426:27 [INFO] [stderr] | [INFO] [stderr] 426 | db.insert(&mut rental).and_then(|id| { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/rental.rs:457:27 [INFO] [stderr] | [INFO] [stderr] 457 | db.insert(&mut rental).and_then(|id| { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/rental.rs:488:27 [INFO] [stderr] | [INFO] [stderr] 488 | db.insert(&mut rental).and_then(|id| { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/database/rpgsystem.rs:96:12 [INFO] [stderr] | [INFO] [stderr] 96 | Ok(db [INFO] [stderr] | ____________^ [INFO] [stderr] 97 | | .pool [INFO] [stderr] 98 | | .prep_exec( [INFO] [stderr] 99 | | "update rpg_systems set name=:name, shortname=:short where rpg_system_id=:id;", [INFO] [stderr] ... | [INFO] [stderr] 104 | | }, [INFO] [stderr] 105 | | ).map(|_| ())?) [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 96 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/database/rpgsystem.rs:116:23 [INFO] [stderr] | [INFO] [stderr] 116 | ).map_err(|err| Error::DatabaseError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::DatabaseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/rpgsystem.rs:168:32 [INFO] [stderr] | [INFO] [stderr] 168 | let result = db.insert(&mut RpgSystem::new( [INFO] [stderr] | ________________________________^ [INFO] [stderr] 169 | | None, [INFO] [stderr] 170 | | String::from(TOO_LONG_STRING), [INFO] [stderr] 171 | | None, [INFO] [stderr] 172 | | )); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/rpgsystem.rs:201:32 [INFO] [stderr] | [INFO] [stderr] 201 | let result = db.insert(&mut system_in).and_then(|id| { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/rpgsystem.rs:230:32 [INFO] [stderr] | [INFO] [stderr] 230 | let result = db.insert(&mut system_in).and_then(|id| { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/rpgsystem.rs:257:32 [INFO] [stderr] | [INFO] [stderr] 257 | let result = db.insert(&mut system_in).and_then(|_| { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/database/title.rs:112:12 [INFO] [stderr] | [INFO] [stderr] 112 | Ok(db.pool.prep_exec("update titles set name=:name, rpg_system_by_id=:system, language=:language, publisher=:publisher, year=:year, coverimage=:coverimage where title_id=:id;", [INFO] [stderr] | ____________^ [INFO] [stderr] 113 | | params!{ [INFO] [stderr] 114 | | "name" => title.name.clone(), [INFO] [stderr] 115 | | "system" => title.system, [INFO] [stderr] ... | [INFO] [stderr] 120 | | "id" => title.id, [INFO] [stderr] 121 | | }).and(Ok(()))?) [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 112 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/database/title.rs:132:23 [INFO] [stderr] | [INFO] [stderr] 132 | ).map_err(|err| Error::DatabaseError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::DatabaseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/title.rs:151:21 [INFO] [stderr] | [INFO] [stderr] 151 | .insert(&mut RpgSystem::new(None, String::from("Kobolde"), None)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/title.rs:153:27 [INFO] [stderr] | [INFO] [stderr] 153 | db.insert(&mut Title::new( [INFO] [stderr] | ___________________________^ [INFO] [stderr] 154 | | None, [INFO] [stderr] 155 | | String::from(TOO_LONG_STRING), [INFO] [stderr] 156 | | system_id, [INFO] [stderr] ... | [INFO] [stderr] 160 | | None, [INFO] [stderr] 161 | | )) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/title.rs:175:21 [INFO] [stderr] | [INFO] [stderr] 175 | .insert(&mut RpgSystem::new(None, String::from("Kobolde"), None)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/title.rs:177:27 [INFO] [stderr] | [INFO] [stderr] 177 | db.insert(&mut Title::new( [INFO] [stderr] | ___________________________^ [INFO] [stderr] 178 | | None, [INFO] [stderr] 179 | | String::from("Kobolde"), [INFO] [stderr] 180 | | system_id, [INFO] [stderr] ... | [INFO] [stderr] 184 | | None, [INFO] [stderr] 185 | | )) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/title.rs:199:21 [INFO] [stderr] | [INFO] [stderr] 199 | .insert(&mut RpgSystem::new(None, String::from("Kobolde"), None)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/title.rs:201:27 [INFO] [stderr] | [INFO] [stderr] 201 | db.insert(&mut Title::new( [INFO] [stderr] | ___________________________^ [INFO] [stderr] 202 | | None, [INFO] [stderr] 203 | | String::from("Kobolde"), [INFO] [stderr] 204 | | system_id, [INFO] [stderr] ... | [INFO] [stderr] 208 | | None, [INFO] [stderr] 209 | | )) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/title.rs:223:21 [INFO] [stderr] | [INFO] [stderr] 223 | .insert(&mut RpgSystem::new(None, String::from("Kobolde"), None)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/title.rs:234:27 [INFO] [stderr] | [INFO] [stderr] 234 | db.insert(&mut orig_title) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/title.rs:260:21 [INFO] [stderr] | [INFO] [stderr] 260 | .insert(&mut RpgSystem::new(None, String::from("Kobolde"), None)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/title.rs:271:27 [INFO] [stderr] | [INFO] [stderr] 271 | db.insert(&mut orig_title).and_then(|_| Ok(orig_title)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/title.rs:288:21 [INFO] [stderr] | [INFO] [stderr] 288 | .insert(&mut RpgSystem::new(None, String::from("Kobolde"), None)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/title.rs:299:27 [INFO] [stderr] | [INFO] [stderr] 299 | db.insert(&mut orig_title).and_then(|_| Ok(orig_title)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/title.rs:316:21 [INFO] [stderr] | [INFO] [stderr] 316 | .insert(&mut RpgSystem::new(None, String::from("Kobolde"), None)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/title.rs:327:27 [INFO] [stderr] | [INFO] [stderr] 327 | db.insert(&mut orig_title).and_then(|_| Ok(orig_title)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/title.rs:344:21 [INFO] [stderr] | [INFO] [stderr] 344 | .insert(&mut RpgSystem::new(None, _s("Kobolde"), None)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/title.rs:355:27 [INFO] [stderr] | [INFO] [stderr] 355 | db.insert(&mut orig_title) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/database/mod.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | / match settings.port { [INFO] [stderr] 93 | | Some(port) => { [INFO] [stderr] 94 | | opts.tcp_port(port); [INFO] [stderr] 95 | | } [INFO] [stderr] 96 | | None => {} [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 92 | if let Some(port) = settings.port { [INFO] [stderr] 93 | opts.tcp_port(port); [INFO] [stderr] 94 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/database/mod.rs:141:18 [INFO] [stderr] | [INFO] [stderr] 141 | .map_err(|err| Error::DatabaseError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::DatabaseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/database/mod.rs:169:22 [INFO] [stderr] | [INFO] [stderr] 169 | .map_err(|err| Error::DatabaseError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::DatabaseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/database/mod.rs:172:132 [INFO] [stderr] | [INFO] [stderr] 172 | let (id, name, language, publisher, year, coverimage, system_id, system_name, system_short, stock, available): (Option<TitleId>, String, String, String, i16, Option<String>, RpgSystemId, String, Option<String>, u32, u32) = mysql::from_row(row); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/database/mod.rs:212:22 [INFO] [stderr] | [INFO] [stderr] 212 | .map_err(|err| Error::DatabaseError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::DatabaseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/database/mod.rs:215:133 [INFO] [stderr] | [INFO] [stderr] 215 | let (id, name, language, publisher, year, coverimage, system_id, system_name, system_short, stock, available) : (Option<TitleId>, String, String, String, i16, Option<String>, RpgSystemId, String, Option<String>, u32, u32) = mysql::from_row(row); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/database/mod.rs:264:22 [INFO] [stderr] | [INFO] [stderr] 264 | .map_err(|err| Error::DatabaseError(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::DatabaseError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/database/mod.rs:268:23 [INFO] [stderr] | [INFO] [stderr] 268 | : (BookId, String, String, TitleId, EntityId, Option<RentalId>, Option<NaiveDate>, Option<NaiveDate>, Option<String>, Option<EntityId>, bool) = mysql::from_row(row); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/database/mod.rs:350:9 [INFO] [stderr] | [INFO] [stderr] 350 | / match settings.port { [INFO] [stderr] 351 | | Some(port) => { [INFO] [stderr] 352 | | opts.tcp_port(port); [INFO] [stderr] 353 | | } [INFO] [stderr] 354 | | None => {} [INFO] [stderr] 355 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 350 | if let Some(port) = settings.port { [INFO] [stderr] 351 | opts.tcp_port(port); [INFO] [stderr] 352 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/database/mod.rs:361:29 [INFO] [stderr] | [INFO] [stderr] 361 | settings.database = String::from(format!("test_{}", rng.gen::<u32>())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("test_{}", rng.gen::<u32>())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/database/mod.rs:375:9 [INFO] [stderr] | [INFO] [stderr] 375 | / match settings.port { [INFO] [stderr] 376 | | Some(port) => { [INFO] [stderr] 377 | | opts.tcp_port(port); [INFO] [stderr] 378 | | } [INFO] [stderr] 379 | | None => {} [INFO] [stderr] 380 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 375 | if let Some(port) = settings.port { [INFO] [stderr] 376 | opts.tcp_port(port); [INFO] [stderr] 377 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/mod.rs:391:21 [INFO] [stderr] | [INFO] [stderr] 391 | .insert(&mut RpgSystem::new(None, _s("Kobolde"), None)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/mod.rs:393:27 [INFO] [stderr] | [INFO] [stderr] 393 | db.insert(&mut Title::new( [INFO] [stderr] | ___________________________^ [INFO] [stderr] 394 | | None, [INFO] [stderr] 395 | | _s("Kobolde"), [INFO] [stderr] 396 | | system_id, [INFO] [stderr] ... | [INFO] [stderr] 400 | | None, [INFO] [stderr] 401 | | )) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/mod.rs:403:27 [INFO] [stderr] | [INFO] [stderr] 403 | db.insert(&mut Member::new( [INFO] [stderr] | ___________________________^ [INFO] [stderr] 404 | | None, [INFO] [stderr] 405 | | _s("uiii-a-uuid-or-sth-similar-2481632"), [INFO] [stderr] 406 | | )).and_then(|member_id| Ok((title_id, member_id))) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `insert` doesn't need a mutable reference [INFO] [stderr] --> src/database/mod.rs:415:27 [INFO] [stderr] | [INFO] [stderr] 415 | db.insert(&mut book).and_then(|id| Ok((id, book))) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/error.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | DatabaseError(MySqlError), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 15 | DatabaseError(Box<MySqlError>), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/serde_formats.rs:8:15 [INFO] [stderr] | [INFO] [stderr] 8 | date: &NaiveDate, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `NaiveDate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 04s [INFO] running `"docker" "inspect" "4a1ad0a18ec5d3627ce20ca2479229c8084ea749042b648d509e2338e30c6efc"` [INFO] running `"docker" "rm" "-f" "4a1ad0a18ec5d3627ce20ca2479229c8084ea749042b648d509e2338e30c6efc"` [INFO] [stdout] 4a1ad0a18ec5d3627ce20ca2479229c8084ea749042b648d509e2338e30c6efc