[INFO] updating cached repository R-Michelsen/Rusty_SAT [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/R-Michelsen/Rusty_SAT [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/R-Michelsen/Rusty_SAT" "work/ex/clippy-test-run/sources/stable/gh/R-Michelsen/Rusty_SAT"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/R-Michelsen/Rusty_SAT'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/R-Michelsen/Rusty_SAT" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/R-Michelsen/Rusty_SAT"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/R-Michelsen/Rusty_SAT'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 48cec4c9af63b347e74115cacc7d38f6dbc5849d [INFO] sha for GitHub repo R-Michelsen/Rusty_SAT: 48cec4c9af63b347e74115cacc7d38f6dbc5849d [INFO] validating manifest of R-Michelsen/Rusty_SAT on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of R-Michelsen/Rusty_SAT on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing R-Michelsen/Rusty_SAT [INFO] finished frobbing R-Michelsen/Rusty_SAT [INFO] frobbed toml for R-Michelsen/Rusty_SAT written to work/ex/clippy-test-run/sources/stable/gh/R-Michelsen/Rusty_SAT/Cargo.toml [INFO] started frobbing R-Michelsen/Rusty_SAT [INFO] finished frobbing R-Michelsen/Rusty_SAT [INFO] frobbed toml for R-Michelsen/Rusty_SAT written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/R-Michelsen/Rusty_SAT/Cargo.toml [INFO] crate R-Michelsen/Rusty_SAT has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting R-Michelsen/Rusty_SAT against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/R-Michelsen/Rusty_SAT:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 895565b3d727af71630078204a83ae0e88248126e2d98f0023f5be0ff7b9490d [INFO] running `"docker" "start" "-a" "895565b3d727af71630078204a83ae0e88248126e2d98f0023f5be0ff7b9490d"` [INFO] [stderr] Checking rusty_sat v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cnf_formula.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return literals; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `literals` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cnf_formula.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / return CNFFormula{ m_decide_count: 1, m_finished: false, [INFO] [stderr] 65 | | m_clauses: clauses , m_variables: variables, [INFO] [stderr] 66 | | m_decisions: Vec::new(), [INFO] [stderr] 67 | | m_assignments: IndexMap::new(), [INFO] [stderr] 68 | | m_decision_level: 0, [INFO] [stderr] 69 | | m_implications: Vec::new() }; [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 64 | CNFFormula{ m_decide_count: 1, m_finished: false, [INFO] [stderr] 65 | m_clauses: clauses , m_variables: variables, [INFO] [stderr] 66 | m_decisions: Vec::new(), [INFO] [stderr] 67 | m_assignments: IndexMap::new(), [INFO] [stderr] 68 | m_decision_level: 0, [INFO] [stderr] 69 | m_implications: Vec::new() } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/cnf_formula.rs:54:22 [INFO] [stderr] | [INFO] [stderr] 54 | else if !literal.starts_with("0") { [INFO] [stderr] | ______________________^ [INFO] [stderr] 55 | | if !variables.contains_key(&literal) { [INFO] [stderr] 56 | | variables.insert(literal, var_index); [INFO] [stderr] 57 | | var_index += 1; [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 54 | else if !literal.starts_with("0") && !variables.contains_key(&literal) { [INFO] [stderr] 55 | variables.insert(literal, var_index); [INFO] [stderr] 56 | var_index += 1; [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cnf_formula.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | return Some(self.m_assignments.get(literal).unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.m_assignments.get(literal).unwrap().clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cnf_formula.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | return Some(self.m_assignments.get(&(literal ^ 1)).unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.m_assignments.get(&(literal ^ 1)).unwrap().clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cnf_formula.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cnf_formula.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cnf_formula.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | return num; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cnf_formula.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | return strings; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `strings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cnf_formula.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | return new_partial_clause; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_partial_clause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cnf_formula.rs:430:9 [INFO] [stderr] | [INFO] [stderr] 430 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/cnf_formula.rs:325:33 [INFO] [stderr] | [INFO] [stderr] 325 | / if x == self.m_decision_level { [INFO] [stderr] 326 | | if conflict_clause[i] != p ^ 1 { [INFO] [stderr] 327 | | continue; [INFO] [stderr] 328 | | } [INFO] [stderr] 329 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 325 | if x == self.m_decision_level && conflict_clause[i] != p ^ 1 { [INFO] [stderr] 326 | continue; [INFO] [stderr] 327 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cnf_formula.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return literals; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `literals` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cnf_formula.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / return CNFFormula{ m_decide_count: 1, m_finished: false, [INFO] [stderr] 65 | | m_clauses: clauses , m_variables: variables, [INFO] [stderr] 66 | | m_decisions: Vec::new(), [INFO] [stderr] 67 | | m_assignments: IndexMap::new(), [INFO] [stderr] 68 | | m_decision_level: 0, [INFO] [stderr] 69 | | m_implications: Vec::new() }; [INFO] [stderr] | |________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 64 | CNFFormula{ m_decide_count: 1, m_finished: false, [INFO] [stderr] 65 | m_clauses: clauses , m_variables: variables, [INFO] [stderr] 66 | m_decisions: Vec::new(), [INFO] [stderr] 67 | m_assignments: IndexMap::new(), [INFO] [stderr] 68 | m_decision_level: 0, [INFO] [stderr] 69 | m_implications: Vec::new() } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/cnf_formula.rs:54:22 [INFO] [stderr] | [INFO] [stderr] 54 | else if !literal.starts_with("0") { [INFO] [stderr] | ______________________^ [INFO] [stderr] 55 | | if !variables.contains_key(&literal) { [INFO] [stderr] 56 | | variables.insert(literal, var_index); [INFO] [stderr] 57 | | var_index += 1; [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 54 | else if !literal.starts_with("0") && !variables.contains_key(&literal) { [INFO] [stderr] 55 | variables.insert(literal, var_index); [INFO] [stderr] 56 | var_index += 1; [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cnf_formula.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | return Some(self.m_assignments.get(literal).unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.m_assignments.get(literal).unwrap().clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cnf_formula.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | return Some(self.m_assignments.get(&(literal ^ 1)).unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.m_assignments.get(&(literal ^ 1)).unwrap().clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cnf_formula.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cnf_formula.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cnf_formula.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | return num; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cnf_formula.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | return strings; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `strings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cnf_formula.rs:172:9 [INFO] [stderr] | [INFO] [stderr] 172 | return new_partial_clause; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_partial_clause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cnf_formula.rs:430:9 [INFO] [stderr] | [INFO] [stderr] 430 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/cnf_formula.rs:325:33 [INFO] [stderr] | [INFO] [stderr] 325 | / if x == self.m_decision_level { [INFO] [stderr] 326 | | if conflict_clause[i] != p ^ 1 { [INFO] [stderr] 327 | | continue; [INFO] [stderr] 328 | | } [INFO] [stderr] 329 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 325 | if x == self.m_decision_level && conflict_clause[i] != p ^ 1 { [INFO] [stderr] 326 | continue; [INFO] [stderr] 327 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cnf_formula.rs:29:36 [INFO] [stderr] | [INFO] [stderr] 29 | if literal.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cnf_formula.rs:30:31 [INFO] [stderr] | [INFO] [stderr] 30 | literals.push(variables.get(&literal.trim_matches('-').to_owned()).unwrap().clone() << 1 | 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*variables.get(&literal.trim_matches('-').to_owned()).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cnf_formula.rs:32:42 [INFO] [stderr] | [INFO] [stderr] 32 | else if !literal.starts_with("0") { [INFO] [stderr] | ^^^ help: try using a char instead: `'0'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cnf_formula.rs:33:31 [INFO] [stderr] | [INFO] [stderr] 33 | literals.push(variables.get(&literal).unwrap().clone() << 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*variables.get(&literal).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cnf_formula.rs:48:40 [INFO] [stderr] | [INFO] [stderr] 48 | if literal.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cnf_formula.rs:54:46 [INFO] [stderr] | [INFO] [stderr] 54 | else if !literal.starts_with("0") { [INFO] [stderr] | ^^^ help: try using a char instead: `'0'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cnf_formula.rs:72:59 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn assignment_find_decision_level(&self, literal: &u32) -> Option { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cnf_formula.rs:74:25 [INFO] [stderr] | [INFO] [stderr] 74 | return Some(self.m_assignments.get(literal).unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.m_assignments.get(literal).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cnf_formula.rs:77:25 [INFO] [stderr] | [INFO] [stderr] 77 | return Some(self.m_assignments.get(&(literal ^ 1)).unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.m_assignments.get(&(literal ^ 1)).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cnf_formula.rs:84:62 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn assignments_find_at_decisionlevel(&self, literal: &u32, dec_level: &i32) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cnf_formula.rs:84:79 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn assignments_find_at_decisionlevel(&self, literal: &u32, dec_level: &i32) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/cnf_formula.rs:90:40 [INFO] [stderr] | [INFO] [stderr] 90 | else if key == literal { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 91 | | return true; [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/cnf_formula.rs:87:42 [INFO] [stderr] | [INFO] [stderr] 87 | if key == &(literal ^ 1) { [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 88 | | return true; [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/cnf_formula.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / let mut negated = false; [INFO] [stderr] 100 | | if literal & 1 != 0 { [INFO] [stderr] 101 | | negated = true; [INFO] [stderr] 102 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let negated = if literal & 1 != 0 { true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/cnf_formula.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | / let mut negated = false; [INFO] [stderr] 120 | | if literal & 1 != 0 { [INFO] [stderr] 121 | | negated = true; [INFO] [stderr] 122 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let negated = if literal & 1 != 0 { true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cnf_formula.rs:157:50 [INFO] [stderr] | [INFO] [stderr] 157 | pub fn update_partial_clause(partial_clause: &Vec, current_clause: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cnf_formula.rs:157:77 [INFO] [stderr] | [INFO] [stderr] 157 | pub fn update_partial_clause(partial_clause: &Vec, current_clause: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cnf_formula.rs:190:50 [INFO] [stderr] | [INFO] [stderr] 190 | while self.m_assignments.contains_key(&((self.m_variables.get_index(index).unwrap().1.clone() << 1) | 1)) || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.m_variables.get_index(index).unwrap().1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cnf_formula.rs:191:49 [INFO] [stderr] | [INFO] [stderr] 191 | self.m_assignments.contains_key(&(self.m_variables.get_index(index).unwrap().1.clone() << 1)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.m_variables.get_index(index).unwrap().1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/cnf_formula.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | / let polarity; [INFO] [stderr] 208 | | [INFO] [stderr] 209 | | if truthval { [INFO] [stderr] 210 | | polarity = 0; [INFO] [stderr] 211 | | } else { [INFO] [stderr] 212 | | polarity = 1; [INFO] [stderr] 213 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let polarity = if truthval { 0 } else { 1 };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 34 [INFO] [stderr] --> src/cnf_formula.rs:233:5 [INFO] [stderr] | [INFO] [stderr] 233 | / pub fn solve(&mut self) -> bool { [INFO] [stderr] 234 | | // For potential conflict [INFO] [stderr] 235 | | let mut conflict = false; [INFO] [stderr] 236 | | let mut conflict_clause: Vec = Vec::new(); [INFO] [stderr] ... | [INFO] [stderr] 430 | | return true; [INFO] [stderr] 431 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cnf_formula.rs:288:16 [INFO] [stderr] | [INFO] [stderr] 288 | if free_literals.len() == 0 && !currently_sat { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `free_literals.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cnf_formula.rs:319:29 [INFO] [stderr] | [INFO] [stderr] 319 | let p = self.m_decisions.last().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.m_decisions.last().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `conflict_clause`. [INFO] [stderr] --> src/cnf_formula.rs:321:30 [INFO] [stderr] | [INFO] [stderr] 321 | for i in 0..conflict_clause.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 321 | for in &conflict_clause { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cnf_formula.rs:323:25 [INFO] [stderr] | [INFO] [stderr] 323 | / match dec_level { [INFO] [stderr] 324 | | Some(x) => { [INFO] [stderr] 325 | | if x == self.m_decision_level { [INFO] [stderr] 326 | | if conflict_clause[i] != p ^ 1 { [INFO] [stderr] ... | [INFO] [stderr] 332 | | None => {} [INFO] [stderr] 333 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 323 | if let Some(x) = dec_level { [INFO] [stderr] 324 | if x == self.m_decision_level { [INFO] [stderr] 325 | if conflict_clause[i] != p ^ 1 { [INFO] [stderr] 326 | continue; [INFO] [stderr] 327 | } [INFO] [stderr] 328 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cnf_formula.rs:342:21 [INFO] [stderr] | [INFO] [stderr] 342 | / match lit_dec_level { [INFO] [stderr] 343 | | Some(x) => { [INFO] [stderr] 344 | | if x == 0 { [INFO] [stderr] 345 | | a_level = -1; [INFO] [stderr] ... | [INFO] [stderr] 351 | | None => {} [INFO] [stderr] 352 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 342 | if let Some(x) = lit_dec_level { [INFO] [stderr] 343 | if x == 0 { [INFO] [stderr] 344 | a_level = -1; [INFO] [stderr] 345 | } [INFO] [stderr] 346 | else { [INFO] [stderr] 347 | a_level = 0; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cnf_formula.rs:360:25 [INFO] [stderr] | [INFO] [stderr] 360 | / match lit_dec_level { [INFO] [stderr] 361 | | Some(x) => { [INFO] [stderr] 362 | | if x > second_max { [INFO] [stderr] 363 | | if x > max { [INFO] [stderr] ... | [INFO] [stderr] 372 | | None => {} [INFO] [stderr] 373 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 360 | if let Some(x) = lit_dec_level { [INFO] [stderr] 361 | if x > second_max { [INFO] [stderr] 362 | if x > max { [INFO] [stderr] 363 | second_max = max; [INFO] [stderr] 364 | max = x; [INFO] [stderr] 365 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/cnf_formula.rs:410:20 [INFO] [stderr] | [INFO] [stderr] 410 | if value > &a_level { [INFO] [stderr] | ^^^^^^^^-------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `a_level` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:35:29 [INFO] [stderr] | [INFO] [stderr] 35 | if line.starts_with("p") { [INFO] [stderr] | ^^^ help: try using a char instead: `'p'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:46:73 [INFO] [stderr] | [INFO] [stderr] 46 | else if (line.starts_with(char::is_numeric) || line.starts_with("-")) && !line.starts_with("0") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:46:100 [INFO] [stderr] | [INFO] [stderr] 46 | else if (line.starts_with(char::is_numeric) || line.starts_with("-")) && !line.starts_with("0") { [INFO] [stderr] | ^^^ help: try using a char instead: `'0'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusty_sat`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cnf_formula.rs:29:36 [INFO] [stderr] | [INFO] [stderr] 29 | if literal.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cnf_formula.rs:30:31 [INFO] [stderr] | [INFO] [stderr] 30 | literals.push(variables.get(&literal.trim_matches('-').to_owned()).unwrap().clone() << 1 | 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*variables.get(&literal.trim_matches('-').to_owned()).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cnf_formula.rs:32:42 [INFO] [stderr] | [INFO] [stderr] 32 | else if !literal.starts_with("0") { [INFO] [stderr] | ^^^ help: try using a char instead: `'0'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cnf_formula.rs:33:31 [INFO] [stderr] | [INFO] [stderr] 33 | literals.push(variables.get(&literal).unwrap().clone() << 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*variables.get(&literal).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cnf_formula.rs:48:40 [INFO] [stderr] | [INFO] [stderr] 48 | if literal.starts_with("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/cnf_formula.rs:54:46 [INFO] [stderr] | [INFO] [stderr] 54 | else if !literal.starts_with("0") { [INFO] [stderr] | ^^^ help: try using a char instead: `'0'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cnf_formula.rs:72:59 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn assignment_find_decision_level(&self, literal: &u32) -> Option { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cnf_formula.rs:74:25 [INFO] [stderr] | [INFO] [stderr] 74 | return Some(self.m_assignments.get(literal).unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.m_assignments.get(literal).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cnf_formula.rs:77:25 [INFO] [stderr] | [INFO] [stderr] 77 | return Some(self.m_assignments.get(&(literal ^ 1)).unwrap().clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.m_assignments.get(&(literal ^ 1)).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cnf_formula.rs:84:62 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn assignments_find_at_decisionlevel(&self, literal: &u32, dec_level: &i32) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cnf_formula.rs:84:79 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn assignments_find_at_decisionlevel(&self, literal: &u32, dec_level: &i32) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/cnf_formula.rs:90:40 [INFO] [stderr] | [INFO] [stderr] 90 | else if key == literal { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 91 | | return true; [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/cnf_formula.rs:87:42 [INFO] [stderr] | [INFO] [stderr] 87 | if key == &(literal ^ 1) { [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 88 | | return true; [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/cnf_formula.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / let mut negated = false; [INFO] [stderr] 100 | | if literal & 1 != 0 { [INFO] [stderr] 101 | | negated = true; [INFO] [stderr] 102 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let negated = if literal & 1 != 0 { true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/cnf_formula.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | / let mut negated = false; [INFO] [stderr] 120 | | if literal & 1 != 0 { [INFO] [stderr] 121 | | negated = true; [INFO] [stderr] 122 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let negated = if literal & 1 != 0 { true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cnf_formula.rs:157:50 [INFO] [stderr] | [INFO] [stderr] 157 | pub fn update_partial_clause(partial_clause: &Vec, current_clause: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cnf_formula.rs:157:77 [INFO] [stderr] | [INFO] [stderr] 157 | pub fn update_partial_clause(partial_clause: &Vec, current_clause: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cnf_formula.rs:190:50 [INFO] [stderr] | [INFO] [stderr] 190 | while self.m_assignments.contains_key(&((self.m_variables.get_index(index).unwrap().1.clone() << 1) | 1)) || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.m_variables.get_index(index).unwrap().1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cnf_formula.rs:191:49 [INFO] [stderr] | [INFO] [stderr] 191 | self.m_assignments.contains_key(&(self.m_variables.get_index(index).unwrap().1.clone() << 1)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.m_variables.get_index(index).unwrap().1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/cnf_formula.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | / let polarity; [INFO] [stderr] 208 | | [INFO] [stderr] 209 | | if truthval { [INFO] [stderr] 210 | | polarity = 0; [INFO] [stderr] 211 | | } else { [INFO] [stderr] 212 | | polarity = 1; [INFO] [stderr] 213 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let polarity = if truthval { 0 } else { 1 };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 34 [INFO] [stderr] --> src/cnf_formula.rs:233:5 [INFO] [stderr] | [INFO] [stderr] 233 | / pub fn solve(&mut self) -> bool { [INFO] [stderr] 234 | | // For potential conflict [INFO] [stderr] 235 | | let mut conflict = false; [INFO] [stderr] 236 | | let mut conflict_clause: Vec = Vec::new(); [INFO] [stderr] ... | [INFO] [stderr] 430 | | return true; [INFO] [stderr] 431 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cnf_formula.rs:288:16 [INFO] [stderr] | [INFO] [stderr] 288 | if free_literals.len() == 0 && !currently_sat { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `free_literals.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/cnf_formula.rs:319:29 [INFO] [stderr] | [INFO] [stderr] 319 | let p = self.m_decisions.last().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.m_decisions.last().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `conflict_clause`. [INFO] [stderr] --> src/cnf_formula.rs:321:30 [INFO] [stderr] | [INFO] [stderr] 321 | for i in 0..conflict_clause.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 321 | for in &conflict_clause { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cnf_formula.rs:323:25 [INFO] [stderr] | [INFO] [stderr] 323 | / match dec_level { [INFO] [stderr] 324 | | Some(x) => { [INFO] [stderr] 325 | | if x == self.m_decision_level { [INFO] [stderr] 326 | | if conflict_clause[i] != p ^ 1 { [INFO] [stderr] ... | [INFO] [stderr] 332 | | None => {} [INFO] [stderr] 333 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 323 | if let Some(x) = dec_level { [INFO] [stderr] 324 | if x == self.m_decision_level { [INFO] [stderr] 325 | if conflict_clause[i] != p ^ 1 { [INFO] [stderr] 326 | continue; [INFO] [stderr] 327 | } [INFO] [stderr] 328 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cnf_formula.rs:342:21 [INFO] [stderr] | [INFO] [stderr] 342 | / match lit_dec_level { [INFO] [stderr] 343 | | Some(x) => { [INFO] [stderr] 344 | | if x == 0 { [INFO] [stderr] 345 | | a_level = -1; [INFO] [stderr] ... | [INFO] [stderr] 351 | | None => {} [INFO] [stderr] 352 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 342 | if let Some(x) = lit_dec_level { [INFO] [stderr] 343 | if x == 0 { [INFO] [stderr] 344 | a_level = -1; [INFO] [stderr] 345 | } [INFO] [stderr] 346 | else { [INFO] [stderr] 347 | a_level = 0; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cnf_formula.rs:360:25 [INFO] [stderr] | [INFO] [stderr] 360 | / match lit_dec_level { [INFO] [stderr] 361 | | Some(x) => { [INFO] [stderr] 362 | | if x > second_max { [INFO] [stderr] 363 | | if x > max { [INFO] [stderr] ... | [INFO] [stderr] 372 | | None => {} [INFO] [stderr] 373 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 360 | if let Some(x) = lit_dec_level { [INFO] [stderr] 361 | if x > second_max { [INFO] [stderr] 362 | if x > max { [INFO] [stderr] 363 | second_max = max; [INFO] [stderr] 364 | max = x; [INFO] [stderr] 365 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/cnf_formula.rs:410:20 [INFO] [stderr] | [INFO] [stderr] 410 | if value > &a_level { [INFO] [stderr] | ^^^^^^^^-------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `a_level` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:35:29 [INFO] [stderr] | [INFO] [stderr] 35 | if line.starts_with("p") { [INFO] [stderr] | ^^^ help: try using a char instead: `'p'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:46:73 [INFO] [stderr] | [INFO] [stderr] 46 | else if (line.starts_with(char::is_numeric) || line.starts_with("-")) && !line.starts_with("0") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:46:100 [INFO] [stderr] | [INFO] [stderr] 46 | else if (line.starts_with(char::is_numeric) || line.starts_with("-")) && !line.starts_with("0") { [INFO] [stderr] | ^^^ help: try using a char instead: `'0'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rusty_sat`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "895565b3d727af71630078204a83ae0e88248126e2d98f0023f5be0ff7b9490d"` [INFO] running `"docker" "rm" "-f" "895565b3d727af71630078204a83ae0e88248126e2d98f0023f5be0ff7b9490d"` [INFO] [stdout] 895565b3d727af71630078204a83ae0e88248126e2d98f0023f5be0ff7b9490d