[INFO] updating cached repository Qwertyman95/Hack-Assembler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Qwertyman95/Hack-Assembler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Qwertyman95/Hack-Assembler" "work/ex/clippy-test-run/sources/stable/gh/Qwertyman95/Hack-Assembler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Qwertyman95/Hack-Assembler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Qwertyman95/Hack-Assembler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Qwertyman95/Hack-Assembler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Qwertyman95/Hack-Assembler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d1bca3e3644ae4529233926d544fece7fe66f740 [INFO] sha for GitHub repo Qwertyman95/Hack-Assembler: d1bca3e3644ae4529233926d544fece7fe66f740 [INFO] validating manifest of Qwertyman95/Hack-Assembler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Qwertyman95/Hack-Assembler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Qwertyman95/Hack-Assembler [INFO] finished frobbing Qwertyman95/Hack-Assembler [INFO] frobbed toml for Qwertyman95/Hack-Assembler written to work/ex/clippy-test-run/sources/stable/gh/Qwertyman95/Hack-Assembler/Cargo.toml [INFO] started frobbing Qwertyman95/Hack-Assembler [INFO] finished frobbing Qwertyman95/Hack-Assembler [INFO] frobbed toml for Qwertyman95/Hack-Assembler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Qwertyman95/Hack-Assembler/Cargo.toml [INFO] crate Qwertyman95/Hack-Assembler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Qwertyman95/Hack-Assembler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Qwertyman95/Hack-Assembler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 866b7ca6d5ad97b8a1877030d79bfb403a5161411e5f13cd3bc8da6aa3801fbd [INFO] running `"docker" "start" "-a" "866b7ca6d5ad97b8a1877030d79bfb403a5161411e5f13cd3bc8da6aa3801fbd"` [INFO] [stderr] Checking assembler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:107:69 [INFO] [stderr] | [INFO] [stderr] 107 | parsed_instructions.push(ParsedLine::AInstruction { address_value: address_value }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `address_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:107:69 [INFO] [stderr] | [INFO] [stderr] 107 | parsed_instructions.push(ParsedLine::AInstruction { address_value: address_value }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `address_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:18:28 [INFO] [stderr] | [INFO] [stderr] 18 | const PREDEFINED_SYMBOLS: &'static [(&'static str, i16)] = &[("SP", 0), [INFO] [stderr] | -^^^^^^^---------------------- help: consider removing `'static`: `&[(&'static str, i16)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:18:39 [INFO] [stderr] | [INFO] [stderr] 18 | const PREDEFINED_SYMBOLS: &'static [(&'static str, i16)] = &[("SP", 0), [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:42:47 [INFO] [stderr] | [INFO] [stderr] 42 | const C_INSTRUCTION_DESTINATION_REGEX_CLASS: &'static str = r#"(?:AMD|MD|AM|AD|M|D|A)"#; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:43:45 [INFO] [stderr] | [INFO] [stderr] 43 | const C_INSTRUCTION_OPERATION_REGEX_CLASS: &'static str = r#"A\+1|D\+1|D-1|A-1|D\+A|D-A|A-D|D&A|D\|A|M\+1|M-1|D\+M|D-M|M-D|D&M|D\|M|!M|-1|-M|!D|!A|-D|-A|0|1|M|D|A"#; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:44:34 [INFO] [stderr] | [INFO] [stderr] 44 | const C_INSTRUCTION_JUMP_CLASS: &'static str = r#"(?:JGT|JEQ|JGE|JLT|JNE|JLE|JMP)"#; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:45:33 [INFO] [stderr] | [INFO] [stderr] 45 | const IDENTIFIER_REGEX_STRING: &'static str = r#"(?:[:alpha:]|[_.&:\$])(?:[:alpha:]|[0-9]|[_.&:\$])*"#; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `PREDEFINED_SYMBOLS`. [INFO] [stderr] --> src/main.rs:65:14 [INFO] [stderr] | [INFO] [stderr] 65 | for i in 0..PREDEFINED_SYMBOLS.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 65 | for in &PREDEFINED_SYMBOLS { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:92:42 [INFO] [stderr] | [INFO] [stderr] 92 | let line_iterator = asm_string.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | / match parsed_instruction { [INFO] [stderr] 127 | | &ParsedLine::AInstruction { address_value: AddressValue::Immediate { ref value } } => { [INFO] [stderr] 128 | | writeln!(output_file, "0{:0>15b}", value); [INFO] [stderr] 129 | | } [INFO] [stderr] ... | [INFO] [stderr] 153 | | } [INFO] [stderr] 154 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 126 | match *parsed_instruction { [INFO] [stderr] 127 | ParsedLine::AInstruction { address_value: AddressValue::Immediate { ref value } } => { [INFO] [stderr] 128 | writeln!(output_file, "0{:0>15b}", value); [INFO] [stderr] 129 | } [INFO] [stderr] 130 | ParsedLine::AInstruction { address_value: AddressValue::Symbol { ref identifier } } => { [INFO] [stderr] 131 | if !symbol_map.contains_key(identifier) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | writeln!(output_file, "0{:0>15b}", value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:136:37 [INFO] [stderr] | [INFO] [stderr] 136 | let address_value = symbol_map.get(identifier).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&symbol_map[identifier]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | writeln!(output_file, "0{:0>15b}", address_value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | / writeln!(output_file, "111{}{}{}", [INFO] [stderr] 141 | | operation.get_machine_code_string(), [INFO] [stderr] 142 | | destination.get_machine_code_string(), [INFO] [stderr] 143 | | jump.get_machine_code_string()); [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | / match self { [INFO] [stderr] 238 | | &Destination::M => "001", [INFO] [stderr] 239 | | &Destination::D => "010", [INFO] [stderr] 240 | | &Destination::MD => "011", [INFO] [stderr] ... | [INFO] [stderr] 245 | | &Destination::None => "000", [INFO] [stderr] 246 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 237 | match *self { [INFO] [stderr] 238 | Destination::M => "001", [INFO] [stderr] 239 | Destination::D => "010", [INFO] [stderr] 240 | Destination::MD => "011", [INFO] [stderr] 241 | Destination::A => "100", [INFO] [stderr] 242 | Destination::AM => "101", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:282:9 [INFO] [stderr] | [INFO] [stderr] 282 | / match self { [INFO] [stderr] 283 | | &JumpCondition::JGT => "001", [INFO] [stderr] 284 | | &JumpCondition::JEQ => "010", [INFO] [stderr] 285 | | &JumpCondition::JGE => "011", [INFO] [stderr] ... | [INFO] [stderr] 290 | | &JumpCondition::None => "000", [INFO] [stderr] 291 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 282 | match *self { [INFO] [stderr] 283 | JumpCondition::JGT => "001", [INFO] [stderr] 284 | JumpCondition::JEQ => "010", [INFO] [stderr] 285 | JumpCondition::JGE => "011", [INFO] [stderr] 286 | JumpCondition::JLT => "100", [INFO] [stderr] 287 | JumpCondition::JNE => "101", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:386:9 [INFO] [stderr] | [INFO] [stderr] 386 | / match self { [INFO] [stderr] 387 | | &Operation::Zero => "0101010", [INFO] [stderr] 388 | | &Operation::One => "0111111", [INFO] [stderr] 389 | | &Operation::NegativeOne => "0111010", [INFO] [stderr] ... | [INFO] [stderr] 414 | | &Operation::DOrM => "1010101", [INFO] [stderr] 415 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 386 | match *self { [INFO] [stderr] 387 | Operation::Zero => "0101010", [INFO] [stderr] 388 | Operation::One => "0111111", [INFO] [stderr] 389 | Operation::NegativeOne => "0111010", [INFO] [stderr] 390 | Operation::D => "0001100", [INFO] [stderr] 391 | Operation::A => "0110000", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:18:28 [INFO] [stderr] | [INFO] [stderr] 18 | const PREDEFINED_SYMBOLS: &'static [(&'static str, i16)] = &[("SP", 0), [INFO] [stderr] | -^^^^^^^---------------------- help: consider removing `'static`: `&[(&'static str, i16)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:18:39 [INFO] [stderr] | [INFO] [stderr] 18 | const PREDEFINED_SYMBOLS: &'static [(&'static str, i16)] = &[("SP", 0), [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:42:47 [INFO] [stderr] | [INFO] [stderr] 42 | const C_INSTRUCTION_DESTINATION_REGEX_CLASS: &'static str = r#"(?:AMD|MD|AM|AD|M|D|A)"#; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:43:45 [INFO] [stderr] | [INFO] [stderr] 43 | const C_INSTRUCTION_OPERATION_REGEX_CLASS: &'static str = r#"A\+1|D\+1|D-1|A-1|D\+A|D-A|A-D|D&A|D\|A|M\+1|M-1|D\+M|D-M|M-D|D&M|D\|M|!M|-1|-M|!D|!A|-D|-A|0|1|M|D|A"#; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:44:34 [INFO] [stderr] | [INFO] [stderr] 44 | const C_INSTRUCTION_JUMP_CLASS: &'static str = r#"(?:JGT|JEQ|JGE|JLT|JNE|JLE|JMP)"#; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:45:33 [INFO] [stderr] | [INFO] [stderr] 45 | const IDENTIFIER_REGEX_STRING: &'static str = r#"(?:[:alpha:]|[_.&:\$])(?:[:alpha:]|[0-9]|[_.&:\$])*"#; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `PREDEFINED_SYMBOLS`. [INFO] [stderr] --> src/main.rs:65:14 [INFO] [stderr] | [INFO] [stderr] 65 | for i in 0..PREDEFINED_SYMBOLS.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 65 | for in &PREDEFINED_SYMBOLS { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:92:42 [INFO] [stderr] | [INFO] [stderr] 92 | let line_iterator = asm_string.split("\n"); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | / match parsed_instruction { [INFO] [stderr] 127 | | &ParsedLine::AInstruction { address_value: AddressValue::Immediate { ref value } } => { [INFO] [stderr] 128 | | writeln!(output_file, "0{:0>15b}", value); [INFO] [stderr] 129 | | } [INFO] [stderr] ... | [INFO] [stderr] 153 | | } [INFO] [stderr] 154 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 126 | match *parsed_instruction { [INFO] [stderr] 127 | ParsedLine::AInstruction { address_value: AddressValue::Immediate { ref value } } => { [INFO] [stderr] 128 | writeln!(output_file, "0{:0>15b}", value); [INFO] [stderr] 129 | } [INFO] [stderr] 130 | ParsedLine::AInstruction { address_value: AddressValue::Symbol { ref identifier } } => { [INFO] [stderr] 131 | if !symbol_map.contains_key(identifier) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | writeln!(output_file, "0{:0>15b}", value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:136:37 [INFO] [stderr] | [INFO] [stderr] 136 | let address_value = symbol_map.get(identifier).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&symbol_map[identifier]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | writeln!(output_file, "0{:0>15b}", address_value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | / writeln!(output_file, "111{}{}{}", [INFO] [stderr] 141 | | operation.get_machine_code_string(), [INFO] [stderr] 142 | | destination.get_machine_code_string(), [INFO] [stderr] 143 | | jump.get_machine_code_string()); [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | / match self { [INFO] [stderr] 238 | | &Destination::M => "001", [INFO] [stderr] 239 | | &Destination::D => "010", [INFO] [stderr] 240 | | &Destination::MD => "011", [INFO] [stderr] ... | [INFO] [stderr] 245 | | &Destination::None => "000", [INFO] [stderr] 246 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 237 | match *self { [INFO] [stderr] 238 | Destination::M => "001", [INFO] [stderr] 239 | Destination::D => "010", [INFO] [stderr] 240 | Destination::MD => "011", [INFO] [stderr] 241 | Destination::A => "100", [INFO] [stderr] 242 | Destination::AM => "101", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:282:9 [INFO] [stderr] | [INFO] [stderr] 282 | / match self { [INFO] [stderr] 283 | | &JumpCondition::JGT => "001", [INFO] [stderr] 284 | | &JumpCondition::JEQ => "010", [INFO] [stderr] 285 | | &JumpCondition::JGE => "011", [INFO] [stderr] ... | [INFO] [stderr] 290 | | &JumpCondition::None => "000", [INFO] [stderr] 291 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 282 | match *self { [INFO] [stderr] 283 | JumpCondition::JGT => "001", [INFO] [stderr] 284 | JumpCondition::JEQ => "010", [INFO] [stderr] 285 | JumpCondition::JGE => "011", [INFO] [stderr] 286 | JumpCondition::JLT => "100", [INFO] [stderr] 287 | JumpCondition::JNE => "101", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:386:9 [INFO] [stderr] | [INFO] [stderr] 386 | / match self { [INFO] [stderr] 387 | | &Operation::Zero => "0101010", [INFO] [stderr] 388 | | &Operation::One => "0111111", [INFO] [stderr] 389 | | &Operation::NegativeOne => "0111010", [INFO] [stderr] ... | [INFO] [stderr] 414 | | &Operation::DOrM => "1010101", [INFO] [stderr] 415 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 386 | match *self { [INFO] [stderr] 387 | Operation::Zero => "0101010", [INFO] [stderr] 388 | Operation::One => "0111111", [INFO] [stderr] 389 | Operation::NegativeOne => "0111010", [INFO] [stderr] 390 | Operation::D => "0001100", [INFO] [stderr] 391 | Operation::A => "0110000", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.75s [INFO] running `"docker" "inspect" "866b7ca6d5ad97b8a1877030d79bfb403a5161411e5f13cd3bc8da6aa3801fbd"` [INFO] running `"docker" "rm" "-f" "866b7ca6d5ad97b8a1877030d79bfb403a5161411e5f13cd3bc8da6aa3801fbd"` [INFO] [stdout] 866b7ca6d5ad97b8a1877030d79bfb403a5161411e5f13cd3bc8da6aa3801fbd