[INFO] updating cached repository Quinas/AC8I-rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Quinas/AC8I-rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Quinas/AC8I-rust" "work/ex/clippy-test-run/sources/stable/gh/Quinas/AC8I-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Quinas/AC8I-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Quinas/AC8I-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Quinas/AC8I-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Quinas/AC8I-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e310919e0b4d4c7726cdf4df61ff49d417f1a779
[INFO] sha for GitHub repo Quinas/AC8I-rust: e310919e0b4d4c7726cdf4df61ff49d417f1a779
[INFO] validating manifest of Quinas/AC8I-rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Quinas/AC8I-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Quinas/AC8I-rust
[INFO] finished frobbing Quinas/AC8I-rust
[INFO] frobbed toml for Quinas/AC8I-rust written to work/ex/clippy-test-run/sources/stable/gh/Quinas/AC8I-rust/Cargo.toml
[INFO] started frobbing Quinas/AC8I-rust
[INFO] finished frobbing Quinas/AC8I-rust
[INFO] frobbed toml for Quinas/AC8I-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Quinas/AC8I-rust/Cargo.toml
[INFO] crate Quinas/AC8I-rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Quinas/AC8I-rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Quinas/AC8I-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6a973379ba3a4f720b566cead1a1b3bc52c3856aa10c09d9116344c7ae51fb82
[INFO] running `"docker" "start" "-a" "6a973379ba3a4f720b566cead1a1b3bc52c3856aa10c09d9116344c7ae51fb82"`
[INFO] [stderr]     Blocking waiting for file lock on the registry index
[INFO] [stderr]     Checking shared_library v0.1.9
[INFO] [stderr]     Checking gfx_core v0.8.2
[INFO] [stderr]    Compiling gfx_gl v0.5.0
[INFO] [stderr]     Checking wayland-sys v0.12.5
[INFO] [stderr]     Checking pistoncore-input v0.21.0
[INFO] [stderr]     Checking osmesa-sys v0.1.2
[INFO] [stderr]     Checking wayland-client v0.12.5
[INFO] [stderr]     Checking wayland-protocols v0.12.5
[INFO] [stderr]     Checking wayland-kbd v0.13.1
[INFO] [stderr]     Checking pistoncore-window v0.32.0
[INFO] [stderr]     Checking pistoncore-event_loop v0.37.0
[INFO] [stderr]     Checking wayland-window v0.13.3
[INFO] [stderr]     Checking piston v0.37.0
[INFO] [stderr]     Checking winit v0.12.0
[INFO] [stderr]     Checking glutin v0.14.0
[INFO] [stderr]     Checking pistoncore-glutin_window v0.47.0
[INFO] [stderr]     Checking gfx v0.17.1
[INFO] [stderr]     Checking gfx_device_gl v0.15.3
[INFO] [stderr]     Checking piston-gfx_texture v0.32.0
[INFO] [stderr]     Checking piston2d-gfx_graphics v0.51.0
[INFO] [stderr]     Checking piston_window v0.80.0
[INFO] [stderr]     Checking chip8_int v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `chip::Chip8`
[INFO] [stderr]   --> src/chip.rs:43:3
[INFO] [stderr]    |
[INFO] [stderr] 43 | /   pub fn new() -> Chip8 {
[INFO] [stderr] 44 | |     let mut chip = Chip8 {
[INFO] [stderr] 45 | |       memory: [0; 4096],
[INFO] [stderr] 46 | |       v: [0; 16],
[INFO] [stderr] ...  |
[INFO] [stderr] 59 | |     chip
[INFO] [stderr] 60 | |   }
[INFO] [stderr]    | |___^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 42 | impl Default for chip::Chip8 {
[INFO] [stderr] 43 |     fn default() -> Self {
[INFO] [stderr] 44 |         Self::new()
[INFO] [stderr] 45 |     }
[INFO] [stderr] 46 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip.rs:159:34
[INFO] [stderr]     |
[INFO] [stderr] 159 |           self.v[vx as usize] = (self.v[vx as usize] as u16 + byte as u16) as u8;
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[vx as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip.rs:159:63
[INFO] [stderr]     |
[INFO] [stderr] 159 |           self.v[vx as usize] = (self.v[vx as usize] as u16 + byte as u16) as u8;
[INFO] [stderr]     |                                                               ^^^^^^^^^^^ help: try: `u16::from(byte)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip.rs:179:21
[INFO] [stderr]     |
[INFO] [stderr] 179 |           let sum = self.v[vy as usize] as u16 + self.v[vx as usize] as u16;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[vy as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip.rs:179:50
[INFO] [stderr]     |
[INFO] [stderr] 179 |           let sum = self.v[vy as usize] as u16 + self.v[vx as usize] as u16;
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[vx as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip.rs:224:47
[INFO] [stderr]     |
[INFO] [stderr] 224 |         OpCode::JP2(addr) => self.pc = addr + self.v[0] as u16,
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip.rs:239:50
[INFO] [stderr]     |
[INFO] [stderr] 239 |             let line = self.memory[(self.index + y as u16) as usize];
[INFO] [stderr]     |                                                  ^^^^^^^^ help: try: `u16::from(y)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/chip.rs:245:20
[INFO] [stderr]     |
[INFO] [stderr] 245 |                 if self.display[(x0 + x) as usize][(y0 + y) as usize] == true {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.display[(x0 + x) as usize][(y0 + y) as usize]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip.rs:285:25
[INFO] [stderr]     |
[INFO] [stderr] 285 |           self.index += self.v[vx as usize] as u16;
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[vx as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip.rs:289:24
[INFO] [stderr]     |
[INFO] [stderr] 289 |           self.index = (self.v[vx as usize] as u16) * 5;
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[vx as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/chip.rs:299:22
[INFO] [stderr]     |
[INFO] [stderr] 299 |           for ind in 0..vx + 1 {
[INFO] [stderr]     |                      ^^^^^^^^^ help: use: `0..=vx`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip.rs:300:39
[INFO] [stderr]     |
[INFO] [stderr] 300 |             self.memory[(self.index + ind as u16) as usize] = self.v[ind as usize];
[INFO] [stderr]     |                                       ^^^^^^^^^^ help: try: `u16::from(ind)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/chip.rs:305:22
[INFO] [stderr]     |
[INFO] [stderr] 305 |           for ind in 0..vx + 1 {
[INFO] [stderr]     |                      ^^^^^^^^^ help: use: `0..=vx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip.rs:306:62
[INFO] [stderr]     |
[INFO] [stderr] 306 |             self.v[ind as usize] = self.memory[(self.index + ind as u16) as usize];
[INFO] [stderr]     |                                                              ^^^^^^^^^^ help: try: `u16::from(ind)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/instruction.rs:58:2
[INFO] [stderr]    |
[INFO] [stderr] 58 |     (chip.memory[chip.pc as usize] as u16) << 8 | (chip.memory[chip.pc as usize + 1] as u16)
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(chip.memory[chip.pc as usize])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/instruction.rs:58:48
[INFO] [stderr]    |
[INFO] [stderr] 58 |     (chip.memory[chip.pc as usize] as u16) << 8 | (chip.memory[chip.pc as usize + 1] as u16)
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(chip.memory[chip.pc as usize + 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `system::System`
[INFO] [stderr]   --> src/system.rs:54:3
[INFO] [stderr]    |
[INFO] [stderr] 54 | /   pub fn new() -> System {
[INFO] [stderr] 55 | |     System {
[INFO] [stderr] 56 | |       chip: Chip8::new(),
[INFO] [stderr] 57 | |       app: App {
[INFO] [stderr] ...  |
[INFO] [stderr] 63 | |     }
[INFO] [stderr] 64 | |   }
[INFO] [stderr]    | |___^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 53 | impl Default for system::System {
[INFO] [stderr] 54 |     fn default() -> Self {
[INFO] [stderr] 55 |         Self::new()
[INFO] [stderr] 56 |     }
[INFO] [stderr] 57 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/system.rs:95:19
[INFO] [stderr]    |
[INFO] [stderr] 95 |                   (x * SIZE) as f64,
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^ help: try: `f64::from(x * SIZE)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/system.rs:96:19
[INFO] [stderr]    |
[INFO] [stderr] 96 |                   (y * SIZE) as f64,
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^ help: try: `f64::from(y * SIZE)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/system.rs:97:19
[INFO] [stderr]    |
[INFO] [stderr] 97 |                   SIZE as f64,
[INFO] [stderr]    |                   ^^^^^^^^^^^ help: try: `f64::from(SIZE)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/system.rs:98:19
[INFO] [stderr]    |
[INFO] [stderr] 98 |                   SIZE as f64,
[INFO] [stderr]    |                   ^^^^^^^^^^^ help: try: `f64::from(SIZE)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `chip::Chip8`
[INFO] [stderr]   --> src/chip.rs:43:3
[INFO] [stderr]    |
[INFO] [stderr] 43 | /   pub fn new() -> Chip8 {
[INFO] [stderr] 44 | |     let mut chip = Chip8 {
[INFO] [stderr] 45 | |       memory: [0; 4096],
[INFO] [stderr] 46 | |       v: [0; 16],
[INFO] [stderr] ...  |
[INFO] [stderr] 59 | |     chip
[INFO] [stderr] 60 | |   }
[INFO] [stderr]    | |___^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 42 | impl Default for chip::Chip8 {
[INFO] [stderr] 43 |     fn default() -> Self {
[INFO] [stderr] 44 |         Self::new()
[INFO] [stderr] 45 |     }
[INFO] [stderr] 46 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip.rs:159:34
[INFO] [stderr]     |
[INFO] [stderr] 159 |           self.v[vx as usize] = (self.v[vx as usize] as u16 + byte as u16) as u8;
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[vx as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip.rs:159:63
[INFO] [stderr]     |
[INFO] [stderr] 159 |           self.v[vx as usize] = (self.v[vx as usize] as u16 + byte as u16) as u8;
[INFO] [stderr]     |                                                               ^^^^^^^^^^^ help: try: `u16::from(byte)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip.rs:179:21
[INFO] [stderr]     |
[INFO] [stderr] 179 |           let sum = self.v[vy as usize] as u16 + self.v[vx as usize] as u16;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[vy as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip.rs:179:50
[INFO] [stderr]     |
[INFO] [stderr] 179 |           let sum = self.v[vy as usize] as u16 + self.v[vx as usize] as u16;
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[vx as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip.rs:224:47
[INFO] [stderr]     |
[INFO] [stderr] 224 |         OpCode::JP2(addr) => self.pc = addr + self.v[0] as u16,
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip.rs:239:50
[INFO] [stderr]     |
[INFO] [stderr] 239 |             let line = self.memory[(self.index + y as u16) as usize];
[INFO] [stderr]     |                                                  ^^^^^^^^ help: try: `u16::from(y)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]    --> src/chip.rs:245:20
[INFO] [stderr]     |
[INFO] [stderr] 245 |                 if self.display[(x0 + x) as usize][(y0 + y) as usize] == true {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.display[(x0 + x) as usize][(y0 + y) as usize]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip.rs:285:25
[INFO] [stderr]     |
[INFO] [stderr] 285 |           self.index += self.v[vx as usize] as u16;
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[vx as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip.rs:289:24
[INFO] [stderr]     |
[INFO] [stderr] 289 |           self.index = (self.v[vx as usize] as u16) * 5;
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[vx as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/chip.rs:299:22
[INFO] [stderr]     |
[INFO] [stderr] 299 |           for ind in 0..vx + 1 {
[INFO] [stderr]     |                      ^^^^^^^^^ help: use: `0..=vx`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip.rs:300:39
[INFO] [stderr]     |
[INFO] [stderr] 300 |             self.memory[(self.index + ind as u16) as usize] = self.v[ind as usize];
[INFO] [stderr]     |                                       ^^^^^^^^^^ help: try: `u16::from(ind)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/chip.rs:305:22
[INFO] [stderr]     |
[INFO] [stderr] 305 |           for ind in 0..vx + 1 {
[INFO] [stderr]     |                      ^^^^^^^^^ help: use: `0..=vx`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip.rs:306:62
[INFO] [stderr]     |
[INFO] [stderr] 306 |             self.v[ind as usize] = self.memory[(self.index + ind as u16) as usize];
[INFO] [stderr]     |                                                              ^^^^^^^^^^ help: try: `u16::from(ind)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/instruction.rs:58:2
[INFO] [stderr]    |
[INFO] [stderr] 58 |     (chip.memory[chip.pc as usize] as u16) << 8 | (chip.memory[chip.pc as usize + 1] as u16)
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(chip.memory[chip.pc as usize])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/instruction.rs:58:48
[INFO] [stderr]    |
[INFO] [stderr] 58 |     (chip.memory[chip.pc as usize] as u16) << 8 | (chip.memory[chip.pc as usize + 1] as u16)
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(chip.memory[chip.pc as usize + 1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `system::System`
[INFO] [stderr]   --> src/system.rs:54:3
[INFO] [stderr]    |
[INFO] [stderr] 54 | /   pub fn new() -> System {
[INFO] [stderr] 55 | |     System {
[INFO] [stderr] 56 | |       chip: Chip8::new(),
[INFO] [stderr] 57 | |       app: App {
[INFO] [stderr] ...  |
[INFO] [stderr] 63 | |     }
[INFO] [stderr] 64 | |   }
[INFO] [stderr]    | |___^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 53 | impl Default for system::System {
[INFO] [stderr] 54 |     fn default() -> Self {
[INFO] [stderr] 55 |         Self::new()
[INFO] [stderr] 56 |     }
[INFO] [stderr] 57 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/system.rs:95:19
[INFO] [stderr]    |
[INFO] [stderr] 95 |                   (x * SIZE) as f64,
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^ help: try: `f64::from(x * SIZE)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/system.rs:96:19
[INFO] [stderr]    |
[INFO] [stderr] 96 |                   (y * SIZE) as f64,
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^ help: try: `f64::from(y * SIZE)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/system.rs:97:19
[INFO] [stderr]    |
[INFO] [stderr] 97 |                   SIZE as f64,
[INFO] [stderr]    |                   ^^^^^^^^^^^ help: try: `f64::from(SIZE)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/system.rs:98:19
[INFO] [stderr]    |
[INFO] [stderr] 98 |                   SIZE as f64,
[INFO] [stderr]    |                   ^^^^^^^^^^^ help: try: `f64::from(SIZE)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 03s
[INFO] running `"docker" "inspect" "6a973379ba3a4f720b566cead1a1b3bc52c3856aa10c09d9116344c7ae51fb82"`
[INFO] running `"docker" "rm" "-f" "6a973379ba3a4f720b566cead1a1b3bc52c3856aa10c09d9116344c7ae51fb82"`
[INFO] [stdout] 6a973379ba3a4f720b566cead1a1b3bc52c3856aa10c09d9116344c7ae51fb82