[INFO] updating cached repository QuietMisdreavus/crystal-rustdoc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/QuietMisdreavus/crystal-rustdoc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/QuietMisdreavus/crystal-rustdoc" "work/ex/clippy-test-run/sources/stable/gh/QuietMisdreavus/crystal-rustdoc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/QuietMisdreavus/crystal-rustdoc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/QuietMisdreavus/crystal-rustdoc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/QuietMisdreavus/crystal-rustdoc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/QuietMisdreavus/crystal-rustdoc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6c5bb2d874f679d09d00acb9fcc148dd6673048f [INFO] sha for GitHub repo QuietMisdreavus/crystal-rustdoc: 6c5bb2d874f679d09d00acb9fcc148dd6673048f [INFO] validating manifest of QuietMisdreavus/crystal-rustdoc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of QuietMisdreavus/crystal-rustdoc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing QuietMisdreavus/crystal-rustdoc [INFO] finished frobbing QuietMisdreavus/crystal-rustdoc [INFO] frobbed toml for QuietMisdreavus/crystal-rustdoc written to work/ex/clippy-test-run/sources/stable/gh/QuietMisdreavus/crystal-rustdoc/Cargo.toml [INFO] started frobbing QuietMisdreavus/crystal-rustdoc [INFO] finished frobbing QuietMisdreavus/crystal-rustdoc [INFO] frobbed toml for QuietMisdreavus/crystal-rustdoc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/QuietMisdreavus/crystal-rustdoc/Cargo.toml [INFO] crate QuietMisdreavus/crystal-rustdoc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting QuietMisdreavus/crystal-rustdoc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/QuietMisdreavus/crystal-rustdoc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8fccbb6102258ddfe8108aa2df22cb308b606c8f421361fb0bee0fc6fd80cb01 [INFO] running `"docker" "start" "-a" "8fccbb6102258ddfe8108aa2df22cb308b606c8f421361fb0bee0fc6fd80cb01"` [INFO] [stderr] Checking syn v0.11.11 [INFO] [stderr] Checking rustdoc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:11:14 [INFO] [stderr] | [INFO] [stderr] 11 | const ROOT: &'static str = concat!(env!("CARGO_MANIFEST_DIR"), "/example"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:11:14 [INFO] [stderr] | [INFO] [stderr] 11 | const ROOT: &'static str = concat!(env!("CARGO_MANIFEST_DIR"), "/example"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / if let &NameValue(ref name, Lit::Str(ref text, _)) = &att.value { [INFO] [stderr] 27 | | if name == "doc" { [INFO] [stderr] 28 | | if !ret.is_empty() { [INFO] [stderr] 29 | | ret.push('\n'); [INFO] [stderr] ... | [INFO] [stderr] 41 | | } [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 26 | if let NameValue(ref name, Lit::Str(ref text, _)) = att.value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / if let &NameValue(ref name, Lit::Str(ref text, _)) = &att.value { [INFO] [stderr] 27 | | if name == "doc" { [INFO] [stderr] 28 | | if !ret.is_empty() { [INFO] [stderr] 29 | | ret.push('\n'); [INFO] [stderr] ... | [INFO] [stderr] 41 | | } [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 26 | if let NameValue(ref name, Lit::Str(ref text, _)) = att.value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.64s [INFO] running `"docker" "inspect" "8fccbb6102258ddfe8108aa2df22cb308b606c8f421361fb0bee0fc6fd80cb01"` [INFO] running `"docker" "rm" "-f" "8fccbb6102258ddfe8108aa2df22cb308b606c8f421361fb0bee0fc6fd80cb01"` [INFO] [stdout] 8fccbb6102258ddfe8108aa2df22cb308b606c8f421361fb0bee0fc6fd80cb01