[INFO] updating cached repository Quantum238/rlox [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Quantum238/rlox [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Quantum238/rlox" "work/ex/clippy-test-run/sources/stable/gh/Quantum238/rlox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Quantum238/rlox'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Quantum238/rlox" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Quantum238/rlox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Quantum238/rlox'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fd28cafd8876e7f18a89f95a7d5df58284bbda5e [INFO] sha for GitHub repo Quantum238/rlox: fd28cafd8876e7f18a89f95a7d5df58284bbda5e [INFO] validating manifest of Quantum238/rlox on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Quantum238/rlox on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Quantum238/rlox [INFO] finished frobbing Quantum238/rlox [INFO] frobbed toml for Quantum238/rlox written to work/ex/clippy-test-run/sources/stable/gh/Quantum238/rlox/Cargo.toml [INFO] started frobbing Quantum238/rlox [INFO] finished frobbing Quantum238/rlox [INFO] frobbed toml for Quantum238/rlox written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Quantum238/rlox/Cargo.toml [INFO] crate Quantum238/rlox has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Quantum238/rlox against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Quantum238/rlox:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6900bd5e64113b1dce04a0e853c81e5f264d021d98aec3c3dcab39dad5b18312 [INFO] running `"docker" "start" "-a" "6900bd5e64113b1dce04a0e853c81e5f264d021d98aec3c3dcab39dad5b18312"` [INFO] [stderr] Checking rlox v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/debug.rs:35:2 [INFO] [stderr] | [INFO] [stderr] 35 | print!("{:?}\n", name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/debug.rs:44:3 [INFO] [stderr] | [INFO] [stderr] 44 | print!("'\n"); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/vm.rs:55:6 [INFO] [stderr] | [INFO] [stderr] 55 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vm.rs:68:4 [INFO] [stderr] | [INFO] [stderr] 68 | chunk: chunk, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chunk` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/debug.rs:35:2 [INFO] [stderr] | [INFO] [stderr] 35 | print!("{:?}\n", name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/debug.rs:44:3 [INFO] [stderr] | [INFO] [stderr] 44 | print!("'\n"); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/vm.rs:55:6 [INFO] [stderr] | [INFO] [stderr] 55 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vm.rs:68:4 [INFO] [stderr] | [INFO] [stderr] 68 | chunk: chunk, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chunk` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/value.rs:17:50 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn writeValueArray(&mut self, value: Value) -> (){ [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused import: `debug::*` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use debug::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `value::*` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use value::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/value.rs:17:50 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn writeValueArray(&mut self, value: Value) -> (){ [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused import: `debug::*` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use debug::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `value::*` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use value::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `freeChunk` [INFO] [stderr] --> src/chunk.rs:40:2 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn freeChunk(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `disassembleChunk` [INFO] [stderr] --> src/debug.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn disassembleChunk(chunk: &Chunk, name: &str){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `freeValueArray` [INFO] [stderr] --> src/value.rs:21:2 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn freeValueArray(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `INTERPRET_RUNTIME_ERROR` [INFO] [stderr] --> src/vm.rs:16:2 [INFO] [stderr] | [INFO] [stderr] 16 | INTERPRET_RUNTIME_ERROR, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/debug.rs:23:6 [INFO] [stderr] | [INFO] [stderr] 23 | let ref instruction = chunk.code[offset]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^---------------------- help: try: `let instruction = &chunk.code[offset];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/debug.rs:40:6 [INFO] [stderr] | [INFO] [stderr] 40 | let ref constant: OpCode = chunk.code[offset + 1]; [INFO] [stderr] | ----^^^^^^^^^^^^---------------------------------- help: try: `let constant: &OpCode = &chunk.code[offset + 1];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/vm.rs:43:3 [INFO] [stderr] | [INFO] [stderr] 43 | loop { [INFO] [stderr] | _________^ [INFO] [stderr] 44 | | if cfg!(feature = "qq"){ [INFO] [stderr] 45 | | disassembleInstruction(&self.chunk, self.ip); [INFO] [stderr] 46 | | } [INFO] [stderr] ... | [INFO] [stderr] 61 | | }; [INFO] [stderr] 62 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rlox`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: method is never used: `freeChunk` [INFO] [stderr] --> src/chunk.rs:40:2 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn freeChunk(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `disassembleChunk` [INFO] [stderr] --> src/debug.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn disassembleChunk(chunk: &Chunk, name: &str){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `freeValueArray` [INFO] [stderr] --> src/value.rs:21:2 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn freeValueArray(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `INTERPRET_RUNTIME_ERROR` [INFO] [stderr] --> src/vm.rs:16:2 [INFO] [stderr] | [INFO] [stderr] 16 | INTERPRET_RUNTIME_ERROR, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/debug.rs:23:6 [INFO] [stderr] | [INFO] [stderr] 23 | let ref instruction = chunk.code[offset]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^---------------------- help: try: `let instruction = &chunk.code[offset];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/debug.rs:40:6 [INFO] [stderr] | [INFO] [stderr] 40 | let ref constant: OpCode = chunk.code[offset + 1]; [INFO] [stderr] | ----^^^^^^^^^^^^---------------------------------- help: try: `let constant: &OpCode = &chunk.code[offset + 1];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/vm.rs:43:3 [INFO] [stderr] | [INFO] [stderr] 43 | loop { [INFO] [stderr] | _________^ [INFO] [stderr] 44 | | if cfg!(feature = "qq"){ [INFO] [stderr] 45 | | disassembleInstruction(&self.chunk, self.ip); [INFO] [stderr] 46 | | } [INFO] [stderr] ... | [INFO] [stderr] 61 | | }; [INFO] [stderr] 62 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rlox`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6900bd5e64113b1dce04a0e853c81e5f264d021d98aec3c3dcab39dad5b18312"` [INFO] running `"docker" "rm" "-f" "6900bd5e64113b1dce04a0e853c81e5f264d021d98aec3c3dcab39dad5b18312"` [INFO] [stdout] 6900bd5e64113b1dce04a0e853c81e5f264d021d98aec3c3dcab39dad5b18312