[INFO] updating cached repository PushAMP/pamcollector [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/PushAMP/pamcollector [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/PushAMP/pamcollector" "work/ex/clippy-test-run/sources/stable/gh/PushAMP/pamcollector"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/PushAMP/pamcollector'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/PushAMP/pamcollector" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PushAMP/pamcollector"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PushAMP/pamcollector'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 21a2438fd4df3660b19d3267d7ac03396a029052 [INFO] sha for GitHub repo PushAMP/pamcollector: 21a2438fd4df3660b19d3267d7ac03396a029052 [INFO] validating manifest of PushAMP/pamcollector on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of PushAMP/pamcollector on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing PushAMP/pamcollector [INFO] finished frobbing PushAMP/pamcollector [INFO] frobbed toml for PushAMP/pamcollector written to work/ex/clippy-test-run/sources/stable/gh/PushAMP/pamcollector/Cargo.toml [INFO] started frobbing PushAMP/pamcollector [INFO] finished frobbing PushAMP/pamcollector [INFO] frobbed toml for PushAMP/pamcollector written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PushAMP/pamcollector/Cargo.toml [INFO] crate PushAMP/pamcollector has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting PushAMP/pamcollector against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/PushAMP/pamcollector:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0f98ccf24a11754c6fd4ecb9408a814b63cccf9bd417ddc5d6b099e10558eccc [INFO] running `"docker" "start" "-a" "0f98ccf24a11754c6fd4ecb9408a814b63cccf9bd417ddc5d6b099e10558eccc"` [INFO] [stderr] Checking futures v0.1.12 [INFO] [stderr] Compiling miniz-sys v0.1.9 [INFO] [stderr] Checking iovec v0.1.0 [INFO] [stderr] Checking net2 v0.2.27 [INFO] [stderr] Checking serde_cbor v0.5.2 [INFO] [stderr] Checking toml v0.3.2 [INFO] [stderr] Checking humantime v1.0.0 [INFO] [stderr] Checking ordered-float v0.4.0 [INFO] [stderr] Checking serde_yaml v0.6.2 [INFO] [stderr] Checking bytes v0.4.1 [INFO] [stderr] Compiling serde_derive v0.9.12 [INFO] [stderr] Checking chrono v0.3.0 [INFO] [stderr] Checking serde-value v0.4.0 [INFO] [stderr] Checking hyper v0.10.5 [INFO] [stderr] Checking mio v0.6.6 [INFO] [stderr] Checking flate2 v0.2.17 [INFO] [stderr] Checking tokio-io v0.1.1 [INFO] [stderr] Checking tokio-service v0.1.0 [INFO] [stderr] Checking tokio-core v0.1.6 [INFO] [stderr] Checking log4rs v0.6.3 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking pamcollector v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/pamcollector/config.rs:8:28 [INFO] [stderr] | [INFO] [stderr] 8 | const DEFAULT_TCP_LISTEN: &'static str = "0.0.0.0:9091"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/pamcollector/config.rs:10:28 [INFO] [stderr] | [INFO] [stderr] 10 | const DEFAULT_CH_ADDRESS: &'static str = "http://0.0.0.0:8123/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:27:27 [INFO] [stderr] | [INFO] [stderr] 27 | const DEFAULT_CONF_FILE: &'static str = "pamcollector.toml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/pamcollector/config.rs:8:28 [INFO] [stderr] | [INFO] [stderr] 8 | const DEFAULT_TCP_LISTEN: &'static str = "0.0.0.0:9091"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/pamcollector/config.rs:10:28 [INFO] [stderr] | [INFO] [stderr] 10 | const DEFAULT_CH_ADDRESS: &'static str = "http://0.0.0.0:8123/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:27:27 [INFO] [stderr] | [INFO] [stderr] 27 | const DEFAULT_CONF_FILE: &'static str = "pamcollector.toml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pamcollector/output.rs:23:23 [INFO] [stderr] | [INFO] [stderr] 23 | fn to_ch_sql(res_vec: &Vec, conf: &Config) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pamcollector/output.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | fn output_spawn(bytes: &Vec, res_vec: &mut Vec, conf: &Config) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/pamcollector/metric.rs:74:14 [INFO] [stderr] | [INFO] [stderr] 74 | format!("{}", labels_str), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `labels_str.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/pamcollector/metric.rs:75:14 [INFO] [stderr] | [INFO] [stderr] 75 | format!("{}", labels_var_str)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `labels_var_str.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/pamcollector/service.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | future::ok(format!("")).boxed() [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pamcollector/output.rs:23:23 [INFO] [stderr] | [INFO] [stderr] 23 | fn to_ch_sql(res_vec: &Vec, conf: &Config) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pamcollector/output.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | fn output_spawn(bytes: &Vec, res_vec: &mut Vec, conf: &Config) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/pamcollector/metric.rs:74:14 [INFO] [stderr] | [INFO] [stderr] 74 | format!("{}", labels_str), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `labels_str.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/pamcollector/metric.rs:75:14 [INFO] [stderr] | [INFO] [stderr] 75 | format!("{}", labels_var_str)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `labels_var_str.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/pamcollector/service.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | future::ok(format!("")).boxed() [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 26.60s [INFO] running `"docker" "inspect" "0f98ccf24a11754c6fd4ecb9408a814b63cccf9bd417ddc5d6b099e10558eccc"` [INFO] running `"docker" "rm" "-f" "0f98ccf24a11754c6fd4ecb9408a814b63cccf9bd417ddc5d6b099e10558eccc"` [INFO] [stdout] 0f98ccf24a11754c6fd4ecb9408a814b63cccf9bd417ddc5d6b099e10558eccc