[INFO] updating cached repository PurpleMyst/schemers [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/PurpleMyst/schemers [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/PurpleMyst/schemers" "work/ex/clippy-test-run/sources/stable/gh/PurpleMyst/schemers"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/PurpleMyst/schemers'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/PurpleMyst/schemers" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PurpleMyst/schemers"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PurpleMyst/schemers'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d80e03fcbe9895ddc97647192929d838823242ac [INFO] sha for GitHub repo PurpleMyst/schemers: d80e03fcbe9895ddc97647192929d838823242ac [INFO] validating manifest of PurpleMyst/schemers on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of PurpleMyst/schemers on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing PurpleMyst/schemers [INFO] finished frobbing PurpleMyst/schemers [INFO] frobbed toml for PurpleMyst/schemers written to work/ex/clippy-test-run/sources/stable/gh/PurpleMyst/schemers/Cargo.toml [INFO] started frobbing PurpleMyst/schemers [INFO] finished frobbing PurpleMyst/schemers [INFO] frobbed toml for PurpleMyst/schemers written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PurpleMyst/schemers/Cargo.toml [INFO] crate PurpleMyst/schemers has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting PurpleMyst/schemers against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/PurpleMyst/schemers:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 22200dfc75a30f7f12e8d7a6b3311af83eb2991c5ea5b88e41e423c19f984d0e [INFO] running `"docker" "start" "-a" "22200dfc75a30f7f12e8d7a6b3311af83eb2991c5ea5b88e41e423c19f984d0e"` [INFO] [stderr] Checking nom v4.0.0 [INFO] [stderr] Compiling gc_derive v0.3.2 [INFO] [stderr] Checking schemers v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: variant is never constructed: `True` [INFO] [stderr] --> src/value.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | True, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:32:8 [INFO] [stderr] | [INFO] [stderr] 32 | if contents.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `contents.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match &s as &str { [INFO] [stderr] 42 | | "if" => return Value::If(rest.skip(1).collect()), [INFO] [stderr] 43 | | _ => {} [INFO] [stderr] 44 | | } [INFO] [stderr] | |_________^ help: try this: `if let "if" = &s as &str { return Value::If(rest.skip(1).collect()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/scope.rs:68:30 [INFO] [stderr] | [INFO] [stderr] 68 | self.eval(if &*condition.borrow() != &Value::False { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 68 | self.eval(if *condition.borrow() != Value::False { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `True` [INFO] [stderr] --> src/value.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | True, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:32:8 [INFO] [stderr] | [INFO] [stderr] 32 | if contents.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `contents.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match &s as &str { [INFO] [stderr] 42 | | "if" => return Value::If(rest.skip(1).collect()), [INFO] [stderr] 43 | | _ => {} [INFO] [stderr] 44 | | } [INFO] [stderr] | |_________^ help: try this: `if let "if" = &s as &str { return Value::If(rest.skip(1).collect()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/scope.rs:68:30 [INFO] [stderr] | [INFO] [stderr] 68 | self.eval(if &*condition.borrow() != &Value::False { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 68 | self.eval(if *condition.borrow() != Value::False { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.56s [INFO] running `"docker" "inspect" "22200dfc75a30f7f12e8d7a6b3311af83eb2991c5ea5b88e41e423c19f984d0e"` [INFO] running `"docker" "rm" "-f" "22200dfc75a30f7f12e8d7a6b3311af83eb2991c5ea5b88e41e423c19f984d0e"` [INFO] [stdout] 22200dfc75a30f7f12e8d7a6b3311af83eb2991c5ea5b88e41e423c19f984d0e