[INFO] updating cached repository PurpleMyst/rdotdot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/PurpleMyst/rdotdot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/PurpleMyst/rdotdot" "work/ex/clippy-test-run/sources/stable/gh/PurpleMyst/rdotdot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/PurpleMyst/rdotdot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/PurpleMyst/rdotdot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PurpleMyst/rdotdot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PurpleMyst/rdotdot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f7f61abb8cfbc794c83f5b47cbc234fb9cec0269 [INFO] sha for GitHub repo PurpleMyst/rdotdot: f7f61abb8cfbc794c83f5b47cbc234fb9cec0269 [INFO] validating manifest of PurpleMyst/rdotdot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of PurpleMyst/rdotdot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing PurpleMyst/rdotdot [INFO] finished frobbing PurpleMyst/rdotdot [INFO] frobbed toml for PurpleMyst/rdotdot written to work/ex/clippy-test-run/sources/stable/gh/PurpleMyst/rdotdot/Cargo.toml [INFO] started frobbing PurpleMyst/rdotdot [INFO] finished frobbing PurpleMyst/rdotdot [INFO] frobbed toml for PurpleMyst/rdotdot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PurpleMyst/rdotdot/Cargo.toml [INFO] crate PurpleMyst/rdotdot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting PurpleMyst/rdotdot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/PurpleMyst/rdotdot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 234e2b2b8f9277308e1fc79904f4ac437ed8870daef200ff4433ae623ad2818c [INFO] running `"docker" "start" "-a" "234e2b2b8f9277308e1fc79904f4ac437ed8870daef200ff4433ae623ad2818c"` [INFO] [stderr] Checking rpds v0.5.0 [INFO] [stderr] Checking peeking_take_while v0.1.2 [INFO] [stderr] Checking nom v4.0.0 [INFO] [stderr] Checking rdotdot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint `bare_trait_object` has been renamed to `bare_trait_objects` [INFO] [stderr] --> src/main.rs:2:27 [INFO] [stderr] | [INFO] [stderr] 2 | anonymous_parameters, bare_trait_object, missing_copy_implementations, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use the new name: `bare_trait_objects` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint `bare_trait_object` has been renamed to `bare_trait_objects` [INFO] [stderr] --> src/main.rs:2:27 [INFO] [stderr] | [INFO] [stderr] 2 | anonymous_parameters, bare_trait_object, missing_copy_implementations, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use the new name: `bare_trait_objects` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:420:9 [INFO] [stderr] | [INFO] [stderr] 420 | return Err((original_tokens, ParsingError::from("Not a var statement."))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err((original_tokens, ParsingError::from("Not a var statement.")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / loop { [INFO] [stderr] 46 | | let c: char = match code_chars.next() { [INFO] [stderr] 47 | | Some(c) => c, [INFO] [stderr] 48 | | None => break, [INFO] [stderr] ... | [INFO] [stderr] 137 | | result.push(token); [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(c) = code_chars.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:228:8 [INFO] [stderr] | [INFO] [stderr] 228 | if result.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `result.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:409:21 [INFO] [stderr] | [INFO] [stderr] 409 | / match expression(tokens) { [INFO] [stderr] 410 | | Ok((mut tokens, rhs)) => { [INFO] [stderr] 411 | | return Ok((tokens, AstNode::VarDeclaration(lhs, Box::new(rhs)))); [INFO] [stderr] 412 | | } [INFO] [stderr] 413 | | [INFO] [stderr] 414 | | Err(_) => {} [INFO] [stderr] 415 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 409 | if let Ok((mut tokens, rhs)) = expression(tokens) { [INFO] [stderr] 410 | return Ok((tokens, AstNode::VarDeclaration(lhs, Box::new(rhs)))); [INFO] [stderr] 411 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:420:9 [INFO] [stderr] | [INFO] [stderr] 420 | return Err((original_tokens, ParsingError::from("Not a var statement."))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err((original_tokens, ParsingError::from("Not a var statement.")))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / loop { [INFO] [stderr] 46 | | let c: char = match code_chars.next() { [INFO] [stderr] 47 | | Some(c) => c, [INFO] [stderr] 48 | | None => break, [INFO] [stderr] ... | [INFO] [stderr] 137 | | result.push(token); [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(c) = code_chars.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:228:8 [INFO] [stderr] | [INFO] [stderr] 228 | if result.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `result.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:409:21 [INFO] [stderr] | [INFO] [stderr] 409 | / match expression(tokens) { [INFO] [stderr] 410 | | Ok((mut tokens, rhs)) => { [INFO] [stderr] 411 | | return Ok((tokens, AstNode::VarDeclaration(lhs, Box::new(rhs)))); [INFO] [stderr] 412 | | } [INFO] [stderr] 413 | | [INFO] [stderr] 414 | | Err(_) => {} [INFO] [stderr] 415 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 409 | if let Ok((mut tokens, rhs)) = expression(tokens) { [INFO] [stderr] 410 | return Ok((tokens, AstNode::VarDeclaration(lhs, Box::new(rhs)))); [INFO] [stderr] 411 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.16s [INFO] running `"docker" "inspect" "234e2b2b8f9277308e1fc79904f4ac437ed8870daef200ff4433ae623ad2818c"` [INFO] running `"docker" "rm" "-f" "234e2b2b8f9277308e1fc79904f4ac437ed8870daef200ff4433ae623ad2818c"` [INFO] [stdout] 234e2b2b8f9277308e1fc79904f4ac437ed8870daef200ff4433ae623ad2818c