[INFO] updating cached repository Proximyst/xorcrypt-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Proximyst/xorcrypt-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Proximyst/xorcrypt-rs" "work/ex/clippy-test-run/sources/stable/gh/Proximyst/xorcrypt-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Proximyst/xorcrypt-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Proximyst/xorcrypt-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Proximyst/xorcrypt-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Proximyst/xorcrypt-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0c48d108fae69dc1af5014eca0d88204e41f7c5b [INFO] sha for GitHub repo Proximyst/xorcrypt-rs: 0c48d108fae69dc1af5014eca0d88204e41f7c5b [INFO] validating manifest of Proximyst/xorcrypt-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Proximyst/xorcrypt-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Proximyst/xorcrypt-rs [INFO] finished frobbing Proximyst/xorcrypt-rs [INFO] frobbed toml for Proximyst/xorcrypt-rs written to work/ex/clippy-test-run/sources/stable/gh/Proximyst/xorcrypt-rs/Cargo.toml [INFO] started frobbing Proximyst/xorcrypt-rs [INFO] finished frobbing Proximyst/xorcrypt-rs [INFO] frobbed toml for Proximyst/xorcrypt-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Proximyst/xorcrypt-rs/Cargo.toml [INFO] crate Proximyst/xorcrypt-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Proximyst/xorcrypt-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Proximyst/xorcrypt-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cacf176c3f137a11ce54d5fa62e8616a1f21b51cd691358063f0bf84a243fd95 [INFO] running `"docker" "start" "-a" "cacf176c3f137a11ce54d5fa62e8616a1f21b51cd691358063f0bf84a243fd95"` [INFO] [stderr] Checking xorcrypt-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cipher.rs:10:31 [INFO] [stderr] | [INFO] [stderr] 10 | ciphered.push(character ^ key.get(iterations).unwrap().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `key[iterations]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/arghandler.rs:15:6 [INFO] [stderr] | [INFO] [stderr] 15 | if read <= 0 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using read == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/arghandler.rs:41:6 [INFO] [stderr] | [INFO] [stderr] 41 | if read <= 0 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using read == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / let _ = match match stdin.read_passwd(&mut stdout) { [INFO] [stderr] 37 | | Ok(password) => password, [INFO] [stderr] 38 | | Err(err) => panic!("an error occurred: {}", err), [INFO] [stderr] 39 | | } { [INFO] [stderr] ... | [INFO] [stderr] 43 | | None => panic!("no password input"), [INFO] [stderr] 44 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cipher.rs:10:31 [INFO] [stderr] | [INFO] [stderr] 10 | ciphered.push(character ^ key.get(iterations).unwrap().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `key[iterations]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/arghandler.rs:15:6 [INFO] [stderr] | [INFO] [stderr] 15 | if read <= 0 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using read == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/arghandler.rs:41:6 [INFO] [stderr] | [INFO] [stderr] 41 | if read <= 0 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using read == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / let _ = match match stdin.read_passwd(&mut stdout) { [INFO] [stderr] 37 | | Ok(password) => password, [INFO] [stderr] 38 | | Err(err) => panic!("an error occurred: {}", err), [INFO] [stderr] 39 | | } { [INFO] [stderr] ... | [INFO] [stderr] 43 | | None => panic!("no password input"), [INFO] [stderr] 44 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: Could not compile `xorcrypt-rs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `xorcrypt-rs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "cacf176c3f137a11ce54d5fa62e8616a1f21b51cd691358063f0bf84a243fd95"` [INFO] running `"docker" "rm" "-f" "cacf176c3f137a11ce54d5fa62e8616a1f21b51cd691358063f0bf84a243fd95"` [INFO] [stdout] cacf176c3f137a11ce54d5fa62e8616a1f21b51cd691358063f0bf84a243fd95