[INFO] updating cached repository ProgrammingRust/fingertips [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ProgrammingRust/fingertips [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ProgrammingRust/fingertips" "work/ex/clippy-test-run/sources/stable/gh/ProgrammingRust/fingertips"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ProgrammingRust/fingertips'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ProgrammingRust/fingertips" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ProgrammingRust/fingertips"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ProgrammingRust/fingertips'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fecdce2521e2193bfaa91e10dcb41e17433c6aa5 [INFO] sha for GitHub repo ProgrammingRust/fingertips: fecdce2521e2193bfaa91e10dcb41e17433c6aa5 [INFO] validating manifest of ProgrammingRust/fingertips on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ProgrammingRust/fingertips on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ProgrammingRust/fingertips [INFO] finished frobbing ProgrammingRust/fingertips [INFO] frobbed toml for ProgrammingRust/fingertips written to work/ex/clippy-test-run/sources/stable/gh/ProgrammingRust/fingertips/Cargo.toml [INFO] started frobbing ProgrammingRust/fingertips [INFO] finished frobbing ProgrammingRust/fingertips [INFO] frobbed toml for ProgrammingRust/fingertips written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ProgrammingRust/fingertips/Cargo.toml [INFO] crate ProgrammingRust/fingertips has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ProgrammingRust/fingertips against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ProgrammingRust/fingertips:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f7190c8247193a468a7e1ce670253e2ca69531f13f37630a40ac7090da961ed4 [INFO] running `"docker" "start" "-a" "f7190c8247193a468a7e1ce670253e2ca69531f13f37630a40ac7090da961ed4"` [INFO] [stderr] Checking fingertips v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/read.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | main: main, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `main` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/read.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | contents: contents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `contents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/read.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | term: term, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `term` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/read.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | df: df, [INFO] [stderr] | ^^^^^^ help: replace it with: `df` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/read.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/read.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | nbytes: nbytes [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `nbytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/read.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | main: main, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `main` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/read.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | contents: contents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `contents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/read.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | term: term, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `term` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/read.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | df: df, [INFO] [stderr] | ^^^^^^ help: replace it with: `df` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/read.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/read.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | nbytes: nbytes [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `nbytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/merge.rs:19:25 [INFO] [stderr] | [INFO] [stderr] 19 | const MERGED_FILENAME: &'static str = "index.dat"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/merge.rs:19:25 [INFO] [stderr] | [INFO] [stderr] 19 | const MERGED_FILENAME: &'static str = "index.dat"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/read.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 112 | let mut bytes = Vec::with_capacity(term_len); [INFO] [stderr] | ---------------------------- help: consider replace allocation with: `vec![0; term_len]` [INFO] [stderr] 113 | bytes.resize(term_len, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/read.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 154 | let mut buf = Vec::with_capacity(e.nbytes as usize); [INFO] [stderr] | ------------------------------------- help: consider replace allocation with: `vec![0; e.nbytes as usize]` [INFO] [stderr] 155 | buf.resize(e.nbytes as usize, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/read.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 112 | let mut bytes = Vec::with_capacity(term_len); [INFO] [stderr] | ---------------------------- help: consider replace allocation with: `vec![0; term_len]` [INFO] [stderr] 113 | bytes.resize(term_len, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/read.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 154 | let mut buf = Vec::with_capacity(e.nbytes as usize); [INFO] [stderr] | ------------------------------------- help: consider replace allocation with: `vec![0; e.nbytes as usize]` [INFO] [stderr] 155 | buf.resize(e.nbytes as usize, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.57s [INFO] running `"docker" "inspect" "f7190c8247193a468a7e1ce670253e2ca69531f13f37630a40ac7090da961ed4"` [INFO] running `"docker" "rm" "-f" "f7190c8247193a468a7e1ce670253e2ca69531f13f37630a40ac7090da961ed4"` [INFO] [stdout] f7190c8247193a468a7e1ce670253e2ca69531f13f37630a40ac7090da961ed4