[INFO] updating cached repository Pomettini/impostor-spritecooker
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Pomettini/impostor-spritecooker
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Pomettini/impostor-spritecooker" "work/ex/clippy-test-run/sources/stable/gh/Pomettini/impostor-spritecooker"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Pomettini/impostor-spritecooker'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Pomettini/impostor-spritecooker" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Pomettini/impostor-spritecooker"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Pomettini/impostor-spritecooker'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c7369614b394feeaf16200ac51c682b0c92afe16
[INFO] sha for GitHub repo Pomettini/impostor-spritecooker: c7369614b394feeaf16200ac51c682b0c92afe16
[INFO] validating manifest of Pomettini/impostor-spritecooker on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Pomettini/impostor-spritecooker on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Pomettini/impostor-spritecooker
[INFO] finished frobbing Pomettini/impostor-spritecooker
[INFO] frobbed toml for Pomettini/impostor-spritecooker written to work/ex/clippy-test-run/sources/stable/gh/Pomettini/impostor-spritecooker/Cargo.toml
[INFO] started frobbing Pomettini/impostor-spritecooker
[INFO] finished frobbing Pomettini/impostor-spritecooker
[INFO] frobbed toml for Pomettini/impostor-spritecooker written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Pomettini/impostor-spritecooker/Cargo.toml
[INFO] crate Pomettini/impostor-spritecooker has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Pomettini/impostor-spritecooker against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Pomettini/impostor-spritecooker:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] f1e66099aeb82be48ab04ff5555e989b43d6972cdd972cb7fb0eacb3c31f8b4f
[INFO] running `"docker" "start" "-a" "f1e66099aeb82be48ab04ff5555e989b43d6972cdd972cb7fb0eacb3c31f8b4f"`
[INFO] [stderr]     Checking exoquant v0.2.0
[INFO] [stderr]    Compiling stb_image v0.2.2
[INFO] [stderr]     Checking crossbeam-epoch v0.3.1
[INFO] [stderr]    Compiling num-derive v0.2.3
[INFO] [stderr]     Checking crossbeam-deque v0.2.0
[INFO] [stderr]     Checking rayon-core v1.4.1
[INFO] [stderr]     Checking rayon v1.0.3
[INFO] [stderr]     Checking tiff v0.2.1
[INFO] [stderr]     Checking jpeg-decoder v0.1.15
[INFO] [stderr]     Checking image v0.20.1
[INFO] [stderr]     Checking spritecooker v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused import: `bitmap::Bitmap`
[INFO] [stderr]  --> src/formats/pico8.rs:1:5
[INFO] [stderr]   |
[INFO] [stderr] 1 | use bitmap::Bitmap;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `data`
[INFO] [stderr]   --> src/formats/pico8.rs:17:22
[INFO] [stderr]    |
[INFO] [stderr] 17 |     pub fn serialize(data: Vec<u8>) -> Vec<u8> {
[INFO] [stderr]    |                      ^^^^ help: consider using `_data` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `Pico8Cart`
[INFO] [stderr]  --> src/formats/pico8.rs:4:1
[INFO] [stderr]   |
[INFO] [stderr] 4 | struct Pico8Cart {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new`
[INFO] [stderr]   --> src/formats/pico8.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     pub fn new(data: Vec<u8>) -> Pico8Cart {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `serialize`
[INFO] [stderr]   --> src/formats/pico8.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 |     pub fn serialize(data: Vec<u8>) -> Vec<u8> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `width`
[INFO] [stderr]  --> src/image.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 |     width: usize,
[INFO] [stderr]   |     ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `height`
[INFO] [stderr]  --> src/image.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 |     height: usize,
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `data`
[INFO] [stderr]  --> src/image.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 |     data: Bitmap,
[INFO] [stderr]   |     ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `add_offsets`
[INFO] [stderr]   --> src/previewimage.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 |     fn add_offsets(image: &mut Bitmap) {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `width`
[INFO] [stderr]  --> src/sprite.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 |     width: usize,
[INFO] [stderr]   |     ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `height`
[INFO] [stderr]  --> src/sprite.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 |     height: usize,
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `data`
[INFO] [stderr]  --> src/sprite.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 |     data: Bitmap,
[INFO] [stderr]   |     ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `x_counter` is used as a loop counter. Consider using `for (x_counter, item) in (0..image.len()).step_by(3).enumerate()` or similar iterators
[INFO] [stderr]   --> src/bmptovga.rs:54:14
[INFO] [stderr]    |
[INFO] [stderr] 54 |     for i in (0..image.len()).step_by(3) {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i`
[INFO] [stderr]   --> src/bmptovga.rs:62:19
[INFO] [stderr]    |
[INFO] [stderr] 62 |             image[i + 0] = 0;
[INFO] [stderr]    |                   ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `x_counter` is used as a loop counter. Consider using `for (x_counter, item) in (0..image.len()).step_by(3).enumerate()` or similar iterators
[INFO] [stderr]   --> src/bmptovga.rs:54:14
[INFO] [stderr]    |
[INFO] [stderr] 54 |     for i in (0..image.len()).step_by(3) {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i`
[INFO] [stderr]   --> src/bmptovga.rs:62:19
[INFO] [stderr]    |
[INFO] [stderr] 62 |             image[i + 0] = 0;
[INFO] [stderr]    |                   ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `origin_counter`
[INFO] [stderr]   --> src/previewimage.rs:77:63
[INFO] [stderr]    |
[INFO] [stderr] 77 |                 image[destination_counter + 0] = offsets.data[origin_counter + 0];
[INFO] [stderr]    |                                                               ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `destination_counter`
[INFO] [stderr]   --> src/previewimage.rs:77:23
[INFO] [stderr]    |
[INFO] [stderr] 77 |                 image[destination_counter + 0] = offsets.data[origin_counter + 0];
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/formats/gameboy.rs:106:22
[INFO] [stderr]     |
[INFO] [stderr] 106 |     output_test[0] = 0b00000000;
[INFO] [stderr]     |                      ^^^^^^^^^^ help: consider: `0b0000_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/formats/gameboy.rs:107:22
[INFO] [stderr]     |
[INFO] [stderr] 107 |     output_test[8] = 0b00000000;
[INFO] [stderr]     |                      ^^^^^^^^^^ help: consider: `0b0000_0000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `bitmap::Bitmap`
[INFO] [stderr]  --> src/formats/pico8.rs:1:5
[INFO] [stderr]   |
[INFO] [stderr] 1 | use bitmap::Bitmap;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `input_test`
[INFO] [stderr]   --> src/formats/pico8.rs:24:9
[INFO] [stderr]    |
[INFO] [stderr] 24 |     let input_test = "012300004567000089ab0000cdef0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
[INFO] [stderr]    |         ^^^^^^^^^^ help: consider using `_input_test` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `data`
[INFO] [stderr]   --> src/formats/pico8.rs:17:22
[INFO] [stderr]    |
[INFO] [stderr] 17 |     pub fn serialize(data: Vec<u8>) -> Vec<u8> {
[INFO] [stderr]    |                      ^^^^ help: consider using `_data` instead
[INFO] [stderr] 
[INFO] [stderr] warning: struct is never constructed: `Pico8Cart`
[INFO] [stderr]  --> src/formats/pico8.rs:4:1
[INFO] [stderr]   |
[INFO] [stderr] 4 | struct Pico8Cart {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `new`
[INFO] [stderr]   --> src/formats/pico8.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     pub fn new(data: Vec<u8>) -> Pico8Cart {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `serialize`
[INFO] [stderr]   --> src/formats/pico8.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 |     pub fn serialize(data: Vec<u8>) -> Vec<u8> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `width`
[INFO] [stderr]  --> src/image.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 |     width: usize,
[INFO] [stderr]   |     ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `height`
[INFO] [stderr]  --> src/image.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 |     height: usize,
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `data`
[INFO] [stderr]  --> src/image.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 |     data: Bitmap,
[INFO] [stderr]   |     ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `add_offsets`
[INFO] [stderr]   --> src/previewimage.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 |     fn add_offsets(image: &mut Bitmap) {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `width`
[INFO] [stderr]  --> src/sprite.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 |     width: usize,
[INFO] [stderr]   |     ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `height`
[INFO] [stderr]  --> src/sprite.rs:5:5
[INFO] [stderr]   |
[INFO] [stderr] 5 |     height: usize,
[INFO] [stderr]   |     ^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `data`
[INFO] [stderr]  --> src/sprite.rs:6:5
[INFO] [stderr]   |
[INFO] [stderr] 6 |     data: Bitmap,
[INFO] [stderr]   |     ^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `x_counter` is used as a loop counter. Consider using `for (x_counter, item) in (0..image.len()).step_by(3).enumerate()` or similar iterators
[INFO] [stderr]   --> src/bmptovga.rs:54:14
[INFO] [stderr]    |
[INFO] [stderr] 54 |     for i in (0..image.len()).step_by(3) {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i`
[INFO] [stderr]   --> src/bmptovga.rs:62:19
[INFO] [stderr]    |
[INFO] [stderr] 62 |             image[i + 0] = 0;
[INFO] [stderr]    |                   ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `x_counter` is used as a loop counter. Consider using `for (x_counter, item) in (0..image.len()).step_by(3).enumerate()` or similar iterators
[INFO] [stderr]   --> src/bmptovga.rs:54:14
[INFO] [stderr]    |
[INFO] [stderr] 54 |     for i in (0..image.len()).step_by(3) {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i`
[INFO] [stderr]   --> src/bmptovga.rs:62:19
[INFO] [stderr]    |
[INFO] [stderr] 62 |             image[i + 0] = 0;
[INFO] [stderr]    |                   ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `origin_counter`
[INFO] [stderr]   --> src/previewimage.rs:77:63
[INFO] [stderr]    |
[INFO] [stderr] 77 |                 image[destination_counter + 0] = offsets.data[origin_counter + 0];
[INFO] [stderr]    |                                                               ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `destination_counter`
[INFO] [stderr]   --> src/previewimage.rs:77:23
[INFO] [stderr]    |
[INFO] [stderr] 77 |                 image[destination_counter + 0] = offsets.data[origin_counter + 0];
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 29.02s
[INFO] running `"docker" "inspect" "f1e66099aeb82be48ab04ff5555e989b43d6972cdd972cb7fb0eacb3c31f8b4f"`
[INFO] running `"docker" "rm" "-f" "f1e66099aeb82be48ab04ff5555e989b43d6972cdd972cb7fb0eacb3c31f8b4f"`
[INFO] [stdout] f1e66099aeb82be48ab04ff5555e989b43d6972cdd972cb7fb0eacb3c31f8b4f