[INFO] updating cached repository Polyrealm/PolyrealmBot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Polyrealm/PolyrealmBot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Polyrealm/PolyrealmBot" "work/ex/clippy-test-run/sources/stable/gh/Polyrealm/PolyrealmBot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Polyrealm/PolyrealmBot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Polyrealm/PolyrealmBot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Polyrealm/PolyrealmBot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Polyrealm/PolyrealmBot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a3111a2cd4a28befcdbfc36f43121391f756a4a1 [INFO] sha for GitHub repo Polyrealm/PolyrealmBot: a3111a2cd4a28befcdbfc36f43121391f756a4a1 [INFO] validating manifest of Polyrealm/PolyrealmBot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Polyrealm/PolyrealmBot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Polyrealm/PolyrealmBot [INFO] finished frobbing Polyrealm/PolyrealmBot [INFO] frobbed toml for Polyrealm/PolyrealmBot written to work/ex/clippy-test-run/sources/stable/gh/Polyrealm/PolyrealmBot/Cargo.toml [INFO] started frobbing Polyrealm/PolyrealmBot [INFO] finished frobbing Polyrealm/PolyrealmBot [INFO] frobbed toml for Polyrealm/PolyrealmBot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Polyrealm/PolyrealmBot/Cargo.toml [INFO] crate Polyrealm/PolyrealmBot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Polyrealm/PolyrealmBot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Polyrealm/PolyrealmBot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0c5b6b408bedfb5b58cb35d727344800eea012060d971743ce0d3c12fec14212 [INFO] running `"docker" "start" "-a" "0c5b6b408bedfb5b58cb35d727344800eea012060d971743ce0d3c12fec14212"` [INFO] [stderr] Checking openssl v0.9.24 [INFO] [stderr] Checking uuid v0.5.1 [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Checking multipart v0.13.6 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Checking evzht9h3nznqzwl v0.0.3 [INFO] [stderr] Checking serenity v0.5.11 [INFO] [stderr] Checking SykoosBot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `prelude::*` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | prelude::*, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return contents; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `contents` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | return call; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `call` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | return response; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `response` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | let mut msg_split = content.split(" "); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `SykoosBot` should have a snake case name such as `sykoos_bot` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(non_snake_case)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(non_snake_case)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: function `readCommandFile` should have a snake case name such as `read_command_file` [INFO] [stderr] --> src/main.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | / fn readCommandFile() -> String { [INFO] [stderr] 37 | | let mut file = File::open("commands.json").unwrap(); [INFO] [stderr] 38 | | let mut contents = String::new(); [INFO] [stderr] 39 | | file.read_to_string(&mut contents); [INFO] [stderr] 40 | | return contents; [INFO] [stderr] 41 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | file.read_to_string(&mut contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: function `addJsonCommand` should have a snake case name such as `add_json_command` [INFO] [stderr] --> src/main.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | / fn addJsonCommand(cmd: &mut json::JsonValue, cmd_array: &mut json::object::Object) -> String { [INFO] [stderr] 44 | | //cmd_array.push(); [INFO] [stderr] 45 | | //TODO: Figure out if we actually need the name lmao [INFO] [stderr] 46 | | let name: String = cmd["name"].take_string().expect("Should be a string").to_string(); //No point in checking if a command has this, because it's required lol. Yes this isn't great code, but it works and that's good enough **FOR NOW** [INFO] [stderr] ... | [INFO] [stderr] 59 | | return call; [INFO] [stderr] 60 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `processJsonScript` should have a snake case name such as `process_json_script` [INFO] [stderr] --> src/main.rs:100:1 [INFO] [stderr] | [INFO] [stderr] 100 | / fn processJsonScript(scr: &json::JsonValue) -> String { [INFO] [stderr] 101 | | let mut response = String::from(""); [INFO] [stderr] 102 | | [INFO] [stderr] 103 | | let mut script = scr.clone(); [INFO] [stderr] ... | [INFO] [stderr] 114 | | return response; [INFO] [stderr] 115 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `script`. [INFO] [stderr] --> src/main.rs:105:14 [INFO] [stderr] | [INFO] [stderr] 105 | for i in 0..script.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 105 | for in &mut script { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function `jsonCommand` should have a snake case name such as `json_command` [INFO] [stderr] --> src/main.rs:117:1 [INFO] [stderr] | [INFO] [stderr] 117 | / fn jsonCommand(context: &mut Context, message: &Message, args: Args) -> Result<(), CommandError> { [INFO] [stderr] 118 | | //message.channel_id.say(&contents) where contents is a String [INFO] [stderr] 119 | | //println!("Context: {:?}", context); [INFO] [stderr] 120 | | //println!("Message: {:?}", message); [INFO] [stderr] ... | [INFO] [stderr] 155 | | Ok(()) [INFO] [stderr] 156 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | / let mut cmd: String; [INFO] [stderr] 128 | | [INFO] [stderr] 129 | | if args.is_empty() { [INFO] [stderr] 130 | | cmd = content.to_string(); [INFO] [stderr] ... | [INFO] [stderr] 134 | | cmd = msg_vec[1].to_string(); [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let cmd = if args.is_empty() { content.to_string() } else { ..; msg_vec[1].to_string() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:132:43 [INFO] [stderr] | [INFO] [stderr] 132 | let mut msg_split = content.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `response_vec`. [INFO] [stderr] --> src/main.rs:147:22 [INFO] [stderr] | [INFO] [stderr] 147 | for i in 0..response_vec.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 147 | for in &response_vec { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `SykoosBot`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `prelude::*` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | prelude::*, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return contents; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `contents` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | return call; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `call` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | return response; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `response` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | let mut msg_split = content.split(" "); [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `SykoosBot` should have a snake case name such as `sykoos_bot` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(non_snake_case)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(non_snake_case)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: function `readCommandFile` should have a snake case name such as `read_command_file` [INFO] [stderr] --> src/main.rs:36:1 [INFO] [stderr] | [INFO] [stderr] 36 | / fn readCommandFile() -> String { [INFO] [stderr] 37 | | let mut file = File::open("commands.json").unwrap(); [INFO] [stderr] 38 | | let mut contents = String::new(); [INFO] [stderr] 39 | | file.read_to_string(&mut contents); [INFO] [stderr] 40 | | return contents; [INFO] [stderr] 41 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | file.read_to_string(&mut contents); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: function `addJsonCommand` should have a snake case name such as `add_json_command` [INFO] [stderr] --> src/main.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | / fn addJsonCommand(cmd: &mut json::JsonValue, cmd_array: &mut json::object::Object) -> String { [INFO] [stderr] 44 | | //cmd_array.push(); [INFO] [stderr] 45 | | //TODO: Figure out if we actually need the name lmao [INFO] [stderr] 46 | | let name: String = cmd["name"].take_string().expect("Should be a string").to_string(); //No point in checking if a command has this, because it's required lol. Yes this isn't great code, but it works and that's good enough **FOR NOW** [INFO] [stderr] ... | [INFO] [stderr] 59 | | return call; [INFO] [stderr] 60 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: function `processJsonScript` should have a snake case name such as `process_json_script` [INFO] [stderr] --> src/main.rs:100:1 [INFO] [stderr] | [INFO] [stderr] 100 | / fn processJsonScript(scr: &json::JsonValue) -> String { [INFO] [stderr] 101 | | let mut response = String::from(""); [INFO] [stderr] 102 | | [INFO] [stderr] 103 | | let mut script = scr.clone(); [INFO] [stderr] ... | [INFO] [stderr] 114 | | return response; [INFO] [stderr] 115 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `script`. [INFO] [stderr] --> src/main.rs:105:14 [INFO] [stderr] | [INFO] [stderr] 105 | for i in 0..script.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 105 | for in &mut script { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function `jsonCommand` should have a snake case name such as `json_command` [INFO] [stderr] --> src/main.rs:117:1 [INFO] [stderr] | [INFO] [stderr] 117 | / fn jsonCommand(context: &mut Context, message: &Message, args: Args) -> Result<(), CommandError> { [INFO] [stderr] 118 | | //message.channel_id.say(&contents) where contents is a String [INFO] [stderr] 119 | | //println!("Context: {:?}", context); [INFO] [stderr] 120 | | //println!("Message: {:?}", message); [INFO] [stderr] ... | [INFO] [stderr] 155 | | Ok(()) [INFO] [stderr] 156 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | / let mut cmd: String; [INFO] [stderr] 128 | | [INFO] [stderr] 129 | | if args.is_empty() { [INFO] [stderr] 130 | | cmd = content.to_string(); [INFO] [stderr] ... | [INFO] [stderr] 134 | | cmd = msg_vec[1].to_string(); [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let cmd = if args.is_empty() { content.to_string() } else { ..; msg_vec[1].to_string() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:132:43 [INFO] [stderr] | [INFO] [stderr] 132 | let mut msg_split = content.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `response_vec`. [INFO] [stderr] --> src/main.rs:147:22 [INFO] [stderr] | [INFO] [stderr] 147 | for i in 0..response_vec.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 147 | for in &response_vec { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `SykoosBot`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0c5b6b408bedfb5b58cb35d727344800eea012060d971743ce0d3c12fec14212"` [INFO] running `"docker" "rm" "-f" "0c5b6b408bedfb5b58cb35d727344800eea012060d971743ce0d3c12fec14212"` [INFO] [stdout] 0c5b6b408bedfb5b58cb35d727344800eea012060d971743ce0d3c12fec14212