[INFO] updating cached repository PoC-Consortium/scavenger [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/PoC-Consortium/scavenger [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/PoC-Consortium/scavenger" "work/ex/clippy-test-run/sources/stable/gh/PoC-Consortium/scavenger"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/PoC-Consortium/scavenger'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/PoC-Consortium/scavenger" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PoC-Consortium/scavenger"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PoC-Consortium/scavenger'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b576e81dc60356cf06c0b8565ed28a7dd6fdb82b [INFO] sha for GitHub repo PoC-Consortium/scavenger: b576e81dc60356cf06c0b8565ed28a7dd6fdb82b [INFO] validating manifest of PoC-Consortium/scavenger on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of PoC-Consortium/scavenger on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing PoC-Consortium/scavenger [INFO] finished frobbing PoC-Consortium/scavenger [INFO] frobbed toml for PoC-Consortium/scavenger written to work/ex/clippy-test-run/sources/stable/gh/PoC-Consortium/scavenger/Cargo.toml [INFO] started frobbing PoC-Consortium/scavenger [INFO] finished frobbing PoC-Consortium/scavenger [INFO] frobbed toml for PoC-Consortium/scavenger written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PoC-Consortium/scavenger/Cargo.toml [INFO] crate PoC-Consortium/scavenger has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting PoC-Consortium/scavenger against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/PoC-Consortium/scavenger:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0bf60500c1faa0b16bcb9fb09130fa256262dd987d906ce82470ccbe4ffc20d9 [INFO] running `"docker" "start" "-a" "0bf60500c1faa0b16bcb9fb09130fa256262dd987d906ce82470ccbe4ffc20d9"` [INFO] [stderr] Checking page_size v0.4.1 [INFO] [stderr] Checking num_cpus v0.2.13 [INFO] [stderr] Compiling ring v0.13.2 [INFO] [stderr] Compiling sys-info v0.5.6 [INFO] [stderr] Compiling scavenger v1.6.7 (/opt/crater/workdir) [INFO] [stderr] Checking core_affinity v0.5.9 [INFO] [stderr] Checking pbr v1.0.1 [INFO] [stderr] Checking clap v2.30.0 [INFO] [stderr] Checking log v0.4.4 [INFO] [stderr] Checking serde_yaml v0.7.5 [INFO] [stderr] Checking flate2 v1.0.2 [INFO] [stderr] Checking chrono v0.4.5 [INFO] [stderr] Checking aligned_alloc v0.1.3 [INFO] [stderr] Checking serde-value v0.5.2 [INFO] [stderr] Checking mio v0.6.15 [INFO] [stderr] Checking tokio-io v0.1.8 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking tokio-threadpool v0.1.6 [INFO] [stderr] Checking stopwatch v0.0.7 [INFO] [stderr] Checking log4rs v0.8.0 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking h2 v0.1.12 [INFO] [stderr] Checking tokio-reactor v0.1.4 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.1 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking sct v0.4.0 [INFO] [stderr] Checking webpki v0.18.1 [INFO] [stderr] Checking tokio v0.1.8 [INFO] [stderr] Checking webpki-roots v0.15.0 [INFO] [stderr] Checking rustls v0.13.1 [INFO] [stderr] Checking ct-logs v0.4.0 [INFO] [stderr] Checking hyper v0.12.8 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-rustls v0.7.2 [INFO] [stderr] Checking hyper-rustls v0.14.0 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plot.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | account_id: account_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `account_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plot.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | account_id: account_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `account_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/plot.rs:207:12 [INFO] [stderr] | [INFO] [stderr] 207 | if self.start_nonce <= plot.start_nonce + plot.nonces - 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 207 | if self.start_nonce < plot.start_nonce + plot.nonces [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/plot.rs:208:16 [INFO] [stderr] | [INFO] [stderr] 208 | && plot.start_nonce <= self.start_nonce + self.nonces - 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 208 | && plot.start_nonce < self.start_nonce + self.nonces [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/plot.rs:207:12 [INFO] [stderr] | [INFO] [stderr] 207 | if self.start_nonce <= plot.start_nonce + plot.nonces - 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 207 | if self.start_nonce < plot.start_nonce + plot.nonces [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/plot.rs:208:16 [INFO] [stderr] | [INFO] [stderr] 208 | && plot.start_nonce <= self.start_nonce + self.nonces - 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 208 | && plot.start_nonce < self.start_nonce + self.nonces [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/miner.rs:115:6 [INFO] [stderr] | [INFO] [stderr] 115 | ) -> (HashMap>>>>, u64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/miner.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | / let mut core_ids: Vec = Vec::new(); [INFO] [stderr] 233 | | if cfg.cpu_thread_pinning { [INFO] [stderr] 234 | | core_ids = core_affinity::get_core_ids().unwrap(); [INFO] [stderr] 235 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let core_ids = if cfg.cpu_thread_pinning { core_affinity::get_core_ids().unwrap() } else { Vec::new() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/reader.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn new( [INFO] [stderr] 44 | | drive_id_to_plots: HashMap>>>>, [INFO] [stderr] 45 | | total_size: u64, [INFO] [stderr] 46 | | num_threads: usize, [INFO] [stderr] ... | [INFO] [stderr] 91 | | } [INFO] [stderr] 92 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/reader.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / let mut core_ids: Vec = Vec::new(); [INFO] [stderr] 65 | | if thread_pinning { [INFO] [stderr] 66 | | core_ids = core_affinity::get_core_ids().unwrap(); [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let core_ids = if thread_pinning { core_affinity::get_core_ids().unwrap() } else { Vec::new() };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/reader.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / fn create_read_task( [INFO] [stderr] 155 | | &self, [INFO] [stderr] 156 | | pb: Option>>>, [INFO] [stderr] 157 | | drive: String, [INFO] [stderr] ... | [INFO] [stderr] 280 | | }) [INFO] [stderr] 281 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/requests.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn submit_nonce( [INFO] [stderr] 155 | | &self, [INFO] [stderr] 156 | | handle: &Handle, [INFO] [stderr] 157 | | account_id: u64, [INFO] [stderr] ... | [INFO] [stderr] 229 | | )); [INFO] [stderr] 230 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/requests.rs:244:46 [INFO] [stderr] | [INFO] [stderr] 244 | hostname::get_hostname().unwrap_or("".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/requests.rs:248:54 [INFO] [stderr] | [INFO] [stderr] 248 | + &*hostname::get_hostname().unwrap_or("".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/miner.rs:115:6 [INFO] [stderr] | [INFO] [stderr] 115 | ) -> (HashMap>>>>, u64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/miner.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | / let mut core_ids: Vec = Vec::new(); [INFO] [stderr] 233 | | if cfg.cpu_thread_pinning { [INFO] [stderr] 234 | | core_ids = core_affinity::get_core_ids().unwrap(); [INFO] [stderr] 235 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let core_ids = if cfg.cpu_thread_pinning { core_affinity::get_core_ids().unwrap() } else { Vec::new() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/reader.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | / pub fn new( [INFO] [stderr] 44 | | drive_id_to_plots: HashMap>>>>, [INFO] [stderr] 45 | | total_size: u64, [INFO] [stderr] 46 | | num_threads: usize, [INFO] [stderr] ... | [INFO] [stderr] 91 | | } [INFO] [stderr] 92 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/reader.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / let mut core_ids: Vec = Vec::new(); [INFO] [stderr] 65 | | if thread_pinning { [INFO] [stderr] 66 | | core_ids = core_affinity::get_core_ids().unwrap(); [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let core_ids = if thread_pinning { core_affinity::get_core_ids().unwrap() } else { Vec::new() };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/reader.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / fn create_read_task( [INFO] [stderr] 155 | | &self, [INFO] [stderr] 156 | | pb: Option>>>, [INFO] [stderr] 157 | | drive: String, [INFO] [stderr] ... | [INFO] [stderr] 280 | | }) [INFO] [stderr] 281 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/requests.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn submit_nonce( [INFO] [stderr] 155 | | &self, [INFO] [stderr] 156 | | handle: &Handle, [INFO] [stderr] 157 | | account_id: u64, [INFO] [stderr] ... | [INFO] [stderr] 229 | | )); [INFO] [stderr] 230 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/requests.rs:244:46 [INFO] [stderr] | [INFO] [stderr] 244 | hostname::get_hostname().unwrap_or("".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/requests.rs:248:54 [INFO] [stderr] | [INFO] [stderr] 248 | + &*hostname::get_hostname().unwrap_or("".to_owned()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 59.75s [INFO] running `"docker" "inspect" "0bf60500c1faa0b16bcb9fb09130fa256262dd987d906ce82470ccbe4ffc20d9"` [INFO] running `"docker" "rm" "-f" "0bf60500c1faa0b16bcb9fb09130fa256262dd987d906ce82470ccbe4ffc20d9"` [INFO] [stdout] 0bf60500c1faa0b16bcb9fb09130fa256262dd987d906ce82470ccbe4ffc20d9