[INFO] updating cached repository Ploppz/test-specs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Ploppz/test-specs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Ploppz/test-specs" "work/ex/clippy-test-run/sources/stable/gh/Ploppz/test-specs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Ploppz/test-specs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Ploppz/test-specs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ploppz/test-specs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ploppz/test-specs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0b8a953b6e46daab70246394dacb01b54a9db7fd [INFO] sha for GitHub repo Ploppz/test-specs: 0b8a953b6e46daab70246394dacb01b54a9db7fd [INFO] validating manifest of Ploppz/test-specs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Ploppz/test-specs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Ploppz/test-specs [INFO] finished frobbing Ploppz/test-specs [INFO] frobbed toml for Ploppz/test-specs written to work/ex/clippy-test-run/sources/stable/gh/Ploppz/test-specs/Cargo.toml [INFO] started frobbing Ploppz/test-specs [INFO] finished frobbing Ploppz/test-specs [INFO] frobbed toml for Ploppz/test-specs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ploppz/test-specs/Cargo.toml [INFO] crate Ploppz/test-specs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Ploppz/test-specs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Ploppz/test-specs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b90726478b02593a25f65f23eaed126a02f13e0ec7f24c546a1abbad4a1f1fa7 [INFO] running `"docker" "start" "-a" "b90726478b02593a25f65f23eaed126a02f13e0ec7f24c546a1abbad4a1f1fa7"` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/src/main.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] warning: path `/opt/crater/workdir/src/main.rs` was erroneously implicitly accepted for binary `spinning-square`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] Checking ticketed_lock v0.1.0 [INFO] [stderr] Checking pulse v0.5.3 [INFO] [stderr] Checking specs v0.8.1 [INFO] [stderr] Checking test-specs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vec.rs:15:16 [INFO] [stderr] | [INFO] [stderr] 15 | Vec2 { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vec.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | Vec2 { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | planner: planner, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `planner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vec.rs:15:16 [INFO] [stderr] | [INFO] [stderr] 15 | Vec2 { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vec.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | Vec2 { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | planner: planner, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `planner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ren` [INFO] [stderr] --> src/main.rs:148:23 [INFO] [stderr] | [INFO] [stderr] 148 | for (pos, ren) in (&pos.pass(), &ren.pass()).join() { [INFO] [stderr] | ^^^ help: consider using `_ren` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/main.rs:141:14 [INFO] [stderr] | [INFO] [stderr] 141 | let (x, y) = ((args.width / 2) as f64, [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/main.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | let (x, y) = ((args.width / 2) as f64, [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/main.rs:157:26 [INFO] [stderr] | [INFO] [stderr] 157 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:66:14 [INFO] [stderr] | [INFO] [stderr] 66 | let (mut force, attraction, pos) = arg.fetch(|w| (w.write::(), w.read::(), w.read::()) ); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:75:14 [INFO] [stderr] | [INFO] [stderr] 75 | let (mut vel, force) = arg.fetch(|w| (w.write::(), w.read::()) ); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:84:14 [INFO] [stderr] | [INFO] [stderr] 84 | let (mut pos, vel) = arg.fetch(|w| (w.write::(), w.read::()) ); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `null_vec` [INFO] [stderr] --> src/vec.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn null_vec() -> Vec2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/vec.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn new(x: f32, y: f32) -> Vec2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `length` [INFO] [stderr] --> src/vec.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn length(&self) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `length_squared` [INFO] [stderr] --> src/vec.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn length_squared(&self) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `normalize` [INFO] [stderr] --> src/vec.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn normalize(&self) -> Vec2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `scale` [INFO] [stderr] --> src/vec.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn scale(&self, x: f32, y: f32) -> Vec2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `scale_uni` [INFO] [stderr] --> src/vec.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn scale_uni(&self, s: f32) -> Vec2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `dot` [INFO] [stderr] --> src/vec.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn dot(a: Vec2, b: Vec2) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cross` [INFO] [stderr] --> src/vec.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn cross(a: Vec2, b: Vec2) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vec.rs:17:19 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn length(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vec.rs:20:27 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn length_squared(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vec.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn normalize(&self) -> Vec2 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vec.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn scale(&self, x: f32, y: f32) -> Vec2 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vec.rs:31:22 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn scale_uni(&self, s: f32) -> Vec2 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ren` [INFO] [stderr] --> src/main.rs:148:23 [INFO] [stderr] | [INFO] [stderr] 148 | for (pos, ren) in (&pos.pass(), &ren.pass()).join() { [INFO] [stderr] | ^^^ help: consider using `_ren` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/main.rs:141:14 [INFO] [stderr] | [INFO] [stderr] 141 | let (x, y) = ((args.width / 2) as f64, [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/main.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | let (x, y) = ((args.width / 2) as f64, [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/main.rs:157:26 [INFO] [stderr] | [INFO] [stderr] 157 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:141:23 [INFO] [stderr] | [INFO] [stderr] 141 | let (x, y) = ((args.width / 2) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width / 2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:142:23 [INFO] [stderr] | [INFO] [stderr] 142 | (args.height / 2) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:149:51 [INFO] [stderr] | [INFO] [stderr] 149 | let transform = c.transform.trans(pos.0.x as f64, pos.0.y as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(pos.0.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:149:67 [INFO] [stderr] | [INFO] [stderr] 149 | let transform = c.transform.trans(pos.0.x as f64, pos.0.y as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(pos.0.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:157:32 [INFO] [stderr] | [INFO] [stderr] 157 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:66:14 [INFO] [stderr] | [INFO] [stderr] 66 | let (mut force, attraction, pos) = arg.fetch(|w| (w.write::(), w.read::(), w.read::()) ); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:75:14 [INFO] [stderr] | [INFO] [stderr] 75 | let (mut vel, force) = arg.fetch(|w| (w.write::(), w.read::()) ); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:84:14 [INFO] [stderr] | [INFO] [stderr] 84 | let (mut pos, vel) = arg.fetch(|w| (w.write::(), w.read::()) ); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `null_vec` [INFO] [stderr] --> src/vec.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn null_vec() -> Vec2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/vec.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn new(x: f32, y: f32) -> Vec2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `length` [INFO] [stderr] --> src/vec.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn length(&self) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `length_squared` [INFO] [stderr] --> src/vec.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn length_squared(&self) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `normalize` [INFO] [stderr] --> src/vec.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn normalize(&self) -> Vec2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `scale` [INFO] [stderr] --> src/vec.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn scale(&self, x: f32, y: f32) -> Vec2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `scale_uni` [INFO] [stderr] --> src/vec.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn scale_uni(&self, s: f32) -> Vec2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `dot` [INFO] [stderr] --> src/vec.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn dot(a: Vec2, b: Vec2) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cross` [INFO] [stderr] --> src/vec.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn cross(a: Vec2, b: Vec2) -> f32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vec.rs:17:19 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn length(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vec.rs:20:27 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn length_squared(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vec.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn normalize(&self) -> Vec2 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vec.rs:28:18 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn scale(&self, x: f32, y: f32) -> Vec2 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/vec.rs:31:22 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn scale_uni(&self, s: f32) -> Vec2 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:141:23 [INFO] [stderr] | [INFO] [stderr] 141 | let (x, y) = ((args.width / 2) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width / 2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:142:23 [INFO] [stderr] | [INFO] [stderr] 142 | (args.height / 2) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:149:51 [INFO] [stderr] | [INFO] [stderr] 149 | let transform = c.transform.trans(pos.0.x as f64, pos.0.y as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(pos.0.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:149:67 [INFO] [stderr] | [INFO] [stderr] 149 | let transform = c.transform.trans(pos.0.x as f64, pos.0.y as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(pos.0.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:157:32 [INFO] [stderr] | [INFO] [stderr] 157 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.09s [INFO] running `"docker" "inspect" "b90726478b02593a25f65f23eaed126a02f13e0ec7f24c546a1abbad4a1f1fa7"` [INFO] running `"docker" "rm" "-f" "b90726478b02593a25f65f23eaed126a02f13e0ec7f24c546a1abbad4a1f1fa7"` [INFO] [stdout] b90726478b02593a25f65f23eaed126a02f13e0ec7f24c546a1abbad4a1f1fa7