[INFO] updating cached repository Ploppz/ecs-test [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Ploppz/ecs-test [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Ploppz/ecs-test" "work/ex/clippy-test-run/sources/stable/gh/Ploppz/ecs-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Ploppz/ecs-test'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Ploppz/ecs-test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ploppz/ecs-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ploppz/ecs-test'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 596a6a6d3d660143d2496ae93ca435130e73b52b [INFO] sha for GitHub repo Ploppz/ecs-test: 596a6a6d3d660143d2496ae93ca435130e73b52b [INFO] validating manifest of Ploppz/ecs-test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Ploppz/ecs-test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Ploppz/ecs-test [INFO] finished frobbing Ploppz/ecs-test [INFO] frobbed toml for Ploppz/ecs-test written to work/ex/clippy-test-run/sources/stable/gh/Ploppz/ecs-test/Cargo.toml [INFO] started frobbing Ploppz/ecs-test [INFO] finished frobbing Ploppz/ecs-test [INFO] frobbed toml for Ploppz/ecs-test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Ploppz/ecs-test/Cargo.toml [INFO] crate Ploppz/ecs-test has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Ploppz/ecs-test against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Ploppz/ecs-test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8ee0dab01d748b57a84fd1330df4df665164fe3b11d122aef80f35ba191898e2 [INFO] running `"docker" "start" "-a" "8ee0dab01d748b57a84fd1330df4df665164fe3b11d122aef80f35ba191898e2"` [INFO] [stderr] Checking vec_map v0.4.0 [INFO] [stderr] Checking deflate v0.7.6 [INFO] [stderr] Checking rayon-core v1.0.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.35.1 [INFO] [stderr] Checking ecs v0.23.1 [INFO] [stderr] Checking rayon v0.7.0 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Checking jpeg-decoder v0.1.12 [INFO] [stderr] Checking image v0.12.4 [INFO] [stderr] Checking piston2d-opengl_graphics v0.42.1 [INFO] [stderr] Checking test-ecs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | world: world, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `world` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | world: world, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `world` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:149:23 [INFO] [stderr] | [INFO] [stderr] 149 | let (x, y) = ((args.width / 2) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width / 2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:150:23 [INFO] [stderr] | [INFO] [stderr] 150 | (args.height / 2) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:165:32 [INFO] [stderr] | [INFO] [stderr] 165 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:149:23 [INFO] [stderr] | [INFO] [stderr] 149 | let (x, y) = ((args.width / 2) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.width / 2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:150:23 [INFO] [stderr] | [INFO] [stderr] 150 | (args.height / 2) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(args.height / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:165:32 [INFO] [stderr] | [INFO] [stderr] 165 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.93s [INFO] running `"docker" "inspect" "8ee0dab01d748b57a84fd1330df4df665164fe3b11d122aef80f35ba191898e2"` [INFO] running `"docker" "rm" "-f" "8ee0dab01d748b57a84fd1330df4df665164fe3b11d122aef80f35ba191898e2"` [INFO] [stdout] 8ee0dab01d748b57a84fd1330df4df665164fe3b11d122aef80f35ba191898e2