[INFO] updating cached repository PlasmaPower/optimal-distance [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/PlasmaPower/optimal-distance [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/PlasmaPower/optimal-distance" "work/ex/clippy-test-run/sources/stable/gh/PlasmaPower/optimal-distance"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/PlasmaPower/optimal-distance'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/PlasmaPower/optimal-distance" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PlasmaPower/optimal-distance"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PlasmaPower/optimal-distance'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 201b4c2132712c51a8cd9dbb242160f1697b045d [INFO] sha for GitHub repo PlasmaPower/optimal-distance: 201b4c2132712c51a8cd9dbb242160f1697b045d [INFO] validating manifest of PlasmaPower/optimal-distance on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of PlasmaPower/optimal-distance on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing PlasmaPower/optimal-distance [INFO] finished frobbing PlasmaPower/optimal-distance [INFO] frobbed toml for PlasmaPower/optimal-distance written to work/ex/clippy-test-run/sources/stable/gh/PlasmaPower/optimal-distance/Cargo.toml [INFO] started frobbing PlasmaPower/optimal-distance [INFO] finished frobbing PlasmaPower/optimal-distance [INFO] frobbed toml for PlasmaPower/optimal-distance written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PlasmaPower/optimal-distance/Cargo.toml [INFO] crate PlasmaPower/optimal-distance has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting PlasmaPower/optimal-distance against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/PlasmaPower/optimal-distance:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e8fbffc0e0025c7737a35302a1605d8b61ee92360fee16729260f0ef2f14eab4 [INFO] running `"docker" "start" "-a" "e8fbffc0e0025c7737a35302a1605d8b61ee92360fee16729260f0ef2f14eab4"` [INFO] [stderr] Checking optimal-distance v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | let mut hash = 0xcbf29ce484222325; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xcbf2_9ce4_8422_2325` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:49:58 [INFO] [stderr] | [INFO] [stderr] 49 | hash = (hash ^ ((i & 0xff) as u64)).wrapping_mul(0x100000001b3); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x0100_0000_01b3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:50:56 [INFO] [stderr] | [INFO] [stderr] 50 | hash = (hash ^ ((i >> 8) as u64)).wrapping_mul(0x100000001b3); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x0100_0000_01b3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | let mut hash = 0xcbf29ce484222325; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xcbf2_9ce4_8422_2325` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:49:58 [INFO] [stderr] | [INFO] [stderr] 49 | hash = (hash ^ ((i & 0xff) as u64)).wrapping_mul(0x100000001b3); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x0100_0000_01b3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:50:56 [INFO] [stderr] | [INFO] [stderr] 50 | hash = (hash ^ ((i >> 8) as u64)).wrapping_mul(0x100000001b3); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x0100_0000_01b3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:49:24 [INFO] [stderr] | [INFO] [stderr] 49 | hash = (hash ^ ((i & 0xff) as u64)).wrapping_mul(0x100000001b3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(i & 0xff)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:50:24 [INFO] [stderr] | [INFO] [stderr] 50 | hash = (hash ^ ((i >> 8) as u64)).wrapping_mul(0x100000001b3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(i >> 8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:86:30 [INFO] [stderr] | [INFO] [stderr] 86 | for (i, item) in items.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `items` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:101:63 [INFO] [stderr] | [INFO] [stderr] 101 | let index = match r_items.iter().position(|x| x == &item) { [INFO] [stderr] | ^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `item` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | let ref mut distances = distances[index]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^-------------------- help: try: `let distances = &mut distances[index];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:49:24 [INFO] [stderr] | [INFO] [stderr] 49 | hash = (hash ^ ((i & 0xff) as u64)).wrapping_mul(0x100000001b3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(i & 0xff)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:50:24 [INFO] [stderr] | [INFO] [stderr] 50 | hash = (hash ^ ((i >> 8) as u64)).wrapping_mul(0x100000001b3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(i >> 8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:86:30 [INFO] [stderr] | [INFO] [stderr] 86 | for (i, item) in items.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `items` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:101:63 [INFO] [stderr] | [INFO] [stderr] 101 | let index = match r_items.iter().position(|x| x == &item) { [INFO] [stderr] | ^^^^^----- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `item` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | let ref mut distances = distances[index]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^-------------------- help: try: `let distances = &mut distances[index];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.41s [INFO] running `"docker" "inspect" "e8fbffc0e0025c7737a35302a1605d8b61ee92360fee16729260f0ef2f14eab4"` [INFO] running `"docker" "rm" "-f" "e8fbffc0e0025c7737a35302a1605d8b61ee92360fee16729260f0ef2f14eab4"` [INFO] [stdout] e8fbffc0e0025c7737a35302a1605d8b61ee92360fee16729260f0ef2f14eab4