[INFO] updating cached repository PlasmaPower/nano-bip32 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/PlasmaPower/nano-bip32 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/PlasmaPower/nano-bip32" "work/ex/clippy-test-run/sources/stable/gh/PlasmaPower/nano-bip32"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/PlasmaPower/nano-bip32'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/PlasmaPower/nano-bip32" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PlasmaPower/nano-bip32"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PlasmaPower/nano-bip32'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e56bd3d722a9f5a01d1daad434a946591d9bc2f0 [INFO] sha for GitHub repo PlasmaPower/nano-bip32: e56bd3d722a9f5a01d1daad434a946591d9bc2f0 [INFO] validating manifest of PlasmaPower/nano-bip32 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of PlasmaPower/nano-bip32 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing PlasmaPower/nano-bip32 [INFO] finished frobbing PlasmaPower/nano-bip32 [INFO] frobbed toml for PlasmaPower/nano-bip32 written to work/ex/clippy-test-run/sources/stable/gh/PlasmaPower/nano-bip32/Cargo.toml [INFO] started frobbing PlasmaPower/nano-bip32 [INFO] finished frobbing PlasmaPower/nano-bip32 [INFO] frobbed toml for PlasmaPower/nano-bip32 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PlasmaPower/nano-bip32/Cargo.toml [INFO] crate PlasmaPower/nano-bip32 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting PlasmaPower/nano-bip32 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/PlasmaPower/nano-bip32:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 38eca8280ba768212c5cac46a69cd38524aabd5a40c4eb52ed97fb85a9c86281 [INFO] running `"docker" "start" "-a" "38eca8280ba768212c5cac46a69cd38524aabd5a40c4eb52ed97fb85a9c86281"` [INFO] [stderr] Compiling rand_core v0.2.0 [INFO] [stderr] Compiling subtle v0.6.2 [INFO] [stderr] Compiling byteorder v1.2.3 [INFO] [stderr] Compiling clear_on_drop v0.2.3 [INFO] [stderr] Checking rand v0.5.0 [INFO] [stderr] Compiling digest v0.7.2 [INFO] [stderr] Checking crypto-mac v0.6.0 [INFO] [stderr] Checking hmac v0.6.2 [INFO] [stderr] Compiling curve25519-dalek v0.17.0 [INFO] [stderr] Checking nano-bip32 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:59:20 [INFO] [stderr] | [INFO] [stderr] 59 | self.key = &bytes_to_scalar(&result.as_slice()[..32]) + &self.key; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 59 | self.key = bytes_to_scalar(&result.as_slice()[..32]) + self.key; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:66:25 [INFO] [stderr] | [INFO] [stderr] 66 | chain_code: self.chain_code.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.chain_code` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/lib.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | / if key.decompress().is_none() { [INFO] [stderr] 87 | | return None; [INFO] [stderr] 88 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `key.decompress()?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:97:20 [INFO] [stderr] | [INFO] [stderr] 97 | self.key = ((&bytes_to_scalar(&result.as_slice()[..32]) * &ED25519_BASEPOINT_TABLE) + &self.key.decompress().unwrap()).compress(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `self.key.decompress().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:59:20 [INFO] [stderr] | [INFO] [stderr] 59 | self.key = &bytes_to_scalar(&result.as_slice()[..32]) + &self.key; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 59 | self.key = bytes_to_scalar(&result.as_slice()[..32]) + self.key; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:66:25 [INFO] [stderr] | [INFO] [stderr] 66 | chain_code: self.chain_code.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.chain_code` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/lib.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | / if key.decompress().is_none() { [INFO] [stderr] 87 | | return None; [INFO] [stderr] 88 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `key.decompress()?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:97:20 [INFO] [stderr] | [INFO] [stderr] 97 | self.key = ((&bytes_to_scalar(&result.as_slice()[..32]) * &ED25519_BASEPOINT_TABLE) + &self.key.decompress().unwrap()).compress(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^-------------------------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `self.key.decompress().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.36s [INFO] running `"docker" "inspect" "38eca8280ba768212c5cac46a69cd38524aabd5a40c4eb52ed97fb85a9c86281"` [INFO] running `"docker" "rm" "-f" "38eca8280ba768212c5cac46a69cd38524aabd5a40c4eb52ed97fb85a9c86281"` [INFO] [stdout] 38eca8280ba768212c5cac46a69cd38524aabd5a40c4eb52ed97fb85a9c86281