[INFO] updating cached repository PlasmaPower/kmer-counter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/PlasmaPower/kmer-counter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/PlasmaPower/kmer-counter" "work/ex/clippy-test-run/sources/stable/gh/PlasmaPower/kmer-counter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/PlasmaPower/kmer-counter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/PlasmaPower/kmer-counter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PlasmaPower/kmer-counter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PlasmaPower/kmer-counter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2c45214e26574202f848066e0a991ef5274443d0 [INFO] sha for GitHub repo PlasmaPower/kmer-counter: 2c45214e26574202f848066e0a991ef5274443d0 [INFO] validating manifest of PlasmaPower/kmer-counter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of PlasmaPower/kmer-counter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing PlasmaPower/kmer-counter [INFO] finished frobbing PlasmaPower/kmer-counter [INFO] frobbed toml for PlasmaPower/kmer-counter written to work/ex/clippy-test-run/sources/stable/gh/PlasmaPower/kmer-counter/Cargo.toml [INFO] started frobbing PlasmaPower/kmer-counter [INFO] finished frobbing PlasmaPower/kmer-counter [INFO] frobbed toml for PlasmaPower/kmer-counter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PlasmaPower/kmer-counter/Cargo.toml [INFO] crate PlasmaPower/kmer-counter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting PlasmaPower/kmer-counter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/PlasmaPower/kmer-counter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] caaba0aaee36bf015b94377835964088fabc7faf65374bd7d09990d7e3321c03 [INFO] running `"docker" "start" "-a" "caaba0aaee36bf015b94377835964088fabc7faf65374bd7d09990d7e3321c03"` [INFO] [stderr] Checking memmap v0.5.0 [INFO] [stderr] Checking jobsteal v0.5.1 [INFO] [stderr] Checking kmer-counter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kmer_length.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kmer_length.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | bitmask: bitmask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `bitmask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/get_kmers.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/get_kmers.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | kmer_len: kmer_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `kmer_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/get_kmers.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kmer_tree.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | counts: counts, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `counts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error_string.rs:11:23 [INFO] [stderr] | [INFO] [stderr] 11 | ErrorString { description: description } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/readers/mmap.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | mmap: mmap, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/readers/mmap.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | ptr: ptr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/readers/mmap.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsers/multifasta.rs:48:25 [INFO] [stderr] | [INFO] [stderr] 48 | SectionReader { file: file } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | inputs: inputs, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inputs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | min_count: min_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | threads: threads, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `threads` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | join_methods: join_methods, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `join_methods` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kmer_length.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kmer_length.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | bitmask: bitmask, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `bitmask` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/get_kmers.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/get_kmers.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | kmer_len: kmer_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `kmer_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/get_kmers.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kmer_tree.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | counts: counts, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `counts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error_string.rs:11:23 [INFO] [stderr] | [INFO] [stderr] 11 | ErrorString { description: description } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/readers/mmap.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | mmap: mmap, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/readers/mmap.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | ptr: ptr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/readers/mmap.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parsers/multifasta.rs:48:25 [INFO] [stderr] | [INFO] [stderr] 48 | SectionReader { file: file } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | inputs: inputs, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inputs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | min_count: min_count, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | threads: threads, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `threads` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | join_methods: join_methods, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `join_methods` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/sort.rs:3:37 [INFO] [stderr] | [INFO] [stderr] 3 | const SORT_INPUT: [(u8, u8); 8] = [(0b11100001, 1), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/sort.rs:4:37 [INFO] [stderr] | [INFO] [stderr] 4 | (0b01011000, 1), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0101_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/sort.rs:5:37 [INFO] [stderr] | [INFO] [stderr] 5 | (0b01111100, 1), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/sort.rs:6:37 [INFO] [stderr] | [INFO] [stderr] 6 | (0b10100100, 1), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/sort.rs:7:37 [INFO] [stderr] | [INFO] [stderr] 7 | (0b10000001, 1), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/sort.rs:8:37 [INFO] [stderr] | [INFO] [stderr] 8 | (0b01111100, 2), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/sort.rs:9:37 [INFO] [stderr] | [INFO] [stderr] 9 | (0b00010100, 1), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/sort.rs:10:37 [INFO] [stderr] | [INFO] [stderr] 10 | (0b00010100, 2)]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/sort.rs:19:21 [INFO] [stderr] | [INFO] [stderr] 19 | vec![0b00010100, 0b01011000, 0b01111100, 0b10000001, 0b10100100, 0b11100001]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/sort.rs:19:33 [INFO] [stderr] | [INFO] [stderr] 19 | vec![0b00010100, 0b01011000, 0b01111100, 0b10000001, 0b10100100, 0b11100001]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0101_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/sort.rs:19:45 [INFO] [stderr] | [INFO] [stderr] 19 | vec![0b00010100, 0b01011000, 0b01111100, 0b10000001, 0b10100100, 0b11100001]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/sort.rs:19:57 [INFO] [stderr] | [INFO] [stderr] 19 | vec![0b00010100, 0b01011000, 0b01111100, 0b10000001, 0b10100100, 0b11100001]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/sort.rs:19:69 [INFO] [stderr] | [INFO] [stderr] 19 | vec![0b00010100, 0b01011000, 0b01111100, 0b10000001, 0b10100100, 0b11100001]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/sort.rs:19:81 [INFO] [stderr] | [INFO] [stderr] 19 | vec![0b00010100, 0b01011000, 0b01111100, 0b10000001, 0b10100100, 0b11100001]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/sort.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | vec![(0b00010100, 3), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/sort.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | (0b01011000, 1), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0101_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/sort.rs:31:22 [INFO] [stderr] | [INFO] [stderr] 31 | (0b01111100, 3), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/sort.rs:32:22 [INFO] [stderr] | [INFO] [stderr] 32 | (0b10000001, 1), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/sort.rs:33:22 [INFO] [stderr] | [INFO] [stderr] 33 | (0b10100100, 1), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests/sort.rs:34:22 [INFO] [stderr] | [INFO] [stderr] 34 | (0b11100001, 1)]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/kmer_tree.rs:42:24 [INFO] [stderr] | [INFO] [stderr] 42 | while let Some(mut count) = self.counts.get_mut(self.index) { [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/kmer_tree.rs:42:24 [INFO] [stderr] | [INFO] [stderr] 42 | while let Some(mut count) = self.counts.get_mut(self.index) { [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/nucleotide.rs:10:25 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn as_text_byte(self) -> u8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/kmer_length.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | (1 << (2 * (length as u64))) - 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(length)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/get_kmers.rs:18:30 [INFO] [stderr] | [INFO] [stderr] 18 | buffer = n as u64 + (buffer << 2) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/get_kmers.rs:39:27 [INFO] [stderr] | [INFO] [stderr] 39 | self.buffer = n as u64 + ((self.buffer << 2) & self.kmer_len.bitmask()); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/output_counts.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | kmer = kmer >> 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `kmer >>= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/runner.rs:75:83 [INFO] [stderr] | [INFO] [stderr] 75 | section.and_then(|section| get_kmers::Kmers::new(section, kmer_len.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `kmer_len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/nucleotide.rs:10:25 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn as_text_byte(self) -> u8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:96:27 [INFO] [stderr] | [INFO] [stderr] 96 | }).unwrap_or_else(|| Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/kmer_length.rs:10:24 [INFO] [stderr] | [INFO] [stderr] 10 | (1 << (2 * (length as u64))) - 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(length)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/get_kmers.rs:18:30 [INFO] [stderr] | [INFO] [stderr] 18 | buffer = n as u64 + (buffer << 2) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:146:21 [INFO] [stderr] | [INFO] [stderr] 146 | .unwrap_or_else(|| Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the `method @ _` pattern can be written as just `method` [INFO] [stderr] --> src/main.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | method @ _ => { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/get_kmers.rs:39:27 [INFO] [stderr] | [INFO] [stderr] 39 | self.buffer = n as u64 + ((self.buffer << 2) & self.kmer_len.bitmask()); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/output_counts.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | kmer = kmer >> 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `kmer >>= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/runner.rs:75:83 [INFO] [stderr] | [INFO] [stderr] 75 | section.and_then(|section| get_kmers::Kmers::new(section, kmer_len.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `kmer_len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:96:27 [INFO] [stderr] | [INFO] [stderr] 96 | }).unwrap_or_else(|| Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:146:21 [INFO] [stderr] | [INFO] [stderr] 146 | .unwrap_or_else(|| Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the `method @ _` pattern can be written as just `method` [INFO] [stderr] --> src/main.rs:139:17 [INFO] [stderr] | [INFO] [stderr] 139 | method @ _ => { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.05s [INFO] running `"docker" "inspect" "caaba0aaee36bf015b94377835964088fabc7faf65374bd7d09990d7e3321c03"` [INFO] running `"docker" "rm" "-f" "caaba0aaee36bf015b94377835964088fabc7faf65374bd7d09990d7e3321c03"` [INFO] [stdout] caaba0aaee36bf015b94377835964088fabc7faf65374bd7d09990d7e3321c03