[INFO] updating cached repository PlasmaPower/borg-test-wrapper [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/PlasmaPower/borg-test-wrapper [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/PlasmaPower/borg-test-wrapper" "work/ex/clippy-test-run/sources/stable/gh/PlasmaPower/borg-test-wrapper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/PlasmaPower/borg-test-wrapper'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/PlasmaPower/borg-test-wrapper" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PlasmaPower/borg-test-wrapper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PlasmaPower/borg-test-wrapper'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 25580ead1e22a18fa30516f87568dfa5935cce65 [INFO] sha for GitHub repo PlasmaPower/borg-test-wrapper: 25580ead1e22a18fa30516f87568dfa5935cce65 [INFO] validating manifest of PlasmaPower/borg-test-wrapper on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of PlasmaPower/borg-test-wrapper on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing PlasmaPower/borg-test-wrapper [INFO] finished frobbing PlasmaPower/borg-test-wrapper [INFO] frobbed toml for PlasmaPower/borg-test-wrapper written to work/ex/clippy-test-run/sources/stable/gh/PlasmaPower/borg-test-wrapper/Cargo.toml [INFO] started frobbing PlasmaPower/borg-test-wrapper [INFO] finished frobbing PlasmaPower/borg-test-wrapper [INFO] frobbed toml for PlasmaPower/borg-test-wrapper written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PlasmaPower/borg-test-wrapper/Cargo.toml [INFO] crate PlasmaPower/borg-test-wrapper has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting PlasmaPower/borg-test-wrapper against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/PlasmaPower/borg-test-wrapper:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 43e966ad0a841957292fdaec9993033a18b6b49aca5b6cce543f9536c8d518b0 [INFO] running `"docker" "start" "-a" "43e966ad0a841957292fdaec9993033a18b6b49aca5b6cce543f9536c8d518b0"` [INFO] [stderr] Checking serde v1.0.6 [INFO] [stderr] Checking errno v0.2.3 [INFO] [stderr] Compiling serde_derive v1.0.6 [INFO] [stderr] Checking env_logger v0.4.2 [INFO] [stderr] Checking bincode v0.8.0 [INFO] [stderr] Checking serde_json v1.0.2 [INFO] [stderr] Checking test-wrappers v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib/shared.rs:388:13 [INFO] [stderr] | [INFO] [stderr] 388 | ret [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib/shared.rs:357:23 [INFO] [stderr] | [INFO] [stderr] 357 | let ret = match *self { [INFO] [stderr] | _______________________^ [INFO] [stderr] 358 | | CPath::FileDescriptor(fd) => { [INFO] [stderr] 359 | | let mut statbuf: NativeStat = mem::uninitialized(); [INFO] [stderr] 360 | | if INTERNAL_FSTAT(fd, &mut statbuf as *mut _) == 0 { [INFO] [stderr] ... | [INFO] [stderr] 386 | | } [INFO] [stderr] 387 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / wrap! { [INFO] [stderr] 50 | | unsafe fn chmod:ORIG_CHMOD(path: *const c_char, mode: mode_t) -> c_int { [INFO] [stderr] 51 | | chmod_base(CPath::from_path(path, true), mode, |fs_mode| ORIG_CHMOD(path, fs_mode)) [INFO] [stderr] 52 | | } [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / wrap! { [INFO] [stderr] 50 | | unsafe fn chmod:ORIG_CHMOD(path: *const c_char, mode: mode_t) -> c_int { [INFO] [stderr] 51 | | chmod_base(CPath::from_path(path, true), mode, |fs_mode| ORIG_CHMOD(path, fs_mode)) [INFO] [stderr] 52 | | } [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / wrap! { [INFO] [stderr] 50 | | unsafe fn chmod:ORIG_CHMOD(path: *const c_char, mode: mode_t) -> c_int { [INFO] [stderr] 51 | | chmod_base(CPath::from_path(path, true), mode, |fs_mode| ORIG_CHMOD(path, fs_mode)) [INFO] [stderr] 52 | | } [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / wrap! { [INFO] [stderr] 50 | | unsafe fn chmod:ORIG_CHMOD(path: *const c_char, mode: mode_t) -> c_int { [INFO] [stderr] 51 | | chmod_base(CPath::from_path(path, true), mode, |fs_mode| ORIG_CHMOD(path, fs_mode)) [INFO] [stderr] 52 | | } [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / wrap! { [INFO] [stderr] 50 | | unsafe fn chmod:ORIG_CHMOD(path: *const c_char, mode: mode_t) -> c_int { [INFO] [stderr] 51 | | chmod_base(CPath::from_path(path, true), mode, |fs_mode| ORIG_CHMOD(path, fs_mode)) [INFO] [stderr] 52 | | } [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / wrap! { [INFO] [stderr] 50 | | unsafe fn chmod:ORIG_CHMOD(path: *const c_char, mode: mode_t) -> c_int { [INFO] [stderr] 51 | | chmod_base(CPath::from_path(path, true), mode, |fs_mode| ORIG_CHMOD(path, fs_mode)) [INFO] [stderr] 52 | | } [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / wrap! { [INFO] [stderr] 50 | | unsafe fn chmod:ORIG_CHMOD(path: *const c_char, mode: mode_t) -> c_int { [INFO] [stderr] 51 | | chmod_base(CPath::from_path(path, true), mode, |fs_mode| ORIG_CHMOD(path, fs_mode)) [INFO] [stderr] 52 | | } [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | / wrap! { [INFO] [stderr] 116 | | unsafe fn __xstat:ORIG_XSTAT(ver: c_int, path: *const c_char, statbuf: *mut libc::stat) -> c_int { [INFO] [stderr] 117 | | let ret = ORIG_XSTAT(ver, path, statbuf); [INFO] [stderr] 118 | | if ret == 0 { [INFO] [stderr] ... | [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | / wrap! { [INFO] [stderr] 116 | | unsafe fn __xstat:ORIG_XSTAT(ver: c_int, path: *const c_char, statbuf: *mut libc::stat) -> c_int { [INFO] [stderr] 117 | | let ret = ORIG_XSTAT(ver, path, statbuf); [INFO] [stderr] 118 | | if ret == 0 { [INFO] [stderr] ... | [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | / wrap! { [INFO] [stderr] 116 | | unsafe fn __xstat:ORIG_XSTAT(ver: c_int, path: *const c_char, statbuf: *mut libc::stat) -> c_int { [INFO] [stderr] 117 | | let ret = ORIG_XSTAT(ver, path, statbuf); [INFO] [stderr] 118 | | if ret == 0 { [INFO] [stderr] ... | [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | / wrap! { [INFO] [stderr] 116 | | unsafe fn __xstat:ORIG_XSTAT(ver: c_int, path: *const c_char, statbuf: *mut libc::stat) -> c_int { [INFO] [stderr] 117 | | let ret = ORIG_XSTAT(ver, path, statbuf); [INFO] [stderr] 118 | | if ret == 0 { [INFO] [stderr] ... | [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | / wrap! { [INFO] [stderr] 116 | | unsafe fn __xstat:ORIG_XSTAT(ver: c_int, path: *const c_char, statbuf: *mut libc::stat) -> c_int { [INFO] [stderr] 117 | | let ret = ORIG_XSTAT(ver, path, statbuf); [INFO] [stderr] 118 | | if ret == 0 { [INFO] [stderr] ... | [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | / wrap! { [INFO] [stderr] 116 | | unsafe fn __xstat:ORIG_XSTAT(ver: c_int, path: *const c_char, statbuf: *mut libc::stat) -> c_int { [INFO] [stderr] 117 | | let ret = ORIG_XSTAT(ver, path, statbuf); [INFO] [stderr] 118 | | if ret == 0 { [INFO] [stderr] ... | [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | / wrap! { [INFO] [stderr] 116 | | unsafe fn __xstat:ORIG_XSTAT(ver: c_int, path: *const c_char, statbuf: *mut libc::stat) -> c_int { [INFO] [stderr] 117 | | let ret = ORIG_XSTAT(ver, path, statbuf); [INFO] [stderr] 118 | | if ret == 0 { [INFO] [stderr] ... | [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | / wrap! { [INFO] [stderr] 116 | | unsafe fn __xstat:ORIG_XSTAT(ver: c_int, path: *const c_char, statbuf: *mut libc::stat) -> c_int { [INFO] [stderr] 117 | | let ret = ORIG_XSTAT(ver, path, statbuf); [INFO] [stderr] 118 | | if ret == 0 { [INFO] [stderr] ... | [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/files.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / wrap! { [INFO] [stderr] 34 | | unsafe fn unlink:ORIG_UNLINK(path: *const c_char) -> c_int { [INFO] [stderr] 35 | | base_unlink(|| libc::open(path as *const _, O_RDONLY | O_NONBLOCK), || ORIG_UNLINK(path)) [INFO] [stderr] 36 | | } [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/files.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / wrap! { [INFO] [stderr] 34 | | unsafe fn unlink:ORIG_UNLINK(path: *const c_char) -> c_int { [INFO] [stderr] 35 | | base_unlink(|| libc::open(path as *const _, O_RDONLY | O_NONBLOCK), || ORIG_UNLINK(path)) [INFO] [stderr] 36 | | } [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/files.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / wrap! { [INFO] [stderr] 34 | | unsafe fn unlink:ORIG_UNLINK(path: *const c_char) -> c_int { [INFO] [stderr] 35 | | base_unlink(|| libc::open(path as *const _, O_RDONLY | O_NONBLOCK), || ORIG_UNLINK(path)) [INFO] [stderr] 36 | | } [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/file_descriptors.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / wrap! { [INFO] [stderr] 34 | | unsafe fn close:ORIG_CLOSE(fd: c_int) -> c_int { [INFO] [stderr] 35 | | { [INFO] [stderr] 36 | | let daemon_stream = DAEMON_STREAM.lock().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 87 | | } [INFO] [stderr] 88 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/file_descriptors.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / wrap! { [INFO] [stderr] 34 | | unsafe fn close:ORIG_CLOSE(fd: c_int) -> c_int { [INFO] [stderr] 35 | | { [INFO] [stderr] 36 | | let daemon_stream = DAEMON_STREAM.lock().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 87 | | } [INFO] [stderr] 88 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/file_descriptors.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / wrap! { [INFO] [stderr] 34 | | unsafe fn close:ORIG_CLOSE(fd: c_int) -> c_int { [INFO] [stderr] 35 | | { [INFO] [stderr] 36 | | let daemon_stream = DAEMON_STREAM.lock().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 87 | | } [INFO] [stderr] 88 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/file_descriptors.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / wrap! { [INFO] [stderr] 34 | | unsafe fn close:ORIG_CLOSE(fd: c_int) -> c_int { [INFO] [stderr] 35 | | { [INFO] [stderr] 36 | | let daemon_stream = DAEMON_STREAM.lock().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 87 | | } [INFO] [stderr] 88 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib/file_descriptors.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | / if cmd == libc::F_DUPFD || cmd == libc::F_DUPFD_CLOEXEC { [INFO] [stderr] 82 | | if ret >= 0 { [INFO] [stderr] 83 | | let _ = base_dup(fd, ret); [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 81 | if (cmd == libc::F_DUPFD || cmd == libc::F_DUPFD_CLOEXEC) && ret >= 0 { [INFO] [stderr] 82 | let _ = base_dup(fd, ret); [INFO] [stderr] 83 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/creation.rs:50:1 [INFO] [stderr] | [INFO] [stderr] 50 | / wrap! { [INFO] [stderr] 51 | | unsafe fn mkdir:ORIG_MKDIR(path: *const c_char, mode: mode_t) -> c_int { [INFO] [stderr] 52 | | let fs_mode = mode | 0o600; [INFO] [stderr] 53 | | let ret = ORIG_MKDIR(path, fs_mode); [INFO] [stderr] ... | [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/creation.rs:50:1 [INFO] [stderr] | [INFO] [stderr] 50 | / wrap! { [INFO] [stderr] 51 | | unsafe fn mkdir:ORIG_MKDIR(path: *const c_char, mode: mode_t) -> c_int { [INFO] [stderr] 52 | | let fs_mode = mode | 0o600; [INFO] [stderr] 53 | | let ret = ORIG_MKDIR(path, fs_mode); [INFO] [stderr] ... | [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/creation.rs:50:1 [INFO] [stderr] | [INFO] [stderr] 50 | / wrap! { [INFO] [stderr] 51 | | unsafe fn mkdir:ORIG_MKDIR(path: *const c_char, mode: mode_t) -> c_int { [INFO] [stderr] 52 | | let fs_mode = mode | 0o600; [INFO] [stderr] 53 | | let ret = ORIG_MKDIR(path, fs_mode); [INFO] [stderr] ... | [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/creation.rs:50:1 [INFO] [stderr] | [INFO] [stderr] 50 | / wrap! { [INFO] [stderr] 51 | | unsafe fn mkdir:ORIG_MKDIR(path: *const c_char, mode: mode_t) -> c_int { [INFO] [stderr] 52 | | let fs_mode = mode | 0o600; [INFO] [stderr] 53 | | let ret = ORIG_MKDIR(path, fs_mode); [INFO] [stderr] ... | [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/creation.rs:50:1 [INFO] [stderr] | [INFO] [stderr] 50 | / wrap! { [INFO] [stderr] 51 | | unsafe fn mkdir:ORIG_MKDIR(path: *const c_char, mode: mode_t) -> c_int { [INFO] [stderr] 52 | | let fs_mode = mode | 0o600; [INFO] [stderr] 53 | | let ret = ORIG_MKDIR(path, fs_mode); [INFO] [stderr] ... | [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/creation.rs:111:1 [INFO] [stderr] | [INFO] [stderr] 111 | / wrap! { [INFO] [stderr] 112 | | unsafe fn __xmknod:ORIG_XMKNOD(ver: c_int, path: *const c_char, mode: mode_t, dev: *const dev_t) -> c_int { [INFO] [stderr] 113 | | mknod_base(|| CPath::from_path(path, false), mode, *dev, |mode| ORIG_XMKNOD(ver, path, mode, dev)) [INFO] [stderr] 114 | | } [INFO] [stderr] ... | [INFO] [stderr] 147 | | } [INFO] [stderr] 148 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/creation.rs:111:1 [INFO] [stderr] | [INFO] [stderr] 111 | / wrap! { [INFO] [stderr] 112 | | unsafe fn __xmknod:ORIG_XMKNOD(ver: c_int, path: *const c_char, mode: mode_t, dev: *const dev_t) -> c_int { [INFO] [stderr] 113 | | mknod_base(|| CPath::from_path(path, false), mode, *dev, |mode| ORIG_XMKNOD(ver, path, mode, dev)) [INFO] [stderr] 114 | | } [INFO] [stderr] ... | [INFO] [stderr] 147 | | } [INFO] [stderr] 148 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/creation.rs:111:1 [INFO] [stderr] | [INFO] [stderr] 111 | / wrap! { [INFO] [stderr] 112 | | unsafe fn __xmknod:ORIG_XMKNOD(ver: c_int, path: *const c_char, mode: mode_t, dev: *const dev_t) -> c_int { [INFO] [stderr] 113 | | mknod_base(|| CPath::from_path(path, false), mode, *dev, |mode| ORIG_XMKNOD(ver, path, mode, dev)) [INFO] [stderr] 114 | | } [INFO] [stderr] ... | [INFO] [stderr] 147 | | } [INFO] [stderr] 148 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/creation.rs:111:1 [INFO] [stderr] | [INFO] [stderr] 111 | / wrap! { [INFO] [stderr] 112 | | unsafe fn __xmknod:ORIG_XMKNOD(ver: c_int, path: *const c_char, mode: mode_t, dev: *const dev_t) -> c_int { [INFO] [stderr] 113 | | mknod_base(|| CPath::from_path(path, false), mode, *dev, |mode| ORIG_XMKNOD(ver, path, mode, dev)) [INFO] [stderr] 114 | | } [INFO] [stderr] ... | [INFO] [stderr] 147 | | } [INFO] [stderr] 148 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/creation.rs:111:1 [INFO] [stderr] | [INFO] [stderr] 111 | / wrap! { [INFO] [stderr] 112 | | unsafe fn __xmknod:ORIG_XMKNOD(ver: c_int, path: *const c_char, mode: mode_t, dev: *const dev_t) -> c_int { [INFO] [stderr] 113 | | mknod_base(|| CPath::from_path(path, false), mode, *dev, |mode| ORIG_XMKNOD(ver, path, mode, dev)) [INFO] [stderr] 114 | | } [INFO] [stderr] ... | [INFO] [stderr] 147 | | } [INFO] [stderr] 148 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/xattrs.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / wrap! { [INFO] [stderr] 71 | | unsafe fn setxattr:_(path: *const c_char, name: *const c_char, value: *const c_void, size: usize, flags: c_int) -> c_int { [INFO] [stderr] 72 | | base_set(CPath::from_path(path, true), name, value, size, flags) [INFO] [stderr] 73 | | } [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/xattrs.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / wrap! { [INFO] [stderr] 71 | | unsafe fn setxattr:_(path: *const c_char, name: *const c_char, value: *const c_void, size: usize, flags: c_int) -> c_int { [INFO] [stderr] 72 | | base_set(CPath::from_path(path, true), name, value, size, flags) [INFO] [stderr] 73 | | } [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/xattrs.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / wrap! { [INFO] [stderr] 71 | | unsafe fn setxattr:_(path: *const c_char, name: *const c_char, value: *const c_void, size: usize, flags: c_int) -> c_int { [INFO] [stderr] 72 | | base_set(CPath::from_path(path, true), name, value, size, flags) [INFO] [stderr] 73 | | } [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/xattrs.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / wrap! { [INFO] [stderr] 71 | | unsafe fn setxattr:_(path: *const c_char, name: *const c_char, value: *const c_void, size: usize, flags: c_int) -> c_int { [INFO] [stderr] 72 | | base_set(CPath::from_path(path, true), name, value, size, flags) [INFO] [stderr] 73 | | } [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/xattrs.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / wrap! { [INFO] [stderr] 71 | | unsafe fn setxattr:_(path: *const c_char, name: *const c_char, value: *const c_void, size: usize, flags: c_int) -> c_int { [INFO] [stderr] 72 | | base_set(CPath::from_path(path, true), name, value, size, flags) [INFO] [stderr] 73 | | } [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/xattrs.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / wrap! { [INFO] [stderr] 71 | | unsafe fn setxattr:_(path: *const c_char, name: *const c_char, value: *const c_void, size: usize, flags: c_int) -> c_int { [INFO] [stderr] 72 | | base_set(CPath::from_path(path, true), name, value, size, flags) [INFO] [stderr] 73 | | } [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/xattrs.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / wrap! { [INFO] [stderr] 71 | | unsafe fn setxattr:_(path: *const c_char, name: *const c_char, value: *const c_void, size: usize, flags: c_int) -> c_int { [INFO] [stderr] 72 | | base_set(CPath::from_path(path, true), name, value, size, flags) [INFO] [stderr] 73 | | } [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/xattrs.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / wrap! { [INFO] [stderr] 71 | | unsafe fn setxattr:_(path: *const c_char, name: *const c_char, value: *const c_void, size: usize, flags: c_int) -> c_int { [INFO] [stderr] 72 | | base_set(CPath::from_path(path, true), name, value, size, flags) [INFO] [stderr] 73 | | } [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/xattrs.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / wrap! { [INFO] [stderr] 71 | | unsafe fn setxattr:_(path: *const c_char, name: *const c_char, value: *const c_void, size: usize, flags: c_int) -> c_int { [INFO] [stderr] 72 | | base_set(CPath::from_path(path, true), name, value, size, flags) [INFO] [stderr] 73 | | } [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib/shared.rs:388:13 [INFO] [stderr] | [INFO] [stderr] 388 | ret [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib/shared.rs:357:23 [INFO] [stderr] | [INFO] [stderr] 357 | let ret = match *self { [INFO] [stderr] | _______________________^ [INFO] [stderr] 358 | | CPath::FileDescriptor(fd) => { [INFO] [stderr] 359 | | let mut statbuf: NativeStat = mem::uninitialized(); [INFO] [stderr] 360 | | if INTERNAL_FSTAT(fd, &mut statbuf as *mut _) == 0 { [INFO] [stderr] ... | [INFO] [stderr] 386 | | } [INFO] [stderr] 387 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / wrap! { [INFO] [stderr] 50 | | unsafe fn chmod:ORIG_CHMOD(path: *const c_char, mode: mode_t) -> c_int { [INFO] [stderr] 51 | | chmod_base(CPath::from_path(path, true), mode, |fs_mode| ORIG_CHMOD(path, fs_mode)) [INFO] [stderr] 52 | | } [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / wrap! { [INFO] [stderr] 50 | | unsafe fn chmod:ORIG_CHMOD(path: *const c_char, mode: mode_t) -> c_int { [INFO] [stderr] 51 | | chmod_base(CPath::from_path(path, true), mode, |fs_mode| ORIG_CHMOD(path, fs_mode)) [INFO] [stderr] 52 | | } [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / wrap! { [INFO] [stderr] 50 | | unsafe fn chmod:ORIG_CHMOD(path: *const c_char, mode: mode_t) -> c_int { [INFO] [stderr] 51 | | chmod_base(CPath::from_path(path, true), mode, |fs_mode| ORIG_CHMOD(path, fs_mode)) [INFO] [stderr] 52 | | } [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / wrap! { [INFO] [stderr] 50 | | unsafe fn chmod:ORIG_CHMOD(path: *const c_char, mode: mode_t) -> c_int { [INFO] [stderr] 51 | | chmod_base(CPath::from_path(path, true), mode, |fs_mode| ORIG_CHMOD(path, fs_mode)) [INFO] [stderr] 52 | | } [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / wrap! { [INFO] [stderr] 50 | | unsafe fn chmod:ORIG_CHMOD(path: *const c_char, mode: mode_t) -> c_int { [INFO] [stderr] 51 | | chmod_base(CPath::from_path(path, true), mode, |fs_mode| ORIG_CHMOD(path, fs_mode)) [INFO] [stderr] 52 | | } [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / wrap! { [INFO] [stderr] 50 | | unsafe fn chmod:ORIG_CHMOD(path: *const c_char, mode: mode_t) -> c_int { [INFO] [stderr] 51 | | chmod_base(CPath::from_path(path, true), mode, |fs_mode| ORIG_CHMOD(path, fs_mode)) [INFO] [stderr] 52 | | } [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / wrap! { [INFO] [stderr] 50 | | unsafe fn chmod:ORIG_CHMOD(path: *const c_char, mode: mode_t) -> c_int { [INFO] [stderr] 51 | | chmod_base(CPath::from_path(path, true), mode, |fs_mode| ORIG_CHMOD(path, fs_mode)) [INFO] [stderr] 52 | | } [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | / wrap! { [INFO] [stderr] 116 | | unsafe fn __xstat:ORIG_XSTAT(ver: c_int, path: *const c_char, statbuf: *mut libc::stat) -> c_int { [INFO] [stderr] 117 | | let ret = ORIG_XSTAT(ver, path, statbuf); [INFO] [stderr] 118 | | if ret == 0 { [INFO] [stderr] ... | [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | / wrap! { [INFO] [stderr] 116 | | unsafe fn __xstat:ORIG_XSTAT(ver: c_int, path: *const c_char, statbuf: *mut libc::stat) -> c_int { [INFO] [stderr] 117 | | let ret = ORIG_XSTAT(ver, path, statbuf); [INFO] [stderr] 118 | | if ret == 0 { [INFO] [stderr] ... | [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | / wrap! { [INFO] [stderr] 116 | | unsafe fn __xstat:ORIG_XSTAT(ver: c_int, path: *const c_char, statbuf: *mut libc::stat) -> c_int { [INFO] [stderr] 117 | | let ret = ORIG_XSTAT(ver, path, statbuf); [INFO] [stderr] 118 | | if ret == 0 { [INFO] [stderr] ... | [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | / wrap! { [INFO] [stderr] 116 | | unsafe fn __xstat:ORIG_XSTAT(ver: c_int, path: *const c_char, statbuf: *mut libc::stat) -> c_int { [INFO] [stderr] 117 | | let ret = ORIG_XSTAT(ver, path, statbuf); [INFO] [stderr] 118 | | if ret == 0 { [INFO] [stderr] ... | [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | / wrap! { [INFO] [stderr] 116 | | unsafe fn __xstat:ORIG_XSTAT(ver: c_int, path: *const c_char, statbuf: *mut libc::stat) -> c_int { [INFO] [stderr] 117 | | let ret = ORIG_XSTAT(ver, path, statbuf); [INFO] [stderr] 118 | | if ret == 0 { [INFO] [stderr] ... | [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | / wrap! { [INFO] [stderr] 116 | | unsafe fn __xstat:ORIG_XSTAT(ver: c_int, path: *const c_char, statbuf: *mut libc::stat) -> c_int { [INFO] [stderr] 117 | | let ret = ORIG_XSTAT(ver, path, statbuf); [INFO] [stderr] 118 | | if ret == 0 { [INFO] [stderr] ... | [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | / wrap! { [INFO] [stderr] 116 | | unsafe fn __xstat:ORIG_XSTAT(ver: c_int, path: *const c_char, statbuf: *mut libc::stat) -> c_int { [INFO] [stderr] 117 | | let ret = ORIG_XSTAT(ver, path, statbuf); [INFO] [stderr] 118 | | if ret == 0 { [INFO] [stderr] ... | [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/permissions.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | / wrap! { [INFO] [stderr] 116 | | unsafe fn __xstat:ORIG_XSTAT(ver: c_int, path: *const c_char, statbuf: *mut libc::stat) -> c_int { [INFO] [stderr] 117 | | let ret = ORIG_XSTAT(ver, path, statbuf); [INFO] [stderr] 118 | | if ret == 0 { [INFO] [stderr] ... | [INFO] [stderr] 178 | | } [INFO] [stderr] 179 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/files.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / wrap! { [INFO] [stderr] 34 | | unsafe fn unlink:ORIG_UNLINK(path: *const c_char) -> c_int { [INFO] [stderr] 35 | | base_unlink(|| libc::open(path as *const _, O_RDONLY | O_NONBLOCK), || ORIG_UNLINK(path)) [INFO] [stderr] 36 | | } [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/files.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / wrap! { [INFO] [stderr] 34 | | unsafe fn unlink:ORIG_UNLINK(path: *const c_char) -> c_int { [INFO] [stderr] 35 | | base_unlink(|| libc::open(path as *const _, O_RDONLY | O_NONBLOCK), || ORIG_UNLINK(path)) [INFO] [stderr] 36 | | } [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/files.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / wrap! { [INFO] [stderr] 34 | | unsafe fn unlink:ORIG_UNLINK(path: *const c_char) -> c_int { [INFO] [stderr] 35 | | base_unlink(|| libc::open(path as *const _, O_RDONLY | O_NONBLOCK), || ORIG_UNLINK(path)) [INFO] [stderr] 36 | | } [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/file_descriptors.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / wrap! { [INFO] [stderr] 34 | | unsafe fn close:ORIG_CLOSE(fd: c_int) -> c_int { [INFO] [stderr] 35 | | { [INFO] [stderr] 36 | | let daemon_stream = DAEMON_STREAM.lock().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 87 | | } [INFO] [stderr] 88 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/file_descriptors.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / wrap! { [INFO] [stderr] 34 | | unsafe fn close:ORIG_CLOSE(fd: c_int) -> c_int { [INFO] [stderr] 35 | | { [INFO] [stderr] 36 | | let daemon_stream = DAEMON_STREAM.lock().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 87 | | } [INFO] [stderr] 88 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/file_descriptors.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / wrap! { [INFO] [stderr] 34 | | unsafe fn close:ORIG_CLOSE(fd: c_int) -> c_int { [INFO] [stderr] 35 | | { [INFO] [stderr] 36 | | let daemon_stream = DAEMON_STREAM.lock().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 87 | | } [INFO] [stderr] 88 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/file_descriptors.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | / wrap! { [INFO] [stderr] 34 | | unsafe fn close:ORIG_CLOSE(fd: c_int) -> c_int { [INFO] [stderr] 35 | | { [INFO] [stderr] 36 | | let daemon_stream = DAEMON_STREAM.lock().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 87 | | } [INFO] [stderr] 88 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib/file_descriptors.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | / if cmd == libc::F_DUPFD || cmd == libc::F_DUPFD_CLOEXEC { [INFO] [stderr] 82 | | if ret >= 0 { [INFO] [stderr] 83 | | let _ = base_dup(fd, ret); [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 81 | if (cmd == libc::F_DUPFD || cmd == libc::F_DUPFD_CLOEXEC) && ret >= 0 { [INFO] [stderr] 82 | let _ = base_dup(fd, ret); [INFO] [stderr] 83 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/creation.rs:50:1 [INFO] [stderr] | [INFO] [stderr] 50 | / wrap! { [INFO] [stderr] 51 | | unsafe fn mkdir:ORIG_MKDIR(path: *const c_char, mode: mode_t) -> c_int { [INFO] [stderr] 52 | | let fs_mode = mode | 0o600; [INFO] [stderr] 53 | | let ret = ORIG_MKDIR(path, fs_mode); [INFO] [stderr] ... | [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/creation.rs:50:1 [INFO] [stderr] | [INFO] [stderr] 50 | / wrap! { [INFO] [stderr] 51 | | unsafe fn mkdir:ORIG_MKDIR(path: *const c_char, mode: mode_t) -> c_int { [INFO] [stderr] 52 | | let fs_mode = mode | 0o600; [INFO] [stderr] 53 | | let ret = ORIG_MKDIR(path, fs_mode); [INFO] [stderr] ... | [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/creation.rs:50:1 [INFO] [stderr] | [INFO] [stderr] 50 | / wrap! { [INFO] [stderr] 51 | | unsafe fn mkdir:ORIG_MKDIR(path: *const c_char, mode: mode_t) -> c_int { [INFO] [stderr] 52 | | let fs_mode = mode | 0o600; [INFO] [stderr] 53 | | let ret = ORIG_MKDIR(path, fs_mode); [INFO] [stderr] ... | [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/creation.rs:50:1 [INFO] [stderr] | [INFO] [stderr] 50 | / wrap! { [INFO] [stderr] 51 | | unsafe fn mkdir:ORIG_MKDIR(path: *const c_char, mode: mode_t) -> c_int { [INFO] [stderr] 52 | | let fs_mode = mode | 0o600; [INFO] [stderr] 53 | | let ret = ORIG_MKDIR(path, fs_mode); [INFO] [stderr] ... | [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/creation.rs:50:1 [INFO] [stderr] | [INFO] [stderr] 50 | / wrap! { [INFO] [stderr] 51 | | unsafe fn mkdir:ORIG_MKDIR(path: *const c_char, mode: mode_t) -> c_int { [INFO] [stderr] 52 | | let fs_mode = mode | 0o600; [INFO] [stderr] 53 | | let ret = ORIG_MKDIR(path, fs_mode); [INFO] [stderr] ... | [INFO] [stderr] 96 | | } [INFO] [stderr] 97 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/creation.rs:111:1 [INFO] [stderr] | [INFO] [stderr] 111 | / wrap! { [INFO] [stderr] 112 | | unsafe fn __xmknod:ORIG_XMKNOD(ver: c_int, path: *const c_char, mode: mode_t, dev: *const dev_t) -> c_int { [INFO] [stderr] 113 | | mknod_base(|| CPath::from_path(path, false), mode, *dev, |mode| ORIG_XMKNOD(ver, path, mode, dev)) [INFO] [stderr] 114 | | } [INFO] [stderr] ... | [INFO] [stderr] 147 | | } [INFO] [stderr] 148 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/creation.rs:111:1 [INFO] [stderr] | [INFO] [stderr] 111 | / wrap! { [INFO] [stderr] 112 | | unsafe fn __xmknod:ORIG_XMKNOD(ver: c_int, path: *const c_char, mode: mode_t, dev: *const dev_t) -> c_int { [INFO] [stderr] 113 | | mknod_base(|| CPath::from_path(path, false), mode, *dev, |mode| ORIG_XMKNOD(ver, path, mode, dev)) [INFO] [stderr] 114 | | } [INFO] [stderr] ... | [INFO] [stderr] 147 | | } [INFO] [stderr] 148 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/creation.rs:111:1 [INFO] [stderr] | [INFO] [stderr] 111 | / wrap! { [INFO] [stderr] 112 | | unsafe fn __xmknod:ORIG_XMKNOD(ver: c_int, path: *const c_char, mode: mode_t, dev: *const dev_t) -> c_int { [INFO] [stderr] 113 | | mknod_base(|| CPath::from_path(path, false), mode, *dev, |mode| ORIG_XMKNOD(ver, path, mode, dev)) [INFO] [stderr] 114 | | } [INFO] [stderr] ... | [INFO] [stderr] 147 | | } [INFO] [stderr] 148 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/creation.rs:111:1 [INFO] [stderr] | [INFO] [stderr] 111 | / wrap! { [INFO] [stderr] 112 | | unsafe fn __xmknod:ORIG_XMKNOD(ver: c_int, path: *const c_char, mode: mode_t, dev: *const dev_t) -> c_int { [INFO] [stderr] 113 | | mknod_base(|| CPath::from_path(path, false), mode, *dev, |mode| ORIG_XMKNOD(ver, path, mode, dev)) [INFO] [stderr] 114 | | } [INFO] [stderr] ... | [INFO] [stderr] 147 | | } [INFO] [stderr] 148 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/creation.rs:111:1 [INFO] [stderr] | [INFO] [stderr] 111 | / wrap! { [INFO] [stderr] 112 | | unsafe fn __xmknod:ORIG_XMKNOD(ver: c_int, path: *const c_char, mode: mode_t, dev: *const dev_t) -> c_int { [INFO] [stderr] 113 | | mknod_base(|| CPath::from_path(path, false), mode, *dev, |mode| ORIG_XMKNOD(ver, path, mode, dev)) [INFO] [stderr] 114 | | } [INFO] [stderr] ... | [INFO] [stderr] 147 | | } [INFO] [stderr] 148 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/xattrs.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / wrap! { [INFO] [stderr] 71 | | unsafe fn setxattr:_(path: *const c_char, name: *const c_char, value: *const c_void, size: usize, flags: c_int) -> c_int { [INFO] [stderr] 72 | | base_set(CPath::from_path(path, true), name, value, size, flags) [INFO] [stderr] 73 | | } [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/xattrs.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / wrap! { [INFO] [stderr] 71 | | unsafe fn setxattr:_(path: *const c_char, name: *const c_char, value: *const c_void, size: usize, flags: c_int) -> c_int { [INFO] [stderr] 72 | | base_set(CPath::from_path(path, true), name, value, size, flags) [INFO] [stderr] 73 | | } [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/xattrs.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / wrap! { [INFO] [stderr] 71 | | unsafe fn setxattr:_(path: *const c_char, name: *const c_char, value: *const c_void, size: usize, flags: c_int) -> c_int { [INFO] [stderr] 72 | | base_set(CPath::from_path(path, true), name, value, size, flags) [INFO] [stderr] 73 | | } [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/xattrs.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / wrap! { [INFO] [stderr] 71 | | unsafe fn setxattr:_(path: *const c_char, name: *const c_char, value: *const c_void, size: usize, flags: c_int) -> c_int { [INFO] [stderr] 72 | | base_set(CPath::from_path(path, true), name, value, size, flags) [INFO] [stderr] 73 | | } [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/xattrs.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / wrap! { [INFO] [stderr] 71 | | unsafe fn setxattr:_(path: *const c_char, name: *const c_char, value: *const c_void, size: usize, flags: c_int) -> c_int { [INFO] [stderr] 72 | | base_set(CPath::from_path(path, true), name, value, size, flags) [INFO] [stderr] 73 | | } [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/xattrs.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / wrap! { [INFO] [stderr] 71 | | unsafe fn setxattr:_(path: *const c_char, name: *const c_char, value: *const c_void, size: usize, flags: c_int) -> c_int { [INFO] [stderr] 72 | | base_set(CPath::from_path(path, true), name, value, size, flags) [INFO] [stderr] 73 | | } [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/xattrs.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / wrap! { [INFO] [stderr] 71 | | unsafe fn setxattr:_(path: *const c_char, name: *const c_char, value: *const c_void, size: usize, flags: c_int) -> c_int { [INFO] [stderr] 72 | | base_set(CPath::from_path(path, true), name, value, size, flags) [INFO] [stderr] 73 | | } [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/xattrs.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / wrap! { [INFO] [stderr] 71 | | unsafe fn setxattr:_(path: *const c_char, name: *const c_char, value: *const c_void, size: usize, flags: c_int) -> c_int { [INFO] [stderr] 72 | | base_set(CPath::from_path(path, true), name, value, size, flags) [INFO] [stderr] 73 | | } [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/lib/shared.rs:273:23 [INFO] [stderr] | [INFO] [stderr] 273 | match (move || -> Result<$ret_t> { $code })() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Try doing something like: : `{ $code }` [INFO] [stderr] | [INFO] [stderr] ::: src/lib/xattrs.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / wrap! { [INFO] [stderr] 71 | | unsafe fn setxattr:_(path: *const c_char, name: *const c_char, value: *const c_void, size: usize, flags: c_int) -> c_int { [INFO] [stderr] 72 | | base_set(CPath::from_path(path, true), name, value, size, flags) [INFO] [stderr] 73 | | } [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/lib/internal_stat/linux64.rs:11:36 [INFO] [stderr] | [INFO] [stderr] 11 | transmute(dlsym(RTLD_NEXT, CString::new("__xstat64").unwrap().as_ptr())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/lib/internal_stat/linux64.rs:11:36 [INFO] [stderr] | [INFO] [stderr] 11 | transmute(dlsym(RTLD_NEXT, CString::new("__xstat64").unwrap().as_ptr())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/lib/internal_stat/linux64.rs:14:36 [INFO] [stderr] | [INFO] [stderr] 14 | transmute(dlsym(RTLD_NEXT, CString::new("__lxstat64").unwrap().as_ptr())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/lib/internal_stat/linux64.rs:14:36 [INFO] [stderr] | [INFO] [stderr] 14 | transmute(dlsym(RTLD_NEXT, CString::new("__lxstat64").unwrap().as_ptr())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/lib/internal_stat/linux64.rs:17:36 [INFO] [stderr] | [INFO] [stderr] 17 | transmute(dlsym(RTLD_NEXT, CString::new("__fxstat64").unwrap().as_ptr())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/lib/internal_stat/linux64.rs:17:36 [INFO] [stderr] | [INFO] [stderr] 17 | transmute(dlsym(RTLD_NEXT, CString::new("__fxstat64").unwrap().as_ptr())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/lib/internal_stat/linux64.rs:20:36 [INFO] [stderr] | [INFO] [stderr] 20 | transmute(dlsym(RTLD_NEXT, CString::new("__fxstatat64").unwrap().as_ptr())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/lib/internal_stat/linux64.rs:20:36 [INFO] [stderr] | [INFO] [stderr] 20 | transmute(dlsym(RTLD_NEXT, CString::new("__fxstatat64").unwrap().as_ptr())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib/shared.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | / if let &bincode::ErrorKind::IoError(ref err) = err.deref() { [INFO] [stderr] 133 | | daemon_error(&err); [INFO] [stderr] 134 | | } else { [INFO] [stderr] 135 | | panic!("Error messaging daemon: {:?}", err); [INFO] [stderr] 136 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 132 | if let bincode::ErrorKind::IoError(ref err) = *err.deref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib/shared.rs:412:28 [INFO] [stderr] | [INFO] [stderr] 412 | Ok(id.clone()) [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib/permissions.rs:26:15 [INFO] [stderr] | [INFO] [stderr] 26 | fn chmod_base<'a, F: Fn(mode_t) -> c_int>(path: CPath, mode: mode_t, orig_chmod: F) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/lib/internal_stat/linux64.rs:11:36 [INFO] [stderr] | [INFO] [stderr] 11 | transmute(dlsym(RTLD_NEXT, CString::new("__xstat64").unwrap().as_ptr())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/lib/internal_stat/linux64.rs:11:36 [INFO] [stderr] | [INFO] [stderr] 11 | transmute(dlsym(RTLD_NEXT, CString::new("__xstat64").unwrap().as_ptr())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/lib/internal_stat/linux64.rs:14:36 [INFO] [stderr] | [INFO] [stderr] 14 | transmute(dlsym(RTLD_NEXT, CString::new("__lxstat64").unwrap().as_ptr())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/lib/internal_stat/linux64.rs:14:36 [INFO] [stderr] | [INFO] [stderr] 14 | transmute(dlsym(RTLD_NEXT, CString::new("__lxstat64").unwrap().as_ptr())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/lib/internal_stat/linux64.rs:17:36 [INFO] [stderr] | [INFO] [stderr] 17 | transmute(dlsym(RTLD_NEXT, CString::new("__fxstat64").unwrap().as_ptr())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/lib/internal_stat/linux64.rs:17:36 [INFO] [stderr] | [INFO] [stderr] 17 | transmute(dlsym(RTLD_NEXT, CString::new("__fxstat64").unwrap().as_ptr())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/lib/internal_stat/linux64.rs:20:36 [INFO] [stderr] | [INFO] [stderr] 20 | transmute(dlsym(RTLD_NEXT, CString::new("__fxstatat64").unwrap().as_ptr())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/lib/internal_stat/linux64.rs:20:36 [INFO] [stderr] | [INFO] [stderr] 20 | transmute(dlsym(RTLD_NEXT, CString::new("__fxstatat64").unwrap().as_ptr())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib/shared.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | / if let &bincode::ErrorKind::IoError(ref err) = err.deref() { [INFO] [stderr] 133 | | daemon_error(&err); [INFO] [stderr] 134 | | } else { [INFO] [stderr] 135 | | panic!("Error messaging daemon: {:?}", err); [INFO] [stderr] 136 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 132 | if let bincode::ErrorKind::IoError(ref err) = *err.deref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib/shared.rs:412:28 [INFO] [stderr] | [INFO] [stderr] 412 | Ok(id.clone()) [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib/permissions.rs:26:15 [INFO] [stderr] | [INFO] [stderr] 26 | fn chmod_base<'a, F: Fn(mode_t) -> c_int>(path: CPath, mode: mode_t, orig_chmod: F) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib/file_descriptors.rs:45:58 [INFO] [stderr] | [INFO] [stderr] 45 | let id = FD_ID_CACHE.lock().unwrap().remove(&fd).unwrap_or( [INFO] [stderr] | __________________________________________________________^ [INFO] [stderr] 46 | | FileId::from_stat(&CPath::from_fd(fd).get_stat()?) [INFO] [stderr] 47 | | ); [INFO] [stderr] | |_________^ help: try this: `unwrap_or_else(|| FileId::from_stat(&CPath::from_fd(fd).get_stat()?))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib/file_descriptors.rs:45:58 [INFO] [stderr] | [INFO] [stderr] 45 | let id = FD_ID_CACHE.lock().unwrap().remove(&fd).unwrap_or( [INFO] [stderr] | __________________________________________________________^ [INFO] [stderr] 46 | | FileId::from_stat(&CPath::from_fd(fd).get_stat()?) [INFO] [stderr] 47 | | ); [INFO] [stderr] | |_________^ help: try this: `unwrap_or_else(|| FileId::from_stat(&CPath::from_fd(fd).get_stat()?))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib/creation.rs:34:15 [INFO] [stderr] | [INFO] [stderr] 34 | fn mknod_base<'a, F: Fn() -> CPath, M: Fn(mode_t) -> c_int>(get_path: F, mode: mode_t, dev: dev_t, mknod: M) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib/creation.rs:34:15 [INFO] [stderr] | [INFO] [stderr] 34 | fn mknod_base<'a, F: Fn() -> CPath, M: Fn(mode_t) -> c_int>(get_path: F, mode: mode_t, dev: dev_t, mknod: M) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib/xattrs.rs:62:15 [INFO] [stderr] | [INFO] [stderr] 62 | out = out.offset(part.len() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `out.add(part.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib/xattrs.rs:62:15 [INFO] [stderr] | [INFO] [stderr] 62 | out = out.offset(part.len() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `out.add(part.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `test-wrappers`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `test-wrappers`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "43e966ad0a841957292fdaec9993033a18b6b49aca5b6cce543f9536c8d518b0"` [INFO] running `"docker" "rm" "-f" "43e966ad0a841957292fdaec9993033a18b6b49aca5b6cce543f9536c8d518b0"` [INFO] [stdout] 43e966ad0a841957292fdaec9993033a18b6b49aca5b6cce543f9536c8d518b0