[INFO] updating cached repository Piripant/spring
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Piripant/spring
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Piripant/spring" "work/ex/clippy-test-run/sources/stable/gh/Piripant/spring"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Piripant/spring'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Piripant/spring" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Piripant/spring"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Piripant/spring'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 0124b6a338a1e360a2e8f989b6c6d6f21ccf4548
[INFO] sha for GitHub repo Piripant/spring: 0124b6a338a1e360a2e8f989b6c6d6f21ccf4548
[INFO] validating manifest of Piripant/spring on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Piripant/spring on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Piripant/spring
[INFO] finished frobbing Piripant/spring
[INFO] frobbed toml for Piripant/spring written to work/ex/clippy-test-run/sources/stable/gh/Piripant/spring/Cargo.toml
[INFO] started frobbing Piripant/spring
[INFO] finished frobbing Piripant/spring
[INFO] frobbed toml for Piripant/spring written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Piripant/spring/Cargo.toml
[INFO] crate Piripant/spring has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Piripant/spring against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Piripant/spring:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 32137c3747c37992d9ad6a3fb32883e90c4c7ceeecbb1008691d9c5563d04076
[INFO] running `"docker" "start" "-a" "32137c3747c37992d9ad6a3fb32883e90c4c7ceeecbb1008691d9c5563d04076"`
[INFO] [stderr]     Checking rand v0.4.2
[INFO] [stderr]     Checking shared_library v0.1.8
[INFO] [stderr]    Compiling imgui-sys v0.0.18
[INFO] [stderr]     Checking png v0.11.0
[INFO] [stderr]     Checking x11-dl v2.17.1
[INFO] [stderr]    Compiling gfx_gl v0.4.0
[INFO] [stderr]    Compiling gl v0.7.0
[INFO] [stderr]     Checking piston2d-graphics v0.24.0
[INFO] [stderr]     Checking jpeg-decoder v0.1.13
[INFO] [stderr]     Checking gfx v0.16.2
[INFO] [stderr]     Checking osmesa-sys v0.1.2
[INFO] [stderr]     Checking pistoncore-input v0.20.0
[INFO] [stderr]     Checking nalgebra v0.14.0
[INFO] [stderr]     Checking image v0.18.0
[INFO] [stderr]     Checking wayland-window v0.8.0
[INFO] [stderr]     Checking pistoncore-window v0.30.0
[INFO] [stderr]     Checking winit v0.8.3
[INFO] [stderr]     Checking pistoncore-event_loop v0.35.0
[INFO] [stderr]     Checking piston-gfx_texture v0.30.0
[INFO] [stderr]     Checking gfx_device_gl v0.14.6
[INFO] [stderr]     Checking glutin v0.10.1
[INFO] [stderr]     Checking piston v0.35.0
[INFO] [stderr]     Checking imgui v0.0.18
[INFO] [stderr]     Checking piston2d-gfx_graphics v0.47.0
[INFO] [stderr]     Checking pistoncore-glutin_window v0.43.0
[INFO] [stderr]     Checking piston_window v0.74.0
[INFO] [stderr]     Checking spring v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/viewer/imgui_piston/mod.rs:124:13
[INFO] [stderr]     |
[INFO] [stderr] 124 |             vertex_buffer: vertex_buffer,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertex_buffer`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/viewer/imgui_piston/mod.rs:132:13
[INFO] [stderr]     |
[INFO] [stderr] 132 |             out: out,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `out`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/viewer/imgui_piston/mod.rs:149:13
[INFO] [stderr]     |
[INFO] [stderr] 149 |             index_buffer: index_buffer,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index_buffer`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/viewer/imgui_piston/mod.rs:124:13
[INFO] [stderr]     |
[INFO] [stderr] 124 |             vertex_buffer: vertex_buffer,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertex_buffer`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/viewer/imgui_piston/mod.rs:132:13
[INFO] [stderr]     |
[INFO] [stderr] 132 |             out: out,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `out`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/viewer/imgui_piston/mod.rs:149:13
[INFO] [stderr]     |
[INFO] [stderr] 149 |             index_buffer: index_buffer,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `index_buffer`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `DebugView`
[INFO] [stderr]  --> src/physics/collisions.rs:1:27
[INFO] [stderr]   |
[INFO] [stderr] 1 | use physics::simulation::{DebugView, Vertex};
[INFO] [stderr]   |                           ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `DebugView`
[INFO] [stderr]  --> src/physics/collisions.rs:1:27
[INFO] [stderr]   |
[INFO] [stderr] 1 | use physics::simulation::{DebugView, Vertex};
[INFO] [stderr]   |                           ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `dt`
[INFO] [stderr]    --> src/viewer/input.rs:103:70
[INFO] [stderr]     |
[INFO] [stderr] 103 | pub fn handle_keyboard(view: &mut ViewState, input: &mut InputState, dt: f64) {
[INFO] [stderr]     |                                                                      ^^ help: consider using `_dt` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/physics/collisions.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 |     distance_vector(a, c, d).signum() != distance_vector(b, c, d).signum()
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(distance_vector(a, c, d).signum() - distance_vector(b, c, d).signum()).abs() < error`
[INFO] [stderr] warning: unused variable: `dt`
[INFO] [stderr]    --> src/viewer/input.rs:103:70
[INFO] [stderr]     |
[INFO] [stderr] 103 | pub fn handle_keyboard(view: &mut ViewState, input: &mut InputState, dt: f64) {
[INFO] [stderr]     |                                                                      ^^ help: consider using `_dt` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/physics/collisions.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 |     distance_vector(a, c, d).signum() != distance_vector(b, c, d).signum()
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/physics/collisions.rs:21:12
[INFO] [stderr]    |
[INFO] [stderr] 21 |         && distance_vector(c, a, b).signum() != distance_vector(d, a, b).signum()
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(distance_vector(c, a, b).signum() - distance_vector(d, a, b).signum()).abs() < error`
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/physics/collisions.rs:21:12
[INFO] [stderr]    |
[INFO] [stderr] 21 |         && distance_vector(c, a, b).signum() != distance_vector(d, a, b).signum()
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/physics/collisions.rs:35:8
[INFO] [stderr]    |
[INFO] [stderr] 35 |     if p.y == a.y || p.y == b.y {
[INFO] [stderr]    |        ^^^^^^^^^^ help: consider comparing them within some error: `(p.y - a.y).abs() < error`
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/physics/collisions.rs:35:8
[INFO] [stderr]    |
[INFO] [stderr] 35 |     if p.y == a.y || p.y == b.y {
[INFO] [stderr]    |        ^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/physics/collisions.rs:35:22
[INFO] [stderr]    |
[INFO] [stderr] 35 |     if p.y == a.y || p.y == b.y {
[INFO] [stderr]    |                      ^^^^^^^^^^ help: consider comparing them within some error: `(p.y - b.y).abs() < error`
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/physics/collisions.rs:35:22
[INFO] [stderr]    |
[INFO] [stderr] 35 |     if p.y == a.y || p.y == b.y {
[INFO] [stderr]    |                      ^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/physics/collisions.rs:60:13
[INFO] [stderr]    |
[INFO] [stderr] 60 |     let p = p.clone();
[INFO] [stderr]    |             ^^^^^^^^^ help: try dereferencing it: `*p`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/physics/collisions.rs:66:21
[INFO] [stderr]    |
[INFO] [stderr] 66 |         let mut a = quad[i].clone();
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^ help: try dereferencing it: `*quad[i]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/physics/collisions.rs:67:21
[INFO] [stderr]    |
[INFO] [stderr] 67 |         let mut b = quad[ni].clone();
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*quad[ni]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `segment`.
[INFO] [stderr]   --> src/physics/collisions.rs:87:14
[INFO] [stderr]    |
[INFO] [stderr] 87 |     for i in 0..2 {
[INFO] [stderr]    |              ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 87 |     for <item> in &segment {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/physics/collisions.rs:118:13
[INFO] [stderr]     |
[INFO] [stderr] 118 |     let e = surface.restitution as f64;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(surface.restitution)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/physics/collisions.rs:124:23
[INFO] [stderr]     |
[INFO] [stderr] 124 |         (a.velocity * a.mass as f64 + b.velocity * b.mass as f64) / segment_mass as f64;
[INFO] [stderr]     |                       ^^^^^^^^^^^^^ help: try: `f64::from(a.mass)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/physics/collisions.rs:124:52
[INFO] [stderr]     |
[INFO] [stderr] 124 |         (a.velocity * a.mass as f64 + b.velocity * b.mass as f64) / segment_mass as f64;
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^ help: try: `f64::from(b.mass)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/physics/collisions.rs:124:69
[INFO] [stderr]     |
[INFO] [stderr] 124 |         (a.velocity * a.mass as f64 + b.velocity * b.mass as f64) / segment_mass as f64;
[INFO] [stderr]     |                                                                     ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(segment_mass)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/physics/collisions.rs:129:44
[INFO] [stderr]     |
[INFO] [stderr] 129 |     let j = -(1.0 + e) * normal_velocity / (1.0 / vertex.mass + 1.0 / segment_mass) as f64;
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1.0 / vertex.mass + 1.0 / segment_mass)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/physics/collisions.rs:139:17
[INFO] [stderr]     |
[INFO] [stderr] 139 |     let coeff = surface.friction as f64;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(surface.friction)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/physics/collisions.rs:151:34
[INFO] [stderr]     |
[INFO] [stderr] 151 |     vertex.velocity += impulse / vertex.mass as f64 - friction;
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(vertex.mass)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/physics/collisions.rs:152:50
[INFO] [stderr]     |
[INFO] [stderr] 152 |     a.velocity += -impulse * distance_ratio_ab / a.mass as f64 + friction;
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^ help: try: `f64::from(a.mass)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/physics/collisions.rs:153:50
[INFO] [stderr]     |
[INFO] [stderr] 153 |     b.velocity += -impulse * distance_ratio_ba / b.mass as f64 + friction;
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^ help: try: `f64::from(b.mass)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/physics/simulation.rs:31:38
[INFO] [stderr]    |
[INFO] [stderr] 31 |         self.acceleration += force / self.mass as f64;
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^ help: try: `f64::from(self.mass)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `physics::simulation::World`
[INFO] [stderr]   --> src/physics/simulation.rs:59:5
[INFO] [stderr]    |
[INFO] [stderr] 59 | /     pub fn new() -> World {
[INFO] [stderr] 60 | |         World {
[INFO] [stderr] 61 | |             verts: Vec::new(),
[INFO] [stderr] 62 | |             surfaces: Vec::new(),
[INFO] [stderr] ...  |
[INFO] [stderr] 66 | |         }
[INFO] [stderr] 67 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 58 | impl Default for physics::simulation::World {
[INFO] [stderr] 59 |     fn default() -> Self {
[INFO] [stderr] 60 |         Self::new()
[INFO] [stderr] 61 |     }
[INFO] [stderr] 62 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `<Surface>::new` doesn't need a mutable reference
[INFO] [stderr]    --> src/physics/simulation.rs:178:46
[INFO] [stderr]     |
[INFO] [stderr] 178 |             .push(Surface::new(ord_a, ord_b, &mut self.verts));
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/physics/simulation.rs:212:23
[INFO] [stderr]     |
[INFO] [stderr] 212 |         let dt = dt / iterations as f64;
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^ help: try: `f64::from(iterations)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `apply_force` doesn't need a mutable reference
[INFO] [stderr]    --> src/physics/simulation.rs:215:37
[INFO] [stderr]     |
[INFO] [stderr] 215 |                 surface.apply_force(&mut self.verts);
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/physics/surface.rs:18:55
[INFO] [stderr]    |
[INFO] [stderr] 18 |     pub fn new(index_a: usize, index_b: usize, verts: &Vec<RefCell<Vertex>>) -> Surface {
[INFO] [stderr]    |                                                       ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[RefCell<Vertex>]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/physics/surface.rs:33:38
[INFO] [stderr]    |
[INFO] [stderr] 33 |     pub fn apply_force(&self, verts: &Vec<RefCell<Vertex>>) {
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[RefCell<Vertex>]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/physics/surface.rs:50:45
[INFO] [stderr]    |
[INFO] [stderr] 50 |             delta.normalize() * extention * -self.strength as f64 - approach_velocity * c as f64;
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(-self.strength)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/physics/surface.rs:50:89
[INFO] [stderr]    |
[INFO] [stderr] 50 |             delta.normalize() * extention * -self.strength as f64 - approach_velocity * c as f64;
[INFO] [stderr]    |                                                                                         ^^^^^^^^ help: try: `f64::from(c)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/viewer/drawing.rs:61:38
[INFO] [stderr]    |
[INFO] [stderr] 61 |                 view.window_size.y = window.size().height as f64;
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(window.size().height)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/viewer/drawing.rs:62:38
[INFO] [stderr]    |
[INFO] [stderr] 62 |                 view.window_size.x = window.size().width as f64;
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(window.size().width)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `viewer::input::InputState`
[INFO] [stderr]   --> src/viewer/input.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 | /     pub fn new() -> InputState {
[INFO] [stderr] 19 | |         InputState {
[INFO] [stderr] 20 | |             cursor: Vector::new(0.0, 0.0),
[INFO] [stderr] 21 | |             last_cursor: Vector::new(0.0, 0.0),
[INFO] [stderr] ...  |
[INFO] [stderr] 28 | |         }
[INFO] [stderr] 29 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 17 | impl Default for viewer::input::InputState {
[INFO] [stderr] 18 |     fn default() -> Self {
[INFO] [stderr] 19 |         Self::new()
[INFO] [stderr] 20 |     }
[INFO] [stderr] 21 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/viewer/input.rs:152:68
[INFO] [stderr]     |
[INFO] [stderr] 152 | fn handle_select(view: &mut ViewState, input: &InputState, button: &MouseButton) {
[INFO] [stderr]     |                                                                    ^^^^^^^^^^^^ help: consider passing by value instead: `MouseButton`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/viewer/input.rs:162:45
[INFO] [stderr]     |
[INFO] [stderr] 162 |                 force = force.normalize() * view.pull_force as f64;
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(view.pull_force)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/viewer/input.rs:189:66
[INFO] [stderr]     |
[INFO] [stderr] 189 | fn handle_edit(view: &mut ViewState, input: &InputState, button: &MouseButton) {
[INFO] [stderr]     |                                                                  ^^^^^^^^^^^^ help: consider passing by value instead: `MouseButton`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/viewer/imgui_piston/mod.rs:227:12
[INFO] [stderr]     |
[INFO] [stderr] 227 |           Ok(encoder.update_buffer(
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 228 | |             &self.bundle.data.vertex_buffer,
[INFO] [stderr] 229 | |             vtx_buffer,
[INFO] [stderr] 230 | |             0,
[INFO] [stderr] 231 | |         )?)
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 227 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/viewer/imgui_piston/mod.rs:248:12
[INFO] [stderr]     |
[INFO] [stderr] 248 |         Ok(encoder.update_buffer(&self.index_buffer, idx_buffer, 0)?)
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 248 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/viewer/ui.rs:39:22
[INFO] [stderr]    |
[INFO] [stderr] 39 |     view.sim_speed = sim_speed as f64;
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^ help: try: `f64::from(sim_speed)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/viewer/ui.rs:40:25
[INFO] [stderr]    |
[INFO] [stderr] 40 |     view.vertex_scale = vertex_scale as f64;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(vertex_scale)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/viewer/ui.rs:128:38
[INFO] [stderr]     |
[INFO] [stderr] 128 | fn set_keys(imgui: &mut ImGui, keys: &Vec<Key>, state: bool) {
[INFO] [stderr]     |                                      ^^^^^^^^^ help: change this to: `&[Key]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/viewer/ui.rs:166:19
[INFO] [stderr]     |
[INFO] [stderr] 166 |     let scale_x = draw_size.width as f64 / window_size.width as f64;
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(draw_size.width)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/viewer/ui.rs:166:44
[INFO] [stderr]     |
[INFO] [stderr] 166 |     let scale_x = draw_size.width as f64 / window_size.width as f64;
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(window_size.width)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/viewer/ui.rs:167:19
[INFO] [stderr]     |
[INFO] [stderr] 167 |     let scale_y = draw_size.height as f64 / window_size.height as f64;
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(draw_size.height)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/viewer/ui.rs:167:45
[INFO] [stderr]     |
[INFO] [stderr] 167 |     let scale_y = draw_size.height as f64 / window_size.height as f64;
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(window_size.height)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/shapes.rs:24:9
[INFO] [stderr]    |
[INFO] [stderr] 24 | /         let mut next_index = (i + 1) % len;
[INFO] [stderr] 25 | |         if i == len - 2 {
[INFO] [stderr] 26 | |             next_index = 0;
[INFO] [stderr] 27 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let <mut> next_index = if i == len - 2 { 0 } else { (i + 1) % len };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 4 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `spring`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/physics/collisions.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 |     distance_vector(a, c, d).signum() != distance_vector(b, c, d).signum()
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(distance_vector(a, c, d).signum() - distance_vector(b, c, d).signum()).abs() < error`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/physics/collisions.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 |     distance_vector(a, c, d).signum() != distance_vector(b, c, d).signum()
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/physics/collisions.rs:21:12
[INFO] [stderr]    |
[INFO] [stderr] 21 |         && distance_vector(c, a, b).signum() != distance_vector(d, a, b).signum()
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(distance_vector(c, a, b).signum() - distance_vector(d, a, b).signum()).abs() < error`
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/physics/collisions.rs:21:12
[INFO] [stderr]    |
[INFO] [stderr] 21 |         && distance_vector(c, a, b).signum() != distance_vector(d, a, b).signum()
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/physics/collisions.rs:35:8
[INFO] [stderr]    |
[INFO] [stderr] 35 |     if p.y == a.y || p.y == b.y {
[INFO] [stderr]    |        ^^^^^^^^^^ help: consider comparing them within some error: `(p.y - a.y).abs() < error`
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/physics/collisions.rs:35:8
[INFO] [stderr]    |
[INFO] [stderr] 35 |     if p.y == a.y || p.y == b.y {
[INFO] [stderr]    |        ^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/physics/collisions.rs:35:22
[INFO] [stderr]    |
[INFO] [stderr] 35 |     if p.y == a.y || p.y == b.y {
[INFO] [stderr]    |                      ^^^^^^^^^^ help: consider comparing them within some error: `(p.y - b.y).abs() < error`
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/physics/collisions.rs:35:22
[INFO] [stderr]    |
[INFO] [stderr] 35 |     if p.y == a.y || p.y == b.y {
[INFO] [stderr]    |                      ^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/physics/collisions.rs:60:13
[INFO] [stderr]    |
[INFO] [stderr] 60 |     let p = p.clone();
[INFO] [stderr]    |             ^^^^^^^^^ help: try dereferencing it: `*p`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/physics/collisions.rs:66:21
[INFO] [stderr]    |
[INFO] [stderr] 66 |         let mut a = quad[i].clone();
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^ help: try dereferencing it: `*quad[i]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/physics/collisions.rs:67:21
[INFO] [stderr]    |
[INFO] [stderr] 67 |         let mut b = quad[ni].clone();
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*quad[ni]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `segment`.
[INFO] [stderr]   --> src/physics/collisions.rs:87:14
[INFO] [stderr]    |
[INFO] [stderr] 87 |     for i in 0..2 {
[INFO] [stderr]    |              ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 87 |     for <item> in &segment {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/physics/collisions.rs:118:13
[INFO] [stderr]     |
[INFO] [stderr] 118 |     let e = surface.restitution as f64;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(surface.restitution)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/physics/collisions.rs:124:23
[INFO] [stderr]     |
[INFO] [stderr] 124 |         (a.velocity * a.mass as f64 + b.velocity * b.mass as f64) / segment_mass as f64;
[INFO] [stderr]     |                       ^^^^^^^^^^^^^ help: try: `f64::from(a.mass)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/physics/collisions.rs:124:52
[INFO] [stderr]     |
[INFO] [stderr] 124 |         (a.velocity * a.mass as f64 + b.velocity * b.mass as f64) / segment_mass as f64;
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^ help: try: `f64::from(b.mass)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/physics/collisions.rs:124:69
[INFO] [stderr]     |
[INFO] [stderr] 124 |         (a.velocity * a.mass as f64 + b.velocity * b.mass as f64) / segment_mass as f64;
[INFO] [stderr]     |                                                                     ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(segment_mass)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/physics/collisions.rs:129:44
[INFO] [stderr]     |
[INFO] [stderr] 129 |     let j = -(1.0 + e) * normal_velocity / (1.0 / vertex.mass + 1.0 / segment_mass) as f64;
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1.0 / vertex.mass + 1.0 / segment_mass)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/physics/collisions.rs:139:17
[INFO] [stderr]     |
[INFO] [stderr] 139 |     let coeff = surface.friction as f64;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(surface.friction)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/physics/collisions.rs:151:34
[INFO] [stderr]     |
[INFO] [stderr] 151 |     vertex.velocity += impulse / vertex.mass as f64 - friction;
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(vertex.mass)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/physics/collisions.rs:152:50
[INFO] [stderr]     |
[INFO] [stderr] 152 |     a.velocity += -impulse * distance_ratio_ab / a.mass as f64 + friction;
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^ help: try: `f64::from(a.mass)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/physics/collisions.rs:153:50
[INFO] [stderr]     |
[INFO] [stderr] 153 |     b.velocity += -impulse * distance_ratio_ba / b.mass as f64 + friction;
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^ help: try: `f64::from(b.mass)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/physics/simulation.rs:31:38
[INFO] [stderr]    |
[INFO] [stderr] 31 |         self.acceleration += force / self.mass as f64;
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^ help: try: `f64::from(self.mass)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `physics::simulation::World`
[INFO] [stderr]   --> src/physics/simulation.rs:59:5
[INFO] [stderr]    |
[INFO] [stderr] 59 | /     pub fn new() -> World {
[INFO] [stderr] 60 | |         World {
[INFO] [stderr] 61 | |             verts: Vec::new(),
[INFO] [stderr] 62 | |             surfaces: Vec::new(),
[INFO] [stderr] ...  |
[INFO] [stderr] 66 | |         }
[INFO] [stderr] 67 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 58 | impl Default for physics::simulation::World {
[INFO] [stderr] 59 |     fn default() -> Self {
[INFO] [stderr] 60 |         Self::new()
[INFO] [stderr] 61 |     }
[INFO] [stderr] 62 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `<Surface>::new` doesn't need a mutable reference
[INFO] [stderr]    --> src/physics/simulation.rs:178:46
[INFO] [stderr]     |
[INFO] [stderr] 178 |             .push(Surface::new(ord_a, ord_b, &mut self.verts));
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/physics/simulation.rs:212:23
[INFO] [stderr]     |
[INFO] [stderr] 212 |         let dt = dt / iterations as f64;
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^ help: try: `f64::from(iterations)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `apply_force` doesn't need a mutable reference
[INFO] [stderr]    --> src/physics/simulation.rs:215:37
[INFO] [stderr]     |
[INFO] [stderr] 215 |                 surface.apply_force(&mut self.verts);
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/physics/surface.rs:18:55
[INFO] [stderr]    |
[INFO] [stderr] 18 |     pub fn new(index_a: usize, index_b: usize, verts: &Vec<RefCell<Vertex>>) -> Surface {
[INFO] [stderr]    |                                                       ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[RefCell<Vertex>]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/physics/surface.rs:33:38
[INFO] [stderr]    |
[INFO] [stderr] 33 |     pub fn apply_force(&self, verts: &Vec<RefCell<Vertex>>) {
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[RefCell<Vertex>]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/physics/surface.rs:50:45
[INFO] [stderr]    |
[INFO] [stderr] 50 |             delta.normalize() * extention * -self.strength as f64 - approach_velocity * c as f64;
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(-self.strength)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/physics/surface.rs:50:89
[INFO] [stderr]    |
[INFO] [stderr] 50 |             delta.normalize() * extention * -self.strength as f64 - approach_velocity * c as f64;
[INFO] [stderr]    |                                                                                         ^^^^^^^^ help: try: `f64::from(c)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/viewer/drawing.rs:61:38
[INFO] [stderr]    |
[INFO] [stderr] 61 |                 view.window_size.y = window.size().height as f64;
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(window.size().height)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/viewer/drawing.rs:62:38
[INFO] [stderr]    |
[INFO] [stderr] 62 |                 view.window_size.x = window.size().width as f64;
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(window.size().width)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `viewer::input::InputState`
[INFO] [stderr]   --> src/viewer/input.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 | /     pub fn new() -> InputState {
[INFO] [stderr] 19 | |         InputState {
[INFO] [stderr] 20 | |             cursor: Vector::new(0.0, 0.0),
[INFO] [stderr] 21 | |             last_cursor: Vector::new(0.0, 0.0),
[INFO] [stderr] ...  |
[INFO] [stderr] 28 | |         }
[INFO] [stderr] 29 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 17 | impl Default for viewer::input::InputState {
[INFO] [stderr] 18 |     fn default() -> Self {
[INFO] [stderr] 19 |         Self::new()
[INFO] [stderr] 20 |     }
[INFO] [stderr] 21 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/viewer/input.rs:152:68
[INFO] [stderr]     |
[INFO] [stderr] 152 | fn handle_select(view: &mut ViewState, input: &InputState, button: &MouseButton) {
[INFO] [stderr]     |                                                                    ^^^^^^^^^^^^ help: consider passing by value instead: `MouseButton`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/viewer/input.rs:162:45
[INFO] [stderr]     |
[INFO] [stderr] 162 |                 force = force.normalize() * view.pull_force as f64;
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(view.pull_force)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/viewer/input.rs:189:66
[INFO] [stderr]     |
[INFO] [stderr] 189 | fn handle_edit(view: &mut ViewState, input: &InputState, button: &MouseButton) {
[INFO] [stderr]     |                                                                  ^^^^^^^^^^^^ help: consider passing by value instead: `MouseButton`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/viewer/imgui_piston/mod.rs:227:12
[INFO] [stderr]     |
[INFO] [stderr] 227 |           Ok(encoder.update_buffer(
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 228 | |             &self.bundle.data.vertex_buffer,
[INFO] [stderr] 229 | |             vtx_buffer,
[INFO] [stderr] 230 | |             0,
[INFO] [stderr] 231 | |         )?)
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 227 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/viewer/imgui_piston/mod.rs:248:12
[INFO] [stderr]     |
[INFO] [stderr] 248 |         Ok(encoder.update_buffer(&self.index_buffer, idx_buffer, 0)?)
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 248 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/viewer/ui.rs:39:22
[INFO] [stderr]    |
[INFO] [stderr] 39 |     view.sim_speed = sim_speed as f64;
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^ help: try: `f64::from(sim_speed)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/viewer/ui.rs:40:25
[INFO] [stderr]    |
[INFO] [stderr] 40 |     view.vertex_scale = vertex_scale as f64;
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(vertex_scale)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/viewer/ui.rs:128:38
[INFO] [stderr]     |
[INFO] [stderr] 128 | fn set_keys(imgui: &mut ImGui, keys: &Vec<Key>, state: bool) {
[INFO] [stderr]     |                                      ^^^^^^^^^ help: change this to: `&[Key]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/viewer/ui.rs:166:19
[INFO] [stderr]     |
[INFO] [stderr] 166 |     let scale_x = draw_size.width as f64 / window_size.width as f64;
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(draw_size.width)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/viewer/ui.rs:166:44
[INFO] [stderr]     |
[INFO] [stderr] 166 |     let scale_x = draw_size.width as f64 / window_size.width as f64;
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(window_size.width)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/viewer/ui.rs:167:19
[INFO] [stderr]     |
[INFO] [stderr] 167 |     let scale_y = draw_size.height as f64 / window_size.height as f64;
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(draw_size.height)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/viewer/ui.rs:167:45
[INFO] [stderr]     |
[INFO] [stderr] 167 |     let scale_y = draw_size.height as f64 / window_size.height as f64;
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(window_size.height)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/shapes.rs:24:9
[INFO] [stderr]    |
[INFO] [stderr] 24 | /         let mut next_index = (i + 1) % len;
[INFO] [stderr] 25 | |         if i == len - 2 {
[INFO] [stderr] 26 | |             next_index = 0;
[INFO] [stderr] 27 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let <mut> next_index = if i == len - 2 { 0 } else { (i + 1) % len };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 4 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `spring`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "32137c3747c37992d9ad6a3fb32883e90c4c7ceeecbb1008691d9c5563d04076"`
[INFO] running `"docker" "rm" "-f" "32137c3747c37992d9ad6a3fb32883e90c4c7ceeecbb1008691d9c5563d04076"`
[INFO] [stdout] 32137c3747c37992d9ad6a3fb32883e90c4c7ceeecbb1008691d9c5563d04076