[INFO] updating cached repository Phrohdoh/slp-viewer-opengl-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Phrohdoh/slp-viewer-opengl-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Phrohdoh/slp-viewer-opengl-rs" "work/ex/clippy-test-run/sources/stable/gh/Phrohdoh/slp-viewer-opengl-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Phrohdoh/slp-viewer-opengl-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Phrohdoh/slp-viewer-opengl-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Phrohdoh/slp-viewer-opengl-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Phrohdoh/slp-viewer-opengl-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 86cae93ec37e3459c40f27087f24f30e371dcb1c [INFO] sha for GitHub repo Phrohdoh/slp-viewer-opengl-rs: 86cae93ec37e3459c40f27087f24f30e371dcb1c [INFO] validating manifest of Phrohdoh/slp-viewer-opengl-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Phrohdoh/slp-viewer-opengl-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Phrohdoh/slp-viewer-opengl-rs [INFO] finished frobbing Phrohdoh/slp-viewer-opengl-rs [INFO] frobbed toml for Phrohdoh/slp-viewer-opengl-rs written to work/ex/clippy-test-run/sources/stable/gh/Phrohdoh/slp-viewer-opengl-rs/Cargo.toml [INFO] started frobbing Phrohdoh/slp-viewer-opengl-rs [INFO] finished frobbing Phrohdoh/slp-viewer-opengl-rs [INFO] frobbed toml for Phrohdoh/slp-viewer-opengl-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Phrohdoh/slp-viewer-opengl-rs/Cargo.toml [INFO] crate Phrohdoh/slp-viewer-opengl-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Phrohdoh/slp-viewer-opengl-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Phrohdoh/slp-viewer-opengl-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] df1b11d89212af933f8cd91cf2d8ee24c8e480137fe71d18905f4e0ff2488bbb [INFO] running `"docker" "start" "-a" "df1b11d89212af933f8cd91cf2d8ee24c8e480137fe71d18905f4e0ff2488bbb"` [INFO] [stderr] Checking itertools v0.6.0 [INFO] [stderr] Checking chariot_io_tools v0.1.1 [INFO] [stderr] Checking error-chain v0.5.0 [INFO] [stderr] Checking chariot_palette v0.1.4 [INFO] [stderr] Checking chariot_slp v0.1.0 [INFO] [stderr] Checking chariot_drs v0.1.1 [INFO] [stderr] Checking slp-viewer-opengl v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:124:14 [INFO] [stderr] | [INFO] [stderr] 124 | .expect(&format!("Failed to read SLP from {}", slp_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to read SLP from {}", slp_path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:129:18 [INFO] [stderr] | [INFO] [stderr] 129 | .expect(&format!("Failed to parse frame-index into an integer value ranging from 0 to {}", max)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to parse frame-index into an integer value ranging from 0 to {}", max))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:143:64 [INFO] [stderr] | [INFO] [stderr] 143 | let colors = chariot_palette::read_from_file(pal_path).expect(&format!("Failed to read palette from {}", pal_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to read palette from {}", pal_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:200:19 [INFO] [stderr] | [INFO] [stderr] 200 | let program = program!(&display, 330 => { vertex: include_str!("slp.vert"), fragment: include_str!("slp.frag"), }).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:124:14 [INFO] [stderr] | [INFO] [stderr] 124 | .expect(&format!("Failed to read SLP from {}", slp_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to read SLP from {}", slp_path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:129:18 [INFO] [stderr] | [INFO] [stderr] 129 | .expect(&format!("Failed to parse frame-index into an integer value ranging from 0 to {}", max)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to parse frame-index into an integer value ranging from 0 to {}", max))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:143:64 [INFO] [stderr] | [INFO] [stderr] 143 | let colors = chariot_palette::read_from_file(pal_path).expect(&format!("Failed to read palette from {}", pal_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to read palette from {}", pal_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:200:19 [INFO] [stderr] | [INFO] [stderr] 200 | let program = program!(&display, 330 => { vertex: include_str!("slp.vert"), fragment: include_str!("slp.frag"), }).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.11s [INFO] running `"docker" "inspect" "df1b11d89212af933f8cd91cf2d8ee24c8e480137fe71d18905f4e0ff2488bbb"` [INFO] running `"docker" "rm" "-f" "df1b11d89212af933f8cd91cf2d8ee24c8e480137fe71d18905f4e0ff2488bbb"` [INFO] [stdout] df1b11d89212af933f8cd91cf2d8ee24c8e480137fe71d18905f4e0ff2488bbb