[INFO] updating cached repository Phrohdoh/slp-to-png-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Phrohdoh/slp-to-png-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Phrohdoh/slp-to-png-rs" "work/ex/clippy-test-run/sources/stable/gh/Phrohdoh/slp-to-png-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Phrohdoh/slp-to-png-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Phrohdoh/slp-to-png-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Phrohdoh/slp-to-png-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Phrohdoh/slp-to-png-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f0620c9e92e822ed9e4042a62edf2d2d24184a3c [INFO] sha for GitHub repo Phrohdoh/slp-to-png-rs: f0620c9e92e822ed9e4042a62edf2d2d24184a3c [INFO] validating manifest of Phrohdoh/slp-to-png-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Phrohdoh/slp-to-png-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Phrohdoh/slp-to-png-rs [INFO] finished frobbing Phrohdoh/slp-to-png-rs [INFO] frobbed toml for Phrohdoh/slp-to-png-rs written to work/ex/clippy-test-run/sources/stable/gh/Phrohdoh/slp-to-png-rs/Cargo.toml [INFO] started frobbing Phrohdoh/slp-to-png-rs [INFO] finished frobbing Phrohdoh/slp-to-png-rs [INFO] frobbed toml for Phrohdoh/slp-to-png-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Phrohdoh/slp-to-png-rs/Cargo.toml [INFO] crate Phrohdoh/slp-to-png-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Phrohdoh/slp-to-png-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Phrohdoh/slp-to-png-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b2e1e14a6f8a1814dec6cc380fd0a031cc48d53ba99517d0edb1c2b9497cc0da [INFO] running `"docker" "start" "-a" "b2e1e14a6f8a1814dec6cc380fd0a031cc48d53ba99517d0edb1c2b9497cc0da"` [INFO] [stderr] Compiling miniz-sys v0.1.9 [INFO] [stderr] Checking clap v2.23.3 [INFO] [stderr] Checking backtrace-sys v0.1.10 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking error-chain v0.5.0 [INFO] [stderr] Checking flate2 v0.2.19 [INFO] [stderr] Checking chariot_palette v0.1.4 [INFO] [stderr] Checking chariot_io_tools v0.1.1 [INFO] [stderr] Checking chariot_slp v0.1.0 [INFO] [stderr] Checking slp-to-png v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:54:37 [INFO] [stderr] | [INFO] [stderr] 54 | let v = v.parse::().expect(&format!("Failed to parse {} into an integer value ranging from 1 to 8", v)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to parse {} into an integer value ranging from 1 to 8", v))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:65:68 [INFO] [stderr] | [INFO] [stderr] 65 | chariot_slp::SlpFile::read_from_file(slp_path, player_idx).expect(&format!("Failed to read SLP from {}", slp_path)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to read SLP from {}", slp_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:70:64 [INFO] [stderr] | [INFO] [stderr] 70 | let colors = chariot_palette::read_from_file(pal_path).expect(&format!("Failed to read palette from {}", pal_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to read palette from {}", pal_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:83:43 [INFO] [stderr] | [INFO] [stderr] 83 | std::fs::create_dir_all(&output_path).expect(&format!("Failed to create output-path {}", output_path.display())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to create output-path {}", output_path.display()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:111:14 [INFO] [stderr] | [INFO] [stderr] 111 | .expect(&format!("Failed to prepare '{}'", output_path.display())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to prepare '{}'", output_path.display()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:117:36 [INFO] [stderr] | [INFO] [stderr] 117 | encoder.write_header().expect(&format!("Failed to write header for '{}'", output_path.display())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to write header for '{}'", output_path.display()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:120:52 [INFO] [stderr] | [INFO] [stderr] 120 | writer.write_chunk(png::chunk::PLTE, &pal).expect(&format!("Failed to write pal to '{}'", output_path.display())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to write pal to '{}'", output_path.display()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:121:48 [INFO] [stderr] | [INFO] [stderr] 121 | writer.write_image_data(&shape.pixels).expect(&format!("Failed to write image data to '{}'", output_path.display())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to write image data to '{}'", output_path.display()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:54:37 [INFO] [stderr] | [INFO] [stderr] 54 | let v = v.parse::().expect(&format!("Failed to parse {} into an integer value ranging from 1 to 8", v)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to parse {} into an integer value ranging from 1 to 8", v))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:65:68 [INFO] [stderr] | [INFO] [stderr] 65 | chariot_slp::SlpFile::read_from_file(slp_path, player_idx).expect(&format!("Failed to read SLP from {}", slp_path)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to read SLP from {}", slp_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:70:64 [INFO] [stderr] | [INFO] [stderr] 70 | let colors = chariot_palette::read_from_file(pal_path).expect(&format!("Failed to read palette from {}", pal_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to read palette from {}", pal_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:83:43 [INFO] [stderr] | [INFO] [stderr] 83 | std::fs::create_dir_all(&output_path).expect(&format!("Failed to create output-path {}", output_path.display())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to create output-path {}", output_path.display()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:111:14 [INFO] [stderr] | [INFO] [stderr] 111 | .expect(&format!("Failed to prepare '{}'", output_path.display())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to prepare '{}'", output_path.display()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:117:36 [INFO] [stderr] | [INFO] [stderr] 117 | encoder.write_header().expect(&format!("Failed to write header for '{}'", output_path.display())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to write header for '{}'", output_path.display()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:120:52 [INFO] [stderr] | [INFO] [stderr] 120 | writer.write_chunk(png::chunk::PLTE, &pal).expect(&format!("Failed to write pal to '{}'", output_path.display())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to write pal to '{}'", output_path.display()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:121:48 [INFO] [stderr] | [INFO] [stderr] 121 | writer.write_image_data(&shape.pixels).expect(&format!("Failed to write image data to '{}'", output_path.display())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to write image data to '{}'", output_path.display()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.68s [INFO] running `"docker" "inspect" "b2e1e14a6f8a1814dec6cc380fd0a031cc48d53ba99517d0edb1c2b9497cc0da"` [INFO] running `"docker" "rm" "-f" "b2e1e14a6f8a1814dec6cc380fd0a031cc48d53ba99517d0edb1c2b9497cc0da"` [INFO] [stdout] b2e1e14a6f8a1814dec6cc380fd0a031cc48d53ba99517d0edb1c2b9497cc0da