[INFO] updating cached repository Phlosioneer/astro-blastro-refactor [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Phlosioneer/astro-blastro-refactor [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Phlosioneer/astro-blastro-refactor" "work/ex/clippy-test-run/sources/stable/gh/Phlosioneer/astro-blastro-refactor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Phlosioneer/astro-blastro-refactor'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Phlosioneer/astro-blastro-refactor" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Phlosioneer/astro-blastro-refactor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Phlosioneer/astro-blastro-refactor'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5c3b6cf563be62375c8d772bd4b4176a5d44711e [INFO] sha for GitHub repo Phlosioneer/astro-blastro-refactor: 5c3b6cf563be62375c8d772bd4b4176a5d44711e [INFO] validating manifest of Phlosioneer/astro-blastro-refactor on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Phlosioneer/astro-blastro-refactor on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Phlosioneer/astro-blastro-refactor [INFO] finished frobbing Phlosioneer/astro-blastro-refactor [INFO] frobbed toml for Phlosioneer/astro-blastro-refactor written to work/ex/clippy-test-run/sources/stable/gh/Phlosioneer/astro-blastro-refactor/Cargo.toml [INFO] started frobbing Phlosioneer/astro-blastro-refactor [INFO] finished frobbing Phlosioneer/astro-blastro-refactor [INFO] frobbed toml for Phlosioneer/astro-blastro-refactor written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Phlosioneer/astro-blastro-refactor/Cargo.toml [INFO] crate Phlosioneer/astro-blastro-refactor has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Phlosioneer/astro-blastro-refactor against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Phlosioneer/astro-blastro-refactor:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9d34e55317fbd8064a3b7c26c75c0a2a7ff681de51cfedd9dcb6df6c0ee11537 [INFO] running `"docker" "start" "-a" "9d34e55317fbd8064a3b7c26c75c0a2a7ff681de51cfedd9dcb6df6c0ee11537"` [INFO] [stderr] Compiling bzip2-sys v0.1.6 [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Checking euclid v0.17.3 [INFO] [stderr] Checking sid v0.5.2 [INFO] [stderr] Checking ordered-float v0.5.1 [INFO] [stderr] Checking alga v0.5.4 [INFO] [stderr] Checking cpal v0.8.2 [INFO] [stderr] Checking sdl2 v0.31.0 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking rusttype v0.5.2 [INFO] [stderr] Checking rodio v0.7.0 [INFO] [stderr] Checking lyon_geom v0.10.1 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Checking zip v0.3.3 [INFO] [stderr] Checking lyon_path v0.10.1 [INFO] [stderr] Checking nalgebra v0.14.4 [INFO] [stderr] Checking lyon_tessellation v0.10.2 [INFO] [stderr] Checking lyon v0.10.2 [INFO] [stderr] Checking gfx_device_gl v0.15.3 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_glyph v0.10.2 [INFO] [stderr] Checking gfx_window_sdl v0.8.0 [INFO] [stderr] Checking ggez v0.4.4 [INFO] [stderr] Checking astro-blasto-refactor v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/better_ecs.rs:296:12 [INFO] [stderr] | [INFO] [stderr] 296 | if other.entities.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `other.entities.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/better_ecs.rs:296:12 [INFO] [stderr] | [INFO] [stderr] 296 | if other.entities.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `other.entities.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/better_ecs.rs:416:14 [INFO] [stderr] | [INFO] [stderr] 416 | .ok_or(EcsError::EntityNotFound(entity))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| EcsError::EntityNotFound(entity))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/better_ecs.rs:417:12 [INFO] [stderr] | [INFO] [stderr] 417 | Ok(components.get(&TypeId::of::()).map(|&id| id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `components.get(&TypeId::of::()).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/better_ecs.rs:416:14 [INFO] [stderr] | [INFO] [stderr] 416 | .ok_or(EcsError::EntityNotFound(entity))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| EcsError::EntityNotFound(entity))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/better_ecs.rs:417:12 [INFO] [stderr] | [INFO] [stderr] 417 | Ok(components.get(&TypeId::of::()).map(|&id| id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `components.get(&TypeId::of::()).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/better_ecs.rs:429:33 [INFO] [stderr] | [INFO] [stderr] 429 | .and_then(|opt| opt.ok_or(EcsError::ComponentTypeNotFound(entity))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| EcsError::ComponentTypeNotFound(entity))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/better_ecs.rs:436:14 [INFO] [stderr] | [INFO] [stderr] 436 | .ok_or(EcsError::ComponentNotFound(component)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| EcsError::ComponentNotFound(component))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/better_ecs.rs:429:33 [INFO] [stderr] | [INFO] [stderr] 429 | .and_then(|opt| opt.ok_or(EcsError::ComponentTypeNotFound(entity))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| EcsError::ComponentTypeNotFound(entity))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/better_ecs.rs:436:14 [INFO] [stderr] | [INFO] [stderr] 436 | .ok_or(EcsError::ComponentNotFound(component)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| EcsError::ComponentNotFound(component))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/better_ecs.rs:450:14 [INFO] [stderr] | [INFO] [stderr] 450 | .ok_or(EcsError::EntityNotFound(entity))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| EcsError::EntityNotFound(entity))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/better_ecs.rs:450:14 [INFO] [stderr] | [INFO] [stderr] 450 | .ok_or(EcsError::EntityNotFound(entity))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| EcsError::EntityNotFound(entity))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/better_ecs.rs:463:14 [INFO] [stderr] | [INFO] [stderr] 463 | .ok_or(EcsError::ComponentNotFound(component))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| EcsError::ComponentNotFound(component))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/better_ecs.rs:463:14 [INFO] [stderr] | [INFO] [stderr] 463 | .ok_or(EcsError::ComponentNotFound(component))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| EcsError::ComponentNotFound(component))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/better_ecs.rs:477:14 [INFO] [stderr] | [INFO] [stderr] 477 | .ok_or(EcsError::EntityNotFound(entity))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| EcsError::EntityNotFound(entity))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/better_ecs.rs:477:14 [INFO] [stderr] | [INFO] [stderr] 477 | .ok_or(EcsError::EntityNotFound(entity))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| EcsError::EntityNotFound(entity))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/better_ecs.rs:568:14 [INFO] [stderr] | [INFO] [stderr] 568 | .ok_or(EcsError::ComponentNotFound(id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| EcsError::ComponentNotFound(id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/better_ecs.rs:591:26 [INFO] [stderr] | [INFO] [stderr] 591 | Ref::new(refbox).ok_or(EcsError::ComponentTypeMismatch(id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| EcsError::ComponentTypeMismatch(id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/better_ecs.rs:568:14 [INFO] [stderr] | [INFO] [stderr] 568 | .ok_or(EcsError::ComponentNotFound(id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| EcsError::ComponentNotFound(id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/better_ecs.rs:607:29 [INFO] [stderr] | [INFO] [stderr] 607 | RefMut::new(refbox).ok_or(EcsError::ComponentTypeMismatch(id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| EcsError::ComponentTypeMismatch(id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/better_ecs.rs:637:11 [INFO] [stderr] | [INFO] [stderr] 637 | ).ok_or(EcsError::ComponentTypeMismatch(component_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| EcsError::ComponentTypeMismatch(component_id))` [INFO] [stderr] | [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] --> src/better_ecs.rs:591:26 [INFO] [stderr] | [INFO] [stderr] 591 | Ref::new(refbox).ok_or(EcsError::ComponentTypeMismatch(id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| EcsError::ComponentTypeMismatch(id))` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/better_ecs.rs:657:11 [INFO] [stderr] | [INFO] [stderr] 657 | ).ok_or(EcsError::ComponentTypeMismatch(component_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| EcsError::ComponentTypeMismatch(component_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/better_ecs.rs:607:29 [INFO] [stderr] | [INFO] [stderr] 607 | RefMut::new(refbox).ok_or(EcsError::ComponentTypeMismatch(id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| EcsError::ComponentTypeMismatch(id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/better_ecs.rs:637:11 [INFO] [stderr] | [INFO] [stderr] 637 | ).ok_or(EcsError::ComponentTypeMismatch(component_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| EcsError::ComponentTypeMismatch(component_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/better_ecs.rs:657:11 [INFO] [stderr] | [INFO] [stderr] 657 | ).ok_or(EcsError::ComponentTypeMismatch(component_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| EcsError::ComponentTypeMismatch(component_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/components.rs:37:24 [INFO] [stderr] | [INFO] [stderr] 37 | transform: transform.into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `transform` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/components.rs:38:22 [INFO] [stderr] | [INFO] [stderr] 38 | physics: physics.into(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider removing `.into()`: `physics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/better_ecs.rs:828:29 [INFO] [stderr] | [INFO] [stderr] 828 | fn update_position(pos: &Position, vel: &Velocity) -> Position { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Position` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/better_ecs.rs:828:45 [INFO] [stderr] | [INFO] [stderr] 828 | fn update_position(pos: &Position, vel: &Velocity) -> Position { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Velocity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/components.rs:37:24 [INFO] [stderr] | [INFO] [stderr] 37 | transform: transform.into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `transform` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/components.rs:38:22 [INFO] [stderr] | [INFO] [stderr] 38 | physics: physics.into(), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider removing `.into()`: `physics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 11s [INFO] running `"docker" "inspect" "9d34e55317fbd8064a3b7c26c75c0a2a7ff681de51cfedd9dcb6df6c0ee11537"` [INFO] running `"docker" "rm" "-f" "9d34e55317fbd8064a3b7c26c75c0a2a7ff681de51cfedd9dcb6df6c0ee11537"` [INFO] [stdout] 9d34e55317fbd8064a3b7c26c75c0a2a7ff681de51cfedd9dcb6df6c0ee11537