[INFO] updating cached repository PhilipTrauner/match3 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/PhilipTrauner/match3 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/PhilipTrauner/match3" "work/ex/clippy-test-run/sources/stable/gh/PhilipTrauner/match3"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/PhilipTrauner/match3'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/PhilipTrauner/match3" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PhilipTrauner/match3"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PhilipTrauner/match3'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6f1778267ad88f8273cd38cb8b8809944c62eebf [INFO] sha for GitHub repo PhilipTrauner/match3: 6f1778267ad88f8273cd38cb8b8809944c62eebf [INFO] validating manifest of PhilipTrauner/match3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of PhilipTrauner/match3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing PhilipTrauner/match3 [INFO] finished frobbing PhilipTrauner/match3 [INFO] frobbed toml for PhilipTrauner/match3 written to work/ex/clippy-test-run/sources/stable/gh/PhilipTrauner/match3/Cargo.toml [INFO] started frobbing PhilipTrauner/match3 [INFO] finished frobbing PhilipTrauner/match3 [INFO] frobbed toml for PhilipTrauner/match3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PhilipTrauner/match3/Cargo.toml [INFO] crate PhilipTrauner/match3 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting PhilipTrauner/match3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/PhilipTrauner/match3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 943d1c388f24244b6000a292d86dd9c236d73d9be76efcfaaa547351d0b15e51 [INFO] running `"docker" "start" "-a" "943d1c388f24244b6000a292d86dd9c236d73d9be76efcfaaa547351d0b15e51"` [INFO] [stderr] Compiling serde v0.9.9 [INFO] [stderr] Compiling xml-rs v0.3.8 [INFO] [stderr] Checking arrayvec v0.3.20 [INFO] [stderr] Checking pistoncore-window v0.26.2 [INFO] [stderr] Compiling target_build_utils v0.3.0 [INFO] [stderr] Checking image v0.12.3 [INFO] [stderr] Checking pistoncore-event_loop v0.31.3 [INFO] [stderr] Checking rusttype v0.2.1 [INFO] [stderr] Checking piston v0.31.3 [INFO] [stderr] Compiling wayland-scanner v0.7.8 [INFO] [stderr] Compiling gl_generator v0.5.2 [INFO] [stderr] Compiling wayland-client v0.7.8 [INFO] [stderr] Compiling glutin v0.7.4 [INFO] [stderr] Compiling gl v0.6.1 [INFO] [stderr] Compiling serde_json v0.9.8 [INFO] [stderr] Compiling libloading v0.3.2 [INFO] [stderr] Checking piston2d-opengl_graphics v0.42.0 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.8 [INFO] [stderr] Checking wayland-kbd v0.6.3 [INFO] [stderr] Checking wayland-window v0.4.4 [INFO] [stderr] Checking winit v0.5.11 [INFO] [stderr] Checking pistoncore-glutin_window v0.35.0 [INFO] [stderr] Checking match3 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:62:4 [INFO] [stderr] | [INFO] [stderr] 62 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:345:3 [INFO] [stderr] | [INFO] [stderr] 345 | tiles: tiles, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `tiles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:368:20 [INFO] [stderr] | [INFO] [stderr] 368 | cursor = Point {x: x, y: y}; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:368:26 [INFO] [stderr] | [INFO] [stderr] 368 | cursor = Point {x: x, y: y}; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:62:4 [INFO] [stderr] | [INFO] [stderr] 62 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:345:3 [INFO] [stderr] | [INFO] [stderr] 345 | tiles: tiles, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `tiles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:368:20 [INFO] [stderr] | [INFO] [stderr] 368 | cursor = Point {x: x, y: y}; [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:368:26 [INFO] [stderr] | [INFO] [stderr] 368 | cursor = Point {x: x, y: y}; [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `graphics::math::Matrix2d` [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use graphics::math::Matrix2d; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | if click.x >= x && click.x <= x + TILE_SIZE.width { [INFO] [stderr] | _________________^ [INFO] [stderr] 156 | | if click.y >= y && click.y <= y + TILE_SIZE.height { [INFO] [stderr] 157 | | let tile_index = [usize_row, usize_column]; [INFO] [stderr] 158 | | if tiles[tile_index[0]][tile_index[1]].selected { [INFO] [stderr] ... | [INFO] [stderr] 165 | | } [INFO] [stderr] 166 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 155 | if click.x >= x && click.x <= x + TILE_SIZE.width && click.y >= y && click.y <= y + TILE_SIZE.height { [INFO] [stderr] 156 | let tile_index = [usize_row, usize_column]; [INFO] [stderr] 157 | if tiles[tile_index[0]][tile_index[1]].selected { [INFO] [stderr] 158 | tiles[tile_index[0]][tile_index[1]].set_selected(false); [INFO] [stderr] 159 | } else { [INFO] [stderr] 160 | tiles[tile_index[0]][tile_index[1]].set_selected(true); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:221:14 [INFO] [stderr] | [INFO] [stderr] 221 | } else if column_2 == USIZE_COLUMNS { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 222 | | if column_1 == USIZE_COLUMNS - 1 { [INFO] [stderr] 223 | | allowed_move = true; [INFO] [stderr] 224 | | } [INFO] [stderr] 225 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 221 | } else if column_2 == USIZE_COLUMNS && column_1 == USIZE_COLUMNS - 1 { [INFO] [stderr] 222 | allowed_move = true; [INFO] [stderr] 223 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `button` [INFO] [stderr] --> src/main.rs:364:29 [INFO] [stderr] | [INFO] [stderr] 364 | if let Some(Button::Mouse(button)) = e.press_args() { [INFO] [stderr] | ^^^^^^ help: consider using `_button` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/main.rs:135:23 [INFO] [stderr] | [INFO] [stderr] 135 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/main.rs:141:23 [INFO] [stderr] | [INFO] [stderr] 141 | fn resize(&mut self, args: &[u32; 2]) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `column_1` is never read [INFO] [stderr] --> src/main.rs:235:17 [INFO] [stderr] | [INFO] [stderr] 235 | let mut column_1: usize = 0; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `column_2` is never read [INFO] [stderr] --> src/main.rs:236:17 [INFO] [stderr] | [INFO] [stderr] 236 | let mut column_2: usize = 0; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `row_1` is never read [INFO] [stderr] --> src/main.rs:252:17 [INFO] [stderr] | [INFO] [stderr] 252 | let mut row_1: usize = 0; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `row_2` is never read [INFO] [stderr] --> src/main.rs:253:17 [INFO] [stderr] | [INFO] [stderr] 253 | let mut row_2: usize = 0; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `column_1` is never read [INFO] [stderr] --> src/main.rs:254:17 [INFO] [stderr] | [INFO] [stderr] 254 | let mut column_1: usize = 0; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `column_2` is never read [INFO] [stderr] --> src/main.rs:255:17 [INFO] [stderr] | [INFO] [stderr] 255 | let mut column_2: usize = 0; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `last_color` [INFO] [stderr] --> src/main.rs:275:16 [INFO] [stderr] | [INFO] [stderr] 275 | let mut last_color: Option<[f32; 4]> = None; [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_last_color` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `color_count` [INFO] [stderr] --> src/main.rs:276:16 [INFO] [stderr] | [INFO] [stderr] 276 | let mut color_count = 0; [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_color_count` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_color` [INFO] [stderr] --> src/main.rs:67:2 [INFO] [stderr] | [INFO] [stderr] 67 | fn set_color(&mut self, color: [f32; 4]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:85:7 [INFO] [stderr] | [INFO] [stderr] 85 | let ref mut tiles = self.tiles; [INFO] [stderr] | ----^^^^^^^^^^^^^-------------- help: try: `let tiles = &mut self.tiles;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:95:15 [INFO] [stderr] | [INFO] [stderr] 95 | let x = column as f64 * TILE_SIZE.height; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(column)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:96:15 [INFO] [stderr] | [INFO] [stderr] 96 | let y = row as f64 * TILE_SIZE.width; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:135:29 [INFO] [stderr] | [INFO] [stderr] 135 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:141:29 [INFO] [stderr] | [INFO] [stderr] 141 | fn resize(&mut self, args: &[u32; 2]) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[u32; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/main.rs:145:2 [INFO] [stderr] | [INFO] [stderr] 145 | fn mouse_click(&mut self, click: &Point) { [INFO] [stderr] | _____^ [INFO] [stderr] 146 | | let ref mut tiles = self.tiles; [INFO] [stderr] 147 | | [INFO] [stderr] 148 | | let mut clicked_tile: Option<[usize; 2]> = None; [INFO] [stderr] ... | [INFO] [stderr] 307 | | } [INFO] [stderr] 308 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:146:7 [INFO] [stderr] | [INFO] [stderr] 146 | let ref mut tiles = self.tiles; [INFO] [stderr] | ----^^^^^^^^^^^^^-------------- help: try: `let tiles = &mut self.tiles;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | let x = column as f64 * TILE_SIZE.height; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(column)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | let y = row as f64 * TILE_SIZE.width; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:207:46 [INFO] [stderr] | [INFO] [stderr] 207 | } else if row_1 == 0 && column_1 == 1 { [INFO] [stderr] | ___________________________________________________________________^ [INFO] [stderr] 208 | | allowed_move = true; [INFO] [stderr] 209 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:205:39 [INFO] [stderr] | [INFO] [stderr] 205 | if row_1 == 1 && column_1 == 0 { [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 206 | | allowed_move = true; [INFO] [stderr] 207 | | } else if row_1 == 0 && column_1 == 1 { [INFO] [stderr] | |_____________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | let mut column_2: usize = 0; [INFO] [stderr] | _________________________________^ [INFO] [stderr] 237 | | if unwrapped_clicked_tile_index[1] < unwrapped_last_clicked_tile_index[1] { [INFO] [stderr] 238 | | column_1 = unwrapped_clicked_tile_index[1]; [INFO] [stderr] 239 | | column_2 = unwrapped_last_clicked_tile_index[1]; [INFO] [stderr] ... | [INFO] [stderr] 242 | | column_2 = unwrapped_clicked_tile_index[1]; [INFO] [stderr] 243 | | } [INFO] [stderr] | |_________________________________^ help: it is more idiomatic to write: `let column_2 = if unwrapped_clicked_tile_index[1] < unwrapped_last_clicked_tile_index[1] { ..; unwrapped_last_clicked_tile_index[1] } else { ..; unwrapped_clicked_tile_index[1] };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:255:9 [INFO] [stderr] | [INFO] [stderr] 255 | let mut column_2: usize = 0; [INFO] [stderr] | _________________________________^ [INFO] [stderr] 256 | | if unwrapped_clicked_tile_index[0] < unwrapped_last_clicked_tile_index[0] { [INFO] [stderr] 257 | | row_1 = unwrapped_clicked_tile_index[0]; [INFO] [stderr] 258 | | row_2 = unwrapped_last_clicked_tile_index[0]; [INFO] [stderr] ... | [INFO] [stderr] 265 | | column_2 = unwrapped_clicked_tile_index[1]; [INFO] [stderr] 266 | | } [INFO] [stderr] | |_________________________________^ help: it is more idiomatic to write: `let column_2 = if unwrapped_clicked_tile_index[0] < unwrapped_last_clicked_tile_index[0] { ..; unwrapped_last_clicked_tile_index[1] } else { ..; unwrapped_clicked_tile_index[1] };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `match3`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `graphics::math::Matrix2d` [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | use graphics::math::Matrix2d; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | if click.x >= x && click.x <= x + TILE_SIZE.width { [INFO] [stderr] | _________________^ [INFO] [stderr] 156 | | if click.y >= y && click.y <= y + TILE_SIZE.height { [INFO] [stderr] 157 | | let tile_index = [usize_row, usize_column]; [INFO] [stderr] 158 | | if tiles[tile_index[0]][tile_index[1]].selected { [INFO] [stderr] ... | [INFO] [stderr] 165 | | } [INFO] [stderr] 166 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 155 | if click.x >= x && click.x <= x + TILE_SIZE.width && click.y >= y && click.y <= y + TILE_SIZE.height { [INFO] [stderr] 156 | let tile_index = [usize_row, usize_column]; [INFO] [stderr] 157 | if tiles[tile_index[0]][tile_index[1]].selected { [INFO] [stderr] 158 | tiles[tile_index[0]][tile_index[1]].set_selected(false); [INFO] [stderr] 159 | } else { [INFO] [stderr] 160 | tiles[tile_index[0]][tile_index[1]].set_selected(true); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:221:14 [INFO] [stderr] | [INFO] [stderr] 221 | } else if column_2 == USIZE_COLUMNS { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 222 | | if column_1 == USIZE_COLUMNS - 1 { [INFO] [stderr] 223 | | allowed_move = true; [INFO] [stderr] 224 | | } [INFO] [stderr] 225 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 221 | } else if column_2 == USIZE_COLUMNS && column_1 == USIZE_COLUMNS - 1 { [INFO] [stderr] 222 | allowed_move = true; [INFO] [stderr] 223 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `button` [INFO] [stderr] --> src/main.rs:364:29 [INFO] [stderr] | [INFO] [stderr] 364 | if let Some(Button::Mouse(button)) = e.press_args() { [INFO] [stderr] | ^^^^^^ help: consider using `_button` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/main.rs:135:23 [INFO] [stderr] | [INFO] [stderr] 135 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/main.rs:141:23 [INFO] [stderr] | [INFO] [stderr] 141 | fn resize(&mut self, args: &[u32; 2]) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `column_1` is never read [INFO] [stderr] --> src/main.rs:235:17 [INFO] [stderr] | [INFO] [stderr] 235 | let mut column_1: usize = 0; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `column_2` is never read [INFO] [stderr] --> src/main.rs:236:17 [INFO] [stderr] | [INFO] [stderr] 236 | let mut column_2: usize = 0; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `row_1` is never read [INFO] [stderr] --> src/main.rs:252:17 [INFO] [stderr] | [INFO] [stderr] 252 | let mut row_1: usize = 0; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `row_2` is never read [INFO] [stderr] --> src/main.rs:253:17 [INFO] [stderr] | [INFO] [stderr] 253 | let mut row_2: usize = 0; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `column_1` is never read [INFO] [stderr] --> src/main.rs:254:17 [INFO] [stderr] | [INFO] [stderr] 254 | let mut column_1: usize = 0; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `column_2` is never read [INFO] [stderr] --> src/main.rs:255:17 [INFO] [stderr] | [INFO] [stderr] 255 | let mut column_2: usize = 0; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `last_color` [INFO] [stderr] --> src/main.rs:275:16 [INFO] [stderr] | [INFO] [stderr] 275 | let mut last_color: Option<[f32; 4]> = None; [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_last_color` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `color_count` [INFO] [stderr] --> src/main.rs:276:16 [INFO] [stderr] | [INFO] [stderr] 276 | let mut color_count = 0; [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_color_count` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_color` [INFO] [stderr] --> src/main.rs:67:2 [INFO] [stderr] | [INFO] [stderr] 67 | fn set_color(&mut self, color: [f32; 4]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:85:7 [INFO] [stderr] | [INFO] [stderr] 85 | let ref mut tiles = self.tiles; [INFO] [stderr] | ----^^^^^^^^^^^^^-------------- help: try: `let tiles = &mut self.tiles;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:95:15 [INFO] [stderr] | [INFO] [stderr] 95 | let x = column as f64 * TILE_SIZE.height; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(column)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:96:15 [INFO] [stderr] | [INFO] [stderr] 96 | let y = row as f64 * TILE_SIZE.width; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:135:29 [INFO] [stderr] | [INFO] [stderr] 135 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:141:29 [INFO] [stderr] | [INFO] [stderr] 141 | fn resize(&mut self, args: &[u32; 2]) { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `[u32; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/main.rs:145:2 [INFO] [stderr] | [INFO] [stderr] 145 | fn mouse_click(&mut self, click: &Point) { [INFO] [stderr] | _____^ [INFO] [stderr] 146 | | let ref mut tiles = self.tiles; [INFO] [stderr] 147 | | [INFO] [stderr] 148 | | let mut clicked_tile: Option<[usize; 2]> = None; [INFO] [stderr] ... | [INFO] [stderr] 307 | | } [INFO] [stderr] 308 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:146:7 [INFO] [stderr] | [INFO] [stderr] 146 | let ref mut tiles = self.tiles; [INFO] [stderr] | ----^^^^^^^^^^^^^-------------- help: try: `let tiles = &mut self.tiles;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | let x = column as f64 * TILE_SIZE.height; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(column)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | let y = row as f64 * TILE_SIZE.width; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:207:46 [INFO] [stderr] | [INFO] [stderr] 207 | } else if row_1 == 0 && column_1 == 1 { [INFO] [stderr] | ___________________________________________________________________^ [INFO] [stderr] 208 | | allowed_move = true; [INFO] [stderr] 209 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:205:39 [INFO] [stderr] | [INFO] [stderr] 205 | if row_1 == 1 && column_1 == 0 { [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 206 | | allowed_move = true; [INFO] [stderr] 207 | | } else if row_1 == 0 && column_1 == 1 { [INFO] [stderr] | |_____________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | let mut column_2: usize = 0; [INFO] [stderr] | _________________________________^ [INFO] [stderr] 237 | | if unwrapped_clicked_tile_index[1] < unwrapped_last_clicked_tile_index[1] { [INFO] [stderr] 238 | | column_1 = unwrapped_clicked_tile_index[1]; [INFO] [stderr] 239 | | column_2 = unwrapped_last_clicked_tile_index[1]; [INFO] [stderr] ... | [INFO] [stderr] 242 | | column_2 = unwrapped_clicked_tile_index[1]; [INFO] [stderr] 243 | | } [INFO] [stderr] | |_________________________________^ help: it is more idiomatic to write: `let column_2 = if unwrapped_clicked_tile_index[1] < unwrapped_last_clicked_tile_index[1] { ..; unwrapped_last_clicked_tile_index[1] } else { ..; unwrapped_clicked_tile_index[1] };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:255:9 [INFO] [stderr] | [INFO] [stderr] 255 | let mut column_2: usize = 0; [INFO] [stderr] | _________________________________^ [INFO] [stderr] 256 | | if unwrapped_clicked_tile_index[0] < unwrapped_last_clicked_tile_index[0] { [INFO] [stderr] 257 | | row_1 = unwrapped_clicked_tile_index[0]; [INFO] [stderr] 258 | | row_2 = unwrapped_last_clicked_tile_index[0]; [INFO] [stderr] ... | [INFO] [stderr] 265 | | column_2 = unwrapped_clicked_tile_index[1]; [INFO] [stderr] 266 | | } [INFO] [stderr] | |_________________________________^ help: it is more idiomatic to write: `let column_2 = if unwrapped_clicked_tile_index[0] < unwrapped_last_clicked_tile_index[0] { ..; unwrapped_last_clicked_tile_index[1] } else { ..; unwrapped_clicked_tile_index[1] };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `match3`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "943d1c388f24244b6000a292d86dd9c236d73d9be76efcfaaa547351d0b15e51"` [INFO] running `"docker" "rm" "-f" "943d1c388f24244b6000a292d86dd9c236d73d9be76efcfaaa547351d0b15e51"` [INFO] [stdout] 943d1c388f24244b6000a292d86dd9c236d73d9be76efcfaaa547351d0b15e51