[INFO] updating cached repository PhilipDaniels/word_chains [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/PhilipDaniels/word_chains [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/PhilipDaniels/word_chains" "work/ex/clippy-test-run/sources/stable/gh/PhilipDaniels/word_chains"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/PhilipDaniels/word_chains'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/PhilipDaniels/word_chains" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PhilipDaniels/word_chains"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PhilipDaniels/word_chains'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bf9430e6e6619f1988c7fe4bd4d6af853559eb35 [INFO] sha for GitHub repo PhilipDaniels/word_chains: bf9430e6e6619f1988c7fe4bd4d6af853559eb35 [INFO] validating manifest of PhilipDaniels/word_chains on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of PhilipDaniels/word_chains on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing PhilipDaniels/word_chains [INFO] finished frobbing PhilipDaniels/word_chains [INFO] frobbed toml for PhilipDaniels/word_chains written to work/ex/clippy-test-run/sources/stable/gh/PhilipDaniels/word_chains/Cargo.toml [INFO] started frobbing PhilipDaniels/word_chains [INFO] finished frobbing PhilipDaniels/word_chains [INFO] frobbed toml for PhilipDaniels/word_chains written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PhilipDaniels/word_chains/Cargo.toml [INFO] crate PhilipDaniels/word_chains has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting PhilipDaniels/word_chains against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/PhilipDaniels/word_chains:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 06327f7d053153cedb205dc7fff10bd648619a02f91f782d33abe07e523dad92 [INFO] running `"docker" "start" "-a" "06327f7d053153cedb205dc7fff10bd648619a02f91f782d33abe07e523dad92"` [INFO] [stderr] Compiling structopt-derive v0.2.5 [INFO] [stderr] Checking structopt v0.2.5 [INFO] [stderr] Checking word_chains v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/dictionary.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | write!(writer, "{}\n", w).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/letter_differences.rs:17:25 [INFO] [stderr] | [INFO] [stderr] 17 | AnchoredWords { anchor: anchor, reachable_words: Vec::new() } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `anchor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/letter_differences.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | write!(writer, "\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | word: word, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `word` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/dictionary.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | write!(writer, "{}\n", w).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/letter_differences.rs:17:25 [INFO] [stderr] | [INFO] [stderr] 17 | AnchoredWords { anchor: anchor, reachable_words: Vec::new() } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `anchor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/letter_differences.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | write!(writer, "\n").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | word: word, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `word` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] extern crate structopt; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/dictionary.rs:6:23 [INFO] [stderr] | [INFO] [stderr] 6 | pub const DICT_OUT : &'static str = "./dictionaries_out"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/dictionary.rs:7:23 [INFO] [stderr] | [INFO] [stderr] 7 | pub const CORPUS : &'static str = "./dictionaries_out/corpus.txt"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/dictionary.rs:9:18 [INFO] [stderr] | [INFO] [stderr] 9 | const DICT_IN : &'static str = "./dictionaries"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/letter_differences.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | return num_diffs == 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `num_diffs == 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] extern crate structopt; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/dictionary.rs:6:23 [INFO] [stderr] | [INFO] [stderr] 6 | pub const DICT_OUT : &'static str = "./dictionaries_out"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/dictionary.rs:7:23 [INFO] [stderr] | [INFO] [stderr] 7 | pub const CORPUS : &'static str = "./dictionaries_out/corpus.txt"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/dictionary.rs:9:18 [INFO] [stderr] | [INFO] [stderr] 9 | const DICT_IN : &'static str = "./dictionaries"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/letter_differences.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | return num_diffs == 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `num_diffs == 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `g` [INFO] [stderr] --> src/letter_differences.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | let g = make_graph(&rwords_for_table); [INFO] [stderr] | ^ help: consider using `_g` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `word` [INFO] [stderr] --> src/graph.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | word: &'word String, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `word` [INFO] [stderr] --> src/graph.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | fn word(&self) -> &String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/dictionary.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | / match v { [INFO] [stderr] 28 | | Ok(bytes) => { [INFO] [stderr] 29 | | num_words_read_from_file += 1; [INFO] [stderr] 30 | | match String::from_utf8(bytes) { [INFO] [stderr] ... | [INFO] [stderr] 35 | | Err(_) => {} [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | if let Ok(bytes) = v { [INFO] [stderr] 28 | num_words_read_from_file += 1; [INFO] [stderr] 29 | match String::from_utf8(bytes) { [INFO] [stderr] 30 | Ok(word) => { if let Some(w) = clean_word(word) { words.insert(w); }}, [INFO] [stderr] 31 | Err(_) => {} [INFO] [stderr] 32 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/dictionary.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | / match String::from_utf8(bytes) { [INFO] [stderr] 31 | | Ok(word) => { if let Some(w) = clean_word(word) { words.insert(w); }}, [INFO] [stderr] 32 | | Err(_) => {} [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let Ok(word) = String::from_utf8(bytes) { if let Some(w) = clean_word(word) { words.insert(w); }}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/letter_differences.rs:41:31 [INFO] [stderr] | [INFO] [stderr] 41 | fn make_graph(anchored_words: &Vec) -> Graph { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[AnchoredWords]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/letter_differences.rs:46:85 [INFO] [stderr] | [INFO] [stderr] 46 | let interesting_words : Vec<&AnchoredWords> = anchored_words.iter().filter(|aw| aw.reachable_words.len() > 0).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!aw.reachable_words.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/letter_differences.rs:104:62 [INFO] [stderr] | [INFO] [stderr] 104 | fn write_difference_file(word_length: usize, anchored_words: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[AnchoredWords]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/letter_differences.rs:111:12 [INFO] [stderr] | [INFO] [stderr] 111 | if v.reachable_words.len() == 0 { continue }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.reachable_words.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/word_base.rs:15:37 [INFO] [stderr] | [INFO] [stderr] 15 | let mut keys : Vec = self.words.keys().map(|&k| k).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.words.keys().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/word_base.rs:38:40 [INFO] [stderr] | [INFO] [stderr] 38 | let wt = self.words.entry(len).or_insert(WordTable::new(len)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| WordTable::new(len))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph.rs:10:18 [INFO] [stderr] | [INFO] [stderr] 10 | fn new(word: &'word String) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph.rs:36:45 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn add_anchor_word(&mut self, word: &'word String) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph.rs:42:55 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn add_reachable_word(&mut self, anchor_word: &'word String, reachable_word: &'word String) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph.rs:42:86 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn add_reachable_word(&mut self, anchor_word: &'word String, reachable_word: &'word String) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused variable: `g` [INFO] [stderr] --> src/letter_differences.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | let g = make_graph(&rwords_for_table); [INFO] [stderr] | ^ help: consider using `_g` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `word` [INFO] [stderr] --> src/graph.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | word: &'word String, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `word` [INFO] [stderr] --> src/graph.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | fn word(&self) -> &String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/dictionary.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | / match v { [INFO] [stderr] 28 | | Ok(bytes) => { [INFO] [stderr] 29 | | num_words_read_from_file += 1; [INFO] [stderr] 30 | | match String::from_utf8(bytes) { [INFO] [stderr] ... | [INFO] [stderr] 35 | | Err(_) => {} [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 27 | if let Ok(bytes) = v { [INFO] [stderr] 28 | num_words_read_from_file += 1; [INFO] [stderr] 29 | match String::from_utf8(bytes) { [INFO] [stderr] 30 | Ok(word) => { if let Some(w) = clean_word(word) { words.insert(w); }}, [INFO] [stderr] 31 | Err(_) => {} [INFO] [stderr] 32 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/dictionary.rs:30:21 [INFO] [stderr] | [INFO] [stderr] 30 | / match String::from_utf8(bytes) { [INFO] [stderr] 31 | | Ok(word) => { if let Some(w) = clean_word(word) { words.insert(w); }}, [INFO] [stderr] 32 | | Err(_) => {} [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let Ok(word) = String::from_utf8(bytes) { if let Some(w) = clean_word(word) { words.insert(w); }}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/letter_differences.rs:41:31 [INFO] [stderr] | [INFO] [stderr] 41 | fn make_graph(anchored_words: &Vec) -> Graph { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[AnchoredWords]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/letter_differences.rs:46:85 [INFO] [stderr] | [INFO] [stderr] 46 | let interesting_words : Vec<&AnchoredWords> = anchored_words.iter().filter(|aw| aw.reachable_words.len() > 0).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!aw.reachable_words.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/letter_differences.rs:104:62 [INFO] [stderr] | [INFO] [stderr] 104 | fn write_difference_file(word_length: usize, anchored_words: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[AnchoredWords]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/letter_differences.rs:111:12 [INFO] [stderr] | [INFO] [stderr] 111 | if v.reachable_words.len() == 0 { continue }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.reachable_words.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/word_base.rs:15:37 [INFO] [stderr] | [INFO] [stderr] 15 | let mut keys : Vec = self.words.keys().map(|&k| k).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.words.keys().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/word_base.rs:38:40 [INFO] [stderr] | [INFO] [stderr] 38 | let wt = self.words.entry(len).or_insert(WordTable::new(len)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| WordTable::new(len))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph.rs:10:18 [INFO] [stderr] | [INFO] [stderr] 10 | fn new(word: &'word String) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph.rs:36:45 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn add_anchor_word(&mut self, word: &'word String) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph.rs:42:55 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn add_reachable_word(&mut self, anchor_word: &'word String, reachable_word: &'word String) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph.rs:42:86 [INFO] [stderr] | [INFO] [stderr] 42 | pub fn add_reachable_word(&mut self, anchor_word: &'word String, reachable_word: &'word String) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.27s [INFO] running `"docker" "inspect" "06327f7d053153cedb205dc7fff10bd648619a02f91f782d33abe07e523dad92"` [INFO] running `"docker" "rm" "-f" "06327f7d053153cedb205dc7fff10bd648619a02f91f782d33abe07e523dad92"` [INFO] [stdout] 06327f7d053153cedb205dc7fff10bd648619a02f91f782d33abe07e523dad92