[INFO] updating cached repository PhazzaT/rvibra [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/PhazzaT/rvibra [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/PhazzaT/rvibra" "work/ex/clippy-test-run/sources/stable/gh/PhazzaT/rvibra"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/PhazzaT/rvibra'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/PhazzaT/rvibra" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PhazzaT/rvibra"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PhazzaT/rvibra'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 68cc023cfdbf05587416b5f9d04b884e8eda63e7 [INFO] sha for GitHub repo PhazzaT/rvibra: 68cc023cfdbf05587416b5f9d04b884e8eda63e7 [INFO] validating manifest of PhazzaT/rvibra on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of PhazzaT/rvibra on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing PhazzaT/rvibra [INFO] finished frobbing PhazzaT/rvibra [INFO] frobbed toml for PhazzaT/rvibra written to work/ex/clippy-test-run/sources/stable/gh/PhazzaT/rvibra/Cargo.toml [INFO] started frobbing PhazzaT/rvibra [INFO] finished frobbing PhazzaT/rvibra [INFO] frobbed toml for PhazzaT/rvibra written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PhazzaT/rvibra/Cargo.toml [INFO] crate PhazzaT/rvibra has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting PhazzaT/rvibra against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/PhazzaT/rvibra:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] af7708880edda9c4d507183242d9856f5686c5ed06aeb98b29e74848eec58e00 [INFO] running `"docker" "start" "-a" "af7708880edda9c4d507183242d9856f5686c5ed06aeb98b29e74848eec58e00"` [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking image v0.17.0 [INFO] [stderr] Checking rvibra v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/kmeans.rs:21:26 [INFO] [stderr] | [INFO] [stderr] 21 | FloatOrd(sqr(fc[0] - c[0] as f64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(c[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/kmeans.rs:22:27 [INFO] [stderr] | [INFO] [stderr] 22 | + sqr(fc[1] - c[1] as f64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(c[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/kmeans.rs:23:27 [INFO] [stderr] | [INFO] [stderr] 23 | + sqr(fc[2] - c[2] as f64)) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(c[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/kmeans.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | / fn initialize<'a>(pixels: PixelRegion<'a>, max_color_count: usize) [INFO] [stderr] 33 | | -> Vec
{ [INFO] [stderr] 34 | | // K-means++, but instead of randomly choosing, [INFO] [stderr] 35 | | // take the most distant color in each iteration [INFO] [stderr] ... | [INFO] [stderr] 57 | | centers [INFO] [stderr] 58 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/kmeans.rs:41:24 [INFO] [stderr] | [INFO] [stderr] 41 | .map(|px| [px[0] as f64, px[1] as f64, px[2] as f64]) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(px[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/kmeans.rs:41:38 [INFO] [stderr] | [INFO] [stderr] 41 | .map(|px| [px[0] as f64, px[1] as f64, px[2] as f64]) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(px[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/kmeans.rs:41:52 [INFO] [stderr] | [INFO] [stderr] 41 | .map(|px| [px[0] as f64, px[1] as f64, px[2] as f64]) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(px[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `acc`. [INFO] [stderr] --> src/kmeans.rs:45:18 [INFO] [stderr] | [INFO] [stderr] 45 | for i in 0..3 { acc[i] /= max_color_count as f64; } [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 45 | for in &mut acc { acc[i] /= max_color_count as f64; } [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/kmeans.rs:54:23 [INFO] [stderr] | [INFO] [stderr] 54 | centers.push([new[0] as f64, new[1] as f64, new[2] as f64]); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(new[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/kmeans.rs:54:38 [INFO] [stderr] | [INFO] [stderr] 54 | centers.push([new[0] as f64, new[1] as f64, new[2] as f64]); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(new[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/kmeans.rs:54:53 [INFO] [stderr] | [INFO] [stderr] 54 | centers.push([new[0] as f64, new[1] as f64, new[2] as f64]); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(new[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `px` [INFO] [stderr] --> src/kmeans.rs:69:22 [INFO] [stderr] | [INFO] [stderr] 69 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 69 | for (i, ) in px.iter().enumerate().take(3) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/kmeans.rs:70:40 [INFO] [stderr] | [INFO] [stderr] 70 | closest.centroid[i] += px[i] as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(px[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/kmeans.rs:90:1 [INFO] [stderr] | [INFO] [stderr] 90 | / pub fn quantize<'a>(pixels: PixelRegion<'a>, max_color_count: usize) [INFO] [stderr] 91 | | -> Vec { [INFO] [stderr] 92 | | // Lloyd's algorithm [INFO] [stderr] 93 | | let mut clusters = initialize(pixels, max_color_count).into_iter().map(|c| { [INFO] [stderr] ... | [INFO] [stderr] 132 | | }).collect::>() [INFO] [stderr] 133 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / fn load_pixels<'a>(img: &'a RgbImage) -> Box<[[u8; 3]]> { [INFO] [stderr] 16 | | img [INFO] [stderr] 17 | | .pixels() [INFO] [stderr] 18 | | .filter(|px| px[0] <= 250 || px[1] <= 250 || px[2] <= 250) [INFO] [stderr] ... | [INFO] [stderr] 22 | | .into_boxed_slice() [INFO] [stderr] 23 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:25:50 [INFO] [stderr] | [INFO] [stderr] 25 | fn posterize<'a>(img: &'a mut RgbImage, palette: &'a Vec<[u8; 3]>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[[u8; 3]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:30:32 [INFO] [stderr] | [INFO] [stderr] 30 | (0..3).map(|i| sqr(c[i] as i32 - px[i] as i32)).sum::() [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(c[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:30:46 [INFO] [stderr] | [INFO] [stderr] 30 | (0..3).map(|i| sqr(c[i] as i32 - px[i] as i32)).sum::() [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(px[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/kmeans.rs:21:26 [INFO] [stderr] | [INFO] [stderr] 21 | FloatOrd(sqr(fc[0] - c[0] as f64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(c[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/kmeans.rs:22:27 [INFO] [stderr] | [INFO] [stderr] 22 | + sqr(fc[1] - c[1] as f64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(c[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/kmeans.rs:23:27 [INFO] [stderr] | [INFO] [stderr] 23 | + sqr(fc[2] - c[2] as f64)) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(c[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/kmeans.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | / fn initialize<'a>(pixels: PixelRegion<'a>, max_color_count: usize) [INFO] [stderr] 33 | | -> Vec
{ [INFO] [stderr] 34 | | // K-means++, but instead of randomly choosing, [INFO] [stderr] 35 | | // take the most distant color in each iteration [INFO] [stderr] ... | [INFO] [stderr] 57 | | centers [INFO] [stderr] 58 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/kmeans.rs:41:24 [INFO] [stderr] | [INFO] [stderr] 41 | .map(|px| [px[0] as f64, px[1] as f64, px[2] as f64]) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(px[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/kmeans.rs:41:38 [INFO] [stderr] | [INFO] [stderr] 41 | .map(|px| [px[0] as f64, px[1] as f64, px[2] as f64]) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(px[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/kmeans.rs:41:52 [INFO] [stderr] | [INFO] [stderr] 41 | .map(|px| [px[0] as f64, px[1] as f64, px[2] as f64]) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(px[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `acc`. [INFO] [stderr] --> src/kmeans.rs:45:18 [INFO] [stderr] | [INFO] [stderr] 45 | for i in 0..3 { acc[i] /= max_color_count as f64; } [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 45 | for in &mut acc { acc[i] /= max_color_count as f64; } [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/kmeans.rs:54:23 [INFO] [stderr] | [INFO] [stderr] 54 | centers.push([new[0] as f64, new[1] as f64, new[2] as f64]); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(new[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/kmeans.rs:54:38 [INFO] [stderr] | [INFO] [stderr] 54 | centers.push([new[0] as f64, new[1] as f64, new[2] as f64]); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(new[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/kmeans.rs:54:53 [INFO] [stderr] | [INFO] [stderr] 54 | centers.push([new[0] as f64, new[1] as f64, new[2] as f64]); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(new[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `px` [INFO] [stderr] --> src/kmeans.rs:69:22 [INFO] [stderr] | [INFO] [stderr] 69 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 69 | for (i, ) in px.iter().enumerate().take(3) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/kmeans.rs:70:40 [INFO] [stderr] | [INFO] [stderr] 70 | closest.centroid[i] += px[i] as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(px[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/kmeans.rs:90:1 [INFO] [stderr] | [INFO] [stderr] 90 | / pub fn quantize<'a>(pixels: PixelRegion<'a>, max_color_count: usize) [INFO] [stderr] 91 | | -> Vec { [INFO] [stderr] 92 | | // Lloyd's algorithm [INFO] [stderr] 93 | | let mut clusters = initialize(pixels, max_color_count).into_iter().map(|c| { [INFO] [stderr] ... | [INFO] [stderr] 132 | | }).collect::>() [INFO] [stderr] 133 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / fn load_pixels<'a>(img: &'a RgbImage) -> Box<[[u8; 3]]> { [INFO] [stderr] 16 | | img [INFO] [stderr] 17 | | .pixels() [INFO] [stderr] 18 | | .filter(|px| px[0] <= 250 || px[1] <= 250 || px[2] <= 250) [INFO] [stderr] ... | [INFO] [stderr] 22 | | .into_boxed_slice() [INFO] [stderr] 23 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:25:50 [INFO] [stderr] | [INFO] [stderr] 25 | fn posterize<'a>(img: &'a mut RgbImage, palette: &'a Vec<[u8; 3]>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[[u8; 3]]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:30:32 [INFO] [stderr] | [INFO] [stderr] 30 | (0..3).map(|i| sqr(c[i] as i32 - px[i] as i32)).sum::() [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(c[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:30:46 [INFO] [stderr] | [INFO] [stderr] 30 | (0..3).map(|i| sqr(c[i] as i32 - px[i] as i32)).sum::() [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(px[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.29s [INFO] running `"docker" "inspect" "af7708880edda9c4d507183242d9856f5686c5ed06aeb98b29e74848eec58e00"` [INFO] running `"docker" "rm" "-f" "af7708880edda9c4d507183242d9856f5686c5ed06aeb98b29e74848eec58e00"` [INFO] [stdout] af7708880edda9c4d507183242d9856f5686c5ed06aeb98b29e74848eec58e00