[INFO] updating cached repository PeterJCLaw/fast-hashdeep [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/PeterJCLaw/fast-hashdeep [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/PeterJCLaw/fast-hashdeep" "work/ex/clippy-test-run/sources/stable/gh/PeterJCLaw/fast-hashdeep"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/PeterJCLaw/fast-hashdeep'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/PeterJCLaw/fast-hashdeep" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PeterJCLaw/fast-hashdeep"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PeterJCLaw/fast-hashdeep'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2ced45803711b2428a5389c55e967575799770cf [INFO] sha for GitHub repo PeterJCLaw/fast-hashdeep: 2ced45803711b2428a5389c55e967575799770cf [INFO] validating manifest of PeterJCLaw/fast-hashdeep on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of PeterJCLaw/fast-hashdeep on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing PeterJCLaw/fast-hashdeep [INFO] finished frobbing PeterJCLaw/fast-hashdeep [INFO] frobbed toml for PeterJCLaw/fast-hashdeep written to work/ex/clippy-test-run/sources/stable/gh/PeterJCLaw/fast-hashdeep/Cargo.toml [INFO] started frobbing PeterJCLaw/fast-hashdeep [INFO] finished frobbing PeterJCLaw/fast-hashdeep [INFO] frobbed toml for PeterJCLaw/fast-hashdeep written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PeterJCLaw/fast-hashdeep/Cargo.toml [INFO] crate PeterJCLaw/fast-hashdeep has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting PeterJCLaw/fast-hashdeep against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/PeterJCLaw/fast-hashdeep:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ba26e59122545f86616dc476cfdafc43abf6af1dde44c9c7cde5bcd61e294160 [INFO] running `"docker" "start" "-a" "ba26e59122545f86616dc476cfdafc43abf6af1dde44c9c7cde5bcd61e294160"` [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking fast-hashdeep v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:384:9 [INFO] [stderr] | [INFO] [stderr] 384 | changed: changed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `changed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:385:9 [INFO] [stderr] | [INFO] [stderr] 385 | copied: copied, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `copied` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:386:9 [INFO] [stderr] | [INFO] [stderr] 386 | moved: moved, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `moved` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:387:9 [INFO] [stderr] | [INFO] [stderr] 387 | deleted: deleted, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `deleted` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:384:9 [INFO] [stderr] | [INFO] [stderr] 384 | changed: changed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `changed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:385:9 [INFO] [stderr] | [INFO] [stderr] 385 | copied: copied, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `copied` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:386:9 [INFO] [stderr] | [INFO] [stderr] 386 | moved: moved, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `moved` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/common.rs:387:9 [INFO] [stderr] | [INFO] [stderr] 387 | deleted: deleted, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `deleted` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/common.rs:141:18 [INFO] [stderr] | [INFO] [stderr] 141 | .expect(&format!("Bad datetime '{}'", parts[0])), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Bad datetime '{}'", parts[0]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | self.changed.len() > 0 || self.copied.len() > 0 || self.moved.len() > 0 || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.changed.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common.rs:163:35 [INFO] [stderr] | [INFO] [stderr] 163 | self.changed.len() > 0 || self.copied.len() > 0 || self.moved.len() > 0 || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.copied.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common.rs:163:60 [INFO] [stderr] | [INFO] [stderr] 163 | self.changed.len() > 0 || self.copied.len() > 0 || self.moved.len() > 0 || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.moved.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | self.deleted.len() > 0 || self.added.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.deleted.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common.rs:164:39 [INFO] [stderr] | [INFO] [stderr] 164 | self.deleted.len() > 0 || self.added.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.added.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/common.rs:167:38 [INFO] [stderr] | [INFO] [stderr] 167 | fn descriptions<'a, T, F>(items: &Vec, title: &'a str, item_formatter: F) -> Option [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common.rs:172:12 [INFO] [stderr] | [INFO] [stderr] 172 | if items.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/common.rs:285:26 [INFO] [stderr] | [INFO] [stderr] 285 | pub fn load_descriptions<'a, I, P>(references: I) -> HashMap [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/common.rs:318:9 [INFO] [stderr] | [INFO] [stderr] 318 | / match maybe_description { [INFO] [stderr] 319 | | &MaybeFileDescription::MissingFile(_) => missing.push(filepath.as_path()), [INFO] [stderr] 320 | | &MaybeFileDescription::FileDescription(ref description) => { [INFO] [stderr] 321 | | actual.insert(filepath.as_path(), &description); [INFO] [stderr] ... | [INFO] [stderr] 336 | | } [INFO] [stderr] 337 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 318 | match *maybe_description { [INFO] [stderr] 319 | MaybeFileDescription::MissingFile(_) => missing.push(filepath.as_path()), [INFO] [stderr] 320 | MaybeFileDescription::FileDescription(ref description) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/common.rs:343:25 [INFO] [stderr] | [INFO] [stderr] 343 | .filter_map(|x| match x { [INFO] [stderr] | _________________________^ [INFO] [stderr] 344 | | &MaybeFileDescription::MissingFile(_) => None, [INFO] [stderr] 345 | | &MaybeFileDescription::FileDescription(ref description) => Some(description), [INFO] [stderr] 346 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 343 | .filter_map(|x| match *x { [INFO] [stderr] 344 | MaybeFileDescription::MissingFile(_) => None, [INFO] [stderr] 345 | MaybeFileDescription::FileDescription(ref description) => Some(description), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/handlers.rs:56:53 [INFO] [stderr] | [INFO] [stderr] 56 | target_descriptions.entry(filepath.clone()).or_insert( [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 57 | | MaybeFileDescription::MissingFile(MissingFile::new(filepath)), [INFO] [stderr] 58 | | ); [INFO] [stderr] | |_________^ help: try this: `or_insert_with(|| MaybeFileDescription::MissingFile(MissingFile::new(filepath)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/common.rs:141:18 [INFO] [stderr] | [INFO] [stderr] 141 | .expect(&format!("Bad datetime '{}'", parts[0])), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Bad datetime '{}'", parts[0]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | self.changed.len() > 0 || self.copied.len() > 0 || self.moved.len() > 0 || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.changed.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common.rs:163:35 [INFO] [stderr] | [INFO] [stderr] 163 | self.changed.len() > 0 || self.copied.len() > 0 || self.moved.len() > 0 || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.copied.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common.rs:163:60 [INFO] [stderr] | [INFO] [stderr] 163 | self.changed.len() > 0 || self.copied.len() > 0 || self.moved.len() > 0 || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.moved.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | self.deleted.len() > 0 || self.added.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.deleted.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common.rs:164:39 [INFO] [stderr] | [INFO] [stderr] 164 | self.deleted.len() > 0 || self.added.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.added.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/common.rs:167:38 [INFO] [stderr] | [INFO] [stderr] 167 | fn descriptions<'a, T, F>(items: &Vec, title: &'a str, item_formatter: F) -> Option [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/common.rs:172:12 [INFO] [stderr] | [INFO] [stderr] 172 | if items.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `items.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/common.rs:285:26 [INFO] [stderr] | [INFO] [stderr] 285 | pub fn load_descriptions<'a, I, P>(references: I) -> HashMap [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/common.rs:318:9 [INFO] [stderr] | [INFO] [stderr] 318 | / match maybe_description { [INFO] [stderr] 319 | | &MaybeFileDescription::MissingFile(_) => missing.push(filepath.as_path()), [INFO] [stderr] 320 | | &MaybeFileDescription::FileDescription(ref description) => { [INFO] [stderr] 321 | | actual.insert(filepath.as_path(), &description); [INFO] [stderr] ... | [INFO] [stderr] 336 | | } [INFO] [stderr] 337 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 318 | match *maybe_description { [INFO] [stderr] 319 | MaybeFileDescription::MissingFile(_) => missing.push(filepath.as_path()), [INFO] [stderr] 320 | MaybeFileDescription::FileDescription(ref description) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/common.rs:343:25 [INFO] [stderr] | [INFO] [stderr] 343 | .filter_map(|x| match x { [INFO] [stderr] | _________________________^ [INFO] [stderr] 344 | | &MaybeFileDescription::MissingFile(_) => None, [INFO] [stderr] 345 | | &MaybeFileDescription::FileDescription(ref description) => Some(description), [INFO] [stderr] 346 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 343 | .filter_map(|x| match *x { [INFO] [stderr] 344 | MaybeFileDescription::MissingFile(_) => None, [INFO] [stderr] 345 | MaybeFileDescription::FileDescription(ref description) => Some(description), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/handlers.rs:56:53 [INFO] [stderr] | [INFO] [stderr] 56 | target_descriptions.entry(filepath.clone()).or_insert( [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 57 | | MaybeFileDescription::MissingFile(MissingFile::new(filepath)), [INFO] [stderr] 58 | | ); [INFO] [stderr] | |_________^ help: try this: `or_insert_with(|| MaybeFileDescription::MissingFile(MissingFile::new(filepath)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.21s [INFO] running `"docker" "inspect" "ba26e59122545f86616dc476cfdafc43abf6af1dde44c9c7cde5bcd61e294160"` [INFO] running `"docker" "rm" "-f" "ba26e59122545f86616dc476cfdafc43abf6af1dde44c9c7cde5bcd61e294160"` [INFO] [stdout] ba26e59122545f86616dc476cfdafc43abf6af1dde44c9c7cde5bcd61e294160