[INFO] updating cached repository Peter-Van-Drunen/rust-factorial
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Peter-Van-Drunen/rust-factorial
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Peter-Van-Drunen/rust-factorial" "work/ex/clippy-test-run/sources/stable/gh/Peter-Van-Drunen/rust-factorial"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Peter-Van-Drunen/rust-factorial'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Peter-Van-Drunen/rust-factorial" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Peter-Van-Drunen/rust-factorial"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Peter-Van-Drunen/rust-factorial'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 9890b023e876a0f7ce5148641f7c66b242315bcd
[INFO] sha for GitHub repo Peter-Van-Drunen/rust-factorial: 9890b023e876a0f7ce5148641f7c66b242315bcd
[INFO] validating manifest of Peter-Van-Drunen/rust-factorial on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Peter-Van-Drunen/rust-factorial on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Peter-Van-Drunen/rust-factorial
[INFO] finished frobbing Peter-Van-Drunen/rust-factorial
[INFO] frobbed toml for Peter-Van-Drunen/rust-factorial written to work/ex/clippy-test-run/sources/stable/gh/Peter-Van-Drunen/rust-factorial/Cargo.toml
[INFO] started frobbing Peter-Van-Drunen/rust-factorial
[INFO] finished frobbing Peter-Van-Drunen/rust-factorial
[INFO] frobbed toml for Peter-Van-Drunen/rust-factorial written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Peter-Van-Drunen/rust-factorial/Cargo.toml
[INFO] crate Peter-Van-Drunen/rust-factorial has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Peter-Van-Drunen/rust-factorial against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Peter-Van-Drunen/rust-factorial:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7857094c89aff99b1c6411b0b10438f8d25cf0a73cc66ba41f48669f215f4fee
[INFO] running `"docker" "start" "-a" "7857094c89aff99b1c6411b0b10438f8d25cf0a73cc66ba41f48669f215f4fee"`
[INFO] [stderr]     Checking factorial v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/main.rs:5:9
[INFO] [stderr]   |
[INFO] [stderr] 5 |         return 1;
[INFO] [stderr]   |         ^^^^^^^^^ help: remove `return` as shown: `1`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/main.rs:7:9
[INFO] [stderr]   |
[INFO] [stderr] 7 |         return n * factorial(n - 1);
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `n * factorial(n - 1)`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/main.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     stdin().read_line(&mut input)
[INFO] [stderr] 17 | |         .ok()
[INFO] [stderr] 18 | |         .expect("Couldn't read line");
[INFO] [stderr]    | |_____________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/main.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |     let n = input.trim().parse::<i32>().ok().expect("Couldn't uwrap");
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/main.rs:5:9
[INFO] [stderr]   |
[INFO] [stderr] 5 |         return 1;
[INFO] [stderr]   |         ^^^^^^^^^ help: remove `return` as shown: `1`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/main.rs:7:9
[INFO] [stderr]   |
[INFO] [stderr] 7 |         return n * factorial(n - 1);
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `n * factorial(n - 1)`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/main.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     stdin().read_line(&mut input)
[INFO] [stderr] 17 | |         .ok()
[INFO] [stderr] 18 | |         .expect("Couldn't read line");
[INFO] [stderr]    | |_____________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ok_expect)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
[INFO] [stderr]   --> src/main.rs:20:13
[INFO] [stderr]    |
[INFO] [stderr] 20 |     let n = input.trim().parse::<i32>().ok().expect("Couldn't uwrap");
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.04s
[INFO] running `"docker" "inspect" "7857094c89aff99b1c6411b0b10438f8d25cf0a73cc66ba41f48669f215f4fee"`
[INFO] running `"docker" "rm" "-f" "7857094c89aff99b1c6411b0b10438f8d25cf0a73cc66ba41f48669f215f4fee"`
[INFO] [stdout] 7857094c89aff99b1c6411b0b10438f8d25cf0a73cc66ba41f48669f215f4fee