[INFO] updating cached repository PeronTheDuck/rust_Floyd_Steinberg_dithering [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/PeronTheDuck/rust_Floyd_Steinberg_dithering [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/PeronTheDuck/rust_Floyd_Steinberg_dithering" "work/ex/clippy-test-run/sources/stable/gh/PeronTheDuck/rust_Floyd_Steinberg_dithering"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/PeronTheDuck/rust_Floyd_Steinberg_dithering'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/PeronTheDuck/rust_Floyd_Steinberg_dithering" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PeronTheDuck/rust_Floyd_Steinberg_dithering"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PeronTheDuck/rust_Floyd_Steinberg_dithering'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c393ff7f362813a2cc6287a1810927f28f4b2627 [INFO] sha for GitHub repo PeronTheDuck/rust_Floyd_Steinberg_dithering: c393ff7f362813a2cc6287a1810927f28f4b2627 [INFO] validating manifest of PeronTheDuck/rust_Floyd_Steinberg_dithering on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of PeronTheDuck/rust_Floyd_Steinberg_dithering on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing PeronTheDuck/rust_Floyd_Steinberg_dithering [INFO] finished frobbing PeronTheDuck/rust_Floyd_Steinberg_dithering [INFO] frobbed toml for PeronTheDuck/rust_Floyd_Steinberg_dithering written to work/ex/clippy-test-run/sources/stable/gh/PeronTheDuck/rust_Floyd_Steinberg_dithering/Cargo.toml [INFO] started frobbing PeronTheDuck/rust_Floyd_Steinberg_dithering [INFO] finished frobbing PeronTheDuck/rust_Floyd_Steinberg_dithering [INFO] frobbed toml for PeronTheDuck/rust_Floyd_Steinberg_dithering written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PeronTheDuck/rust_Floyd_Steinberg_dithering/Cargo.toml [INFO] crate PeronTheDuck/rust_Floyd_Steinberg_dithering has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting PeronTheDuck/rust_Floyd_Steinberg_dithering against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/PeronTheDuck/rust_Floyd_Steinberg_dithering:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 866a5ef042e1aac8322dd5d0b200ee59ee9d22eda0c8463c92392a68902b5f3c [INFO] running `"docker" "start" "-a" "866a5ef042e1aac8322dd5d0b200ee59ee9d22eda0c8463c92392a68902b5f3c"` [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking image v0.20.0 [INFO] [stderr] Checking floyd_steinberg_dithering v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | let out = image::Rgba([r, g, b, 0xFFu8]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | out [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | let out = image::Rgba([r, g, b, 0xFFu8]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: type `rgba` should have a camel case name such as `Rgba` [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | type rgba = image::Rgba; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:7:25 [INFO] [stderr] | [INFO] [stderr] 7 | fn process_pixel(pixel: &rgba, factor: u8) -> rgba { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `rgba` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:9:22 [INFO] [stderr] | [INFO] [stderr] 9 | let factor:f64 = factor as f64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(factor)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | let r = ((factor * (r as f64) / 255f64).round() * (255f64 / factor)) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | let g = ((factor * (g as f64) / 255f64).round() * (255f64 / factor)) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:13:24 [INFO] [stderr] | [INFO] [stderr] 13 | let b = ((factor * (b as f64) / 255f64).round() * (255f64 / factor)) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:25:11 [INFO] [stderr] | [INFO] [stderr] 25 | while args_list.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args_list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | (old_pixel[0] as i16 - new_pixel[0] as i16).min(0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(old_pixel[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:40 [INFO] [stderr] | [INFO] [stderr] 58 | (old_pixel[0] as i16 - new_pixel[0] as i16).min(0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(new_pixel[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | (old_pixel[1] as i16 - new_pixel[1] as i16).min(0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(old_pixel[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:59:40 [INFO] [stderr] | [INFO] [stderr] 59 | (old_pixel[1] as i16 - new_pixel[1] as i16).min(0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(new_pixel[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | (old_pixel[2] as i16 - new_pixel[2] as i16).min(0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(old_pixel[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:60:40 [INFO] [stderr] | [INFO] [stderr] 60 | (old_pixel[2] as i16 - new_pixel[2] as i16).min(0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(new_pixel[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:72:42 [INFO] [stderr] | [INFO] [stderr] 72 | modified_pixel[i] = ((next_pixel[i] as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(next_pixel[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:73:28 [INFO] [stderr] | [INFO] [stderr] 73 | + ((loss_diference[i] as f64) * (quant[i] / 16f64))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(loss_diference[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: type `rgba` should have a camel case name such as `Rgba` [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | type rgba = image::Rgba; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:7:25 [INFO] [stderr] | [INFO] [stderr] 7 | fn process_pixel(pixel: &rgba, factor: u8) -> rgba { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `rgba` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:9:22 [INFO] [stderr] | [INFO] [stderr] 9 | let factor:f64 = factor as f64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(factor)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | let r = ((factor * (r as f64) / 255f64).round() * (255f64 / factor)) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | let g = ((factor * (g as f64) / 255f64).round() * (255f64 / factor)) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:13:24 [INFO] [stderr] | [INFO] [stderr] 13 | let b = ((factor * (b as f64) / 255f64).round() * (255f64 / factor)) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:25:11 [INFO] [stderr] | [INFO] [stderr] 25 | while args_list.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args_list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | (old_pixel[0] as i16 - new_pixel[0] as i16).min(0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(old_pixel[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:40 [INFO] [stderr] | [INFO] [stderr] 58 | (old_pixel[0] as i16 - new_pixel[0] as i16).min(0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(new_pixel[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | (old_pixel[1] as i16 - new_pixel[1] as i16).min(0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(old_pixel[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:59:40 [INFO] [stderr] | [INFO] [stderr] 59 | (old_pixel[1] as i16 - new_pixel[1] as i16).min(0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(new_pixel[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | (old_pixel[2] as i16 - new_pixel[2] as i16).min(0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(old_pixel[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:60:40 [INFO] [stderr] | [INFO] [stderr] 60 | (old_pixel[2] as i16 - new_pixel[2] as i16).min(0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(new_pixel[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:72:42 [INFO] [stderr] | [INFO] [stderr] 72 | modified_pixel[i] = ((next_pixel[i] as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(next_pixel[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:73:28 [INFO] [stderr] | [INFO] [stderr] 73 | + ((loss_diference[i] as f64) * (quant[i] / 16f64))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(loss_diference[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.09s [INFO] running `"docker" "inspect" "866a5ef042e1aac8322dd5d0b200ee59ee9d22eda0c8463c92392a68902b5f3c"` [INFO] running `"docker" "rm" "-f" "866a5ef042e1aac8322dd5d0b200ee59ee9d22eda0c8463c92392a68902b5f3c"` [INFO] [stdout] 866a5ef042e1aac8322dd5d0b200ee59ee9d22eda0c8463c92392a68902b5f3c