[INFO] updating cached repository PerArneng/sysgraph
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/PerArneng/sysgraph
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/PerArneng/sysgraph" "work/ex/clippy-test-run/sources/stable/gh/PerArneng/sysgraph"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/PerArneng/sysgraph'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/PerArneng/sysgraph" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PerArneng/sysgraph"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PerArneng/sysgraph'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] b1c413cc0d733b567fbed04788467f631cbbbaf4
[INFO] sha for GitHub repo PerArneng/sysgraph: b1c413cc0d733b567fbed04788467f631cbbbaf4
[INFO] validating manifest of PerArneng/sysgraph on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of PerArneng/sysgraph on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing PerArneng/sysgraph
[INFO] finished frobbing PerArneng/sysgraph
[INFO] frobbed toml for PerArneng/sysgraph written to work/ex/clippy-test-run/sources/stable/gh/PerArneng/sysgraph/Cargo.toml
[INFO] started frobbing PerArneng/sysgraph
[INFO] finished frobbing PerArneng/sysgraph
[INFO] frobbed toml for PerArneng/sysgraph written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/PerArneng/sysgraph/Cargo.toml
[INFO] crate PerArneng/sysgraph has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting PerArneng/sysgraph against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/PerArneng/sysgraph:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 46d5e4ac0bc9dc4d178ae0f1336cc8690c0e7d57be9125a20bafad743567575e
[INFO] running `"docker" "start" "-a" "46d5e4ac0bc9dc4d178ae0f1336cc8690c0e7d57be9125a20bafad743567575e"`
[INFO] [stderr]     Checking xml-rs v0.7.0
[INFO] [stderr]     Checking sysgraph v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/model.rs:12:9
[INFO] [stderr]    |
[INFO] [stderr] 12 | /         return ComponentDiagram {
[INFO] [stderr] 13 | |             name: name.to_owned()
[INFO] [stderr] 14 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 12 |         ComponentDiagram {
[INFO] [stderr] 13 |             name: name.to_owned()
[INFO] [stderr] 14 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/io/component_diagram_parser.rs:7:9
[INFO] [stderr]   |
[INFO] [stderr] 7 |         return self.parse_bytes(spec.as_bytes());
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.parse_bytes(spec.as_bytes())`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/io/component_diagram_xml_rs_parser.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 |         return ComponentDiagramXmlRsParser {};
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ComponentDiagramXmlRsParser {}`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/io/component_diagram_xml_rs_parser.rs:53:9
[INFO] [stderr]    |
[INFO] [stderr] 53 |         return Ok(ComponentDiagram::new("hello"));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ComponentDiagram::new("hello"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `io::component_diagram_xml_rs_parser::ComponentDiagramXmlRsParser`
[INFO] [stderr]   --> src/io/component_diagram_xml_rs_parser.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 | /     pub fn new() -> ComponentDiagramXmlRsParser {
[INFO] [stderr] 16 | |         return ComponentDiagramXmlRsParser {};
[INFO] [stderr] 17 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 9  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/model.rs:12:9
[INFO] [stderr]    |
[INFO] [stderr] 12 | /         return ComponentDiagram {
[INFO] [stderr] 13 | |             name: name.to_owned()
[INFO] [stderr] 14 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 12 |         ComponentDiagram {
[INFO] [stderr] 13 |             name: name.to_owned()
[INFO] [stderr] 14 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/io/component_diagram_parser.rs:7:9
[INFO] [stderr]   |
[INFO] [stderr] 7 |         return self.parse_bytes(spec.as_bytes());
[INFO] [stderr]   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.parse_bytes(spec.as_bytes())`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/io/component_diagram_xml_rs_parser.rs:16:9
[INFO] [stderr]    |
[INFO] [stderr] 16 |         return ComponentDiagramXmlRsParser {};
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ComponentDiagramXmlRsParser {}`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/io/component_diagram_xml_rs_parser.rs:53:9
[INFO] [stderr]    |
[INFO] [stderr] 53 |         return Ok(ComponentDiagram::new("hello"));
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ComponentDiagram::new("hello"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `io::component_diagram_xml_rs_parser::ComponentDiagramXmlRsParser`
[INFO] [stderr]   --> src/io/component_diagram_xml_rs_parser.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 | /     pub fn new() -> ComponentDiagramXmlRsParser {
[INFO] [stderr] 16 | |         return ComponentDiagramXmlRsParser {};
[INFO] [stderr] 17 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 9  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/args.rs:69:9
[INFO] [stderr]    |
[INFO] [stderr] 69 |         return Result::Ok(args);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(args)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/args.rs:69:9
[INFO] [stderr]    |
[INFO] [stderr] 69 |         return Result::Ok(args);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Result::Ok(args)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.46s
[INFO] running `"docker" "inspect" "46d5e4ac0bc9dc4d178ae0f1336cc8690c0e7d57be9125a20bafad743567575e"`
[INFO] running `"docker" "rm" "-f" "46d5e4ac0bc9dc4d178ae0f1336cc8690c0e7d57be9125a20bafad743567575e"`
[INFO] [stdout] 46d5e4ac0bc9dc4d178ae0f1336cc8690c0e7d57be9125a20bafad743567575e